From 1cc0dfad84de6cb6c540ba0b4380402322e02783 Mon Sep 17 00:00:00 2001 From: Daniel Gultsch Date: Mon, 20 Apr 2020 11:38:02 +0200 Subject: [PATCH] move sdp logging to different tag --- .../xmpp/jingle/JingleRtpConnection.java | 1 - .../xmpp/jingle/SessionDescription.java | 2 +- .../conversations/xmpp/jingle/WebRTCWrapper.java | 15 +++++++++++++-- 3 files changed, 14 insertions(+), 4 deletions(-) diff --git a/src/main/java/eu/siacs/conversations/xmpp/jingle/JingleRtpConnection.java b/src/main/java/eu/siacs/conversations/xmpp/jingle/JingleRtpConnection.java index 313549fb1..39c8bef48 100644 --- a/src/main/java/eu/siacs/conversations/xmpp/jingle/JingleRtpConnection.java +++ b/src/main/java/eu/siacs/conversations/xmpp/jingle/JingleRtpConnection.java @@ -606,7 +606,6 @@ public class JingleRtpConnection extends AbstractJingleConnection implements Web try { org.webrtc.SessionDescription webRTCSessionDescription = this.webRTCWrapper.createOffer().get(); final SessionDescription sessionDescription = SessionDescription.parse(webRTCSessionDescription.description); - Log.d(Config.LOGTAG, "description: " + webRTCSessionDescription.description); final RtpContentMap rtpContentMap = RtpContentMap.of(sessionDescription); sendSessionInitiate(rtpContentMap, targetState); this.webRTCWrapper.setLocalDescription(webRTCSessionDescription).get(); diff --git a/src/main/java/eu/siacs/conversations/xmpp/jingle/SessionDescription.java b/src/main/java/eu/siacs/conversations/xmpp/jingle/SessionDescription.java index dc4007d69..b7400b5b4 100644 --- a/src/main/java/eu/siacs/conversations/xmpp/jingle/SessionDescription.java +++ b/src/main/java/eu/siacs/conversations/xmpp/jingle/SessionDescription.java @@ -20,7 +20,7 @@ import eu.siacs.conversations.xmpp.jingle.stanzas.RtpDescription; public class SessionDescription { - private final static String LINE_DIVIDER = "\r\n"; + public final static String LINE_DIVIDER = "\r\n"; private final static String HARDCODED_MEDIA_PROTOCOL = "UDP/TLS/RTP/SAVPF"; //probably only true for DTLS-SRTP aka when we have a fingerprint private final static int HARDCODED_MEDIA_PORT = 9; private final static String HARDCODED_ICE_OPTIONS = "trickle renomination"; diff --git a/src/main/java/eu/siacs/conversations/xmpp/jingle/WebRTCWrapper.java b/src/main/java/eu/siacs/conversations/xmpp/jingle/WebRTCWrapper.java index b6ed9aa10..e987be4ef 100644 --- a/src/main/java/eu/siacs/conversations/xmpp/jingle/WebRTCWrapper.java +++ b/src/main/java/eu/siacs/conversations/xmpp/jingle/WebRTCWrapper.java @@ -50,6 +50,8 @@ import eu.siacs.conversations.services.AppRTCAudioManager; public class WebRTCWrapper { + private static final String EXTENDED_LOGGING_TAG = WebRTCWrapper.class.getSimpleName(); + private static final int CAPTURING_RESOLUTION = 1920; private static final int CAPTURING_MAX_FRAME_RATE = 30; @@ -110,11 +112,12 @@ public class WebRTCWrapper { @Override public void onAddStream(MediaStream mediaStream) { - Log.d(Config.LOGTAG, "onAddStream"); final List videoTracks = mediaStream.videoTracks; if (videoTracks.size() > 0) { - Log.d(Config.LOGTAG, "more than zero remote video tracks found. using first"); remoteVideoTrack = videoTracks.get(0); + Log.d(Config.LOGTAG, "remote video track enabled?=" + remoteVideoTrack.enabled()); + } else { + Log.d(Config.LOGTAG, "no remote video tracks found"); } } @@ -317,6 +320,10 @@ public class WebRTCWrapper { } public ListenableFuture setLocalDescription(final SessionDescription sessionDescription) { + Log.d(EXTENDED_LOGGING_TAG, "setting local description:"); + for (final String line : sessionDescription.description.split(eu.siacs.conversations.xmpp.jingle.SessionDescription.LINE_DIVIDER)) { + Log.d(EXTENDED_LOGGING_TAG, line); + } return Futures.transformAsync(getPeerConnectionFuture(), peerConnection -> { final SettableFuture future = SettableFuture.create(); peerConnection.setLocalDescription(new SetSdpObserver() { @@ -337,6 +344,10 @@ public class WebRTCWrapper { } public ListenableFuture setRemoteDescription(final SessionDescription sessionDescription) { + Log.d(EXTENDED_LOGGING_TAG, "setting remote description:"); + for (final String line : sessionDescription.description.split(eu.siacs.conversations.xmpp.jingle.SessionDescription.LINE_DIVIDER)) { + Log.d(EXTENDED_LOGGING_TAG, line); + } return Futures.transformAsync(getPeerConnectionFuture(), peerConnection -> { final SettableFuture future = SettableFuture.create(); peerConnection.setRemoteDescription(new SetSdpObserver() {