From 71545f4f665cd4fea6e6ecc1824ffac1f454bce2 Mon Sep 17 00:00:00 2001
From: Daniel Gultsch <daniel@gultsch.de>
Date: Tue, 13 May 2014 17:11:27 +0200
Subject: [PATCH] code cleanup

---
 .../ui/ConversationActivity.java              | 22 ++++++++++---------
 1 file changed, 12 insertions(+), 10 deletions(-)

diff --git a/src/eu/siacs/conversations/ui/ConversationActivity.java b/src/eu/siacs/conversations/ui/ConversationActivity.java
index 887282450..c650240fc 100644
--- a/src/eu/siacs/conversations/ui/ConversationActivity.java
+++ b/src/eu/siacs/conversations/ui/ConversationActivity.java
@@ -6,8 +6,6 @@ import java.util.ArrayList;
 import java.util.Hashtable;
 import java.util.List;
 
-import org.openintents.openpgp.OpenPgpError;
-
 import eu.siacs.conversations.R;
 import eu.siacs.conversations.entities.Account;
 import eu.siacs.conversations.entities.Contact;
@@ -120,6 +118,10 @@ public class ConversationActivity extends XmppActivity {
 	public Conversation getSelectedConversation() {
 		return this.selectedConversation;
 	}
+	
+	public void setSelectedConversation(Conversation conversation) {
+		this.selectedConversation = conversation;
+	}
 
 	public ListView getConversationListView() {
 		return this.listView;
@@ -235,8 +237,8 @@ public class ConversationActivity extends XmppActivity {
 			public void onItemClick(AdapterView<?> arg0, View clickedView,
 					int position, long arg3) {
 				paneShouldBeOpen = false;
-				if (selectedConversation != conversationList.get(position)) {
-					selectedConversation = conversationList.get(position);
+				if (getSelectedConversation() != conversationList.get(position)) {
+					setSelectedConversation(conversationList.get(position));
 					swapConversationFragment(); // .onBackendConnected(conversationList.get(position));
 				} else {
 					spl.closePane();
@@ -367,7 +369,7 @@ public class ConversationActivity extends XmppActivity {
 						
 						@Override
 						public void error(int error) {
-							// TODO Auto-generated method stub
+							displayErrorDialog(error);
 							
 						}
 					});
@@ -452,7 +454,7 @@ public class ConversationActivity extends XmppActivity {
 			Intent inviteIntent = new Intent(getApplicationContext(),
 					ContactsActivity.class);
 			inviteIntent.setAction("invite");
-			inviteIntent.putExtra("uuid", selectedConversation.getUuid());
+			inviteIntent.putExtra("uuid", getSelectedConversation().getUuid());
 			startActivity(inviteIntent);
 			break;
 		case R.id.action_security:
@@ -531,9 +533,9 @@ public class ConversationActivity extends XmppActivity {
 		spl.openPane();
 		xmppConnectionService.archiveConversation(conversation);
 		if (conversationList.size() > 0) {
-			selectedConversation = conversationList.get(0);
+			setSelectedConversation(conversationList.get(0));
 		} else {
-			selectedConversation = null;
+			setSelectedConversation(null);
 		}
 	}
 
@@ -619,7 +621,7 @@ public class ConversationActivity extends XmppActivity {
 
 				for (int i = 0; i < conversationList.size(); ++i) {
 					if (conversationList.get(i).getUuid().equals(convToView)) {
-						selectedConversation = conversationList.get(i);
+						setSelectedConversation(conversationList.get(i));
 					}
 				}
 				paneShouldBeOpen = false;
@@ -642,7 +644,7 @@ public class ConversationActivity extends XmppActivity {
 				if (selectedFragment != null) {
 					selectedFragment.onBackendConnected();
 				} else {
-					selectedConversation = conversationList.get(0);
+					setSelectedConversation(conversationList.get(0));
 					swapConversationFragment();
 				}
 				ExceptionHelper.checkForCrash(this, this.xmppConnectionService);