From 72e268e6b169b8429cc5d18b2df8b4f22bc52376 Mon Sep 17 00:00:00 2001
From: Daniel Gultsch <daniel@gultsch.de>
Date: Thu, 18 Feb 2021 09:36:51 +0100
Subject: [PATCH] add TODO comments wrt to missing <retract/> parsing

---
 .../siacs/conversations/xmpp/jingle/JingleConnectionManager.java | 1 +
 .../eu/siacs/conversations/xmpp/jingle/JingleRtpConnection.java  | 1 +
 2 files changed, 2 insertions(+)

diff --git a/src/main/java/eu/siacs/conversations/xmpp/jingle/JingleConnectionManager.java b/src/main/java/eu/siacs/conversations/xmpp/jingle/JingleConnectionManager.java
index 5e9925aca..0525b4a20 100644
--- a/src/main/java/eu/siacs/conversations/xmpp/jingle/JingleConnectionManager.java
+++ b/src/main/java/eu/siacs/conversations/xmpp/jingle/JingleConnectionManager.java
@@ -265,6 +265,7 @@ public class JingleConnectionManager extends AbstractConnectionManager {
                     return;
                 }
             }
+            //TODO handle reject for cases where we don’t have carbon copies (normally reject is to be sent to own bare jid as well)
             Log.d(Config.LOGTAG, account.getJid().asBareJid() + ": ignore jingle message from self");
             return;
         }
diff --git a/src/main/java/eu/siacs/conversations/xmpp/jingle/JingleRtpConnection.java b/src/main/java/eu/siacs/conversations/xmpp/jingle/JingleRtpConnection.java
index 1df1f9a57..a5350be1a 100644
--- a/src/main/java/eu/siacs/conversations/xmpp/jingle/JingleRtpConnection.java
+++ b/src/main/java/eu/siacs/conversations/xmpp/jingle/JingleRtpConnection.java
@@ -668,6 +668,7 @@ public class JingleRtpConnection extends AbstractJingleConnection implements Web
                 Log.d(Config.LOGTAG, "ignoring retract because already in " + this.state);
             }
         } else {
+            //TODO parse retract from self
             Log.d(Config.LOGTAG, id.account.getJid().asBareJid() + ": received retract from " + from + ". expected retract from" + id.with + ". ignoring");
         }
     }