fixed nfc. react to ?join uris. some refactoring. code cleanup. thanks to @emdete

src/main/AndroidManifest.xml

@@ -12,16 +12,17 @@
     <uses-permission android:name="android.permission.WAKE_LOCK" />
     <uses-permission android:name="android.permission.RECEIVE_BOOT_COMPLETED" />
     <uses-permission android:name="android.permission.VIBRATE" />
+    <uses-permission android:name="android.permission.NFC" />
 
     <application
         android:allowBackup="true"
         android:icon="@drawable/ic_launcher"
         android:label="@string/app_name"
-        tools:replace="android:label"
+        android:theme="@style/ConversationsTheme"
-        android:theme="@style/ConversationsTheme" >
+        tools:replace="android:label">
         <service android:name="eu.siacs.conversations.services.XmppConnectionService" />
 
-        <receiver android:name="eu.siacs.conversations.services.EventReceiver" >
+        <receiver android:name="eu.siacs.conversations.services.EventReceiver">
             <intent-filter>
                 <action android:name="android.intent.action.BOOT_COMPLETED" />
                 <action android:name="android.net.conn.CONNECTIVITY_CHANGE" />
@@ -33,7 +34,7 @@
             android:name="eu.siacs.conversations.ui.ConversationActivity"
             android:label="@string/title_activity_conversations"
             android:launchMode="singleTask"
-            android:windowSoftInputMode="stateHidden" >
+            android:windowSoftInputMode="stateHidden">
             <intent-filter>
                 <action android:name="android.intent.action.MAIN" />
 
@@ -43,8 +44,7 @@
         <activity
             android:name="eu.siacs.conversations.ui.StartConversationActivity"
             android:configChanges="orientation|screenSize"
-            android:label="@string/title_activity_start_conversation"
+            android:label="@string/title_activity_start_conversation">
-            android:logo="@drawable/ic_activity" >
             <intent-filter>
                 <action android:name="android.intent.action.SENDTO" />
 
@@ -61,42 +61,40 @@
 
                 <data android:scheme="xmpp" />
             </intent-filter>
+            <intent-filter>
+                <action android:name="android.nfc.action.NDEF_DISCOVERED" />
+                <category android:name="android.intent.category.DEFAULT" />
+                <data android:scheme="xmpp" />
+            </intent-filter>
         </activity>
         <activity
             android:name="eu.siacs.conversations.ui.SettingsActivity"
-            android:label="@string/title_activity_settings" >
+            android:label="@string/title_activity_settings"></activity>
-        </activity>
         <activity
             android:name="eu.siacs.conversations.ui.ChooseContactActivity"
-            android:label="@string/title_activity_choose_contact" >
+            android:label="@string/title_activity_choose_contact"></activity>
-        </activity>
         <activity
             android:name="eu.siacs.conversations.ui.ManageAccountActivity"
             android:configChanges="orientation|screenSize"
-            android:label="@string/title_activity_manage_accounts" >
+            android:label="@string/title_activity_manage_accounts"></activity>
-        </activity>
         <activity
             android:name="eu.siacs.conversations.ui.EditAccountActivity"
-            android:windowSoftInputMode="stateHidden|adjustResize" >
+            android:windowSoftInputMode="stateHidden|adjustResize"></activity>
-        </activity>
         <activity
             android:name="eu.siacs.conversations.ui.ConferenceDetailsActivity"
             android:label="@string/title_activity_conference_details"
-            android:windowSoftInputMode="stateHidden" >
+            android:windowSoftInputMode="stateHidden"></activity>
-        </activity>
         <activity
             android:name="eu.siacs.conversations.ui.ContactDetailsActivity"
             android:label="@string/title_activity_contact_details"
-            android:windowSoftInputMode="stateHidden" >
+            android:windowSoftInputMode="stateHidden"></activity>
-        </activity>
         <activity
             android:name="eu.siacs.conversations.ui.PublishProfilePictureActivity"
             android:label="@string/mgmt_account_publish_avatar"
-            android:windowSoftInputMode="stateHidden" >
+            android:windowSoftInputMode="stateHidden"></activity>
-        </activity>
         <activity
             android:name="eu.siacs.conversations.ui.ShareWithActivity"
-            android:label="@string/title_activity_conversations" >
+            android:label="@string/title_activity_conversations">
             <intent-filter>
                 <action android:name="android.intent.action.SEND" />
 

src/main/java/eu/siacs/conversations/ui/ConversationActivity.java

@@ -1,21 +1,5 @@
 package eu.siacs.conversations.ui;
 
-import java.util.ArrayList;
-import java.util.List;
-
-import eu.siacs.conversations.R;
-import eu.siacs.conversations.entities.Contact;
-import eu.siacs.conversations.entities.Conversation;
-import eu.siacs.conversations.entities.Message;
-import eu.siacs.conversations.services.XmppConnectionService.OnAccountUpdate;
-import eu.siacs.conversations.services.XmppConnectionService.OnConversationUpdate;
-import eu.siacs.conversations.services.XmppConnectionService.OnRosterUpdate;
-import eu.siacs.conversations.ui.adapter.ConversationAdapter;
-import eu.siacs.conversations.utils.ExceptionHelper;
-import android.net.Uri;
-import android.os.Bundle;
-import android.os.SystemClock;
-import android.provider.MediaStore;
 import android.annotation.SuppressLint;
 import android.app.ActionBar;
 import android.app.AlertDialog;
@@ -23,8 +7,16 @@ import android.app.FragmentTransaction;
 import android.app.PendingIntent;
 import android.content.DialogInterface;
 import android.content.DialogInterface.OnClickListener;
-import android.content.IntentSender.SendIntentException;
 import android.content.Intent;
+import android.content.IntentSender.SendIntentException;
+import android.net.Uri;
+import android.nfc.NdefMessage;
+import android.nfc.NdefRecord;
+import android.nfc.NfcAdapter;
+import android.nfc.NfcEvent;
+import android.os.Bundle;
+import android.os.SystemClock;
+import android.provider.MediaStore;
 import android.support.v4.widget.SlidingPaneLayout;
 import android.support.v4.widget.SlidingPaneLayout.PanelSlideListener;
 import android.view.KeyEvent;
@@ -40,6 +32,19 @@ import android.widget.PopupMenu;
 import android.widget.PopupMenu.OnMenuItemClickListener;
 import android.widget.Toast;
 
+import java.util.ArrayList;
+import java.util.List;
+
+import eu.siacs.conversations.R;
+import eu.siacs.conversations.entities.Contact;
+import eu.siacs.conversations.entities.Conversation;
+import eu.siacs.conversations.entities.Message;
+import eu.siacs.conversations.services.XmppConnectionService.OnAccountUpdate;
+import eu.siacs.conversations.services.XmppConnectionService.OnConversationUpdate;
+import eu.siacs.conversations.services.XmppConnectionService.OnRosterUpdate;
+import eu.siacs.conversations.ui.adapter.ConversationAdapter;
+import eu.siacs.conversations.utils.ExceptionHelper;
+
 public class ConversationActivity extends XmppActivity implements
 		OnAccountUpdate, OnConversationUpdate, OnRosterUpdate {
 
@@ -78,6 +83,18 @@ public class ConversationActivity extends XmppActivity implements
 
 	private Uri pendingImageUri = null;
 
+	private NfcAdapter.CreateNdefMessageCallback mNdefPushMessageCallback = new NfcAdapter.CreateNdefMessageCallback() {
+		@Override
+		public NdefMessage createNdefMessage(NfcEvent nfcEvent) {
+			Conversation conversation = getSelectedConversation();
+			NdefMessage msg = new NdefMessage(new NdefRecord[]{
+					NdefRecord.createUri("xmpp:"+conversation.getAccount().getJid()),
+					NdefRecord.createApplicationRecord("eu.siacs.conversations")
+			});
+			return msg;
+		}
+	};
+
 	public List<Conversation> getConversationList() {
 		return this.conversationList;
 	}
@@ -147,6 +164,8 @@ public class ConversationActivity extends XmppActivity implements
 		getActionBar().setDisplayHomeAsUpEnabled(false);
 		getActionBar().setHomeButtonEnabled(false);
 
+		registerNdefPushMessageCallback(this.mNdefPushMessageCallback);
+
 		this.listAdapter = new ConversationAdapter(this, conversationList);
 		listView.setAdapter(this.listAdapter);
 

src/main/java/eu/siacs/conversations/ui/StartConversationActivity.java

@@ -1,11 +1,5 @@
 package eu.siacs.conversations.ui;
 
-import java.io.UnsupportedEncodingException;
-import java.net.URLDecoder;
-import java.util.ArrayList;
-import java.util.Collections;
-import java.util.List;
-
 import android.annotation.SuppressLint;
 import android.app.ActionBar;
 import android.app.ActionBar.Tab;
@@ -19,12 +13,15 @@ import android.content.DialogInterface;
 import android.content.DialogInterface.OnClickListener;
 import android.content.Intent;
 import android.net.Uri;
+import android.nfc.NdefMessage;
+import android.nfc.NdefRecord;
+import android.nfc.NfcAdapter;
 import android.os.Bundle;
+import android.os.Parcelable;
 import android.support.v13.app.FragmentPagerAdapter;
 import android.support.v4.view.ViewPager;
 import android.text.Editable;
 import android.text.TextWatcher;
-import android.util.Log;
 import android.view.ContextMenu;
 import android.view.ContextMenu.ContextMenuInfo;
 import android.view.KeyEvent;
@@ -45,7 +42,12 @@ import android.widget.Spinner;
 import com.google.zxing.integration.android.IntentIntegrator;
 import com.google.zxing.integration.android.IntentResult;
 
-import eu.siacs.conversations.Config;
+import java.io.UnsupportedEncodingException;
+import java.net.URLDecoder;
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.List;
+
 import eu.siacs.conversations.R;
 import eu.siacs.conversations.entities.Account;
 import eu.siacs.conversations.entities.Bookmark;
@@ -75,6 +77,8 @@ public class StartConversationActivity extends XmppActivity {
 	private List<String> mKnownHosts;
 	private List<String> mKnownConferenceHosts;
 
+	private Invite mPendingInvite = null;
+
 	private Menu mOptionsMenu;
 	private EditText mSearchEditText;
 
@@ -377,7 +381,7 @@ public class StartConversationActivity extends XmppActivity {
 	}
 
 	@SuppressLint("InflateParams")
-	protected void showJoinConferenceDialog() {
+	protected void showJoinConferenceDialog(String prefilledJid) {
 		AlertDialog.Builder builder = new AlertDialog.Builder(this);
 		builder.setTitle(R.string.join_conference);
 		View dialogView = getLayoutInflater().inflate(
@@ -387,6 +391,9 @@ public class StartConversationActivity extends XmppActivity {
 				.findViewById(R.id.jid);
 		jid.setAdapter(new KnownHostsAdapter(this,
 				android.R.layout.simple_list_item_1, mKnownConferenceHosts));
+		if (prefilledJid != null) {
+			jid.append(prefilledJid);
+		}
 		populateAccountSpinner(spinner);
 		final CheckBox bookmarkCheckBox = (CheckBox) dialogView
 				.findViewById(R.id.bookmark);
@@ -499,7 +506,7 @@ public class StartConversationActivity extends XmppActivity {
 				showCreateContactDialog(null);
 				return true;
 			case R.id.action_join_conference:
-			showJoinConferenceDialog();
+				showJoinConferenceDialog(null);
 				return true;
 			case R.id.action_scan_qr_code:
 				new IntentIntegrator(this).initiateScan();
@@ -523,10 +530,21 @@ public class StartConversationActivity extends XmppActivity {
 			IntentResult scanResult = IntentIntegrator.parseActivityResult(requestCode, resultCode, intent);
 			if (scanResult != null && scanResult.getFormatName() != null) {
 				String data = scanResult.getContents();
-				Log.d(Config.LOGTAG, data);
+				Invite invite = parseInviteUri(data);
+				if (xmppConnectionServiceBound) {
+					if (invite.muc) {
+						showJoinConferenceDialog(invite.jid);
+					} else {
+						handleJid(invite.jid);
+					}
+				} else if (invite.jid != null) {
+					this.mPendingInvite = invite;
+				} else {
+					this.mPendingInvite = null;
 				}
 			}
-		super.onActivityResult(requestCode,requestCode,intent);
+		}
+		super.onActivityResult(requestCode, requestCode, intent);
 	}
 
 	@Override
@@ -541,35 +559,88 @@ public class StartConversationActivity extends XmppActivity {
 		this.mKnownHosts = xmppConnectionService.getKnownHosts();
 		this.mKnownConferenceHosts = xmppConnectionService
 				.getKnownConferenceHosts();
-		if (!startByIntent()) {
+		if (this.mPendingInvite != null) {
+			if (this.mPendingInvite.muc) {
+				showJoinConferenceDialog(this.mPendingInvite.jid);
+			} else {
+				handleJid(this.mPendingInvite.jid);
+			}
+			this.mPendingInvite = null;
+		} else if (!handleIntent(getIntent())) {
 			if (mSearchEditText != null) {
 				filter(mSearchEditText.getText().toString());
 			} else {
 				filter(null);
 			}
 		}
+		setIntent(null);
 	}
 
-	protected boolean startByIntent() {
+	protected boolean handleIntent(Intent intent) {
-		if (getIntent() != null
+		if (intent == null || intent.getAction() == null) {
-				&& Intent.ACTION_SENDTO.equals(getIntent().getAction())) {
+			return false;
+		}
+		String jid;
+		Uri uri;
+		Invite invite;
+		switch (intent.getAction()) {
+			case Intent.ACTION_SENDTO:
 				try {
-				String jid = URLDecoder.decode(
+					jid = URLDecoder.decode(
-						getIntent().getData().getEncodedPath(), "UTF-8").split(
+							intent.getData().getEncodedPath(), "UTF-8").split(
 							"/")[1];
-				setIntent(null);
 					return handleJid(jid);
 				} catch (UnsupportedEncodingException e) {
-				setIntent(null);
 					return false;
 				}
-		} else if (getIntent() != null
+			case Intent.ACTION_VIEW:
-				&& Intent.ACTION_VIEW.equals(getIntent().getAction())) {
+				uri = intent.getData();
-			Uri uri = getIntent().getData();
+				invite = parseInviteUri(uri);
-			String jid = uri.getSchemeSpecificPart().split("\\?")[0];
+				if (invite.muc) {
-			return handleJid(jid);
+					showJoinConferenceDialog(invite.jid);
-		}
 					return false;
+				} else {
+					return handleJid(invite.jid);
+				}
+			case NfcAdapter.ACTION_NDEF_DISCOVERED:
+				if (android.os.Build.VERSION.SDK_INT >= 16) {
+					Parcelable[] messages = getIntent().getParcelableArrayExtra(NfcAdapter.EXTRA_NDEF_MESSAGES);
+					NdefMessage message = (NdefMessage) messages[0];
+					NdefRecord record = message.getRecords()[0];
+					invite = parseInviteUri(record.toUri());
+					if (invite != null) {
+						if (invite.muc) {
+							showJoinConferenceDialog(invite.jid);
+							return false;
+						} else {
+							return handleJid(invite.jid);
+						}
+					}
+				} else {
+					return false;
+				}
+			default:
+				return false;
+		}
+	}
+
+	private Invite parseInviteUri(String uri) {
+		try {
+			return parseInviteUri(Uri.parse(uri));
+		} catch (IllegalArgumentException e) {
+			return null;
+		}
+	}
+
+	private Invite parseInviteUri(Uri uri) {
+		Invite invite = new Invite();
+		invite.muc = uri.getQuery() != null && uri.getQuery().equalsIgnoreCase("join");
+		if (uri.getAuthority() != null) {
+			invite.jid = uri.getAuthority();
+		} else {
+			invite.jid = uri.getSchemeSpecificPart().split("\\?")[0];
+		}
+		return invite;
 	}
 
 	private boolean handleJid(String jid) {
@@ -583,7 +654,8 @@ public class StartConversationActivity extends XmppActivity {
 		} else {
 			if (mMenuSearchView != null) {
 				mMenuSearchView.expandActionView();
-				mSearchEditText.setText(jid);
+				mSearchEditText.setText("");
+				mSearchEditText.append(jid);
 				filter(jid);
 			} else {
 				mInitialJid = jid;
@@ -695,4 +767,9 @@ public class StartConversationActivity extends XmppActivity {
 			return true;
 		}
 	}
+
+	private class Invite {
+		public String jid;
+		public boolean muc;
+	}
 }

src/main/java/eu/siacs/conversations/ui/XmppActivity.java

@@ -38,6 +38,7 @@ import android.graphics.Bitmap;
 import android.graphics.drawable.BitmapDrawable;
 import android.graphics.drawable.Drawable;
 import android.net.Uri;
+import android.nfc.NfcAdapter;
 import android.os.AsyncTask;
 import android.os.Bundle;
 import android.os.IBinder;
@@ -543,6 +544,15 @@ public abstract class XmppActivity extends Activity {
 		return false;
 	}
 
+	protected void registerNdefPushMessageCallback(NfcAdapter.CreateNdefMessageCallback callback) {
+		if (android.os.Build.VERSION.SDK_INT >= 16) {
+			NfcAdapter nfcAdapter = NfcAdapter.getDefaultAdapter(this);
+			if (nfcAdapter != null && nfcAdapter.isEnabled()) {
+				nfcAdapter.setNdefPushMessageCallback(callback, this);
+			}
+		}
+	}
+
 	public AvatarService avatarService() {
 		return xmppConnectionService.getAvatarService();
 	}