From 8927ba8065fd145fb6c8eeceaa6a807a7ee6d4f0 Mon Sep 17 00:00:00 2001 From: Daniel Gultsch Date: Sat, 20 Aug 2016 10:44:50 +0200 Subject: [PATCH] various null pointer checks --- .../java/eu/siacs/conversations/entities/Account.java | 3 ++- .../siacs/conversations/ui/ContactDetailsActivity.java | 3 +++ .../conversations/ui/StartConversationActivity.java | 9 +++++++-- 3 files changed, 12 insertions(+), 3 deletions(-) diff --git a/src/main/java/eu/siacs/conversations/entities/Account.java b/src/main/java/eu/siacs/conversations/entities/Account.java index b3694108a..23001de76 100644 --- a/src/main/java/eu/siacs/conversations/entities/Account.java +++ b/src/main/java/eu/siacs/conversations/entities/Account.java @@ -302,7 +302,8 @@ public class Account extends AbstractEntity { } public boolean isOnion() { - return getServer().toString().toLowerCase().endsWith(".onion"); + final Jid server = getServer(); + return server != null && server.toString().toLowerCase().endsWith(".onion"); } public void setPort(int port) { diff --git a/src/main/java/eu/siacs/conversations/ui/ContactDetailsActivity.java b/src/main/java/eu/siacs/conversations/ui/ContactDetailsActivity.java index c6df77dcf..d663cbd12 100644 --- a/src/main/java/eu/siacs/conversations/ui/ContactDetailsActivity.java +++ b/src/main/java/eu/siacs/conversations/ui/ContactDetailsActivity.java @@ -313,6 +313,9 @@ public class ContactDetailsActivity extends XmppActivity implements OnAccountUpd } private void populateView() { + if (contact == null) { + return; + } invalidateOptionsMenu(); setTitle(contact.getDisplayName()); if (contact.showInRoster()) { diff --git a/src/main/java/eu/siacs/conversations/ui/StartConversationActivity.java b/src/main/java/eu/siacs/conversations/ui/StartConversationActivity.java index 67c97dd1f..cc7394b46 100644 --- a/src/main/java/eu/siacs/conversations/ui/StartConversationActivity.java +++ b/src/main/java/eu/siacs/conversations/ui/StartConversationActivity.java @@ -815,8 +815,13 @@ public class StartConversationActivity extends XmppActivity implements OnRosterU switch (intent.getAction()) { case Intent.ACTION_SENDTO: case Intent.ACTION_VIEW: - Log.d(Config.LOGTAG, "received uri=" + intent.getData()); - return new Invite(intent.getData()).invite(); + Uri uri = intent.getData(); + if (uri != null) { + Log.d(Config.LOGTAG, "received uri=" + intent.getData()); + return new Invite(intent.getData()).invite(); + } else { + return false; + } case NfcAdapter.ACTION_NDEF_DISCOVERED: for (Parcelable message : getIntent().getParcelableArrayExtra(NfcAdapter.EXTRA_NDEF_MESSAGES)) { if (message instanceof NdefMessage) {