From 9963616270dcb4dad12e3a00f5ea1804fb3f2201 Mon Sep 17 00:00:00 2001 From: Daniel Gultsch Date: Sat, 28 Apr 2018 16:56:32 +0200 Subject: [PATCH] do not crash when inner message contains invalid jid --- .../java/eu/siacs/conversations/parser/MessageParser.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/main/java/eu/siacs/conversations/parser/MessageParser.java b/src/main/java/eu/siacs/conversations/parser/MessageParser.java index 6da26fd11..209a2a689 100644 --- a/src/main/java/eu/siacs/conversations/parser/MessageParser.java +++ b/src/main/java/eu/siacs/conversations/parser/MessageParser.java @@ -293,8 +293,8 @@ public class MessageParser extends AbstractParser implements OnMessagePacketRece } boolean notify = false; - if (from == null) { - Log.d(Config.LOGTAG, "no from in: " + packet.toString()); + if (from == null || !InvalidJid.isValid(from) || !InvalidJid.isValid(to)) { + Log.e(Config.LOGTAG, "encountered invalid message from='" + from + "' to='" + to + "'"); return; }