sum7/Conversations
sum7
/
Conversations
1
1
Fork 0
Code Issues Pull Requests Releases Wiki Activity

close cursor for database

This commit is contained in:
iNPUTmice 2014-11-16 00:34:16 +01:00
parent 17c2ed411d
commit ac4eabbd22
1 changed files with 18 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
src/main/java/eu/siacs/conversations/persistance/DatabaseBackend.java
View File

@ -143,7 +143,9 @@ public class DatabaseBackend extends SQLiteOpenHelper {
+ Conversation.TABLENAME + " where " + Conversation.STATUS + Conversation.TABLENAME + " where " + Conversation.STATUS
+ "=" + Conversation.STATUS_AVAILABLE, null); + "=" + Conversation.STATUS_AVAILABLE, null);
cursor.moveToFirst(); cursor.moveToFirst();
return cursor.getInt(0); int count = cursor.getInt(0);
cursor.close();
return count;
} }
public CopyOnWriteArrayList<Conversation> getConversations(int status) { public CopyOnWriteArrayList<Conversation> getConversations(int status) {
@ -156,6 +158,7 @@ public class DatabaseBackend extends SQLiteOpenHelper {
while (cursor.moveToNext()) { while (cursor.moveToNext()) {
list.add(Conversation.fromCursor(cursor)); list.add(Conversation.fromCursor(cursor));
} }
cursor.close();
return list; return list;
} }
@ -189,6 +192,7 @@ public class DatabaseBackend extends SQLiteOpenHelper {
list.add(message); list.add(message);
} while (cursor.moveToPrevious()); } while (cursor.moveToPrevious());
} }
cursor.close();
return list; return list;
} }
@ -201,7 +205,9 @@ public class DatabaseBackend extends SQLiteOpenHelper {
if (cursor.getCount() == 0) if (cursor.getCount() == 0)
return null; return null;
cursor.moveToFirst(); cursor.moveToFirst();
return Conversation.fromCursor(cursor); Conversation conversation = Conversation.fromCursor(cursor);
cursor.close();
return conversation;
} }
public void updateConversation(Conversation conversation) { public void updateConversation(Conversation conversation) {
@ -313,7 +319,9 @@ public class DatabaseBackend extends SQLiteOpenHelper {
return null; return null;
} }
cursor.moveToFirst(); cursor.moveToFirst();
return Conversation.fromCursor(cursor); Conversation conversation = Conversation.fromCursor(cursor);
cursor.close();
return conversation;
} }
public Message findMessageByUuid(String messageUuid) { public Message findMessageByUuid(String messageUuid) {
@ -325,7 +333,9 @@ public class DatabaseBackend extends SQLiteOpenHelper {
return null; return null;
} }
cursor.moveToFirst(); cursor.moveToFirst();
return Message.fromCursor(cursor); Message message = Message.fromCursor(cursor);
cursor.close();
return message;
} }
public Account findAccountByUuid(String accountUuid) { public Account findAccountByUuid(String accountUuid) {
@ -337,7 +347,9 @@ public class DatabaseBackend extends SQLiteOpenHelper {
return null; return null;
} }
cursor.moveToFirst(); cursor.moveToFirst();
return Account.fromCursor(cursor); Account account = Account.fromCursor(cursor);
cursor.close();
return account;
} }
public List<Message> getImageMessages(Conversation conversation) { public List<Message> getImageMessages(Conversation conversation) {
@ -355,6 +367,7 @@ public class DatabaseBackend extends SQLiteOpenHelper {
list.add(message); list.add(message);
} while (cursor.moveToPrevious()); } while (cursor.moveToPrevious());
} }
cursor.close();
return list; return list;
} }
} }