From d0af5a002eaf46734d30e5b72e5ff0711c789003 Mon Sep 17 00:00:00 2001
From: Daniel Gultsch <daniel@gultsch.de>
Date: Mon, 4 Oct 2021 15:18:37 +0200
Subject: [PATCH] leave code comment about xmpp vs jabber vcard entry

---
 .../java/eu/siacs/conversations/ui/ContactDetailsActivity.java | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/main/java/eu/siacs/conversations/ui/ContactDetailsActivity.java b/src/main/java/eu/siacs/conversations/ui/ContactDetailsActivity.java
index e1ea08b5f..7c1d08643 100644
--- a/src/main/java/eu/siacs/conversations/ui/ContactDetailsActivity.java
+++ b/src/main/java/eu/siacs/conversations/ui/ContactDetailsActivity.java
@@ -155,6 +155,8 @@ public class ContactDetailsActivity extends OmemoActivity implements OnAccountUp
             } else {
                 intent.putExtra(Intents.Insert.IM_HANDLE, value);
                 intent.putExtra(Intents.Insert.IM_PROTOCOL, CommonDataKinds.Im.PROTOCOL_JABBER);
+                //TODO for modern use we want PROTOCOL_CUSTOM and an extra field with a value of 'XMPP'
+                // however we don’t have such a field and thus have to use the legacy PROTOCOL_JABBER
             }
             intent.putExtra("finishActivityOnSaveCompleted", true);
             try {
@@ -249,6 +251,7 @@ public class ContactDetailsActivity extends OmemoActivity implements OnAccountUp
 
     @Override
     public void onRequestPermissionsResult(int requestCode, @NonNull String[] permissions, @NonNull int[] grantResults) {
+        super.onRequestPermissionsResult(requestCode, permissions, grantResults);
         if (grantResults.length > 0)
             if (grantResults[0] == PackageManager.PERMISSION_GRANTED) {
                 if (requestCode == REQUEST_SYNC_CONTACTS && xmppConnectionServiceBound) {