add droneci build

.ci/prepare-publish.sh

@@ -0,0 +1,14 @@
+#!/bin/sh
+find -type d -name "siacs" -print0 | xargs --null -I{} bash -c 'x="{}"; mv "$x" "${x/siacs/sum7}" '
+find -type f -name "*.java" -exec sed -i "/eu.siacs.conversations.axolotl/! s/eu.siacs./eu.sum7./" "{}" \;
+find -type f -name "*.xml"  -exec sed -i "/eu.siacs.conversations.axolotl/! s/eu.siacs./eu.sum7./" "{}" \;
+# workaround for bug in fdroid nightly
+sed -i "s/-debug.apk/-unsigned.apk/" /usr/lib/python3/dist-packages/fdroidserver/nightly.py
+# generate new version
+git fetch --tags
+export versionCode="$DRONE_BUILD_NUMBER"
+export versionName="$(git describe --tag --abbrev=0)-${DRONE_BUILD_NUMBER}"
+echo "set VersionCode '${versionCode}' and VersonName '${versionName}'"
+sed -i "s/^\(\s*versionCode\s*\).*$/\1$versionCode/" build.gradle
+sed -i "0,/versionName/s/^\(\s*versionName\).*/\1 \"$versionName\"/" build.gradle
+cat -n build.gradle

.drone.yml

@@ -0,0 +1,31 @@
+---
+kind: pipeline
+type: docker
+name: default
+
+steps:
+- image: registry.gitlab.com/fdroid/ci-images-client:latest
+  name: build
+  when:
+    branch:
+      exclude:
+      - droneci
+  commands:
+  - ./gradlew assembleConversationsFreeCompatDebug
+
+- image: registry.gitlab.com/fdroid/ci-images-client:latest
+  name: publish
+  when:
+    branch:
+      include:
+      - droneci
+  environment:
+    DEBUG_KEYSTORE:
+      from_secret: DEBUG_KEYSTORE
+  commands:
+  - .ci/prepare-publish.sh
+  # build free version
+  - ./gradlew assembleConversationsFreeCompatRelease
+  - ls build/outputs/apk/conversationsFreeCompat/*
+  # publish on nightly fdroid repo
+  - fdroid nightly -v

.github/workflows/android.yml

@@ -1,38 +0,0 @@
-name: Android CI
-
-on:
-  push:
-    branches: [ master ]
-  pull_request:
-    branches: [ master ]
-
-jobs:
-  build:
-
-    runs-on: ubuntu-latest
-
-    steps:
-    - uses: actions/checkout@v2
-    - name: set up JDK 11
-      uses: actions/setup-java@v2
-      with:
-        java-version: '11'
-        distribution: 'adopt'
-    - name: Download WebRTC
-      run: mkdir libs && wget -O libs/libwebrtc-m92.aar https://gultsch.de/files/libwebrtc-m92.aar
-    - name: Grant execute permission for gradlew
-      run: chmod +x gradlew
-    - name: Build Quicksy (Compat)
-      run: ./gradlew assembleQuicksyFreeCompatDebug
-    - name: Build Quicksy (System)
-      run: ./gradlew assembleQuicksyFreeSystemDebug
-    - name: Build Conversations (Compat)
-      run: ./gradlew assembleConversationsFreeCompatDebug
-    - name: Build Conversations (System)
-      run: ./gradlew assembleConversationsFreeSystemDebug
-    - uses: actions/upload-artifact@v2
-      with:
-        name: Conversations all-flavors (debug)
-        path: ./build/outputs/apk/**/debug/Conversations-*.apk
-
-      

.travis.yml

@@ -0,0 +1,22 @@
+language: android
+jdk:
+  - oraclejdk8
+android:
+  components:
+    - platform-tools
+    - tools
+    - build-tools-28.0.3
+    - extra-google-google_play_services
+  licenses:
+    - '.+'
+before_script:
+    - mkdir libs
+    - wget -O libs/libwebrtc-m87.aar https://gultsch.de/files/libwebrtc-m87.aar
+script:
+    - ./gradlew assembleQuicksyFreeCompatDebug
+    - ./gradlew assembleQuicksyFreeSystemDebug
+    - ./gradlew assembleConversationsFreeCompatDebug
+    - ./gradlew assembleConversationsFreeSystemDebug
+
+before_install:
+    - yes | sdkmanager "platforms;android-28"

.tx/config

@@ -2,7 +2,7 @@
 host = https://www.transifex.com
 lang_map = af_ZA: af-rZA, am_ET: am-rET, ar_AE: ar-rAE, ar_BH: ar-rBH, ar_DZ: ar-rDZ, ar_EG: ar-rEG, ar_IQ: ar-rIQ, ar_JO: ar-rJO, ar_KW: ar-rKW, ar_LB: ar-rLB, ar_LY: ar-rLY, ar_MA: ar-rMA, ar_OM: ar-rOM, ar_QA: ar-rQA, ar_SA: ar-rSA, ar_SY: ar-rSY, ar_TN: ar-rTN, ar_YE: ar-rYE, arn_CL: arn-rCL, as_IN: as-rIN, az_AZ: az-rAZ, ba_RU: ba-rRU, be_BY: be-rBY, bg_BG: bg-rBG, bn_BD: bn-rBD, bn_IN: bn-rIN, bo_CN: bo-rCN, br_FR: br-rFR, bs_BA: bs-rBA, ca_ES: ca-rES, co_FR: co-rFR, cs_CZ: cs-rCZ, cy_GB: cy-rGB, da_DK: da-rDK, de_AT: de-rAT, de_CH: de-rCH, de_DE: de-rDE, de_LI: de-rLI, de_LU: de-rLU, dsb_DE: dsb-rDE, dv_MV: dv-rMV, el_GR: el-rGR, en_AU: en-rAU, en_BZ: en-rBZ, en_CA: en-rCA, en_GB: en-rGB, en_IE: en-rIE, en_IN: en-rIN, en_JM: en-rJM, en_MY: en-rMY, en_NZ: en-rNZ, en_PH: en-rPH, en_SG: en-rSG, en_TT: en-rTT, en_US: en-rUS, en_ZA: en-rZA, en_ZW: en-rZW, es_AR: es-rAR, es_BO: es-rBO, es_CL: es-rCL, es_CO: es-rCO, es_CR: es-rCR, es_DO: es-rDO, es_EC: es-rEC, es_ES: es-rES, es_GT: es-rGT, es_HN: es-rHN, es_MX: es-rMX, es_NI: es-rNI, es_PA: es-rPA, es_PE: es-rPE, es_PR: es-rPR, es_PY: es-rPY, es_SV: es-rSV, es_US: es-rUS, es_UY: es-rUY, es_VE: es-rVE, et_EE: et-rEE, eu_ES: eu-rES, fa_IR: fa-rIR, fi_FI: fi-rFI, fil_PH: fil-rPH, fo_FO: fo-rFO, fr_BE: fr-rBE, fr_CA: fr-rCA, fr_CH: fr-rCH, fr_FR: fr-rFR, fr_LU: fr-rLU, fr_MC: fr-rMC, fy_NL: fy-rNL, ga_IE: ga-rIE, gd_GB: gd-rGB, gl_ES: gl-rES, gsw_FR: gsw-rFR, gu_IN: gu-rIN, ha_NG: ha-rNG, hi_IN: hi-rIN, hr_BA: hr-rBA, hr_HR: hr-rHR, hsb_DE: hsb-rDE, hu_HU: hu-rHU, hy_AM: hy-rAM, id_ID: id-rID, ig_NG: ig-rNG, ii_CN: ii-rCN, is_IS: is-rIS, it_CH: it-rCH, it_IT: it-rIT, iu_CA: iu-rCA, ja_JP: ja-rJP, ka_GE: ka-rGE, kk_KZ: kk-rKZ, kl_GL: kl-rGL, km_KH: km-rKH, kn_IN: kn-rIN, ko_KR: ko-rKR, kok_IN: kok-rIN, ky_KG: ky-rKG, lb_LU: lb-rLU, lo_LA: lo-rLA, lt_LT: lt-rLT, lv_LV: lv-rLV, mi_NZ: mi-rNZ, mk_MK: mk-rMK, ml_IN: ml-rIN, mn_CN: mn-rCN, mn_MN: mn-rMN, moh_CA: moh-rCA, mr_IN: mr-rIN, ms_BN: ms-rBN, ms_MY: ms-rMY, mt_MT: mt-rMT, nb_NO: nb-rNO, ne_NP: ne-rNP, nl_BE: nl-rBE, nl_NL: nl-rNL, nn_NO: nn-rNO, nso_ZA: nso-rZA, oc_FR: oc-rFR, or_IN: or-rIN, pa_IN: pa-rIN, pl_PL: pl-rPL, prs_AF: prs-rAF, ps_AF: ps-rAF, pt_BR: pt-rBR, pt_PT: pt-rPT, qut_GT: qut-rGT, quz_BO: quz-rBO, quz_EC: quz-rEC, quz_PE: quz-rPE, rm_CH: rm-rCH, ro_RO: ro-rRO, ru_RU: ru-rRU, rw_RW: rw-rRW, sa_IN: sa-rIN, sah_RU: sah-rRU, se_FI: se-rFI, se_NO: se-rNO, se_SE: se-rSE, si_LK: si-rLK, sk_SK: sk-rSK, sl_SI: sl-rSI, sma_NO: sma-rNO, sma_SE: sma-rSE, smj_NO: smj-rNO, smj_SE: smj-rSE, smn_FI: smn-rFI, sms_FI: sms-rFI, sq_AL: sq-rAL, sr_BA: sr-rBA, sr_CS: sr-rCS, sr_ME: sr-rME, sr_RS: sr-rRS, sv_FI: sv-rFI, sv_SE: sv-rSE, sw_KE: sw-rKE, syr_SY: syr-rSY, ta_IN: ta-rIN, te_IN: te-rIN, tg_TJ: tg-rTJ, th_TH: th-rTH, tk_TM: tk-rTM, tn_ZA: tn-rZA, tr_TR: tr-rTR, tt_RU: tt-rRU, tzm_DZ: tzm-rDZ, ug_CN: ug-rCN, uk_UA: uk-rUA, ur_PK: ur-rPK, uz_UZ: uz-rUZ, vi_VN: vi-rVN, wo_SN: wo-rSN, xh_ZA: xh-rZA, yo_NG: yo-rNG, zh_CN: zh-rCN, zh_HK: zh-rHK, zh_MO: zh-rMO, zh_SG: zh-rSG, zh_TW: zh-rTW, zu_ZA: zu-rZA, no_NO: no-rNO, he_IL: iw-rIL, he: iw
 
-[conversations.main-strings]
+[conversations.strings]
 file_filter = src/main/res/values-<lang>/strings.xml
 source_file = src/main/res/values/strings.xml
 source_lang = en

CHANGELOG.md

@@ -1,54 +1,5 @@
 # Changelog
 
-### Version 2.10.2
-
-* Fix crash when rendering some quotes
-* Fix crash in welcome screen
-
-### Version 2.10.1
-
-* Fix issue with some videos not being compressed
-* Fix rare crash when opening notification
-
-### Version 2.10.0
-
-* Show black bars when remote video does not match aspect ratio of screen
-* Improve search performance
-* Add setting to prevent screenshots
-
-### Version 2.9.13
-
-* minor A/V improvements
-
-### Version 2.9.12
-
-* Always verify domain name. No user overwrite
-* Support roster pre authentication
-
-### Version 2.9.11
-
-* Fixed 'No Connectivity' issues on Android 7.1
-
-### Version 2.9.10
-* fix HTTP up/download for users that don’t trust system CAs
-
-### Version 2.9.9
-
-* Various bug fixes around Tor support
-* Improve call compatibility with Dino
-
-### Version 2.9.8
-
-* Verify A/V calls with preexisting OMEMO sessions
-* Improve compatibility with non libwebrtc WebRTC implementations
-
-### Version 2.9.7
-
-* Ability to select incoming call ringtone
-* Fix OpenPGP key id discovery for OpenKeychain 5.6+
-* Properly verify punycode TLS certificates
-* Improve stability of RTP session establishment (calling)
-
 ### Version 2.9.6
 
 * Show call button for offline contacts if they previously announced support
@@ -61,7 +12,6 @@
 
 ### Version 2.9.4
 * minor stability improvements for A/V calls
-* Conversations releases from here on forward require Android 5
 
 ### Version 2.9.3
 

README.md

@@ -43,7 +43,7 @@
 
 * End-to-end encryption with [OMEMO](http://conversations.im/omemo/) or [OpenPGP](http://openpgp.org/about/)
 * Send and receive images as well as other kind of files
-* [Encrypted audio and video calls (DTLS-SRTP)](https://help.conversations.im)
+* Encrypted audio and video calls (DTLS-SRTP)
 * Share your location
 * Send voice messages
 * Indication when your contact has read your message
@@ -139,7 +139,7 @@ Note: This is kind of a weird quirk in OpenFire. Most other servers would just t
 
 Maybe you attempted to use the Jabber ID `test@b.tld` because `a.tld` doesn’t point to the correct host. In that case you might have to enable the extended connection settings in the expert settings of Conversations and set a host name.
 
-#### I get 'Stream opening error'. What does that mean?
+### I get 'Stream opening error'. What does that mean?
 
 In most cases this error is caused by ejabberd advertising support for TLSv1.3 but not properly supporting it. This can happen if the OpenSSL version on the server already supports TLSv1.3 but the fast\_tls wrapper library used by ejabberd not (properly) support it. Upgrading fast\_tls and ejabberd or - theoretically - downgrading OpenSSL should fix the issue. A work around is to explicitly disable TLSv1.3 support in the ejabberd configuration. More information can be found on [this issue on the ejabberd issue tracker](https://github.com/processone/ejabberd/issues/2614).
 
@@ -371,7 +371,7 @@ Unfortunately we don‘t have a recommendation for iPhones right now. There are
 **Note:** Starting with version 2.8.0 you will need to compile libwebrtc.
 [Instructions](https://webrtc.github.io/webrtc-org/native-code/android/) can be found on the WebRTC
 website. Place the resulting libwebrtc.aar in the `libs/` directory. The PlayStore release currently
-uses the stable M90 release and renamed the file name to `libwebrtc-m90.aar` put potentially you can
+uses the stable M81 release and renamed the file name to `libwebrtc-m81.aar` put potentially you can
 reference any file name by modifying `build.gradle`.
 
 Make sure to have ANDROID_HOME point to your Android SDK. Use the Android SDK Manager to install missing dependencies.

build.gradle

@@ -1,12 +1,14 @@
+import com.android.build.OutputFile
+
 // Top-level build file where you can add configuration options common to all
 // sub-projects/modules.
 buildscript {
     repositories {
         google()
-        mavenCentral()
+        jcenter()
     }
     dependencies {
-        classpath 'com.android.tools.build:gradle:7.0.3'
+        classpath 'com.android.tools.build:gradle:4.1.2'
     }
 }
 
@@ -14,8 +16,8 @@ apply plugin: 'com.android.application'
 
 repositories {
     google()
-    mavenCentral()
     jcenter()
+    mavenCentral()
 }
 
 configurations {
@@ -33,23 +35,24 @@ configurations {
 dependencies {
     implementation 'androidx.viewpager:viewpager:1.0.0'
 
-    playstoreImplementation('com.google.firebase:firebase-messaging:22.0.0') {
+    //should remain that low because later versions introduce dependency to androidx (not sure exactly from what version)
+    playstoreImplementation('com.google.firebase:firebase-messaging:21.0.1') {
         exclude group: 'com.google.firebase', module: 'firebase-core'
         exclude group: 'com.google.firebase', module: 'firebase-analytics'
         exclude group: 'com.google.firebase', module: 'firebase-measurement-connector'
     }
     conversationsPlaystoreCompatImplementation("com.android.installreferrer:installreferrer:2.2")
     conversationsPlaystoreSystemImplementation("com.android.installreferrer:installreferrer:2.2")
-    quicksyPlaystoreCompatImplementation 'com.google.android.gms:play-services-auth-api-phone:17.5.1'
+    quicksyPlaystoreCompatImplementation 'com.google.android.gms:play-services-auth-api-phone:17.5.0'
-    quicksyPlaystoreSystemImplementation 'com.google.android.gms:play-services-auth-api-phone:17.5.1'
+    quicksyPlaystoreSystemImplementation 'com.google.android.gms:play-services-auth-api-phone:17.5.0'
     implementation 'org.sufficientlysecure:openpgp-api:10.0'
     implementation 'com.theartofdev.edmodo:android-image-cropper:2.8.0'
-    implementation 'androidx.appcompat:appcompat:1.3.1'
+    implementation 'androidx.appcompat:appcompat:1.2.0'
-    implementation 'androidx.exifinterface:exifinterface:1.3.3'
+    implementation 'androidx.exifinterface:exifinterface:1.3.2'
     implementation 'androidx.cardview:cardview:1.0.0'
     implementation 'androidx.swiperefreshlayout:swiperefreshlayout:1.1.0'
     implementation 'androidx.emoji:emoji:1.1.0'
-    implementation 'com.google.android.material:material:1.4.0'
+    implementation 'com.google.android.material:material:1.2.1'
     compatImplementation 'androidx.emoji:emoji-appcompat:1.1.0'
     conversationsFreeCompatImplementation 'androidx.emoji:emoji-bundled:1.1.0'
     quicksyFreeCompatImplementation 'androidx.emoji:emoji-bundled:1.1.0'
@@ -62,22 +65,21 @@ dependencies {
     implementation 'org.whispersystems:signal-protocol-java:2.6.2'
     implementation 'com.makeramen:roundedimageview:2.3.0'
     implementation "com.wefika:flowlayout:0.4.1"
-    implementation 'com.otaliastudios:transcoder:0.10.4'
+    implementation 'net.ypresto.androidtranscoder:android-transcoder:0.3.0'
-
+    implementation 'org.jxmpp:jxmpp-jid:0.6.4'
-    implementation 'org.jxmpp:jxmpp-jid:1.0.2'
+    implementation 'org.osmdroid:osmdroid-android:6.1.5'
-    implementation 'org.osmdroid:osmdroid-android:6.1.10'
     implementation 'org.hsluv:hsluv:0.2'
-    implementation 'org.conscrypt:conscrypt-android:2.5.2'
+    implementation 'org.conscrypt:conscrypt-android:2.2.1'
     implementation 'me.drakeet.support:toastcompat:1.1.0'
-    implementation "com.leinardi.android:speed-dial:3.2.0"
+    implementation "com.leinardi.android:speed-dial:2.0.1"
-
+    //retrofit needs to stick with 2.6.x (https://github.com/square/retrofit/blob/master/CHANGELOG.md)
-    implementation "com.squareup.retrofit2:retrofit:2.9.0"
+    implementation "com.squareup.retrofit2:retrofit:2.6.4"
-    implementation "com.squareup.retrofit2:converter-gson:2.9.0"
+    implementation "com.squareup.retrofit2:converter-gson:2.6.4"
-    implementation "com.squareup.okhttp3:okhttp:4.9.2"
+    //okhttp needs to stick with 3.12.x
-
+    implementation 'com.squareup.okhttp3:okhttp:3.12.12'
-    implementation 'com.google.guava:guava:30.1.1-android'
+    implementation 'com.google.guava:guava:27.1-android'
-    quicksyImplementation 'io.michaelrocks:libphonenumber-android:8.12.36'
+    quicksyImplementation 'io.michaelrocks:libphonenumber-android:8.12.16'
-    // implementation fileTree(include: ['libwebrtc-m92.aar'], dir: 'libs')
+    //implementation fileTree(include: ['libwebrtc-m87.aar'], dir: 'libs')
     implementation 'org.webrtc:google-webrtc:1.0.32006'
 }
 
@@ -93,25 +95,26 @@ android {
     defaultConfig {
         minSdkVersion 21
         targetSdkVersion 29
-        versionCode 4202301
+        versionCode 408
-        versionName "2.10.2"
+        versionName "2.9.6.1"
         archivesBaseName += "-$versionName"
         applicationId "eu.sum7.conversations"
         resValue "string", "applicationId", applicationId
-        def appName = "Conv6ations"
+        resValue "string", "app_name", "Conv6ations"
-        resValue "string", "app_name", appName
+        buildConfigField "String", "LOGTAG", "\"conver6ations\""
-        buildConfigField "String", "APP_NAME", "\"$appName\"";
     }
 
 
-    configurations {
-        implementation.exclude group: 'org.jetbrains' , module:'annotations'
-    }
-
     dataBinding {
         enabled true
     }
 
+    dexOptions {
+        // Skip pre-dexing when running on Travis CI or when disabled via -Dpre-dex=false.
+        preDexLibraries = preDexEnabled && !travisBuild
+        jumboMode true
+    }
+
     compileOptions {
         sourceCompatibility JavaVersion.VERSION_1_8
         targetCompatibility JavaVersion.VERSION_1_8
@@ -124,11 +127,9 @@ android {
         quicksy {
             dimension "mode"
             applicationId = "im.quicksy.client"
+            resValue "string", "app_name", "Quicksy"
             resValue "string", "applicationId", applicationId
-
+            buildConfigField "String", "LOGTAG", "\"quicksy\""
-            def appName = "Quicksy"
-            resValue "string", "app_name", appName
-            buildConfigField "String", "APP_NAME", "\"$appName\"";
         }
 
         conversations {
@@ -262,4 +263,5 @@ android {
         exclude 'META-INF/BCKEY.DSA'
         exclude 'META-INF/BCKEY.SF'
     }
+
 }

conversations.doap

@@ -453,19 +453,12 @@
             <xmpp:version>0.2.0</xmpp:version>
         </xmpp:SupportedXep>
     </implements>
-    <implements>
-        <xmpp:SupportedXep>
-            <xmpp:xep rdf:resource="https://xmpp.org/extensions/xep-0454.html"/>
-            <xmpp:status>complete</xmpp:status>
-            <xmpp:version>0.1.0</xmpp:version>
-        </xmpp:SupportedXep>
-    </implements>
 
     <release>
         <Version>
-            <revision>2.9.13</revision>
+            <revision>2.5.8</revision>
-            <created>2021-05-03</created>
+            <created>2019-09-12</created>
-            <file-release rdf:resource="https://github.com/iNPUTmice/Conversations/archive/2.9.13.tar.gz"/>
+            <file-release rdf:resource="https://github.com/iNPUTmice/Conversations/archive/2.5.8.tar.gz"/>
         </Version>
     </release>
 </Project>

docs/MISSION.md

@@ -0,0 +1,25 @@
+Conversations is a messenger for the next decade. Based on already established
+internet standards that have been around for over ten years Conversations isn’t
+trying to replace current commercial messengers. It will simply outlive them.
+Commercial, closed source products are coming and going. 15 years ago we had ICQ
+which was replaced by Skype. MySpace was replaced by Facebook. WhatsApp and
+Hangouts will disappear soon. Internet standards however stick around. People
+are still using IRC and e-mail even though these protocols have been around for
+decades. Utilizing proven standards doesn’t mean one can not evolve. GMail has
+revolutionized the way we look at e-mail. Firefox and Chrome have changed the
+way we use the Web. Conversations will change the way we look at instant
+messaging. Being less obtrusive than a telephone call instant messaging has
+always played an important role in modern society. Conversations will show that
+instant messaging can be fast, reliable and private. Conversations will not
+force its security and privacy aspects upon the user. For those willing to use
+encryption Conversations will make it as uncomplicated as possible. However
+Conversations is aware that end-to-end encryption by the very principle isn’t
+trivial. Instead of trying the impossible and making encryption easier than
+comparing a fingerprint Conversations will try to educate the willing user and
+explain the necessary steps and the reasons behind them. Those unwilling to
+learn about encryption will still be protected by the design principals of
+Conversations.  Conversations will simply not share or generate certain
+information for example by encouraging the use of federated servers.
+Conversations will always utilize the best available standards for encryption
+and media encoding instead of reinventing the wheel. However it isn’t afraid to
+break with behavior patterns that have been proven ineffective.

docs/XEPs.md

@@ -0,0 +1,32 @@
+* XEP-0027: Current Jabber OpenPGP Usage
+* XEP-0030: Service Discovery
+* XEP-0045: Multi-User Chat
+* XEP-0048: Bookmarks
+* XEP-0084: User Avatar
+* XEP-0085: Chat State Notifications
+* XEP-0092: Software Version
+* XEP-0115: Entity Capabilities
+* XEP-0163: Personal Eventing Protocol (avatars and nicks)
+* XEP-0166: Jingle (only used for file transfer)
+* XEP-0172: User Nickname
+* XEP-0184: Message Delivery Receipts (reply only)
+* XEP-0191: Blocking command
+* XEP-0198: Stream Management
+* XEP-0199: XMPP Ping
+* XEP-0234: Jingle File Transfer
+* XEP-0237: Roster Versioning
+* XEP-0245: The /me Command
+* XEP-0249: Direct MUC Invitations (receiving only)
+* XEP-0260: Jingle SOCKS5 Bytestreams Transport Method
+* XEP-0261: Jingle In-Band Bytestreams Transport Method
+* XEP-0280: Message Carbons
+* XEP-0308: Last Message Correction
+* XEP-0313: Message Archive Management
+* XEP-0319: Last User Interaction in Presence
+* XEP-0333: Chat Markers
+* XEP-0352: Client State Indication
+* XEP-0357: Push Notifications
+* XEP-0363: HTTP File Upload
+* XEP-0368: SRV records for XMPP over TLS
+* XEP-0377: Spam Reporting 
+* XEP-0384: OMEMO Encryption

docs/observations.md

@@ -0,0 +1,97 @@
+Observations on implementing XMPP
+=================================
+After spending the last two and a half month basically writing my own XMPP
+library from scratch I decided to share some of the observations I made in the
+process. In part this article can be seen as a response to a blog post made by
+Dr. Ing. Georg Lukas. The blog post introduces a couple of XEP (XMPP Extensions)
+which make the life on mobile devices a lot easier but states that they are
+currently very few implementations of those XEPs. So I went ahead and
+implemented all of them in my Android XMPP client.
+
+### General observations
+The first thing I noticed is that XMPP is actually okish designed. If you were
+to design a new chat protocol today you probably wouldn’t choose XML again
+however the protocol basically consists of only three different packages which
+are quickly hidden under some sort of abstraction layer within your library.
+Getting from zero to sending messages to other users actually was very simple
+and straight forward. But then came the XEPs.
+
+### Multi-User Chat
+The first one was XEP-0045 Multi-User Chat. This is the one XEP of the XEPs I’m
+going to mention in my article which is actually wildly adopted. Most clients
+and servers I know of support MUC. However the level of completeness varies.
+MUC actually introduces access and permission roles which are far more complex
+than what some of us are used to from IRC but a lot of clients just don’t
+implement them. I’m not implementing them myself (at least for now) because I
+somewhat doubt that someone would actually use them (however this might be some
+sort of chicken or egg problem). I did find some strange bugs though which might
+be interesting for other library developers. In theory a MUC server
+implementation can allow a  single user (same jid) to join a conference room
+multiple times with the same nick from different clients. This means if someone
+wants to participate in a conference from two different devices (mobile and
+desktop for example) one wouldn’t have to name oneself `userDesktop` and
+`userMobile` but just `user`. Both ejabberd and prosody support this but with
+strange side effects. Prosody for example doesn’t allow a user to change its
+name once two clients are “merged” by having the same nick.
+
+### Carbons and Stream Management
+Two of the other XEPs Lukas mentions — Carbons (XEP-0280) and Stream Management
+(XEP-0198) — were actually fairly easy to implement. The only challenges were to
+find a server to support them (I ended up running my own Prosody server) and a
+desktop client to test them with. For carbons there is a patched Mcabber version
+and Gajim. After implementing stream management I had very good results on my
+mobile device. I had sessions running for up to 24 hours with a walking outside,
+loosing mobile coverage for a few minutes and so on. The only limitation was
+that I had to keep on developing and reinstalling my app.
+
+### Off the record
+And then came OTR... This is were I spend the most time debugging stuff and
+trying to get things right and compatible with other clients. This is the part
+were I want to help other developers not to make the same mistakes and maybe
+come to some sort of consent among XMPP developers to ultimately increase the
+interoperability. OTR has some down sides which make it difficult or at times
+even dangerous to implement within XMPP. First of all it is a synchronous
+protocol which is tunneled through a different protocol (XMPP). Synchronous
+means — among other things — auto replies. (An OTR session begins with “hi I’m
+speaking otr give me your key” “ok cool here is my key”) And auto replies — we
+know that since the first time an out of office auto responder went postal — are
+dangerous. Things really start to get messy when you use one of the best
+features of XMPP — multiple clients. The way XMPP works is that clients are
+encouraged to send their messages to the raw jid and let the server decide what
+full jid the messages are routed to. If in doubt even all of them. So what
+happens when Alice sends a  start-otr-message to Bobs raw jid? Bob receives the
+message on his notebook as well as his cell phone. Both of them answer. Alice
+gets two different replies. Shit explodes. Even if Alice  sends the message to
+bob/notebook chances are that Bob has carbon messages enabled and still receives
+the messages on both devices. Now assuming that Bobs client is clever enough not
+to auto reply to carbonated messages Bob/cellphone will still end up with a lot
+of garbage messages. (Essentially the entire conversation between Alice and
+Bob/notebook but unreadable of course) Therefor it should be good practice to
+tag OTR messages as both private and no-copy (private is part of the carbons
+XEP, no-copy is a general hint). I found that prosody for some reasons doesn’t
+honor the private tag on outgoing messages. While this is easily fixed I presume
+that having both the private and the no-copy tag will make it more compatible
+with servers or clients I don’t know about yet.
+
+#### Rules to follow when implementing OTR
+To summarize my observations on implementing OTR in XMPP let me make the
+following three statements.
+
+1. While it is good practice for unencrypted messages to be send to the raw jid
+and have the receiving server or user decide how they should be routed OTR
+messages must be send to a specific resource. To make this work the user should
+be given the option to select the presence (which can be assisted with some
+educated guessing by the client based on previous messages).  Furthermore a
+client should encourage a user to choose meaningful presences instead of the
+clients name or even random ones. Something like `/mobile`, `/notebook`,
+`/desktop` is a greater assist to any one who wants to start an otr session then
+`/Gajim`, `/mcabber` or `/pidgin`.
+
+2. Messages should be tagged private and no-copy to avoid unnecessary traffic or
+otr error loops with faulty clients. This tagging should be done even if your
+own client doesn’t support carbons.
+
+3. When dealing with “legacy clients” — meaning clients which don’t follow my
+advise — a client should be extra careful not to create message loops. This
+means to not respond with otr errors if a client is not 100% sure it is the only
+client which received the message

gradle/wrapper/gradle-wrapper.properties

@@ -3,4 +3,4 @@ distributionBase=GRADLE_USER_HOME
 distributionPath=wrapper/dists
 zipStoreBase=GRADLE_USER_HOME
 zipStorePath=wrapper/dists
-distributionUrl=https\://services.gradle.org/distributions/gradle-7.0.2-all.zip
+distributionUrl=https\://services.gradle.org/distributions/gradle-6.5-all.zip

metadata/en-US/changelogs/42000.txt

@@ -1,4 +0,0 @@
-• Ability to select incoming call ringtone
-• Fix OpenPGP key id discovery for OpenKeychain 5.6+
-• Properly verify punycode TLS certificates
-• Improve stability of RTP session establishment (calling)

metadata/en-US/changelogs/42006.txt

@@ -1,2 +0,0 @@
-• Verify A/V calls with preexisting OMEMO sessions
-• Improve compatibility with non libwebrtc WebRTC implementations

metadata/en-US/changelogs/42010.txt

@@ -1 +0,0 @@
-• Various bug fixes around Tor support

metadata/en-US/changelogs/42013.txt

@@ -1,3 +0,0 @@
-• Improve call compatibility with Dino
-• fix HTTP up/download for users that don’t trust system CAs
-• Fixed 'No Connectivity' issues on Android 7.1

metadata/en-US/changelogs/42015.txt

@@ -1,3 +0,0 @@
-• Always verify domain name. No user overwrite
-• Support roster pre authentication
-• minor A/V improvements 

metadata/en-US/changelogs/42018.txt

@@ -1,3 +0,0 @@
-• Show black bars when remote video does not match aspect ratio of screen
-• Improve search performance
-• Add setting to prevent screenshots

metadata/en-US/changelogs/42022.txt

@@ -1,2 +0,0 @@
-• Fix issue with some videos not being compressed
-• Fix rare crash when opening notification

metadata/en-US/changelogs/42023.txt

@@ -1,2 +0,0 @@
-• Fix crash when rendering some quotes
-• Fix crash in welcome screen

metadata/en-US/changelogs/4202301.txt

@@ -1 +0,0 @@
-• Fix usage directTLS of manuelle enter an address

proguard-rules.pro

@@ -26,15 +26,6 @@
 -dontwarn java.lang.**
 -dontwarn javax.lang.**
 
--dontwarn com.android.org.conscrypt.SSLParametersImpl
--dontwarn org.apache.harmony.xnet.provider.jsse.SSLParametersImpl
--dontwarn org.bouncycastle.jsse.BCSSLParameters
--dontwarn org.bouncycastle.jsse.BCSSLSocket
--dontwarn org.bouncycastle.jsse.provider.BouncyCastleJsseProvider
--dontwarn org.openjsse.javax.net.ssl.SSLParameters
--dontwarn org.openjsse.javax.net.ssl.SSLSocket
--dontwarn org.openjsse.net.ssl.OpenJSSE
-
 -keepclassmembers class eu.siacs.conversations.http.services.** {
   !transient <fields>;
 }

src/conversations/java/eu/siacs/conversations/ui/ImportBackupActivity.java

@@ -6,6 +6,7 @@ import android.content.DialogInterface;
 import android.content.Intent;
 import android.content.ServiceConnection;
 import android.net.Uri;
+import android.os.Build;
 import android.os.Bundle;
 import android.os.IBinder;
 import android.util.Log;
@@ -29,7 +30,6 @@ import eu.siacs.conversations.databinding.ActivityImportBackupBinding;
 import eu.siacs.conversations.databinding.DialogEnterPasswordBinding;
 import eu.siacs.conversations.services.ImportBackupService;
 import eu.siacs.conversations.ui.adapter.BackupFileAdapter;
-import eu.siacs.conversations.ui.util.SettingsUtils;
 import eu.siacs.conversations.utils.ThemeHelper;
 
 public class ImportBackupActivity extends ActionBarActivity implements ServiceConnection, ImportBackupService.OnBackupFilesLoaded, BackupFileAdapter.OnItemClickedListener, ImportBackupService.OnBackupProcessed {
@@ -56,12 +56,6 @@ public class ImportBackupActivity extends ActionBarActivity implements ServiceCo
         this.backupFileAdapter.setOnItemClickedListener(this);
     }
 
-    @Override
-    protected void onResume(){
-        super.onResume();
-        SettingsUtils.applyScreenshotPreventionSetting(this);
-    }
-
     @Override
     public boolean onCreateOptionsMenu(final Menu menu) {
         getMenuInflater().inflate(R.menu.import_backup, menu);
@@ -131,8 +125,7 @@ public class ImportBackupActivity extends ActionBarActivity implements ServiceCo
         try {
             final ImportBackupService.BackupFile backupFile = ImportBackupService.BackupFile.read(this, uri);
             showEnterPasswordDialog(backupFile, finishOnCancel);
-        } catch (final IOException | IllegalArgumentException e) {
+        } catch (IOException | IllegalArgumentException e) {
-            Log.d(Config.LOGTAG, "unable to open backup file " + uri, e);
             Snackbar.make(binding.coordinator, R.string.not_a_backup_file, Snackbar.LENGTH_LONG).show();
         }
     }
@@ -188,7 +181,6 @@ public class ImportBackupActivity extends ActionBarActivity implements ServiceCo
 
     @Override
     public void onActivityResult(int requestCode, int resultCode, Intent intent) {
-        super.onActivityResult(requestCode, resultCode, intent);
         if (resultCode == RESULT_OK) {
             if (requestCode == 0xbac) {
                 openBackupFileFromUri(intent.getData(), false);
@@ -233,17 +225,15 @@ public class ImportBackupActivity extends ActionBarActivity implements ServiceCo
     @Override
     public boolean onOptionsItemSelected(MenuItem item) {
         if (item.getItemId() == R.id.action_open_backup_file) {
-            openBackupFile();
+            Intent intent = new Intent(Intent.ACTION_GET_CONTENT);
+            intent.setType("*/*");
+            if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.JELLY_BEAN_MR2) {
+                intent.putExtra(Intent.EXTRA_ALLOW_MULTIPLE, false);
+            }
+            intent.addCategory(Intent.CATEGORY_OPENABLE);
+            startActivityForResult(Intent.createChooser(intent, getString(R.string.open_backup)), 0xbac);
             return true;
         }
         return super.onOptionsItemSelected(item);
     }
-
-    private void openBackupFile() {
-        final Intent intent = new Intent(Intent.ACTION_GET_CONTENT);
-        intent.setType("*/*");
-        intent.putExtra(Intent.EXTRA_ALLOW_MULTIPLE, false);
-        intent.addCategory(Intent.CATEGORY_OPENABLE);
-        startActivityForResult(Intent.createChooser(intent, getString(R.string.open_backup)), 0xbac);
-    }
 }

src/conversations/java/eu/siacs/conversations/ui/ManageAccountActivity.java

@@ -228,7 +228,6 @@ public class ManageAccountActivity extends XmppActivity implements OnAccountUpda
 
     @Override
     public void onRequestPermissionsResult(int requestCode, @NonNull String[] permissions, @NonNull int[] grantResults) {
-        super.onRequestPermissionsResult(requestCode, permissions, grantResults);
         if (grantResults.length > 0) {
             if (allGranted(grantResults)) {
                 switch (requestCode) {

src/conversations/java/eu/siacs/conversations/ui/WelcomeActivity.java

@@ -106,8 +106,7 @@ public class WelcomeActivity extends XmppActivity implements XmppConnectionServi
     }
 
     @Override
-    public void onNewIntent(final Intent intent) {
+    public void onNewIntent(Intent intent) {
-        super.onNewIntent(intent);
         if (intent != null) {
             setIntent(intent);
         }
@@ -202,7 +201,6 @@ public class WelcomeActivity extends XmppActivity implements XmppConnectionServi
 
     @Override
     public void onRequestPermissionsResult(int requestCode, @NonNull String[] permissions, @NonNull int[] grantResults) {
-        super.onRequestPermissionsResult(requestCode, permissions, grantResults);
         UriHandlerActivity.onRequestPermissionResult(this, requestCode, grantResults);
         if (grantResults.length > 0) {
             if (allGranted(grantResults)) {

src/conversations/java/eu/siacs/conversations/utils/PhoneNumberUtilWrapper.java

@@ -1,11 +0,0 @@
-package eu.siacs.conversations.utils;
-
-import android.content.Context;
-
-import eu.siacs.conversations.xmpp.Jid;
-
-public class PhoneNumberUtilWrapper {
-    public static String toFormattedPhoneNumber(Context context, Jid jid) {
-        throw new AssertionError("This method is not implemented in Conversations");
-    }
-}

src/conversations/res/values-ar/strings.xml

@@ -3,18 +3,4 @@
     <string name="pick_a_server">اختر مزود خدمة XMPP الخاص بك</string>
     <string name="use_chat.sum7.eu">استخدِم chat.sum7.eu</string>
     <string name="create_new_account">أنشئ حسابًا جديدًا</string>
-    <string name="do_you_have_an_account">هل تملك حساب XMPP؟؟ قد يكون ذلك ممكنا لو كنت تستعمل خدمة XMPP أخرى أو إستعملت تطبيق كونفرسايشنز سابقا. أو يمكنك صنع حساب XMPP جديد الآن.
-ملاحظة: بعض خدمات البريد الإلكتروني تقدم حسابات XMPP.</string>
-    <string name="server_select_text">XMPP هي خدمة مستقلة للتواصل بشبكة الرسائل المباشرة. يمكنك إستعمال هذه الخدمة مع أي خادم XMPP تختاره.
-سعيا لراحتك جعلنا خلق حساب في كونفيرسايشنز سهلا مع مقدم خدمة خاص بالإستعمال مع كونفيرسايشنز.</string>
-    <string name="magic_create_text_on_x">لقد تمت دعوتك لـ %1$s. سيتم دلّك على طريقة صنع حساب.
-عندما تختار %1$sكمقدّم خدمة سيصبح من الممكن لك التواصل مع مستعملين من أي خادم آخر عن طريق إعطائهم عنوانك الكامل على XMPP.</string>
-    <string name="magic_create_text_fixed">تمّت دعوتك إلى %1$s. تم إختيار إسم مستخدم خاص بك. سيتم قيادتك عبر طريقة صنع حساب.
-سيمكنك التواصل مع مستخدمين من مزودين آخرين عبر إعطائهم كامل عنوانك XMPP.</string>
-    <string name="your_server_invitation">سيرفر دعوتك</string>
-    <string name="improperly_formatted_provisioning">لم يتم التقاط الكود بطريقة جيّدة</string>
-    <string name="tap_share_button_send_invite">إضغط على زر مشاركة لترسل إلى المتصل بك دعوة إلى %1$s.</string>
-    <string name="if_contact_is_nearby_use_qr">إذا كان المتصل بك قريبا منك، يمكنه فحص الكود بالأسفل ليقبل دعوتك.</string>
-    <string name="easy_invite_share_text">إنظم %1$s وتحدّث معي: %2$s</string>
-    <string name="share_invite_with">شارك إستدعاء مع...</string>
     </resources>

src/conversations/res/values-bn-rIN/strings.xml

@@ -1,16 +0,0 @@
-<?xml version="1.0" encoding="utf-8"?>
-<resources>
-    <string name="pick_a_server">XMPP সার্ভার নির্বাচন করুন</string>
-    <string name="use_chat.sum7.eu">chat.sum7.eu ব্যবহার করা যাক</string>
-    <string name="create_new_account">নতুন অ্যকাউন্ট তৈরী করা যাক</string>
-    <string name="do_you_have_an_account">আপনার কি একটা XMPP অ্যকাউন্ট ইতিমধ্যে করা আছে? সেরকমটা হতেই পারে যদি এর আগে আপনি কোনো অন্য XMPP প্রোগ্রাম বা অ্যাপ ব্যবহার করে থাকেন। এই মুহুর্তে আরেকটা অ্যকাউন্ট তৈরী করা সম্ভব না।‌\nHint: মাঝে মাঝে ইমেল অ্যকাউন্ট খুললেও এরকম অ্যকাউন্ট নিজে থেকেই তৈরী হয়ে যায়।</string>
-    <string name="server_select_text">XMPP কোনো একটি নির্দিষ্ট সংস্থার উপরে নির্ভরশীল নয়। এই অ্যপটি আপনি যেকোনো সংস্থার XMPP সার্ভারের সাথে ব্যবহার করতে পারেন।\nমনে রাখবেন, সুধুমাত্র আপনার সুবিধার্থেই chat.sum7.eu -এ আপনার জন্যে একটি অ্যকাউন্ট তৈরী করে দেওয়া হয়েছে। Conversations অ্যপটি এই সার্ভারের সাথে সবথেকে বেশী কার্যকারী।</string>
-    <string name="magic_create_text_on_x">আপনাকে %1$s-এ আমন্ত্রিত করা হয়েছে। অ্যকাউন্ট তৈরী করার সময় আপনাকে সাহায্য করা হবে।\n%1$s ব্যবহার করলেও, অন্য সেবা-প্রদানকারী সংস্থার ব্যবহারকারীদের সাথে আপনি কথা বলতে পারবেন, আপনার সম্পূর্ণ XMPP অ্যড্রেস তাদেরকে বলে দিয়ে।</string>
-    <string name="magic_create_text_fixed">আপনাকে %1$s-এ নিমন্ত্রণ করা হয়েছে। একটি username-ও আপনার জন্যে নির্দিষ্ট করে রাখা হয়েছে। অ্যকাউন্ট তৈরী করার সময় আপনাকে সাহায্য করা হবে।\nঅন্য XMPP সেবা প্রদানকারী সংস্থার ব্যবহারকারীদের সাথে আপনিও কথা বলতে পারবেন, আপনার সম্পূর্ণ XMPP অ্যড্রেস তাদেরকে বলে দিয়ে।</string>
-    <string name="your_server_invitation">আপনার নিমন্ত্রণপত্র, সার্ভার থেকে</string>
-    <string name="improperly_formatted_provisioning">Provisioning code-এ গরমিল আছে</string>
-    <string name="tap_share_button_send_invite">Share বোতামটা টিপে %1$s-কে একটি আমন্ত্রপত্র পাঠান</string>
-    <string name="if_contact_is_nearby_use_qr">পরিচিত ব্যক্তি যদি নিকটেই থাকেন, তাহলে তারা এই কোডটাও স্ক্যান করে নিতে পারেন</string>
-    <string name="easy_invite_share_text">%1$sতে এসো, আর আমার সাথে কথা বলো: %2$s</string>
-    <string name="share_invite_with">একটি আমন্ত্রণপত্র দেওয়া যাক...</string>
-</resources>

src/conversations/res/values-da-rDK/strings.xml

@@ -1,16 +0,0 @@
-<?xml version="1.0" encoding="utf-8"?>
-<resources>
-    <string name="pick_a_server">Vælg din XMPP-udbyder</string>
-    <string name="use_chat.sum7.eu">Brug chat.sum7.eu</string>
-    <string name="create_new_account">Opret ny konto</string>
-    <string name="do_you_have_an_account">Har du allerede en XMPP-konto? Dette kan være tilfældet, hvis du allerede bruger en anden XMPP-klient eller har brugt Conversations før. Hvis ikke, kan du lige nu oprette en ny XMPP-konto.\nTip: Nogle e-mail-udbydere leverer også XMPP-konti.</string>
-    <string name="server_select_text">XMPP er et udbyderuafhængigt onlinemeddelelsesnetværk. Du kan bruge denne klient med hvilken XMPP-server du end vælger.\nMen for din nemhedsskyld har vi gjort vi det let at oprette en konto på chat.sum7.eu; en udbyder, der er specielt velegnet til brug med Conversations.</string>
-    <string name="magic_create_text_on_x">Du er blevet inviteret til %1$s. Vi guider dig gennem processen med at oprette en konto.\nNår du vælger %1$s som udbyder, kan du kommunikere med brugere fra andre udbydere ved at give dem din fulde XMPP-adresse.</string>
-    <string name="magic_create_text_fixed">Du er blevet inviteret til %1$s. Der er allerede valgt et brugernavn til dig. Vi guider dig gennem processen med at oprette en konto.\nDu vil være i stand til at kommunikere med brugere fra andre udbydere ved at give dem din fulde XMPP-adresse.</string>
-    <string name="your_server_invitation">Din server invitation</string>
-    <string name="improperly_formatted_provisioning">Forkert formateret klargøringskode</string>
-    <string name="tap_share_button_send_invite">Tryk på deleknappen for at sende din kontakt en invitation til %1$s.</string>
-    <string name="if_contact_is_nearby_use_qr">Hvis din kontakt er i nærheden, kan de også skanne koden nedenfor for at acceptere din invitation.</string>
-    <string name="easy_invite_share_text">Deltag med %1$s og chat med mig: %2$s</string>
-    <string name="share_invite_with">Del invitation med...</string>
-</resources>

src/conversations/res/values-el/strings.xml

@@ -9,8 +9,4 @@
     <string name="magic_create_text_fixed">Έχετε προσκληθεί στο %1$s. Ένα όνομα χρήστη έχει ήδη επιλεγεί για εσάς. Θα σας καθοδηγήσουμε στη διαδικασία δημιουργίας λογαριασμού.\nΘα μπορείτε να επικοινωνείτε με χρήστες άλλων παρόχων δίνοντάς τους την πλήρη διεύθυνση XMPP σας.</string>
     <string name="your_server_invitation">Η πρόσκλησή σας στον διακομιστή</string>
     <string name="improperly_formatted_provisioning">Λάθος μορφοποίηση κώδικα παροχής</string>
-    <string name="tap_share_button_send_invite">Πατήστε το πλήκτρο διαμοιρασμού για να στείλετε στην επαφή σας μια πρόσκληση στο %1$s.</string>
-    <string name="if_contact_is_nearby_use_qr">Αν η επαφή σας βρίσκεται κοντά σας, μπορεί επίσης να σαρώσει τον κωδικό παρακάτω για να αποδεχτεί την πρόσκλησή σας.</string>
-    <string name="easy_invite_share_text">Μπείτε στο %1$s και συνομιλήστε μαζί μου: %2$s</string>
-    <string name="share_invite_with">Διαμοιρασμός πρόσκλησης με...</string>
     </resources>

src/conversations/res/values-fr/strings.xml

@@ -9,8 +9,4 @@
     <string name="magic_create_text_fixed">Vous avez été invité à %1$s. Un nom d’utilisateur a déjà été choisi pour vous. Nous allons vous guider à travers le processus de création d’un compte.\nVous pourrez communiquer avec les utilisateurs des autres fournisseurs en leur donnant votre adresse XMPP complète.</string>
     <string name="your_server_invitation">Votre invitation au serveur</string>
     <string name="improperly_formatted_provisioning">Code de provisionnement mal formaté</string>
-    <string name="tap_share_button_send_invite">Appuyez sur le bouton partager pour envoyer à votre contact une invitation pour %1$s</string>
-    <string name="if_contact_is_nearby_use_qr">Si vos contacts sont à votre côté, ils peuvent aussi scanner le code ci dessous pour accepter votre invitation</string>
-    <string name="easy_invite_share_text">Rejoignez %1$set discutez avec moi : %2$s</string>
-    <string name="share_invite_with">Partager une invitation avec ...</string>
     </resources>

src/conversations/res/values-hu/strings.xml

@@ -9,8 +9,4 @@
     <string name="magic_create_text_fixed">Meghívást kapott a(z) %1$s kiszolgálóra. Már kiválasztottak Önnek egy felhasználónevet. Végig fogjuk vezetni egy fiók létrehozásának folyamatán.\nKépes lesz más szolgáltatók felhasználóival is kommunikálni, ha megadja nekik a teljes XMPP-címét.</string>
     <string name="your_server_invitation">Az Ön kiszolgálómeghívása</string>
     <string name="improperly_formatted_provisioning">Helytelenül formázott kiépítési kód</string>
-    <string name="tap_share_button_send_invite">Koppintson a megosztás gombra, hogy meghívót küldjön a partnerének erre: %1$s.</string>
-    <string name="if_contact_is_nearby_use_qr">Ha a partnere a közelben van, akkor a meghívás elfogadásához leolvashatja a lenti kódot.</string>
-    <string name="easy_invite_share_text">Csatlakozzon ehhez: %1$s, és csevegjen velem: %2$s</string>
-    <string name="share_invite_with">Meghívás megosztása…</string>
     </resources>

src/conversations/res/values-it/strings.xml

@@ -1,14 +1,14 @@
 <?xml version="1.0" encoding="utf-8"?>
 <resources>
-    <string name="pick_a_server">Scegli il tuo fornitore XMPP</string>
+    <string name="pick_a_server">Scegli il tuo provider XMPP</string>
     <string name="use_chat.sum7.eu">Usa chat.sum7.eu</string>
-    <string name="create_new_account">Crea un nuovo profilo</string>
+    <string name="create_new_account">Crea un nuovo account</string>
-    <string name="do_you_have_an_account">Possiedi già un profilo XMPP? Questo succede se stai già usando un diverso client XMPP o hai già usato prima Conversations. In caso negativo puoi creare un profilo XMPP adesso.
+    <string name="do_you_have_an_account">Possiedi già un account XMPP? Questo succede se stai già usando un diverso client XMPP o hai già usato prima Conversations. In caso negativo puoi creare un account XMPP adesso.
 Suggerimento: alcuni provider di email forniscono anche un account XMPP.</string>
-    <string name="server_select_text">XMPP è una rete di messaggistica istantanea indipendente dal fornitore. Puoi usare questo client con qualsiasi server XMPP.
+    <string name="server_select_text">XMPP è una rete di instant messaging indipendente dal provider. Puoi usare questo client con qualsiasi server XMPP.
-In ogni caso per facilitare puoi creare facilmente un account su chat.sum7.eu, un fornitore pensato apposta per essere usato con Conversations.</string>
+In ogni caso per facilitare puoi creare facilmente un account su chat.sum7.eu, un provider pensato apposta per essere usato con Conversations.</string>
-    <string name="magic_create_text_on_x">Hai ricevuto un invito per %1$s. Ti guideremo nel procedimento per creare un profilo.\nQuando scegli %1$s come fornitore sarai in grado di comunicare con utenti di altri fornitori dando loro l\'indirizzo XMPP completo.</string>
+    <string name="magic_create_text_on_x">Sei stato invitato su %1$s. Ti guideremo nel procedimento per creare un account.\nQuando scegli %1$s come fornitore sarai in grado di comunicare con utenti di altri fornitori dando loro l\'indirizzo XMPP completo.</string>
-    <string name="magic_create_text_fixed">Hai ricevuto un invito per %1$s. È già stato scelto un nome utente per te. Ti guideremo nel procedimento per creare un profilo.\nSarai in grado di comunicare con utenti di altri fornitori dando loro l\'indirizzo XMPP completo.</string>
+    <string name="magic_create_text_fixed">Sei stato invitato su %1$s. È già stato scelto un nome utente per te. Ti guideremo nel procedimento per creare un account.\nSarai in grado di comunicare con utenti di altri fornitori dando loro l\'indirizzo XMPP completo.</string>
     <string name="your_server_invitation">Il tuo invito al server</string>
     <string name="improperly_formatted_provisioning">Codice di approvvigionamento formattato male</string>
     <string name="tap_share_button_send_invite">Tocca il pulsante condividi per inviare al contatto un invito per %1$s.</string>

src/conversations/res/values-ja/strings.xml

@@ -2,15 +2,11 @@
 <resources>
     <string name="pick_a_server">XMPPプロバイダーを選択してください</string>
     <string name="use_chat.sum7.eu">chat.sum7.euを利用する</string>
-    <string name="create_new_account">新規アカウントを作成</string>
+    <string name="create_new_account">アカウントを作成</string>
-    <string name="do_you_have_an_account">XMPP アカウントをお持ちですか？既にほかの XMPP クライアントを利用しているか、 Conversations を利用したことがある場合はこちら。初めての方は、今すぐ新規 XMPP アカウントを作成できます。\nヒント: e メールのプロバイダーが XMPP アカウントも提供している場合があります。</string>
+    <string name="do_you_have_an_account">XMPPアカウントをお持ちですか？既にほかのXMPPクライアントを利用しているか、Conversationsを利用したことがある場合はこちら。初めての方は、今すぐ新しいXMPPアカウントを作成できます。\nヒント: eメールのプロバイダーがXMPPアカウントも提供している場合があります。</string>
     <string name="server_select_text">XMPPは、プロバイダーに依存しないインスタントメッセージのプロトコルです。XMPPサーバーならどこでも、このクライアントを使用することができます。\nよろしければ、Conversationsに最適化されたプロバイダーchat.sum7.euで簡単にアカウントを作成することもできます。</string>
     <string name="magic_create_text_on_x">%1$sへ招待されました。アカウント作成手順をご案内します。 \n%1$sをプロバイダーに選択してほかのプロバイダーのユーザーと会話するには、XMPPのフルアドレスを相手にお知らせください。</string>
-    <string name="magic_create_text_fixed">%1$s へ招待されました。ユーザー名は既に選択されています。アカウント作成手順をご案内します。 \nほかのプロバイダーのユーザーと会話するには、 XMPP のフルアドレスを相手にお知らせください。</string>
+    <string name="magic_create_text_fixed">%1$sへ招待されました。ユーザーネームは既に選択されています。アカウント作成手順をご案内します。 \nほかのプロバイダーのユーザーと会話するには、XMPPのフルアドレスを相手にお知らせください。</string>
     <string name="your_server_invitation">サーバーの招待</string>
     <string name="improperly_formatted_provisioning">仮コードの書式が不正です</string>
-    <string name="tap_share_button_send_invite">共有ボタンを叩いて、連絡先の %1$s に招待を送信する。</string>
-    <string name="if_contact_is_nearby_use_qr">あなたの連絡先が近くにいる場合は、下のコードをスキャンして、あなたの招待を受け取ることもできます。</string>
-    <string name="easy_invite_share_text">%1$s に参加して私とお話しましょう: %2$s</string>
-    <string name="share_invite_with">…で招待を共有</string>
     </resources>

src/conversations/res/values-ru/strings.xml

@@ -9,8 +9,4 @@
     <string name="magic_create_text_fixed">Вас пригласили на %1$s. Вам уже назначили имя пользователя. Мы проведём вас через процесс создания аккаунта. Этот аккаунт позволит вам общаться с пользователями и на этом, и на других серверах, используя ваш полный XMPP-адрес.</string>
     <string name="your_server_invitation">Ваше приглашение</string>
     <string name="improperly_formatted_provisioning">Неправильный формат кода</string>
-    <string name="tap_share_button_send_invite">Нажмите кнопку «Поделиться», чтобы отправить вашему контакту приглашение в %1$s.</string>
-    <string name="if_contact_is_nearby_use_qr">Если ваш контакт находится поблизости, он также может отсканировать приведенный ниже код, чтобы принять ваше приглашение.</string>
-    <string name="easy_invite_share_text">Присоединяйтесь к %1$s и пообщайтесь со мной: %2$s</string>
-    <string name="share_invite_with">Поделиться приглашением с…</string>
     </resources>

src/conversations/res/values-sk/strings.xml

@@ -1,14 +0,0 @@
-<?xml version="1.0" encoding="utf-8"?>
-<resources>
-    <string name="pick_a_server">Vyberte si svojho XMPP poskytovateľa</string>
-    <string name="use_chat.sum7.eu">Použiť chat.sum7.eu</string>
-    <string name="create_new_account">Vytvoriť nové konto</string>
-    <string name="do_you_have_an_account">Máte už svoje XMPP konto? Môže to tak byť v prípade, že už používate iného klienta XMPP alebo ste predtým používali Conversations. Ak nie, môžete si vytvoriť nové XMPP konto práve teraz.\nHint: Niektorí poskytovatelia emailu zároveň poskytujú aj XMPP kontá.</string>
-    <string name="server_select_text">XMPP je sieť pre okamžité správy nezávislá od poskytovateľa. Tohto klienta môžete používať s akýmkoľvek XMPP serverom, ktorý si vyberiete..\nAvšak pre vaše pohodlie sme zjednodušili vytvorenie konta na chat.sum7.eu; poskytovateľ špeciálne vhodný na používanie s Conversations.</string>
-    <string name="magic_create_text_on_x">Boli ste pozvaný do %1$s. Prevedieme vás procesom vytvorenia konta..\nPo výbere %1$s ako poskytovateľa, budete môcť komunikovať s užívateľmi iných poskytovateľov tak, že im dáte vašu úplnú XMPP adresu.</string>
-    <string name="magic_create_text_fixed">Boli ste pozvaný do %1$s . Užívateľské meno vám už bolo vopred vybrané. Prevedieme vás procesom vytvorenia konta..\nBudete môcť komunikovať s užívateľmi iných poskytovateľov tak, že im dáte vašu úplnú XMPP adresu.</string>
-    <string name="tap_share_button_send_invite">Ťuknite na tlačidlo zdieľať na odoslanie pozvánky do %1$s vášmu kontaktu.</string>
-    <string name="if_contact_is_nearby_use_qr">Ak je váš kontakt blízko, na prijatie vašej pozvánky si môže nasnímať kód nižšie.</string>
-    <string name="easy_invite_share_text">Pripojte sa k %1$sa rozprávajte sa so mnou: %2$s</string>
-    <string name="share_invite_with">Zdieľať pozvánku s...</string>
-</resources>

src/conversations/res/values-sv/strings.xml

@@ -1,8 +1,5 @@
 <?xml version="1.0" encoding="utf-8"?>
 <resources>
-    <string name="pick_a_server">Välj din XMPP leverantör</string>
     <string name="use_chat.sum7.eu">Använd chat.sum7.eu</string>
     <string name="create_new_account">Skapa nytt konto</string>
-    <string name="your_server_invitation">Din server inbjudan</string>
-    <string name="share_invite_with">Dela inbjudan med...</string>
     </resources>

src/conversations/res/values-vi/strings.xml

@@ -1,16 +0,0 @@
-<?xml version="1.0" encoding="utf-8"?>
-<resources>
-    <string name="pick_a_server">Chọn nhà cung cấp XMPP của bạn</string>
-    <string name="use_chat.sum7.eu">Sử dụng chat.sum7.eu</string>
-    <string name="create_new_account">Tạo tài khoản mới</string>
-    <string name="do_you_have_an_account">Bạn đã có tài khoản XMPP chưa? Điều này có thể đúng nếu bạn đang dùng một ứng dụng khách cho XMPP khác hoặc đã sử dụng Conversations trước đó. Nếu không, bạn có thể tạo tài khoản XMPP mới ngay bây giờ.\nGợi ý: Một số nhà cung cấp email cũng cung cấp tài khoản XMPP.</string>
-    <string name="server_select_text">XMPP là một mạng nhắn tin ngay lập tức không phụ thuộc vào nhà cung cấp. Bạn có thể sử dụng ứng dụng khách này với bất kỳ máy chủ XMPP nào mà bạn chọn.\nTuy nhiên, vì sự thuận tiện của bạn, chúng tôi đã làm cho việc tạo tài khoản trên chat.sum7.eu được dễ dàng; một nhà cung cấp đặc biệt phù hợp với việc sử dụng Conversations.</string>
-    <string name="magic_create_text_on_x">Bạn đã được mời vào %1$s. Chúng tôi sẽ hướng dẫn bạn trong quá trình tạo tài khoản.\nKhi chọn %1$s là nhà cung cấp, bạn sẽ có thể giao tiếp với những người dùng của các nhà cung cấp khác bằng cách đưa cho họ địa chỉ XMPP đầy đủ của bạn.</string>
-    <string name="magic_create_text_fixed">Bạn đã được mời vào %1$s. Một tên người dùng đã được chọn sẵn cho bạn. Chúng tôi sẽ hướng dẫn bạn trong quá trình tạo tài khoản.\nBạn sẽ có thể giao tiếp với những người dùng của các nhà cung cấp khác bằng cách đưa cho họ địa chỉ XMPP đầy đủ của bạn.</string>
-    <string name="your_server_invitation">Lời mời vào máy chủ của bạn</string>
-    <string name="improperly_formatted_provisioning">Mã cung cấp không được định dạng đúng</string>
-    <string name="tap_share_button_send_invite">Nhấn nút chia sẻ để gửi lời mời vào %1$s đến liên hệ của bạn.</string>
-    <string name="if_contact_is_nearby_use_qr">Nếu liên hệ của bạn ở gần đây, họ cũng có thể quét mã ở dưới để chấp nhận lời mời của bạn.</string>
-    <string name="easy_invite_share_text">Hãy tham gia vào %1$s và trò chuyện với tôi: %2$s</string>
-    <string name="share_invite_with">Chia sẻ lời mời với...</string>
-</resources>

src/main/AndroidManifest.xml

@@ -39,6 +39,8 @@
     <uses-permission android:name="android.permission.USE_FULL_SCREEN_INTENT" />
     <uses-permission android:name="android.permission.SYSTEM_ALERT_WINDOW" />
 
+    <uses-sdk tools:overrideLibrary="net.ypresto.androidtranscoder" />
+
     <uses-feature
         android:name="android.hardware.camera"
         android:required="false" />
@@ -52,8 +54,7 @@
 
 
     <application
-        android:allowBackup="true"
+        android:allowBackup="false"
-        android:fullBackupContent="@xml/backup_content"
         android:appCategory="social"
         android:hardwareAccelerated="true"
         android:icon="@mipmap/new_launcher"
@@ -143,14 +144,6 @@
                 <data android:scheme="imto" />
                 <data android:host="jabber" />
             </intent-filter>
-            <intent-filter>
-                <action android:name="android.intent.action.SENDTO" />
-
-                <category android:name="android.intent.category.DEFAULT" />
-
-                <data android:scheme="imto" />
-                <data android:host="xmpp" />
-            </intent-filter>
         </activity>
         <activity
             android:name=".ui.StartConversationActivity"

src/main/java/eu/siacs/conversations/Config.java

@@ -3,12 +3,9 @@ package eu.siacs.conversations;
 import android.graphics.Bitmap;
 import android.net.Uri;
 
-import java.util.Arrays;
 import java.util.Collections;
 import java.util.List;
-import java.util.Locale;
 
-import eu.siacs.conversations.crypto.XmppDomainVerifier;
 import eu.siacs.conversations.xmpp.Jid;
 import eu.siacs.conversations.xmpp.chatstate.ChatState;
 
@@ -36,7 +33,7 @@ public final class Config {
         return (ENCRYPTION_MASK & (ENCRYPTION_MASK - 1)) != 0;
     }
 
-    public static final String LOGTAG = BuildConfig.APP_NAME.toLowerCase(Locale.US);
+    public static final String LOGTAG = BuildConfig.LOGTAG;
 
     public static final Jid BUG_REPORTS = Jid.of("bugs@chat.sum7.eu");
     public static final Uri HELP = Uri.parse("https://sum7.eu/chat");
@@ -104,7 +101,6 @@ public final class Config {
     public static final boolean REMOVE_BROKEN_DEVICES = false;
     public static final boolean OMEMO_PADDING = false;
     public static final boolean PUT_AUTH_TAG_INTO_KEY = true;
-    public static final boolean AUTOMATICALLY_COMPLETE_SESSIONS = true;
 
     public static final boolean USE_BOOKMARKS2 = false;
 
@@ -118,7 +114,6 @@ public final class Config {
     public static final boolean ENCRYPT_ON_HTTP_UPLOADED = false;
 
     public static final boolean X509_VERIFICATION = false; //use x509 certificates to verify OMEMO keys
-    public static final boolean REQUIRE_RTP_VERIFICATION = false; //require a/v calls to be verified with OMEMO
 
     public static final boolean ONLY_INTERNAL_STORAGE = false; //use internal storage instead of sdcard to save attachments
 
@@ -178,14 +173,7 @@ public final class Config {
 
         //if the contacts domain matches one of the following domains OMEMO won’t be turned on automatically
         //can be used for well known, widely used gateways
-        private static final List<String> CONTACT_DOMAINS = Arrays.asList(
+        public static final List<String> CONTACT_DOMAINS = Collections.singletonList("cheogram.com");
-                "cheogram.com",
-                "*.covid.monal.im"
-        );
-
-        public static boolean matchesContactDomain(final String domain) {
-            return XmppDomainVerifier.matchDomain(domain, CONTACT_DOMAINS);
-        }
     }
 
     private Config() {
@@ -200,9 +188,4 @@ public final class Config {
         public final static float LOCATION_FIX_SPACE_DELTA = 10; // m
         public final static int LOCATION_FIX_SIGNIFICANT_TIME_DELTA = 1000 * 60 * 2; // ms
     }
-
-    // How deep nested quotes should be displayed. '2' means one quote nested in another.
-    public static final int QUOTE_MAX_DEPTH = 7;
-    // How deep nested quotes should be created on quoting a message.
-    public static final int QUOTING_MAX_DEPTH = 1;
 }

src/main/java/eu/siacs/conversations/android/JabberIdContact.java

@@ -17,21 +17,6 @@ import eu.siacs.conversations.xmpp.Jid;
 
 public class JabberIdContact extends AbstractPhoneContact {
 
-    private static final String[] PROJECTION = new String[]{ContactsContract.Data._ID,
-            ContactsContract.Data.DISPLAY_NAME,
-            ContactsContract.Data.PHOTO_URI,
-            ContactsContract.Data.LOOKUP_KEY,
-            ContactsContract.CommonDataKinds.Im.DATA
-    };
-    private static final String SELECTION = ContactsContract.Data.MIMETYPE + "=? AND (" + ContactsContract.CommonDataKinds.Im.PROTOCOL + "=? or (" + ContactsContract.CommonDataKinds.Im.PROTOCOL + "=? and lower(" + ContactsContract.CommonDataKinds.Im.CUSTOM_PROTOCOL + ")=?))";
-
-    private static final String[] SELECTION_ARGS = {
-            ContactsContract.CommonDataKinds.Im.CONTENT_ITEM_TYPE,
-            String.valueOf(ContactsContract.CommonDataKinds.Im.PROTOCOL_JABBER),
-            String.valueOf(ContactsContract.CommonDataKinds.Im.PROTOCOL_CUSTOM),
-            "xmpp"
-    };
-
     private final Jid jid;
 
     private JabberIdContact(Cursor cursor) throws IllegalArgumentException {
@@ -51,26 +36,38 @@ public class JabberIdContact extends AbstractPhoneContact {
         if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.M && context.checkSelfPermission(Manifest.permission.READ_CONTACTS) != PackageManager.PERMISSION_GRANTED) {
             return Collections.emptyMap();
         }
-        try (final Cursor cursor = context.getContentResolver().query(ContactsContract.Data.CONTENT_URI, PROJECTION, SELECTION, SELECTION_ARGS, null)) {
+        final String[] PROJECTION = new String[]{ContactsContract.Data._ID,
-            if (cursor == null) {
+                ContactsContract.Data.DISPLAY_NAME,
+                ContactsContract.Data.PHOTO_URI,
+                ContactsContract.Data.LOOKUP_KEY,
+                ContactsContract.CommonDataKinds.Im.DATA};
+
+        final String SELECTION = "(" + ContactsContract.Data.MIMETYPE + "=\""
+                + ContactsContract.CommonDataKinds.Im.CONTENT_ITEM_TYPE
+                + "\") AND (" + ContactsContract.CommonDataKinds.Im.PROTOCOL
+                + "=\"" + ContactsContract.CommonDataKinds.Im.PROTOCOL_JABBER
+                + "\")";
+        final Cursor cursor;
+        try {
+            cursor = context.getContentResolver().query(ContactsContract.Data.CONTENT_URI, PROJECTION, SELECTION, null, null);
+        } catch (Exception e) {
             return Collections.emptyMap();
         }
         final HashMap<Jid, JabberIdContact> contacts = new HashMap<>();
-            while (cursor.moveToNext()) {
+        while (cursor != null && cursor.moveToNext()) {
             try {
                 final JabberIdContact contact = new JabberIdContact(cursor);
                 final JabberIdContact preexisting = contacts.put(contact.getJid(), contact);
                 if (preexisting == null || preexisting.rating() < contact.rating()) {
                     contacts.put(contact.getJid(), contact);
                 }
-                } catch (final IllegalArgumentException e) {
+            } catch (IllegalArgumentException e) {
                 Log.d(Config.LOGTAG,"unable to create jabber id contact");
             }
         }
+        if (cursor != null) {
+            cursor.close();
+        }
         return contacts;
-        } catch (final Exception e) {
-            Log.d(Config.LOGTAG, "unable to query", e);
-            return Collections.emptyMap();
-        }
     }
 }

src/main/java/eu/siacs/conversations/crypto/DomainHostnameVerifier.java

@@ -1,11 +1,10 @@
 package eu.siacs.conversations.crypto;
 
 import javax.net.ssl.HostnameVerifier;
-import javax.net.ssl.SSLPeerUnverifiedException;
 import javax.net.ssl.SSLSession;
 
 public interface DomainHostnameVerifier extends HostnameVerifier {
 
-    boolean verify(String domain, String hostname, SSLSession sslSession) throws SSLPeerUnverifiedException;
+    boolean verify(String domain, String hostname, SSLSession sslSession);
 
 }

src/main/java/eu/siacs/conversations/crypto/PgpDecryptionService.java

@@ -14,6 +14,7 @@ import java.io.FileOutputStream;
 import java.io.IOException;
 import java.io.InputStream;
 import java.io.OutputStream;
+import java.net.URL;
 import java.util.ArrayDeque;
 import java.util.HashSet;
 import java.util.List;
@@ -208,7 +209,7 @@ public class PgpDecryptionService {
 									message.setRelativeFilePath(path);
 								}
 							}
-							final String url = message.getFileParams().url;
+							URL url = message.getFileParams().url;
 							mXmppConnectionService.getFileBackend().updateFileParams(message, url);
 							message.setEncryption(Message.ENCRYPTION_DECRYPTED);
 							mXmppConnectionService.updateMessage(message);

src/main/java/eu/siacs/conversations/crypto/PgpEngine.java

@@ -6,10 +6,6 @@ import android.util.Log;
 
 import androidx.annotation.StringRes;
 
-import com.google.common.base.Joiner;
-import com.google.common.base.Splitter;
-import com.google.common.base.Strings;
-
 import org.openintents.openpgp.OpenPgpError;
 import org.openintents.openpgp.OpenPgpSignatureResult;
 import org.openintents.openpgp.util.OpenPgpApi;
@@ -22,7 +18,6 @@ import java.io.FileOutputStream;
 import java.io.IOException;
 import java.io.InputStream;
 import java.io.OutputStream;
-import java.util.ArrayList;
 
 import eu.siacs.conversations.Config;
 import eu.siacs.conversations.R;
@@ -34,7 +29,6 @@ import eu.siacs.conversations.entities.Message;
 import eu.siacs.conversations.persistance.FileBackend;
 import eu.siacs.conversations.services.XmppConnectionService;
 import eu.siacs.conversations.ui.UiCallback;
-import eu.siacs.conversations.utils.AsciiArmor;
 
 public class PgpEngine {
 	private final OpenPgpApi api;
@@ -72,7 +66,7 @@ public class PgpEngine {
 			params.putExtra(OpenPgpApi.EXTRA_REQUEST_ASCII_ARMOR, true);
 			String body;
 			if (message.hasFileOnRemoteHost()) {
-                body = message.getFileParams().url;
+				body = message.getFileParams().url.toString();
 			} else {
 				body = message.getBody();
 			}
@@ -83,14 +77,14 @@ public class PgpEngine {
 					case OpenPgpApi.RESULT_CODE_SUCCESS:
 						try {
 							os.flush();
-                            final ArrayList<String> encryptedMessageBody = new ArrayList<>();
+							StringBuilder encryptedMessageBody = new StringBuilder();
-                            final String[] lines = os.toString().split("\n");
+							String[] lines = os.toString().split("\n");
 							for (int i = 2; i < lines.length - 1; ++i) {
 								if (!lines[i].contains("Version")) {
-                                    encryptedMessageBody.add(lines[i].trim());
+									encryptedMessageBody.append(lines[i].trim());
 								}
 							}
-                            message.setEncryptedBody(Joiner.on('\n').join(encryptedMessageBody));
+							message.setEncryptedBody(encryptedMessageBody.toString());
 							message.setEncryption(Message.ENCRYPTION_DECRYPTED);
 							mXmppConnectionService.sendMessage(message);
 							callback.success(message);
@@ -153,26 +147,36 @@ public class PgpEngine {
 		}
 	}
 
-    public long fetchKeyId(final Account account, final String status, final String signature) {
+	public long fetchKeyId(Account account, String status, String signature) {
-        if (signature == null || api == null) {
+		if ((signature == null) || (api == null)) {
 			return 0;
 		}
-        final Intent params = new Intent();
+		if (status == null) {
+			status = "";
+		}
+		final StringBuilder pgpSig = new StringBuilder();
+		pgpSig.append("-----BEGIN PGP SIGNED MESSAGE-----");
+		pgpSig.append('\n');
+		pgpSig.append('\n');
+		pgpSig.append(status);
+		pgpSig.append('\n');
+		pgpSig.append("-----BEGIN PGP SIGNATURE-----");
+		pgpSig.append('\n');
+		pgpSig.append('\n');
+		pgpSig.append(signature.replace("\n", "").trim());
+		pgpSig.append('\n');
+		pgpSig.append("-----END PGP SIGNATURE-----");
+		Intent params = new Intent();
 		params.setAction(OpenPgpApi.ACTION_DECRYPT_VERIFY);
-        try {
+		params.putExtra(OpenPgpApi.EXTRA_REQUEST_ASCII_ARMOR, true);
-            params.putExtra(OpenPgpApi.RESULT_DETACHED_SIGNATURE, AsciiArmor.decode(signature));
+		InputStream is = new ByteArrayInputStream(pgpSig.toString().getBytes());
-        } catch (final Exception e) {
+		ByteArrayOutputStream os = new ByteArrayOutputStream();
-            Log.d(Config.LOGTAG, "unable to parse signature", e);
+		Intent result = api.executeApi(params, is, os);
-            return 0;
-        }
-        final InputStream is = new ByteArrayInputStream(Strings.nullToEmpty(status).getBytes());
-        final ByteArrayOutputStream os = new ByteArrayOutputStream();
-        final Intent result = api.executeApi(params, is, os);
 		switch (result.getIntExtra(OpenPgpApi.RESULT_CODE,
 				OpenPgpApi.RESULT_CODE_ERROR)) {
 			case OpenPgpApi.RESULT_CODE_SUCCESS:
-                final OpenPgpSignatureResult sigResult = result.getParcelableExtra(OpenPgpApi.RESULT_SIGNATURE);
+				OpenPgpSignatureResult sigResult = result
-                //TODO unsure that sigResult.getResult() is either 1, 2 or 3
+						.getParcelableExtra(OpenPgpApi.RESULT_SIGNATURE);
 				if (sigResult != null) {
 					return sigResult.getKeyId();
 				} else {
@@ -219,17 +223,18 @@ public class PgpEngine {
 		api.executeApiAsync(params, is, os, result -> {
 			switch (result.getIntExtra(OpenPgpApi.RESULT_CODE, 0)) {
 				case OpenPgpApi.RESULT_CODE_SUCCESS:
-                    final ArrayList<String> signature = new ArrayList<>();
+					StringBuilder signatureBuilder = new StringBuilder();
 					try {
 						os.flush();
+						String[] lines = os.toString().split("\n");
 						boolean sig = false;
-                        for (final String line : Splitter.on('\n').split(os.toString())) {
+						for (String line : lines) {
 							if (sig) {
 								if (line.contains("END PGP SIGNATURE")) {
 									sig = false;
 								} else {
 									if (!line.contains("Version")) {
-                                        signature.add(line.trim());
+										signatureBuilder.append(line.trim());
 									}
 								}
 							}
@@ -241,7 +246,7 @@ public class PgpEngine {
 						callback.error(R.string.openpgp_error, null);
 						return;
 					}
-                    callback.success(Joiner.on('\n').join(signature));
+					callback.success(signatureBuilder.toString());
 					return;
 				case OpenPgpApi.RESULT_CODE_USER_INTERACTION_REQUIRED:
 					callback.userInputRequired(result.getParcelableExtra(OpenPgpApi.RESULT_INTENT), status);

src/main/java/eu/siacs/conversations/crypto/XmppDomainVerifier.java

@@ -1,10 +1,9 @@
 package eu.siacs.conversations.crypto;
 
+import android.os.Build;
 import android.util.Log;
 import android.util.Pair;
 
-import com.google.common.collect.ImmutableList;
-
 import org.bouncycastle.asn1.ASN1Primitive;
 import org.bouncycastle.asn1.DERIA5String;
 import org.bouncycastle.asn1.DERTaggedObject;
@@ -17,20 +16,17 @@ import org.bouncycastle.asn1.x500.style.IETFUtils;
 import org.bouncycastle.cert.jcajce.JcaX509CertificateHolder;
 
 import java.io.IOException;
-import java.net.IDN;
 import java.security.cert.Certificate;
 import java.security.cert.CertificateEncodingException;
-import java.security.cert.CertificateParsingException;
 import java.security.cert.X509Certificate;
 import java.util.ArrayList;
 import java.util.Collection;
 import java.util.List;
 import java.util.Locale;
 
-import javax.net.ssl.SSLPeerUnverifiedException;
 import javax.net.ssl.SSLSession;
 
-public class XmppDomainVerifier {
+public class XmppDomainVerifier implements DomainHostnameVerifier {
 
     private static final String LOGTAG = "XmppDomainVerifier";
 
@@ -75,8 +71,8 @@ public class XmppDomainVerifier {
         }
     }
 
-    public static boolean matchDomain(final String needle, final List<String> haystack) {
+    private static boolean matchDomain(String needle, List<String> haystack) {
-        for (final String entry : haystack) {
+        for (String entry : haystack) {
             if (entry.startsWith("*.")) {
                 int offset = 0;
                 while (offset < needle.length()) {
@@ -84,13 +80,16 @@ public class XmppDomainVerifier {
                     if (i < 0) {
                         break;
                     }
+                    Log.d(LOGTAG, "comparing " + needle.substring(i) + " and " + entry.substring(1));
                     if (needle.substring(i).equalsIgnoreCase(entry.substring(1))) {
+                        Log.d(LOGTAG, "domain " + needle + " matched " + entry);
                         return true;
                     }
                     offset = i + 1;
                 }
             } else {
                 if (entry.equalsIgnoreCase(needle)) {
+                    Log.d(LOGTAG, "domain " + needle + " matched " + entry);
                     return true;
                 }
             }
@@ -98,42 +97,25 @@ public class XmppDomainVerifier {
         return false;
     }
 
-    public boolean verify(final String unicodeDomain, final String unicodeHostname, SSLSession sslSession) throws SSLPeerUnverifiedException {
+    @Override
-        final String domain = IDN.toASCII(unicodeDomain);
+    public boolean verify(String domain, String hostname, SSLSession sslSession) {
-        final String hostname = unicodeHostname == null ? null : IDN.toASCII(unicodeHostname);
+        try {
-        final Certificate[] chain = sslSession.getPeerCertificates();
+            Certificate[] chain = sslSession.getPeerCertificates();
             if (chain.length == 0 || !(chain[0] instanceof X509Certificate)) {
                 return false;
             }
-        final X509Certificate certificate = (X509Certificate) chain[0];
+            X509Certificate certificate = (X509Certificate) chain[0];
             final List<String> commonNames = getCommonNames(certificate);
-        if (isSelfSigned(certificate)) {
+            if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.KITKAT && isSelfSigned(certificate)) {
                 if (commonNames.size() == 1 && matchDomain(domain, commonNames)) {
                     Log.d(LOGTAG, "accepted CN in self signed cert as work around for " + domain);
                     return true;
                 }
             }
-        try {
+            Collection<List<?>> alternativeNames = certificate.getSubjectAlternativeNames();
-            final ValidDomains validDomains = parseValidDomains(certificate);
+            List<String> xmppAddrs = new ArrayList<>();
-            Log.d(LOGTAG, "searching for " + domain + " in srvNames: " + validDomains.srvNames + " xmppAddrs: " + validDomains.xmppAddrs + " domains:" + validDomains.domains);
+            List<String> srvNames = new ArrayList<>();
-            if (hostname != null) {
+            List<String> domains = new ArrayList<>();
-                Log.d(LOGTAG, "also trying to verify hostname " + hostname);
-            }
-            return validDomains.xmppAddrs.contains(domain)
-                    || validDomains.srvNames.contains("_xmpp-client." + domain)
-                    || matchDomain(domain, validDomains.domains)
-                    || (hostname != null && matchDomain(hostname, validDomains.domains));
-        } catch (final Exception e) {
-            return false;
-        }
-    }
-
-    public static ValidDomains parseValidDomains(final X509Certificate certificate) throws CertificateParsingException {
-        final List<String> commonNames = getCommonNames(certificate);
-        final Collection<List<?>> alternativeNames = certificate.getSubjectAlternativeNames();
-        final List<String> xmppAddrs = new ArrayList<>();
-        final List<String> srvNames = new ArrayList<>();
-        final List<String> domains = new ArrayList<>();
             if (alternativeNames != null) {
                 for (List<?> san : alternativeNames) {
                     final Integer type = (Integer) san.get(0);
@@ -162,26 +144,16 @@ public class XmppDomainVerifier {
             if (srvNames.size() == 0 && xmppAddrs.size() == 0 && domains.size() == 0) {
                 domains.addAll(commonNames);
             }
-        return new ValidDomains(xmppAddrs, srvNames, domains);
+            Log.d(LOGTAG, "searching for " + domain + " in srvNames: " + srvNames + " xmppAddrs: " + xmppAddrs + " domains:" + domains);
+            if (hostname != null) {
+                Log.d(LOGTAG, "also trying to verify hostname " + hostname);
             }
-
+            return xmppAddrs.contains(domain)
-    public static final class ValidDomains {
+                    || srvNames.contains("_xmpp-client." + domain)
-        final List<String> xmppAddrs;
+                    || matchDomain(domain, domains)
-        final List<String> srvNames;
+                    || (hostname != null && matchDomain(hostname, domains));
-        final List<String> domains;
+        } catch (Exception e) {
-
+            return false;
-        private ValidDomains(List<String> xmppAddrs, List<String> srvNames, List<String> domains) {
-            this.xmppAddrs = xmppAddrs;
-            this.srvNames = srvNames;
-            this.domains = domains;
-        }
-
-        public List<String> all() {
-            ImmutableList.Builder<String> all = new ImmutableList.Builder<>();
-            all.addAll(xmppAddrs);
-            all.addAll(srvNames);
-            all.addAll(domains);
-            return all.build();
         }
     }
 
@@ -193,4 +165,9 @@ public class XmppDomainVerifier {
             return false;
         }
     }
+
+    @Override
+    public boolean verify(String domain, SSLSession sslSession) {
+        return verify(domain, null, sslSession);
+    }
 }

src/main/java/eu/siacs/conversations/crypto/axolotl/AxolotlService.java

@@ -8,13 +8,6 @@ import android.util.Pair;
 import androidx.annotation.NonNull;
 import androidx.annotation.Nullable;
 
-import com.google.common.collect.ImmutableList;
-import com.google.common.collect.ImmutableMap;
-import com.google.common.util.concurrent.Futures;
-import com.google.common.util.concurrent.ListenableFuture;
-import com.google.common.util.concurrent.MoreExecutors;
-import com.google.common.util.concurrent.SettableFuture;
-
 import org.bouncycastle.jce.provider.BouncyCastleProvider;
 import org.whispersystems.libsignal.IdentityKey;
 import org.whispersystems.libsignal.IdentityKeyPair;
@@ -56,15 +49,9 @@ import eu.siacs.conversations.services.XmppConnectionService;
 import eu.siacs.conversations.utils.CryptoHelper;
 import eu.siacs.conversations.utils.SerialSingleThreadExecutor;
 import eu.siacs.conversations.xml.Element;
-import eu.siacs.conversations.xml.Namespace;
 import eu.siacs.conversations.xmpp.Jid;
 import eu.siacs.conversations.xmpp.OnAdvancedStreamFeaturesLoaded;
 import eu.siacs.conversations.xmpp.OnIqPacketReceived;
-import eu.siacs.conversations.xmpp.jingle.OmemoVerification;
-import eu.siacs.conversations.xmpp.jingle.OmemoVerifiedRtpContentMap;
-import eu.siacs.conversations.xmpp.jingle.RtpContentMap;
-import eu.siacs.conversations.xmpp.jingle.stanzas.IceUdpTransportInfo;
-import eu.siacs.conversations.xmpp.jingle.stanzas.OmemoVerifiedIceUdpTransportInfo;
 import eu.siacs.conversations.xmpp.pep.PublishOptions;
 import eu.siacs.conversations.xmpp.stanzas.IqPacket;
 import eu.siacs.conversations.xmpp.stanzas.MessagePacket;
@@ -738,22 +725,16 @@ public class AxolotlService implements OnAdvancedStreamFeaturesLoaded {
         axolotlStore.setFingerprintStatus(fingerprint, status);
     }
 
-    private ListenableFuture<XmppAxolotlSession> verifySessionWithPEP(final XmppAxolotlSession session) {
+    private void verifySessionWithPEP(final XmppAxolotlSession session) {
         Log.d(Config.LOGTAG, "trying to verify fresh session (" + session.getRemoteAddress().getName() + ") with pep");
         final SignalProtocolAddress address = session.getRemoteAddress();
         final IdentityKey identityKey = session.getIdentityKey();
-        final Jid jid;
         try {
-            jid = Jid.of(address.getName());
+            IqPacket packet = mXmppConnectionService.getIqGenerator().retrieveVerificationForDevice(Jid.of(address.getName()), address.getDeviceId());
-        } catch (final IllegalArgumentException e) {
+            mXmppConnectionService.sendIqPacket(account, packet, new OnIqPacketReceived() {
-            fetchStatusMap.put(address, FetchStatus.SUCCESS);
+                @Override
-            finishBuildingSessionsFromPEP(address);
+                public void onIqPacketReceived(Account account, IqPacket packet) {
-            return Futures.immediateFuture(session);
+                    Pair<X509Certificate[], byte[]> verification = mXmppConnectionService.getIqParser().verification(packet);
-        }
-        final SettableFuture<XmppAxolotlSession> future = SettableFuture.create();
-        final IqPacket packet = mXmppConnectionService.getIqGenerator().retrieveVerificationForDevice(jid, address.getDeviceId());
-        mXmppConnectionService.sendIqPacket(account, packet, (account, response) -> {
-            Pair<X509Certificate[], byte[]> verification = mXmppConnectionService.getIqParser().verification(response);
                     if (verification != null) {
                         try {
                             Signature verifier = Signature.getInstance("sha256WithRSA");
@@ -770,14 +751,13 @@ public class AxolotlService implements OnAdvancedStreamFeaturesLoaded {
                                     Bundle information = CryptoHelper.extractCertificateInformation(verification.first[0]);
                                     try {
                                         final String cn = information.getString("subject_cn");
-                                final Jid jid1 = Jid.of(address.getName());
+                                        final Jid jid = Jid.of(address.getName());
-                                Log.d(Config.LOGTAG, "setting common name for " + jid1 + " to " + cn);
+                                        Log.d(Config.LOGTAG, "setting common name for " + jid + " to " + cn);
-                                account.getRoster().getContact(jid1).setCommonName(cn);
+                                        account.getRoster().getContact(jid).setCommonName(cn);
                                     } catch (final IllegalArgumentException ignored) {
                                         //ignored
                                     }
                                     finishBuildingSessionsFromPEP(address);
-                            future.set(session);
                                     return;
                                 } catch (Exception e) {
                                     Log.d(Config.LOGTAG, "could not verify certificate");
@@ -791,9 +771,12 @@ public class AxolotlService implements OnAdvancedStreamFeaturesLoaded {
                     }
                     fetchStatusMap.put(address, FetchStatus.SUCCESS);
                     finishBuildingSessionsFromPEP(address);
-            future.set(session);
+                }
             });
-        return future;
+        } catch (IllegalArgumentException e) {
+            fetchStatusMap.put(address, FetchStatus.SUCCESS);
+            finishBuildingSessionsFromPEP(address);
+        }
     }
 
     private void finishBuildingSessionsFromPEP(final SignalProtocolAddress address) {
@@ -909,23 +892,22 @@ public class AxolotlService implements OnAdvancedStreamFeaturesLoaded {
         }
     }
 
-    private ListenableFuture<XmppAxolotlSession> buildSessionFromPEP(final SignalProtocolAddress address) {
+    private void buildSessionFromPEP(final SignalProtocolAddress address) {
-        return buildSessionFromPEP(address, null);
+        buildSessionFromPEP(address, null);
     }
 
-    private ListenableFuture<XmppAxolotlSession> buildSessionFromPEP(final SignalProtocolAddress address, OnSessionBuildFromPep callback) {
+    private void buildSessionFromPEP(final SignalProtocolAddress address, OnSessionBuildFromPep callback) {
-        final SettableFuture<XmppAxolotlSession> sessionSettableFuture = SettableFuture.create();
         Log.i(Config.LOGTAG, AxolotlService.getLogprefix(account) + "Building new session for " + address.toString());
         if (address.equals(getOwnAxolotlAddress())) {
             throw new AssertionError("We should NEVER build a session with ourselves. What happened here?!");
         }
+
         final Jid jid = Jid.of(address.getName());
         final boolean oneOfOurs = jid.asBareJid().equals(account.getJid().asBareJid());
         IqPacket bundlesPacket = mXmppConnectionService.getIqGenerator().retrieveBundlesForDevice(jid, address.getDeviceId());
         mXmppConnectionService.sendIqPacket(account, bundlesPacket, (account, packet) -> {
             if (packet.getType() == IqPacket.TYPE.TIMEOUT) {
                 fetchStatusMap.put(address, FetchStatus.TIMEOUT);
-                sessionSettableFuture.setException(new CryptoFailedException("Unable to build session. Timeout"));
             } else if (packet.getType() == IqPacket.TYPE.RESULT) {
                 Log.d(Config.LOGTAG, AxolotlService.getLogprefix(account) + "Received preKey IQ packet, processing...");
                 final IqParser parser = mXmppConnectionService.getIqParser();
@@ -938,7 +920,6 @@ public class AxolotlService implements OnAdvancedStreamFeaturesLoaded {
                     if (callback != null) {
                         callback.onSessionBuildFailed();
                     }
-                    sessionSettableFuture.setException(new CryptoFailedException("Unable to build session. IQ Packet Invalid"));
                     return;
                 }
                 Random random = new Random();
@@ -950,7 +931,6 @@ public class AxolotlService implements OnAdvancedStreamFeaturesLoaded {
                     if (callback != null) {
                         callback.onSessionBuildFailed();
                     }
-                    sessionSettableFuture.setException(new CryptoFailedException("Unable to build session. No suitable PreKey found"));
                     return;
                 }
 
@@ -965,7 +945,7 @@ public class AxolotlService implements OnAdvancedStreamFeaturesLoaded {
                     XmppAxolotlSession session = new XmppAxolotlSession(account, axolotlStore, address, bundle.getIdentityKey());
                     sessions.put(address, session);
                     if (Config.X509_VERIFICATION) {
-                        sessionSettableFuture.setFuture(verifySessionWithPEP(session)); //TODO; maybe inject callback in here too
+                        verifySessionWithPEP(session); //TODO; maybe inject callback in here too
                     } else {
                         FingerprintStatus status = getFingerprintTrust(CryptoHelper.bytesToHex(bundle.getIdentityKey().getPublicKey().serialize()));
                         FetchStatus fetchStatus;
@@ -981,7 +961,6 @@ public class AxolotlService implements OnAdvancedStreamFeaturesLoaded {
                         if (callback != null) {
                             callback.onSessionBuildSuccessful();
                         }
-                        sessionSettableFuture.set(session);
                     }
                 } catch (UntrustedIdentityException | InvalidKeyException e) {
                     Log.e(Config.LOGTAG, AxolotlService.getLogprefix(account) + "Error building session for " + address + ": "
@@ -994,7 +973,6 @@ public class AxolotlService implements OnAdvancedStreamFeaturesLoaded {
                     if (callback != null) {
                         callback.onSessionBuildFailed();
                     }
-                    sessionSettableFuture.setException(new CryptoFailedException(e));
                 }
             } else {
                 fetchStatusMap.put(address, FetchStatus.ERROR);
@@ -1008,10 +986,8 @@ public class AxolotlService implements OnAdvancedStreamFeaturesLoaded {
                 if (callback != null) {
                     callback.onSessionBuildFailed();
                 }
-                sessionSettableFuture.setException(new CryptoFailedException("Unable to build session. IQ Packet Error"));
             }
         });
-        return sessionSettableFuture;
     }
 
     private void removeFromDeviceAnnouncement(Integer id) {
@@ -1185,7 +1161,7 @@ public class AxolotlService implements OnAdvancedStreamFeaturesLoaded {
         final XmppAxolotlMessage axolotlMessage = new XmppAxolotlMessage(account.getJid().asBareJid(), getOwnDeviceId());
         final String content;
         if (message.hasFileOnRemoteHost()) {
-            content = message.getFileParams().url;
+            content = message.getFileParams().url.toString();
         } else {
             content = message.getBody();
         }
@@ -1222,154 +1198,6 @@ public class AxolotlService implements OnAdvancedStreamFeaturesLoaded {
         });
     }
 
-    private OmemoVerifiedIceUdpTransportInfo encrypt(final IceUdpTransportInfo element, final XmppAxolotlSession session) throws CryptoFailedException {
-        final OmemoVerifiedIceUdpTransportInfo transportInfo = new OmemoVerifiedIceUdpTransportInfo();
-        transportInfo.setAttributes(element.getAttributes());
-        for (final Element child : element.getChildren()) {
-            if ("fingerprint".equals(child.getName()) && Namespace.JINGLE_APPS_DTLS.equals(child.getNamespace())) {
-                final Element fingerprint = new Element("fingerprint", Namespace.OMEMO_DTLS_SRTP_VERIFICATION);
-                fingerprint.setAttribute("setup", child.getAttribute("setup"));
-                fingerprint.setAttribute("hash", child.getAttribute("hash"));
-                final XmppAxolotlMessage axolotlMessage = new XmppAxolotlMessage(account.getJid().asBareJid(), getOwnDeviceId());
-                final String content = child.getContent();
-                axolotlMessage.encrypt(content);
-                axolotlMessage.addDevice(session, true);
-                fingerprint.addChild(axolotlMessage.toElement());
-                transportInfo.addChild(fingerprint);
-            } else {
-                transportInfo.addChild(child);
-            }
-        }
-        return transportInfo;
-    }
-
-
-    public ListenableFuture<OmemoVerifiedPayload<OmemoVerifiedRtpContentMap>> encrypt(final RtpContentMap rtpContentMap, final Jid jid, final int deviceId) {
-        return Futures.transformAsync(
-                getSession(jid, deviceId),
-                session -> encrypt(rtpContentMap, session),
-                MoreExecutors.directExecutor()
-        );
-    }
-
-    private ListenableFuture<OmemoVerifiedPayload<OmemoVerifiedRtpContentMap>> encrypt(final RtpContentMap rtpContentMap, final XmppAxolotlSession session) {
-        if (Config.REQUIRE_RTP_VERIFICATION) {
-            requireVerification(session);
-        }
-        final ImmutableMap.Builder<String, RtpContentMap.DescriptionTransport> descriptionTransportBuilder = new ImmutableMap.Builder<>();
-        final OmemoVerification omemoVerification = new OmemoVerification();
-        omemoVerification.setDeviceId(session.getRemoteAddress().getDeviceId());
-        omemoVerification.setSessionFingerprint(session.getFingerprint());
-        for (final Map.Entry<String, RtpContentMap.DescriptionTransport> content : rtpContentMap.contents.entrySet()) {
-            final RtpContentMap.DescriptionTransport descriptionTransport = content.getValue();
-            final OmemoVerifiedIceUdpTransportInfo encryptedTransportInfo;
-            try {
-                encryptedTransportInfo = encrypt(descriptionTransport.transport, session);
-            } catch (final CryptoFailedException e) {
-                return Futures.immediateFailedFuture(e);
-            }
-            descriptionTransportBuilder.put(
-                    content.getKey(),
-                    new RtpContentMap.DescriptionTransport(descriptionTransport.description, encryptedTransportInfo)
-            );
-        }
-        return Futures.immediateFuture(
-                new OmemoVerifiedPayload<>(
-                        omemoVerification,
-                        new OmemoVerifiedRtpContentMap(rtpContentMap.group, descriptionTransportBuilder.build())
-                ));
-    }
-
-    private ListenableFuture<XmppAxolotlSession> getSession(final Jid jid, final int deviceId) {
-        final SignalProtocolAddress address = new SignalProtocolAddress(jid.asBareJid().toString(), deviceId);
-        final XmppAxolotlSession session = sessions.get(address);
-        if (session == null) {
-            return buildSessionFromPEP(address);
-        }
-        return Futures.immediateFuture(session);
-    }
-
-    public ListenableFuture<OmemoVerifiedPayload<RtpContentMap>> decrypt(OmemoVerifiedRtpContentMap omemoVerifiedRtpContentMap, final Jid from) {
-        final ImmutableMap.Builder<String, RtpContentMap.DescriptionTransport> descriptionTransportBuilder = new ImmutableMap.Builder<>();
-        final OmemoVerification omemoVerification = new OmemoVerification();
-        final ImmutableList.Builder<ListenableFuture<XmppAxolotlSession>> pepVerificationFutures = new ImmutableList.Builder<>();
-        for (final Map.Entry<String, RtpContentMap.DescriptionTransport> content : omemoVerifiedRtpContentMap.contents.entrySet()) {
-            final RtpContentMap.DescriptionTransport descriptionTransport = content.getValue();
-            final OmemoVerifiedPayload<IceUdpTransportInfo> decryptedTransport;
-            try {
-                decryptedTransport = decrypt((OmemoVerifiedIceUdpTransportInfo) descriptionTransport.transport, from, pepVerificationFutures);
-            } catch (CryptoFailedException e) {
-                return Futures.immediateFailedFuture(e);
-            }
-            omemoVerification.setOrEnsureEqual(decryptedTransport);
-            descriptionTransportBuilder.put(
-                    content.getKey(),
-                    new RtpContentMap.DescriptionTransport(descriptionTransport.description, decryptedTransport.payload)
-            );
-        }
-        processPostponed();
-        final ImmutableList<ListenableFuture<XmppAxolotlSession>> sessionFutures = pepVerificationFutures.build();
-        return Futures.transform(
-                Futures.allAsList(sessionFutures),
-                sessions -> {
-                    if (Config.REQUIRE_RTP_VERIFICATION) {
-                        for (XmppAxolotlSession session : sessions) {
-                            requireVerification(session);
-                        }
-                    }
-                    return new OmemoVerifiedPayload<>(
-                            omemoVerification,
-                            new RtpContentMap(omemoVerifiedRtpContentMap.group, descriptionTransportBuilder.build())
-                    );
-
-                },
-                MoreExecutors.directExecutor()
-        );
-    }
-
-    private OmemoVerifiedPayload<IceUdpTransportInfo> decrypt(final OmemoVerifiedIceUdpTransportInfo verifiedIceUdpTransportInfo, final Jid from, ImmutableList.Builder<ListenableFuture<XmppAxolotlSession>> pepVerificationFutures) throws CryptoFailedException {
-        final IceUdpTransportInfo transportInfo = new IceUdpTransportInfo();
-        transportInfo.setAttributes(verifiedIceUdpTransportInfo.getAttributes());
-        final OmemoVerification omemoVerification = new OmemoVerification();
-        for (final Element child : verifiedIceUdpTransportInfo.getChildren()) {
-            if ("fingerprint".equals(child.getName()) && Namespace.OMEMO_DTLS_SRTP_VERIFICATION.equals(child.getNamespace())) {
-                final Element fingerprint = new Element("fingerprint", Namespace.JINGLE_APPS_DTLS);
-                fingerprint.setAttribute("setup", child.getAttribute("setup"));
-                fingerprint.setAttribute("hash", child.getAttribute("hash"));
-                final Element encrypted = child.findChildEnsureSingle(XmppAxolotlMessage.CONTAINERTAG, AxolotlService.PEP_PREFIX);
-                final XmppAxolotlMessage xmppAxolotlMessage = XmppAxolotlMessage.fromElement(encrypted, from.asBareJid());
-                final XmppAxolotlSession session = getReceivingSession(xmppAxolotlMessage);
-                final XmppAxolotlMessage.XmppAxolotlPlaintextMessage plaintext = xmppAxolotlMessage.decrypt(session, getOwnDeviceId());
-                final Integer preKeyId = session.getPreKeyIdAndReset();
-                if (preKeyId != null) {
-                    postponedSessions.add(session);
-                }
-                if (session.isFresh()) {
-                    pepVerificationFutures.add(putFreshSession(session));
-                } else if (Config.REQUIRE_RTP_VERIFICATION) {
-                    pepVerificationFutures.add(Futures.immediateFuture(session));
-                }
-                fingerprint.setContent(plaintext.getPlaintext());
-                omemoVerification.setDeviceId(session.getRemoteAddress().getDeviceId());
-                omemoVerification.setSessionFingerprint(plaintext.getFingerprint());
-                transportInfo.addChild(fingerprint);
-            } else {
-                transportInfo.addChild(child);
-            }
-        }
-        return new OmemoVerifiedPayload<>(omemoVerification, transportInfo);
-    }
-
-    private static void requireVerification(final XmppAxolotlSession session) {
-        if (session.getTrust().isVerified()) {
-            return;
-        }
-        throw new NotVerifiedException(String.format(
-                "session with %s was not verified",
-                session.getFingerprint()
-        ));
-    }
-
     public void prepareKeyTransportMessage(final Conversation conversation, final OnMessageCreatedCallback onMessageCreatedCallback) {
         executor.execute(new Runnable() {
             @Override
@@ -1490,7 +1318,7 @@ public class AxolotlService implements OnAdvancedStreamFeaturesLoaded {
             } else {
                 Log.d(Config.LOGTAG, account.getJid().asBareJid() + ": nothing to flush. Not republishing key");
             }
-            if (trustedOrPreviouslyResponded(session) && Config.AUTOMATICALLY_COMPLETE_SESSIONS) {
+            if (trustedOrPreviouslyResponded(session)) {
                 completeSession(session);
             }
         }
@@ -1505,7 +1333,7 @@ public class AxolotlService implements OnAdvancedStreamFeaturesLoaded {
         final Iterator<XmppAxolotlSession> iterator = postponedSessions.iterator();
         while (iterator.hasNext()) {
             final XmppAxolotlSession session = iterator.next();
-            if (trustedOrPreviouslyResponded(session) && Config.AUTOMATICALLY_COMPLETE_SESSIONS) {
+            if (trustedOrPreviouslyResponded(session)) {
                 completeSession(session);
             }
             iterator.remove();
@@ -1567,16 +1395,15 @@ public class AxolotlService implements OnAdvancedStreamFeaturesLoaded {
         return keyTransportMessage;
     }
 
-    private ListenableFuture<XmppAxolotlSession> putFreshSession(XmppAxolotlSession session) {
+    private void putFreshSession(XmppAxolotlSession session) {
         sessions.put(session);
         if (Config.X509_VERIFICATION) {
             if (session.getIdentityKey() != null) {
-                return verifySessionWithPEP(session);
+                verifySessionWithPEP(session);
             } else {
                 Log.e(Config.LOGTAG, account.getJid().asBareJid() + ": identity key was empty after reloading for x509 verification");
             }
         }
-        return Futures.immediateFuture(session);
     }
 
     public enum FetchStatus {
@@ -1738,36 +1565,4 @@ public class AxolotlService implements OnAdvancedStreamFeaturesLoaded {
             }
         }
     }
-
-    public static class OmemoVerifiedPayload<T> {
-        private final int deviceId;
-        private final String fingerprint;
-        private final T payload;
-
-        private OmemoVerifiedPayload(OmemoVerification omemoVerification, T payload) {
-            this.deviceId = omemoVerification.getDeviceId();
-            this.fingerprint = omemoVerification.getFingerprint();
-            this.payload = payload;
-        }
-
-        public int getDeviceId() {
-            return deviceId;
-        }
-
-        public String getFingerprint() {
-            return fingerprint;
-        }
-
-        public T getPayload() {
-            return payload;
-        }
-    }
-
-    public static class NotVerifiedException extends SecurityException {
-
-        public NotVerifiedException(String message) {
-            super(message);
-        }
-
-    }
 }

src/main/java/eu/siacs/conversations/crypto/axolotl/XmppAxolotlMessage.java

@@ -59,7 +59,7 @@ public class XmppAxolotlMessage {
             switch (keyElement.getName()) {
                 case KEYTAG:
                     try {
-                        int recipientId = Integer.parseInt(keyElement.getAttribute(REMOTEID));
+                        Integer recipientId = Integer.parseInt(keyElement.getAttribute(REMOTEID));
                         byte[] key = Base64.decode(keyElement.getContent().trim(), Base64.DEFAULT);
                         boolean isPreKey = keyElement.getAttributeAsBoolean("prekey");
                         this.keys.add(new XmppAxolotlSession.AxolotlKey(recipientId, key, isPreKey));
@@ -145,7 +145,7 @@ public class XmppAxolotlMessage {
         return ciphertext != null;
     }
 
-    void encrypt(final String plaintext) throws CryptoFailedException {
+    void encrypt(String plaintext) throws CryptoFailedException {
         try {
             SecretKey secretKey = new SecretKeySpec(innerKey, KEYTYPE);
             IvParameterSpec ivSpec = new IvParameterSpec(iv);

src/main/java/eu/siacs/conversations/entities/Account.java

@@ -4,8 +4,7 @@ import android.content.ContentValues;
 import android.database.Cursor;
 import android.os.SystemClock;
 import android.util.Log;
-
+import android.util.Pair;
-import com.google.common.base.Strings;
 
 import org.json.JSONException;
 import org.json.JSONObject;
@@ -65,6 +64,7 @@ public class Account extends AbstractEntity implements AvatarService.Avatarable
     public static final int OPTION_FIXED_USERNAME = 9;
     private static final String KEY_PGP_SIGNATURE = "pgp_signature";
     private static final String KEY_PGP_ID = "pgp_id";
+    public final HashSet<Pair<String, String>> inProgressDiscoFetches = new HashSet<>();
     protected final JSONObject keys;
     private final Roster roster = new Roster(this);
     private final Collection<Jid> blocklist = new CopyOnWriteArraySet<>();
@@ -148,7 +148,7 @@ public class Account extends AbstractEntity implements AvatarService.Avatarable
     }
 
     public boolean httpUploadAvailable(long filesize) {
-        return xmppConnection != null && xmppConnection.getFeatures().httpUpload(filesize);
+        return xmppConnection != null && (xmppConnection.getFeatures().httpUpload(filesize) || xmppConnection.getFeatures().p1S3FileTransfer());
     }
 
     public boolean httpUploadAvailable() {
@@ -249,7 +249,7 @@ public class Account extends AbstractEntity implements AvatarService.Avatarable
     }
 
     public String getHostname() {
-        return Strings.nullToEmpty(this.hostname);
+        return this.hostname == null ? "" : this.hostname;
     }
 
     public void setHostname(String hostname) {
@@ -637,7 +637,6 @@ public class Account extends AbstractEntity implements AvatarService.Avatarable
         REGISTRATION_INVALID_TOKEN(true,false),
         REGISTRATION_PASSWORD_TOO_WEAK(true, false),
         TLS_ERROR,
-        TLS_ERROR_DOMAIN,
         INCOMPATIBLE_SERVER,
         TOR_NOT_AVAILABLE,
         DOWNGRADE_ATTACK,
@@ -704,8 +703,6 @@ public class Account extends AbstractEntity implements AvatarService.Avatarable
                     return R.string.account_status_regis_invalid_token;
                 case TLS_ERROR:
                     return R.string.account_status_tls_error;
-                case TLS_ERROR_DOMAIN:
-                    return R.string.account_status_tls_error_domain;
                 case INCOMPATIBLE_SERVER:
                     return R.string.account_status_incompatible_server;
                 case TOR_NOT_AVAILABLE:

src/main/java/eu/siacs/conversations/entities/Contact.java

@@ -588,7 +588,8 @@ public class Contact implements ListItem, Blockable {
     }
 
     public RtpCapability.Capability getRtpCapability() {
-        return this.rtpCapability == null ? RtpCapability.Capability.NONE : this.rtpCapability;
+
+        return this.rtpCapability;
     }
 
     public static final class Options {

src/main/java/eu/siacs/conversations/entities/Conversation.java

@@ -28,7 +28,6 @@ import eu.siacs.conversations.persistance.DatabaseBackend;
 import eu.siacs.conversations.services.AvatarService;
 import eu.siacs.conversations.services.QuickConversationsService;
 import eu.siacs.conversations.utils.JidHelper;
-import eu.siacs.conversations.utils.MessageUtils;
 import eu.siacs.conversations.utils.UIHelper;
 import eu.siacs.conversations.xmpp.Jid;
 import eu.siacs.conversations.xmpp.chatstate.ChatState;
@@ -144,7 +143,7 @@ public class Conversation extends AbstractEntity implements Blockable, Comparabl
         }
         final String contact = conversation.getJid().getDomain().toEscapedString();
         final String account = conversation.getAccount().getServer();
-        if (Config.OMEMO_EXCEPTIONS.matchesContactDomain(contact) || Config.OMEMO_EXCEPTIONS.ACCOUNT_DOMAINS.contains(account)) {
+        if (Config.OMEMO_EXCEPTIONS.CONTACT_DOMAINS.contains(contact) || Config.OMEMO_EXCEPTIONS.ACCOUNT_DOMAINS.contains(account)) {
             return false;
         }
         return conversation.isSingleOrPrivateAndNonAnonymous() || conversation.getBooleanAttribute(ATTRIBUTE_FORMERLY_PRIVATE_NON_ANONYMOUS, false);
@@ -259,22 +258,9 @@ public class Conversation extends AbstractEntity implements Blockable, Comparabl
     public Message findMessageWithFileAndUuid(final String uuid) {
         synchronized (this.messages) {
             for (final Message message : this.messages) {
-                final Transferable transferable = message.getTransferable();
-                final boolean unInitiatedButKnownSize = MessageUtils.unInitiatedButKnownSize(message);
                 if (message.getUuid().equals(uuid)
                         && message.getEncryption() != Message.ENCRYPTION_PGP
-                        && (message.isFileOrImage() || message.treatAsDownloadable() || unInitiatedButKnownSize || (transferable != null && transferable.getStatus() != Transferable.STATUS_UPLOADING))) {
+                        && (message.isFileOrImage() || message.treatAsDownloadable())) {
-                    return message;
-                }
-            }
-        }
-        return null;
-    }
-
-    public Message findMessageWithUuid(final String uuid) {
-        synchronized (this.messages) {
-            for (final Message message : this.messages) {
-                if (message.getUuid().equals(uuid)) {
                     return message;
                 }
             }
@@ -802,7 +788,7 @@ public class Conversation extends AbstractEntity implements Blockable, Comparabl
                 if (message.getStatus() == Message.STATUS_UNSEND || message.getStatus() == Message.STATUS_SEND) {
                     String otherBody;
                     if (message.hasFileOnRemoteHost()) {
-                        otherBody = message.getFileParams().url;
+                        otherBody = message.getFileParams().url.toString();
                     } else {
                         otherBody = message.body;
                     }

src/main/java/eu/siacs/conversations/entities/Message.java

@@ -8,11 +8,12 @@ import android.util.Log;
 
 import com.google.common.base.Strings;
 import com.google.common.collect.ImmutableSet;
-import com.google.common.primitives.Longs;
 
 import org.json.JSONException;
 
 import java.lang.ref.WeakReference;
+import java.net.MalformedURLException;
+import java.net.URL;
 import java.util.ArrayList;
 import java.util.Iterator;
 import java.util.List;
@@ -21,7 +22,6 @@ import java.util.concurrent.CopyOnWriteArraySet;
 
 import eu.siacs.conversations.Config;
 import eu.siacs.conversations.crypto.axolotl.FingerprintStatus;
-import eu.siacs.conversations.http.URL;
 import eu.siacs.conversations.services.AvatarService;
 import eu.siacs.conversations.ui.util.PresenceSelector;
 import eu.siacs.conversations.utils.CryptoHelper;
@@ -547,7 +547,7 @@ public class Message extends AbstractEntity implements AvatarService.Avatarable
 		} else {
 			String body, otherBody;
 			if (this.hasFileOnRemoteHost()) {
-                body = getFileParams().url;
+				body = getFileParams().url.toString();
 				otherBody = message.body == null ? null : message.body.trim();
 			} else {
 				body = this.body;
@@ -794,11 +794,12 @@ public class Message extends AbstractEntity implements AvatarService.Avatarable
 		if (relativeFilePath != null) {
 			extension = MimeUtils.extractRelevantExtension(relativeFilePath);
 		} else {
-            final String url = URL.tryParse(body.split("\n")[0]);
+			try {
-            if (url == null) {
+				final URL url = new URL(body.split("\n")[0]);
+				extension = MimeUtils.extractRelevantExtension(url);
+			} catch (MalformedURLException e) {
 				return null;
 			}
-            extension = MimeUtils.extractRelevantExtension(url);
 		}
 		return MimeUtils.guessMimeTypeFromExtension(extension);
 	}
@@ -839,8 +840,8 @@ public class Message extends AbstractEntity implements AvatarService.Avatarable
 				case 1:
 					try {
 						fileParams.size = Long.parseLong(parts[0]);
-                    } catch (final NumberFormatException e) {
+					} catch (NumberFormatException e) {
-                        fileParams.url = URL.tryParse(parts[0]);
+						fileParams.url = parseUrl(parts[0]);
 					}
 					break;
 				case 5:
@@ -849,11 +850,11 @@ public class Message extends AbstractEntity implements AvatarService.Avatarable
 					fileParams.width = parseInt(parts[2]);
 					fileParams.height = parseInt(parts[3]);
 				case 2:
-                    fileParams.url = URL.tryParse(parts[0]);
+					fileParams.url = parseUrl(parts[0]);
-                    fileParams.size = Longs.tryParse(parts[1]);
+					fileParams.size = parseLong(parts[1]);
 					break;
 				case 3:
-                    fileParams.size = Longs.tryParse(parts[0]);
+					fileParams.size = parseLong(parts[0]);
 					fileParams.width = parseInt(parts[1]);
 					fileParams.height = parseInt(parts[2]);
 					break;
@@ -862,6 +863,14 @@ public class Message extends AbstractEntity implements AvatarService.Avatarable
 		return fileParams;
 	}
 
+	private static long parseLong(String value) {
+		try {
+			return Long.parseLong(value);
+		} catch (NumberFormatException e) {
+			return 0;
+		}
+	}
+
 	private static int parseInt(String value) {
 		try {
 			return Integer.parseInt(value);
@@ -870,6 +879,14 @@ public class Message extends AbstractEntity implements AvatarService.Avatarable
 		}
 	}
 
+	private static URL parseUrl(String value) {
+		try {
+			return new URL(value);
+		} catch (MalformedURLException e) {
+			return null;
+		}
+	}
+
 	public void untie() {
 		this.mNextMessage = null;
 		this.mPreviousMessage = null;
@@ -883,11 +900,6 @@ public class Message extends AbstractEntity implements AvatarService.Avatarable
 		return type == TYPE_FILE || type == TYPE_IMAGE || type == TYPE_PRIVATE_FILE;
 	}
 
-
-    public boolean isTypeText() {
-        return type == TYPE_TEXT || type == TYPE_PRIVATE;
-    }
-
 	public boolean hasFileOnRemoteHost() {
 		return isFileOrImage() && getFileParams().url != null;
 	}
@@ -896,16 +908,12 @@ public class Message extends AbstractEntity implements AvatarService.Avatarable
 		return isFileOrImage() && getFileParams().url == null;
 	}
 
-    public static class FileParams {
+	public class FileParams {
-        public String url;
+		public URL url;
-        public Long size = null;
+		public long size = 0;
 		public int width = 0;
 		public int height = 0;
 		public int runtime = 0;
-
-        public long getSize() {
-            return size == null ? 0 : size;
-        }
 	}
 
 	public void setFingerprint(String fingerprint) {
@@ -984,28 +992,13 @@ public class Message extends AbstractEntity implements AvatarService.Avatarable
 		}
 		if (conversation.getMode() == Conversation.MODE_MULTI) {
 			final Jid nextCounterpart = conversation.getNextCounterpart();
-            return configurePrivateMessage(conversation, message, nextCounterpart, isFile);
+			if (nextCounterpart != null) {
-        }
+				message.setCounterpart(nextCounterpart);
-        return false;
+				message.setTrueCounterpart(conversation.getMucOptions().getTrueCounterpart(nextCounterpart));
-    }
-
-    public static boolean configurePrivateMessage(final Message message, final Jid counterpart) {
-        final Conversation conversation;
-        if (message.conversation instanceof Conversation) {
-            conversation = (Conversation) message.conversation;
-        } else {
-            return false;
-        }
-        return configurePrivateMessage(conversation, message, counterpart, false);
-    }
-
-    private static boolean configurePrivateMessage(final Conversation conversation, final Message message, final Jid counterpart, final boolean isFile) {
-        if (counterpart == null) {
-            return false;
-        }
-        message.setCounterpart(counterpart);
-        message.setTrueCounterpart(conversation.getMucOptions().getTrueCounterpart(counterpart));
 				message.setType(isFile ? Message.TYPE_PRIVATE_FILE : Message.TYPE_PRIVATE);
 				return true;
 			}
 		}
+		return false;
+	}
+}

src/main/java/eu/siacs/conversations/entities/Transferable.java

@@ -22,7 +22,7 @@ public interface Transferable {
 
 	int getStatus();
 
-	Long getFileSize();
+	long getFileSize();
 
 	int getProgress();
 

src/main/java/eu/siacs/conversations/entities/TransferablePlaceholder.java

@@ -18,8 +18,8 @@ public class TransferablePlaceholder implements Transferable {
 	}
 
 	@Override
-	public Long getFileSize() {
+	public long getFileSize() {
-		return null;
+		return 0;
 	}
 
 	@Override

src/main/java/eu/siacs/conversations/generator/AbstractGenerator.java

@@ -12,7 +12,6 @@ import java.util.List;
 import java.util.Locale;
 import java.util.TimeZone;
 
-import eu.siacs.conversations.BuildConfig;
 import eu.siacs.conversations.Config;
 import eu.siacs.conversations.R;
 import eu.siacs.conversations.crypto.axolotl.AxolotlService;
@@ -66,6 +65,7 @@ public abstract class AbstractGenerator {
             Namespace.JINGLE_MESSAGE
     };
     protected XmppConnectionService mXmppConnectionService;
+    private String mVersion = null;
 
     AbstractGenerator(XmppConnectionService service) {
         this.mXmppConnectionService = service;
@@ -77,11 +77,18 @@ public abstract class AbstractGenerator {
     }
 
     String getIdentityVersion() {
-        return BuildConfig.VERSION_NAME;
+        if (mVersion == null) {
+            this.mVersion = PhoneHelper.getVersionName(mXmppConnectionService);
+        }
+        return this.mVersion;
     }
 
     String getIdentityName() {
-        return BuildConfig.APP_NAME;
+        return mXmppConnectionService.getString(R.string.app_name);
+    }
+
+    public String getUserAgent() {
+        return mXmppConnectionService.getString(R.string.app_name) + '/' + getIdentityVersion();
     }
 
     String getIdentityType() {

src/main/java/eu/siacs/conversations/generator/IqGenerator.java

@@ -408,6 +408,20 @@ public class IqGenerator extends AbstractGenerator {
         return packet;
     }
 
+    public IqPacket requestP1S3Slot(Jid host, String md5) {
+        IqPacket packet = new IqPacket(IqPacket.TYPE.SET);
+        packet.setTo(host);
+        packet.query(Namespace.P1_S3_FILE_TRANSFER).setAttribute("md5", md5);
+        return packet;
+    }
+
+    public IqPacket requestP1S3Url(Jid host, String fileId) {
+        IqPacket packet = new IqPacket(IqPacket.TYPE.GET);
+        packet.setTo(host);
+        packet.query(Namespace.P1_S3_FILE_TRANSFER).setAttribute("fileid", fileId);
+        return packet;
+    }
+
     private static String convertFilename(String name) {
         int pos = name.indexOf('.');
         if (pos != -1) {

src/main/java/eu/siacs/conversations/generator/MessageGenerator.java

@@ -1,5 +1,6 @@
 package eu.siacs.conversations.generator;
 
+import java.net.URL;
 import java.text.SimpleDateFormat;
 import java.util.ArrayList;
 import java.util.Date;
@@ -13,6 +14,7 @@ import eu.siacs.conversations.entities.Account;
 import eu.siacs.conversations.entities.Conversation;
 import eu.siacs.conversations.entities.Conversational;
 import eu.siacs.conversations.entities.Message;
+import eu.siacs.conversations.http.P1S3UrlStreamHandler;
 import eu.siacs.conversations.services.XmppConnectionService;
 import eu.siacs.conversations.xml.Element;
 import eu.siacs.conversations.xml.Namespace;
@@ -101,9 +103,18 @@ public class MessageGenerator extends AbstractGenerator {
         MessagePacket packet = preparePacket(message);
         String content;
         if (message.hasFileOnRemoteHost()) {
-            final Message.FileParams fileParams = message.getFileParams();
+            Message.FileParams fileParams = message.getFileParams();
-            content = fileParams.url;
+            final URL url = fileParams.url;
+            if (P1S3UrlStreamHandler.PROTOCOL_NAME.equals(url.getProtocol())) {
+                Element x = packet.addChild("x", Namespace.P1_S3_FILE_TRANSFER);
+                final String file = url.getFile();
+                x.setAttribute("name", file.charAt(0) == '/' ? file.substring(1) : file);
+                x.setAttribute("fileid", url.getHost());
+                return packet;
+            } else {
+                content = url.toString();
                 packet.addChild("x", Namespace.OOB).addChild("url").setContent(content);
+            }
         } else {
             content = message.getBody();
         }
@@ -115,9 +126,16 @@ public class MessageGenerator extends AbstractGenerator {
         MessagePacket packet = preparePacket(message);
         if (message.hasFileOnRemoteHost()) {
             Message.FileParams fileParams = message.getFileParams();
-            final String url = fileParams.url;
+            final URL url = fileParams.url;
-            packet.setBody(url);
+            if (P1S3UrlStreamHandler.PROTOCOL_NAME.equals(url.getProtocol())) {
-            packet.addChild("x", Namespace.OOB).addChild("url").setContent(url);
+                Element x = packet.addChild("x", Namespace.P1_S3_FILE_TRANSFER);
+                final String file = url.getFile();
+                x.setAttribute("name", file.charAt(0) == '/' ? file.substring(1) : file);
+                x.setAttribute("fileid", url.getHost());
+            } else {
+                packet.setBody(url.toString());
+                packet.addChild("x", Namespace.OOB).addChild("url").setContent(url.toString());
+            }
         } else {
             if (Config.supportUnencrypted()) {
                 packet.setBody(PGP_FALLBACK_MESSAGE);

src/main/java/eu/siacs/conversations/generator/PresenceGenerator.java

@@ -25,19 +25,12 @@ public class PresenceGenerator extends AbstractGenerator {
         return packet;
     }
 
-    public PresencePacket requestPresenceUpdatesFrom(final Contact contact) {
+    public PresencePacket requestPresenceUpdatesFrom(Contact contact) {
-        return requestPresenceUpdatesFrom(contact, null);
-    }
-
-    public PresencePacket requestPresenceUpdatesFrom(final Contact contact, final String preAuth) {
         PresencePacket packet = subscription("subscribe", contact);
         String displayName = contact.getAccount().getDisplayName();
         if (!TextUtils.isEmpty(displayName)) {
             packet.addChild("nick", Namespace.NICK).setContent(displayName);
         }
-        if (preAuth != null) {
-            packet.addChild("preauth", Namespace.PARS).setAttribute("token", preAuth);
-        }
         return packet;
     }
 

src/main/java/eu/siacs/conversations/http/AesGcmURL.java

@@ -1,41 +0,0 @@
-package eu.siacs.conversations.http;
-
-import java.util.regex.Pattern;
-
-import okhttp3.HttpUrl;
-
-public final class AesGcmURL {
-
-    /**
-     * This matches a 48 or 44 byte IV + KEY hex combo, like used in http/aesgcm upload anchors
-     */
-    public static final Pattern IV_KEY = Pattern.compile("([A-Fa-f0-9]{2}){48}|([A-Fa-f0-9]{2}){44}");
-
-    public static final String PROTOCOL_NAME = "aesgcm";
-
-    private AesGcmURL() {
-
-    }
-
-    public static String toAesGcmUrl(HttpUrl url) {
-        if (url.isHttps()) {
-            return PROTOCOL_NAME + url.toString().substring(5);
-        } else {
-            return url.toString();
-        }
-    }
-
-    public static HttpUrl of(final String url) {
-        final int end = url.indexOf("://");
-        if (end < 0) {
-            throw new IllegalArgumentException("Scheme not found");
-        }
-        final String protocol = url.substring(0, end);
-        if (PROTOCOL_NAME.equals(protocol)) {
-            return HttpUrl.get("https" + url.substring(PROTOCOL_NAME.length()));
-        } else {
-            return HttpUrl.get(url);
-        }
-    }
-
-}

src/main/java/eu/siacs/conversations/http/AesGcmURLStreamHandler.java

@@ -0,0 +1,23 @@
+package eu.siacs.conversations.http;
+
+import java.io.IOException;
+import java.net.URL;
+import java.net.URLConnection;
+import java.net.URLStreamHandler;
+import java.util.regex.Pattern;
+
+
+public class AesGcmURLStreamHandler extends URLStreamHandler {
+
+    /**
+     * This matches a 48 or 44 byte IV + KEY hex combo, like used in http/aesgcm upload anchors
+     */
+    public static final Pattern IV_KEY = Pattern.compile("([A-Fa-f0-9]{2}){48}|([A-Fa-f0-9]{2}){44}");
+
+    public static final String PROTOCOL_NAME = "aesgcm";
+
+    @Override
+    protected URLConnection openConnection(URL url) throws IOException {
+        return new URL("https"+url.toString().substring(url.getProtocol().length())).openConnection();
+    }
+}

src/main/java/eu/siacs/conversations/http/CustomURLStreamHandlerFactory.java

@@ -0,0 +1,18 @@
+package eu.siacs.conversations.http;
+
+import java.net.URLStreamHandler;
+import java.net.URLStreamHandlerFactory;
+
+public class CustomURLStreamHandlerFactory implements URLStreamHandlerFactory {
+
+    @Override
+    public URLStreamHandler createURLStreamHandler(String protocol) {
+        if (AesGcmURLStreamHandler.PROTOCOL_NAME.equals(protocol)) {
+            return new AesGcmURLStreamHandler();
+        } else if (P1S3UrlStreamHandler.PROTOCOL_NAME.equals(protocol)) {
+            return new P1S3UrlStreamHandler();
+        } else {
+            return null;
+        }
+    }
+}

src/main/java/eu/siacs/conversations/http/HttpConnectionManager.java

@@ -1,81 +1,42 @@
 package eu.siacs.conversations.http;
 
-import android.os.Build;
 import android.util.Log;
 
 import org.apache.http.conn.ssl.StrictHostnameVerifier;
 
 import java.io.IOException;
-import java.io.InputStream;
 import java.net.InetAddress;
 import java.net.InetSocketAddress;
 import java.net.Proxy;
-import java.net.UnknownHostException;
+import java.net.URL;
 import java.security.KeyManagementException;
 import java.security.NoSuchAlgorithmException;
 import java.util.ArrayList;
 import java.util.List;
-import java.util.concurrent.Executor;
-import java.util.concurrent.Executors;
-import java.util.concurrent.TimeUnit;
 
+import javax.net.ssl.HostnameVerifier;
+import javax.net.ssl.HttpsURLConnection;
 import javax.net.ssl.SSLSocketFactory;
 import javax.net.ssl.X509TrustManager;
 
-import eu.siacs.conversations.BuildConfig;
 import eu.siacs.conversations.Config;
 import eu.siacs.conversations.entities.Account;
 import eu.siacs.conversations.entities.Message;
 import eu.siacs.conversations.services.AbstractConnectionManager;
 import eu.siacs.conversations.services.XmppConnectionService;
 import eu.siacs.conversations.utils.TLSSocketFactory;
-import okhttp3.HttpUrl;
-import okhttp3.OkHttpClient;
-import okhttp3.Request;
-import okhttp3.ResponseBody;
 
 public class HttpConnectionManager extends AbstractConnectionManager {
 
     private final List<HttpDownloadConnection> downloadConnections = new ArrayList<>();
     private final List<HttpUploadConnection> uploadConnections = new ArrayList<>();
 
-    public static final Executor EXECUTOR = Executors.newFixedThreadPool(4);
-
-    public static final OkHttpClient OK_HTTP_CLIENT;
-
-    static {
-        OK_HTTP_CLIENT = new OkHttpClient.Builder()
-                .addInterceptor(chain -> {
-                    final Request original = chain.request();
-                    final Request modified = original.newBuilder()
-                            .header("User-Agent", getUserAgent())
-                            .build();
-                    return chain.proceed(modified);
-                })
-                .build();
-    }
-
-
-    public static String getUserAgent() {
-        return String.format("%s/%s", BuildConfig.APP_NAME, BuildConfig.VERSION_NAME);
-    }
-
     public HttpConnectionManager(XmppConnectionService service) {
         super(service);
     }
 
-    public static Proxy getProxy() {
+    public static Proxy getProxy() throws IOException {
-        final InetAddress localhost;
+        return new Proxy(Proxy.Type.SOCKS, new InetSocketAddress(InetAddress.getByAddress(new byte[]{127, 0, 0, 1}), 9050));
-        try {
-            localhost = InetAddress.getByAddress(new byte[]{127, 0, 0, 1});
-        } catch (final UnknownHostException e) {
-            throw new IllegalStateException(e);
-        }
-        if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.N) {
-            return new Proxy(Proxy.Type.SOCKS, new InetSocketAddress(localhost, 9050));
-        } else {
-            return new Proxy(Proxy.Type.HTTP, new InetSocketAddress(localhost, 8118));
-        }
     }
 
     public void createNewDownloadConnection(Message message) {
@@ -110,6 +71,15 @@ public class HttpConnectionManager extends AbstractConnectionManager {
         }
     }
 
+    public boolean checkConnection(Message message) {
+        final Account account = message.getConversation().getAccount();
+        final URL url = message.getFileParams().url;
+        if (url.getProtocol().equalsIgnoreCase(P1S3UrlStreamHandler.PROTOCOL_NAME) && account.getStatus() != Account.State.ONLINE) {
+            return false;
+        }
+        return mXmppConnectionService.hasInternetConnection();
+    }
+
     void finishConnection(HttpDownloadConnection connection) {
         synchronized (this.downloadConnections) {
             this.downloadConnections.remove(connection);
@@ -122,25 +92,9 @@ public class HttpConnectionManager extends AbstractConnectionManager {
         }
     }
 
-    OkHttpClient buildHttpClient(final HttpUrl url, final Account account, boolean interactive) {
+    void setupTrustManager(final HttpsURLConnection connection, final boolean interactive) {
-        return buildHttpClient(url, account, 30, interactive);
-    }
-
-    OkHttpClient buildHttpClient(final HttpUrl url, final Account account, int readTimeout, boolean interactive) {
-        final String slotHostname = url.host();
-        final boolean onionSlot = slotHostname.endsWith(".onion");
-        final OkHttpClient.Builder builder = OK_HTTP_CLIENT.newBuilder();
-        builder.writeTimeout(30, TimeUnit.SECONDS);
-        builder.readTimeout(readTimeout, TimeUnit.SECONDS);
-        setupTrustManager(builder, interactive);
-        if (mXmppConnectionService.useTorToConnect() || account.isOnion() || onionSlot) {
-            builder.proxy(HttpConnectionManager.getProxy()).build();
-        }
-        return builder.build();
-    }
-
-    private void setupTrustManager(final OkHttpClient.Builder builder, final boolean interactive) {
         final X509TrustManager trustManager;
+        final HostnameVerifier hostnameVerifier = mXmppConnectionService.getMemorizingTrustManager().wrapHostnameVerifier(new StrictHostnameVerifier(), interactive);
         if (interactive) {
             trustManager = mXmppConnectionService.getMemorizingTrustManager().getInteractive();
         } else {
@@ -148,27 +102,9 @@ public class HttpConnectionManager extends AbstractConnectionManager {
         }
         try {
             final SSLSocketFactory sf = new TLSSocketFactory(new X509TrustManager[]{trustManager}, mXmppConnectionService.getRNG());
-            builder.sslSocketFactory(sf, trustManager);
+            connection.setSSLSocketFactory(sf);
-            builder.hostnameVerifier(new StrictHostnameVerifier());
+            connection.setHostnameVerifier(hostnameVerifier);
         } catch (final KeyManagementException | NoSuchAlgorithmException ignored) {
         }
     }
-
-    public static InputStream open(final String url, final boolean tor) throws IOException {
-        return open(HttpUrl.get(url), tor);
-    }
-
-    public static InputStream open(final HttpUrl httpUrl, final boolean tor) throws IOException {
-        final OkHttpClient.Builder builder = OK_HTTP_CLIENT.newBuilder();
-        if (tor) {
-            builder.proxy(HttpConnectionManager.getProxy()).build();
-        }
-        final OkHttpClient client = builder.build();
-        final Request request = new Request.Builder().get().url(httpUrl).build();
-        final ResponseBody body = client.newCall(request).execute().body();
-        if (body == null) {
-            throw new IOException("No response body found");
-        }
-        return body.byteStream();
-    }
 }

src/main/java/eu/siacs/conversations/http/HttpDownloadConnection.java

@@ -1,23 +1,29 @@
 package eu.siacs.conversations.http;
 
+import android.os.PowerManager;
 import android.util.Log;
 
 import androidx.annotation.Nullable;
 
 import com.google.common.base.Strings;
 import com.google.common.io.ByteStreams;
-import com.google.common.primitives.Longs;
 
+import java.io.BufferedInputStream;
 import java.io.FileInputStream;
 import java.io.IOException;
 import java.io.InputStream;
 import java.io.OutputStream;
-import java.util.Locale;
+import java.net.HttpURLConnection;
+import java.net.MalformedURLException;
+import java.net.URL;
+import java.util.concurrent.CancellationException;
 
+import javax.net.ssl.HttpsURLConnection;
 import javax.net.ssl.SSLHandshakeException;
 
 import eu.siacs.conversations.Config;
 import eu.siacs.conversations.R;
+import eu.siacs.conversations.entities.Account;
 import eu.siacs.conversations.entities.DownloadableFile;
 import eu.siacs.conversations.entities.Message;
 import eu.siacs.conversations.entities.Transferable;
@@ -27,30 +33,28 @@ import eu.siacs.conversations.services.XmppConnectionService;
 import eu.siacs.conversations.utils.CryptoHelper;
 import eu.siacs.conversations.utils.FileWriterException;
 import eu.siacs.conversations.utils.MimeUtils;
-import okhttp3.Call;
+import eu.siacs.conversations.utils.WakeLockHelper;
-import okhttp3.HttpUrl;
+import eu.siacs.conversations.xmpp.stanzas.IqPacket;
-import okhttp3.OkHttpClient;
-import okhttp3.Request;
-import okhttp3.Response;
-
-import static eu.siacs.conversations.http.HttpConnectionManager.EXECUTOR;
 
 public class HttpDownloadConnection implements Transferable {
 
     private final Message message;
+    private final boolean mUseTor;
     private final HttpConnectionManager mHttpConnectionManager;
     private final XmppConnectionService mXmppConnectionService;
-    private HttpUrl mUrl;
+    private URL mUrl;
     private DownloadableFile file;
     private int mStatus = Transferable.STATUS_UNKNOWN;
     private boolean acceptedAutomatically = false;
     private int mProgress = 0;
-    private Call mostRecentCall;
+    private boolean canceled = false;
+    private Method method = Method.HTTP_UPLOAD;
 
     HttpDownloadConnection(Message message, HttpConnectionManager manager) {
         this.message = message;
         this.mHttpConnectionManager = manager;
         this.mXmppConnectionService = manager.getXmppConnectionService();
+        this.mUseTor = mXmppConnectionService.useTorToConnect();
     }
 
     @Override
@@ -82,13 +86,13 @@ public class HttpDownloadConnection implements Transferable {
         try {
             final Message.FileParams fileParams = message.getFileParams();
             if (message.hasFileOnRemoteHost()) {
-                mUrl = AesGcmURL.of(fileParams.url);
+                mUrl = CryptoHelper.toHttpsUrl(fileParams.url);
-            } else if (message.isOOb() && fileParams.url != null && fileParams.size != null) {
+            } else if (message.isOOb() && fileParams.url != null && fileParams.size > 0) {
-                mUrl = AesGcmURL.of(fileParams.url);
+                mUrl = fileParams.url;
             } else {
-                mUrl = AesGcmURL.of(message.getBody().split("\n")[0]);
+                mUrl = CryptoHelper.toHttpsUrl(new URL(message.getBody().split("\n")[0]));
             }
-            final AbstractConnectionManager.Extension extension = AbstractConnectionManager.Extension.of(mUrl.encodedPath());
+            final AbstractConnectionManager.Extension extension = AbstractConnectionManager.Extension.of(mUrl.getPath());
             if (VALID_CRYPTO_EXTENSIONS.contains(extension.main)) {
                 this.message.setEncryption(Message.ENCRYPTION_PGP);
             } else if (message.getEncryption() != Message.ENCRYPTION_OTR
@@ -105,23 +109,22 @@ public class HttpDownloadConnection implements Transferable {
             if (this.message.getEncryption() == Message.ENCRYPTION_AXOLOTL && this.file.getKey() == null) {
                 this.message.setEncryption(Message.ENCRYPTION_NONE);
             }
-            //TODO add auth tag size to knownFileSize
+            method = mUrl.getProtocol().equalsIgnoreCase(P1S3UrlStreamHandler.PROTOCOL_NAME) ? Method.P1_S3 : Method.HTTP_UPLOAD;
-            final Long knownFileSize = message.getFileParams().size;
+            long knownFileSize = message.getFileParams().size;
-            Log.d(Config.LOGTAG,"knownFileSize: "+knownFileSize+", body="+message.getBody());
+            if (knownFileSize > 0 && interactive && method != Method.P1_S3) {
-            if (knownFileSize != null && interactive) {
                 this.file.setExpectedSize(knownFileSize);
                 download(true);
             } else {
                 checkFileSize(interactive);
             }
-        } catch (final IllegalArgumentException e) {
+        } catch (MalformedURLException e) {
             this.cancel();
         }
     }
 
     private void setupFile() {
-        final String reference = mUrl.fragment();
+        final String reference = mUrl.getRef();
-        if (reference != null && AesGcmURL.IV_KEY.matcher(reference).matches()) {
+        if (reference != null && AesGcmURLStreamHandler.IV_KEY.matcher(reference).matches()) {
             this.file = new DownloadableFile(mXmppConnectionService.getCacheDir().getAbsolutePath() + "/" + message.getUuid());
             this.file.setKeyAndIv(CryptoHelper.hexToBytes(reference));
             Log.d(Config.LOGTAG, "create temporary OMEMO encrypted file: " + this.file.getAbsolutePath() + "(" + message.getMimeType() + ")");
@@ -130,20 +133,17 @@ public class HttpDownloadConnection implements Transferable {
         }
     }
 
-    private void download(final boolean interactive) {
+    private void download(boolean interactive) {
-        EXECUTOR.execute(new FileDownloader(interactive));
+        new Thread(new FileDownloader(interactive)).start();
     }
 
-    private void checkFileSize(final boolean interactive) {
+    private void checkFileSize(boolean interactive) {
-        EXECUTOR.execute(new FileSizeChecker(interactive));
+        new Thread(new FileSizeChecker(interactive)).start();
     }
 
     @Override
     public void cancel() {
-        final Call call = this.mostRecentCall;
+        this.canceled = true;
-        if (call != null && !call.isCanceled()) {
-            call.cancel();
-        }
         mHttpConnectionManager.finishConnection(this);
         message.setTransferable(null);
         if (message.isFileOrImage()) {
@@ -207,19 +207,14 @@ public class HttpDownloadConnection implements Transferable {
         mHttpConnectionManager.updateConversationUi(true);
     }
 
-    private void showToastForException(final Exception e) {
+    private void showToastForException(Exception e) {
-        final Call call = mostRecentCall;
-        final boolean cancelled = call != null && call.isCanceled();
-        if (e == null || cancelled) {
-            return;
-        }
         if (e instanceof java.net.UnknownHostException) {
             mXmppConnectionService.showErrorToastInUi(R.string.download_failed_server_not_found);
         } else if (e instanceof java.net.ConnectException) {
             mXmppConnectionService.showErrorToastInUi(R.string.download_failed_could_not_connect);
         } else if (e instanceof FileWriterException) {
             mXmppConnectionService.showErrorToastInUi(R.string.download_failed_could_not_write_file);
-        } else {
+        } else if (!(e instanceof CancellationException)) {
             mXmppConnectionService.showErrorToastInUi(R.string.download_failed_file_not_found);
         }
     }
@@ -235,11 +230,11 @@ public class HttpDownloadConnection implements Transferable {
     }
 
     @Override
-    public Long getFileSize() {
+    public long getFileSize() {
         if (this.file != null) {
             return this.file.getExpectedSize();
         } else {
-            return null;
+            return 0;
         }
     }
 
@@ -263,13 +258,41 @@ public class HttpDownloadConnection implements Transferable {
 
         @Override
         public void run() {
+            if (mUrl.getProtocol().equalsIgnoreCase(P1S3UrlStreamHandler.PROTOCOL_NAME)) {
+                retrieveUrl();
+            } else {
                 check();
             }
+        }
 
-        private void retrieveFailed(@Nullable final Exception e) {
+        private void retrieveUrl() {
+            changeStatus(STATUS_CHECKING);
+            final Account account = message.getConversation().getAccount();
+            IqPacket request = mXmppConnectionService.getIqGenerator().requestP1S3Url(account.getDomain(), mUrl.getHost());
+            mXmppConnectionService.sendIqPacket(message.getConversation().getAccount(), request, (a, packet) -> {
+                if (packet.getType() == IqPacket.TYPE.RESULT) {
+                    String download = packet.query().getAttribute("download");
+                    if (download != null) {
+                        try {
+                            mUrl = new URL(download);
+                            check();
+                            return;
+                        } catch (MalformedURLException e) {
+                            //fallthrough
+                        }
+                    }
+                }
+                Log.d(Config.LOGTAG, "unable to retrieve actual download url");
+                retrieveFailed(null);
+            });
+        }
+
+        private void retrieveFailed(@Nullable Exception e) {
             changeStatus(STATUS_OFFER_CHECK_FILESIZE);
             if (interactive) {
+                if (e != null) {
                     showToastForException(e);
+                }
             } else {
                 HttpDownloadConnection.this.acceptedAutomatically = false;
                 HttpDownloadConnection.this.mXmppConnectionService.getNotificationService().push(message);
@@ -281,7 +304,7 @@ public class HttpDownloadConnection implements Transferable {
             long size;
             try {
                 size = retrieveFileSize();
-            } catch (final Exception e) {
+            } catch (Exception e) {
                 Log.d(Config.LOGTAG, "io exception in http file size checker: " + e.getMessage());
                 retrieveFailed(e);
                 return;
@@ -305,24 +328,46 @@ public class HttpDownloadConnection implements Transferable {
         }
 
         private long retrieveFileSize() throws IOException {
+            try {
                 Log.d(Config.LOGTAG, "retrieve file size. interactive:" + interactive);
                 changeStatus(STATUS_CHECKING);
-            final OkHttpClient client = mHttpConnectionManager.buildHttpClient(
+                HttpURLConnection connection;
-                    mUrl,
+                final String hostname = mUrl.getHost();
-                    message.getConversation().getAccount(),
+                final boolean onion = hostname != null && hostname.endsWith(".onion");
-                    interactive
+                if (mUseTor || message.getConversation().getAccount().isOnion() || onion) {
-            );
+                    connection = (HttpURLConnection) mUrl.openConnection(HttpConnectionManager.getProxy());
-            final Request request = new Request.Builder()
+                } else {
-                    .url(URL.stripFragment(mUrl))
+                    connection = (HttpURLConnection) mUrl.openConnection();
-                    .head()
+                }
-                    .build();
+                if (method == Method.P1_S3) {
-            mostRecentCall = client.newCall(request);
+                    connection.setRequestMethod("GET");
-            try {
+                    connection.addRequestProperty("Range", "bytes=0-0");
-                final Response response = mostRecentCall.execute();
+                } else {
-                throwOnInvalidCode(response);
+                    connection.setRequestMethod("HEAD");
-                final String contentLength = response.header("Content-Length");
+                }
-                final String contentType = response.header("Content-Type");
+                connection.setUseCaches(false);
-                final AbstractConnectionManager.Extension extension = AbstractConnectionManager.Extension.of(mUrl.encodedPath());
+                Log.d(Config.LOGTAG, "url: " + connection.getURL().toString());
+                connection.setRequestProperty("User-Agent", mXmppConnectionService.getIqGenerator().getUserAgent());
+                if (connection instanceof HttpsURLConnection) {
+                    mHttpConnectionManager.setupTrustManager((HttpsURLConnection) connection, interactive);
+                }
+                connection.setConnectTimeout(Config.SOCKET_TIMEOUT * 1000);
+                connection.setReadTimeout(Config.SOCKET_TIMEOUT * 1000);
+                connection.connect();
+                String contentLength;
+                if (method == Method.P1_S3) {
+                    String contentRange = connection.getHeaderField("Content-Range");
+                    String[] contentRangeParts = contentRange == null ? new String[0] : contentRange.split("/");
+                    if (contentRangeParts.length != 2) {
+                        contentLength = null;
+                    } else {
+                        contentLength = contentRangeParts[1];
+                    }
+                } else {
+                    contentLength = connection.getHeaderField("Content-Length");
+                }
+                final String contentType = connection.getContentType();
+                final AbstractConnectionManager.Extension extension = AbstractConnectionManager.Extension.of(mUrl.getPath());
                 if (Strings.isNullOrEmpty(extension.getExtension()) && contentType != null) {
                     final String fileExtension = MimeUtils.guessExtensionFromMimeType(contentType);
                     if (fileExtension != null) {
@@ -331,14 +376,11 @@ public class HttpDownloadConnection implements Transferable {
                         setupFile();
                     }
                 }
-                if (Strings.isNullOrEmpty(contentLength)) {
+                connection.disconnect();
+                if (contentLength == null) {
                     throw new IOException("no content-length found in HEAD response");
                 }
-                final long size = Long.parseLong(contentLength, 10);
+                return Long.parseLong(contentLength, 10);
-                if (size < 0) {
-                    throw new IOException("Server reported negative file size");
-                }
-                return size;
             } catch (IOException e) {
                 Log.d(Config.LOGTAG, "io exception during HEAD " + e.getMessage());
                 throw e;
@@ -353,6 +395,8 @@ public class HttpDownloadConnection implements Transferable {
 
         private final boolean interactive;
 
+        private OutputStream os;
+
         public FileDownloader(boolean interactive) {
             this.interactive = interactive;
         }
@@ -365,10 +409,9 @@ public class HttpDownloadConnection implements Transferable {
                 decryptIfNeeded();
                 updateImageBounds();
                 finish();
-            } catch (final SSLHandshakeException e) {
+            } catch (SSLHandshakeException e) {
                 changeStatus(STATUS_OFFER);
-            } catch (final Exception e) {
+            } catch (Exception e) {
-                Log.d(Config.LOGTAG, message.getConversation().getAccount().getJid().asBareJid() + ": unable to download file", e);
                 if (interactive) {
                     showToastForException(e);
                 } else {
@@ -380,84 +423,108 @@ public class HttpDownloadConnection implements Transferable {
         }
 
         private void download() throws Exception {
-            final OkHttpClient client = mHttpConnectionManager.buildHttpClient(
+            InputStream is = null;
-                    mUrl,
+            HttpURLConnection connection = null;
-                    message.getConversation().getAccount(),
+            PowerManager.WakeLock wakeLock = mHttpConnectionManager.createWakeLock("http_download_" + message.getUuid());
-                    interactive
+            try {
-            );
+                wakeLock.acquire();
-
+                if (mUseTor || message.getConversation().getAccount().isOnion()) {
-            final Request.Builder requestBuilder = new Request.Builder().url(URL.stripFragment(mUrl));
+                    connection = (HttpURLConnection) mUrl.openConnection(HttpConnectionManager.getProxy());
-
+                } else {
+                    connection = (HttpURLConnection) mUrl.openConnection();
+                }
+                if (connection instanceof HttpsURLConnection) {
+                    mHttpConnectionManager.setupTrustManager((HttpsURLConnection) connection, interactive);
+                }
+                connection.setUseCaches(false);
+                connection.setRequestProperty("User-Agent", mXmppConnectionService.getIqGenerator().getUserAgent());
                 final long expected = file.getExpectedSize();
                 final boolean tryResume = file.exists() && file.getSize() > 0 && file.getSize() < expected;
-            final long resumeSize;
+                long resumeSize = 0;
+
                 if (tryResume) {
                     resumeSize = file.getSize();
                     Log.d(Config.LOGTAG, "http download trying resume after " + resumeSize + " of " + expected);
-                requestBuilder.addHeader("Range", String.format(Locale.ENGLISH, "bytes=%d-", resumeSize));
+                    connection.setRequestProperty("Range", "bytes=" + resumeSize + "-");
-            } else {
-                resumeSize = 0;
                 }
-            final Request request = requestBuilder.build();
+                connection.setConnectTimeout(Config.SOCKET_TIMEOUT * 1000);
-            mostRecentCall = client.newCall(request);
+                connection.setReadTimeout(Config.SOCKET_TIMEOUT * 1000);
-            final Response response = mostRecentCall.execute();
+                connection.connect();
-            throwOnInvalidCode(response);
+                is = new BufferedInputStream(connection.getInputStream());
-            final String contentRange = response.header("Content-Range");
+                final String contentRange = connection.getHeaderField("Content-Range");
-            final boolean serverResumed = tryResume && contentRange != null && contentRange.startsWith("bytes " + resumeSize + "-");
+                boolean serverResumed = tryResume && contentRange != null && contentRange.startsWith("bytes " + resumeSize + "-");
-            final InputStream inputStream = response.body().byteStream();
-            final OutputStream outputStream;
                 long transmitted = 0;
                 if (tryResume && serverResumed) {
                     Log.d(Config.LOGTAG, "server resumed");
                     transmitted = file.getSize();
                     updateProgress(Math.round(((double) transmitted / expected) * 100));
-                outputStream = AbstractConnectionManager.createOutputStream(file, true, false);
+                    os = AbstractConnectionManager.createOutputStream(file, true, false);
+                    if (os == null) {
+                        throw new FileWriterException();
+                    }
                 } else {
-                final String contentLength = response.header("Content-Length");
+                    long reportedContentLengthOnGet;
-                final long size = Strings.isNullOrEmpty(contentLength) ? 0 : Longs.tryParse(contentLength);
+                    try {
-                if (expected != size) {
+                        reportedContentLengthOnGet = Long.parseLong(connection.getHeaderField("Content-Length"));
-                    Log.d(Config.LOGTAG, "content-length reported on GET (" + size + ") did not match Content-Length reported on HEAD (" + expected + ")");
+                    } catch (NumberFormatException | NullPointerException e) {
+                        reportedContentLengthOnGet = 0;
+                    }
+                    if (expected != reportedContentLengthOnGet) {
+                        Log.d(Config.LOGTAG, "content-length reported on GET (" + reportedContentLengthOnGet + ") did not match Content-Length reported on HEAD (" + expected + ")");
                     }
                     file.getParentFile().mkdirs();
                     if (!file.exists() && !file.createNewFile()) {
                         throw new FileWriterException();
                     }
-                outputStream = AbstractConnectionManager.createOutputStream(file, false, false);
+                    os = AbstractConnectionManager.createOutputStream(file, false, false);
                 }
                 int count;
-            final byte[] buffer = new byte[4096];
+                byte[] buffer = new byte[4096];
-            while ((count = inputStream.read(buffer)) != -1) {
+                while ((count = is.read(buffer)) != -1) {
                     transmitted += count;
                     try {
-                    outputStream.write(buffer, 0, count);
+                        os.write(buffer, 0, count);
                     } catch (IOException e) {
                         throw new FileWriterException();
                     }
                     updateProgress(Math.round(((double) transmitted / expected) * 100));
+                    if (canceled) {
+                        throw new CancellationException();
+                    }
+                }
+                try {
+                    os.flush();
+                } catch (IOException e) {
+                    throw new FileWriterException();
+                }
+            } catch (CancellationException | IOException e) {
+                Log.d(Config.LOGTAG, message.getConversation().getAccount().getJid().asBareJid() + ": http download failed", e);
+                throw e;
+            } finally {
+                FileBackend.close(os);
+                FileBackend.close(is);
+                if (connection != null) {
+                    connection.disconnect();
+                }
+                WakeLockHelper.release(wakeLock);
             }
-            outputStream.flush();
         }
 
         private void updateImageBounds() {
             final boolean privateMessage = message.isPrivateMessage();
             message.setType(privateMessage ? Message.TYPE_PRIVATE_FILE : Message.TYPE_FILE);
-            final String url;
+            final URL url;
-            final String ref = mUrl.fragment();
+            final String ref = mUrl.getRef();
-            if (ref != null && AesGcmURL.IV_KEY.matcher(ref).matches()) {
+            if (method == Method.P1_S3) {
-                url = AesGcmURL.toAesGcmUrl(mUrl);
+                url = message.getFileParams().url;
+            } else if (ref != null && AesGcmURLStreamHandler.IV_KEY.matcher(ref).matches()) {
+                url = CryptoHelper.toAesGcmUrl(mUrl);
             } else {
-                url = mUrl.toString();
+                url = mUrl;
             }
             mXmppConnectionService.getFileBackend().updateFileParams(message, url);
             mXmppConnectionService.updateMessage(message);
         }
 
     }
-
-    private static void throwOnInvalidCode(final Response response) throws IOException {
-        final int code = response.code();
-        if (code < 200 || code >= 300) {
-            throw new IOException(String.format(Locale.ENGLISH, "HTTP Status code was %d", code));
-        }
-    }
 }

src/main/java/eu/siacs/conversations/http/HttpUploadConnection.java

@@ -1,36 +1,33 @@
 package eu.siacs.conversations.http;
 
+import android.os.PowerManager;
 import android.util.Log;
 
-import com.google.common.util.concurrent.FutureCallback;
+import java.io.FileInputStream;
-import com.google.common.util.concurrent.Futures;
+import java.io.InputStream;
-import com.google.common.util.concurrent.ListenableFuture;
+import java.io.OutputStream;
-import com.google.common.util.concurrent.MoreExecutors;
+import java.net.HttpURLConnection;
-
+import java.net.URL;
-import org.checkerframework.checker.nullness.compatqual.NullableDecl;
-import org.jetbrains.annotations.NotNull;
-
-import java.io.IOException;
 import java.util.Arrays;
+import java.util.HashMap;
 import java.util.List;
-import java.util.concurrent.Future;
+import java.util.Scanner;
+
+import javax.net.ssl.HttpsURLConnection;
 
 import eu.siacs.conversations.Config;
 import eu.siacs.conversations.entities.Account;
 import eu.siacs.conversations.entities.DownloadableFile;
 import eu.siacs.conversations.entities.Message;
 import eu.siacs.conversations.entities.Transferable;
+import eu.siacs.conversations.persistance.FileBackend;
 import eu.siacs.conversations.services.AbstractConnectionManager;
 import eu.siacs.conversations.services.XmppConnectionService;
+import eu.siacs.conversations.utils.Checksum;
 import eu.siacs.conversations.utils.CryptoHelper;
-import okhttp3.Call;
+import eu.siacs.conversations.utils.WakeLockHelper;
-import okhttp3.Callback;
-import okhttp3.OkHttpClient;
-import okhttp3.Request;
-import okhttp3.RequestBody;
-import okhttp3.Response;
 
-public class HttpUploadConnection implements Transferable, AbstractConnectionManager.ProgressListener {
+public class HttpUploadConnection implements Transferable {
 
 	static final List<String> WHITE_LISTED_HEADERS = Arrays.asList(
 			"Authorization",
@@ -40,22 +37,26 @@ public class HttpUploadConnection implements Transferable, AbstractConnectionMan
 
 	private final HttpConnectionManager mHttpConnectionManager;
 	private final XmppConnectionService mXmppConnectionService;
+	private final SlotRequester mSlotRequester;
 	private final Method method;
+	private final boolean mUseTor;
+	private boolean cancelled = false;
 	private boolean delayed = false;
 	private DownloadableFile file;
 	private final Message message;
+	private String mime;
 	private SlotRequester.Slot slot;
 	private byte[] key = null;
 
 	private long transmitted = 0;
-    private Call mostRecentCall;
-    private ListenableFuture<SlotRequester.Slot> slotFuture;
 
 	public HttpUploadConnection(Message message, Method method, HttpConnectionManager httpConnectionManager) {
 		this.message = message;
 		this.method = method;
 		this.mHttpConnectionManager = httpConnectionManager;
 		this.mXmppConnectionService = httpConnectionManager.getXmppConnectionService();
+		this.mSlotRequester = new SlotRequester(this.mXmppConnectionService);
+		this.mUseTor = mXmppConnectionService.useTorToConnect();
 	}
 
 	@Override
@@ -69,8 +70,8 @@ public class HttpUploadConnection implements Transferable, AbstractConnectionMan
 	}
 
 	@Override
-    public Long getFileSize() {
+	public long getFileSize() {
-        return file == null ? null : file.getExpectedSize();
+		return file == null ? 0 : file.getExpectedSize();
 	}
 
 	@Override
@@ -83,24 +84,11 @@ public class HttpUploadConnection implements Transferable, AbstractConnectionMan
 
 	@Override
 	public void cancel() {
-        final ListenableFuture<SlotRequester.Slot> slotFuture = this.slotFuture;
+		this.cancelled = true;
-        if (slotFuture != null && !slotFuture.isDone()) {
-            if (slotFuture.cancel(true)) {
-                Log.d(Config.LOGTAG,"cancelled slot requester");
-            }
-        }
-        final Call call = this.mostRecentCall;
-        if (call != null && !call.isCanceled()) {
-            call.cancel();
-            Log.d(Config.LOGTAG,"cancelled HTTP request");
-        }
 	}
 
 	private void fail(String errorMessage) {
 		finish();
-        final Call call = this.mostRecentCall;
-        final Future<SlotRequester.Slot> slotFuture = this.slotFuture;
-        final boolean cancelled = (call != null && call.isCanceled()) || (slotFuture != null && slotFuture.isCancelled());
 		mXmppConnectionService.markMessage(message, Message.STATUS_SEND_FAILED, cancelled ? Message.ERROR_MESSAGE_CANCELLED : errorMessage);
 	}
 
@@ -112,11 +100,10 @@ public class HttpUploadConnection implements Transferable, AbstractConnectionMan
 	public void init(boolean delay) {
 		final Account account = message.getConversation().getAccount();
 		this.file = mXmppConnectionService.getFileBackend().getFile(message, false);
-        final String mime;
 		if (message.getEncryption() == Message.ENCRYPTION_PGP || message.getEncryption() == Message.ENCRYPTION_DECRYPTED) {
-            mime = "application/pgp-encrypted";
+			this.mime = "application/pgp-encrypted";
 		} else {
-            mime = this.file.getMimeType();
+			this.mime = this.file.getMimeType();
 		}
 		final long originalFileSize = file.getSize();
 		this.delayed = delay;
@@ -127,62 +114,108 @@ public class HttpUploadConnection implements Transferable, AbstractConnectionMan
 			mXmppConnectionService.getRNG().nextBytes(this.key);
 			this.file.setKeyAndIv(this.key);
 		}
+
+		final String md5;
+
+		if (method == Method.P1_S3) {
+			try {
+				md5 = Checksum.md5(AbstractConnectionManager.upgrade(file, new FileInputStream(file)));
+			} catch (Exception e) {
+				Log.d(Config.LOGTAG, account.getJid().asBareJid()+": unable to calculate md5()", e);
+				fail(e.getMessage());
+				return;
+			}
+		} else {
+			md5 = null;
+		}
+
 		this.file.setExpectedSize(originalFileSize + (file.getKey() != null ? 16 : 0));
 		message.resetFileParams();
-        this.slotFuture = new SlotRequester(mXmppConnectionService).request(method, account, file, mime);
+		this.mSlotRequester.request(method, account, file, mime, md5, new SlotRequester.OnSlotRequested() {
-        Futures.addCallback(this.slotFuture, new FutureCallback<SlotRequester.Slot>() {
 			@Override
-            public void onSuccess(@NullableDecl SlotRequester.Slot result) {
+			public void success(SlotRequester.Slot slot) {
-                HttpUploadConnection.this.slot = result;
+				if (!cancelled) {
-                try {
+					HttpUploadConnection.this.slot = slot;
-                    HttpUploadConnection.this.upload();
+					new Thread(HttpUploadConnection.this::upload).start();
-                } catch (final Exception e) {
-                    fail(e.getMessage());
 				}
 			}
 
 			@Override
-            public void onFailure(@NotNull final Throwable throwable) {
+			public void failure(String message) {
-                Log.d(Config.LOGTAG, account.getJid().asBareJid() + ": unable to request slot", throwable);
+				fail(message);
-                fail(throwable.getMessage());
 			}
-        }, MoreExecutors.directExecutor());
+		});
 		message.setTransferable(this);
 		mXmppConnectionService.markMessage(message, Message.STATUS_UNSEND);
 	}
 
 	private void upload() {
-        final OkHttpClient client = mHttpConnectionManager.buildHttpClient(
+		OutputStream os = null;
-                slot.put,
+		InputStream fileInputStream = null;
-                message.getConversation().getAccount(),
+		HttpURLConnection connection = null;
-                0,
+		PowerManager.WakeLock wakeLock = mHttpConnectionManager.createWakeLock("http_upload_"+message.getUuid());
-                true
+		try {
-        );
+			fileInputStream = new FileInputStream(file);
-        final RequestBody requestBody = AbstractConnectionManager.requestBody(file, this);
+			final String slotHostname = slot.getPutUrl().getHost();
-        final Request request = new Request.Builder()
+			final boolean onionSlot = slotHostname != null && slotHostname.endsWith(".onion");
-                .url(slot.put)
+			final int expectedFileSize = (int) file.getExpectedSize();
-                .put(requestBody)
+			final int readTimeout = (expectedFileSize / 2048) + Config.SOCKET_TIMEOUT; //assuming a minimum transfer speed of 16kbit/s
-                .headers(slot.headers)
+			wakeLock.acquire(readTimeout);
-                .build();
+			Log.d(Config.LOGTAG, "uploading to " + slot.getPutUrl().toString()+ " w/ read timeout of "+readTimeout+"s");
-        Log.d(Config.LOGTAG, "uploading file to " + slot.put);
-        this.mostRecentCall = client.newCall(request);
-        this.mostRecentCall.enqueue(new Callback() {
-            @Override
-            public void onFailure(@NotNull Call call, IOException e) {
-                Log.d(Config.LOGTAG, "http upload failed", e);
-                fail(e.getMessage());
-            }
 
-            @Override
+			if (mUseTor || message.getConversation().getAccount().isOnion() || onionSlot) {
-            public void onResponse(@NotNull Call call, @NotNull Response response)  {
+				connection = (HttpURLConnection) slot.getPutUrl().openConnection(HttpConnectionManager.getProxy());
-                final int code = response.code();
+			} else {
+				connection = (HttpURLConnection) slot.getPutUrl().openConnection();
+			}
+			if (connection instanceof HttpsURLConnection) {
+				mHttpConnectionManager.setupTrustManager((HttpsURLConnection) connection, true);
+			}
+			connection.setUseCaches(false);
+			connection.setRequestMethod("PUT");
+			connection.setFixedLengthStreamingMode(expectedFileSize);
+			connection.setRequestProperty("User-Agent",mXmppConnectionService.getIqGenerator().getUserAgent());
+			if(slot.getHeaders() != null) {
+				for(HashMap.Entry<String,String> entry : slot.getHeaders().entrySet()) {
+					connection.setRequestProperty(entry.getKey(),entry.getValue());
+				}
+			}
+			connection.setDoOutput(true);
+			connection.setDoInput(true);
+			connection.setConnectTimeout(Config.SOCKET_TIMEOUT * 1000);
+			connection.setReadTimeout(readTimeout * 1000);
+			connection.connect();
+			final InputStream innerInputStream = AbstractConnectionManager.upgrade(file, fileInputStream);
+			os = connection.getOutputStream();
+			transmitted = 0;
+			int count;
+			byte[] buffer = new byte[4096];
+			while (((count = innerInputStream.read(buffer)) != -1) && !cancelled) {
+				transmitted += count;
+				os.write(buffer, 0, count);
+				mHttpConnectionManager.updateConversationUi(false);
+			}
+			os.flush();
+			os.close();
+			int code = connection.getResponseCode();
+			InputStream is = connection.getErrorStream();
+			if (is != null) {
+				try (Scanner scanner = new Scanner(is)) {
+					scanner.useDelimiter("\\Z");
+					Log.d(Config.LOGTAG, "body: " + scanner.next());
+				}
+			}
 			if (code == 200 || code == 201) {
 				Log.d(Config.LOGTAG, "finished uploading file");
-                    final String get;
+				final URL get;
 				if (key != null) {
-                        get = AesGcmURL.toAesGcmUrl(slot.get.newBuilder().fragment(CryptoHelper.bytesToHex(key)).build());
+					if (method == Method.P1_S3) {
+						get = new URL(slot.getGetUrl().toString()+"#"+CryptoHelper.bytesToHex(key));
 					} else {
-                        get = slot.get.toString();
+						get = CryptoHelper.toAesGcmUrl(new URL(slot.getGetUrl().toString() + "#" + CryptoHelper.bytesToHex(key)));
+					}
+				} else {
+					get = slot.getGetUrl();
 				}
 				mXmppConnectionService.getFileBackend().updateFileParams(message, get);
 				mXmppConnectionService.getFileBackend().updateMediaScanner(file);
@@ -195,17 +228,21 @@ public class HttpUploadConnection implements Transferable, AbstractConnectionMan
 				Log.d(Config.LOGTAG,"http upload failed because response code was "+code);
 				fail("http upload failed because response code was "+code);
 			}
+		} catch (Exception e) {
+			e.printStackTrace();
+			Log.d(Config.LOGTAG,"http upload failed "+e.getMessage());
+			fail(e.getMessage());
+		} finally {
+			FileBackend.close(fileInputStream);
+			FileBackend.close(os);
+			if (connection != null) {
+				connection.disconnect();
+			}
+			WakeLockHelper.release(wakeLock);
 		}
-        });
 	}
 
 	public Message getMessage() {
 		return message;
 	}
-
-    @Override
-    public void onProgress(final long progress) {
-        this.transmitted = progress;
-        mHttpConnectionManager.updateConversationUi(false);
-    }
 }

src/main/java/eu/siacs/conversations/http/Method.java

@@ -33,7 +33,7 @@ import eu.siacs.conversations.entities.Account;
 import eu.siacs.conversations.xmpp.XmppConnection;
 
 public enum  Method {
-	HTTP_UPLOAD, HTTP_UPLOAD_LEGACY;
+	P1_S3, HTTP_UPLOAD, HTTP_UPLOAD_LEGACY;
 
 	public static Method determine(Account account) {
 		XmppConnection.Features features = account.getXmppConnection() == null ? null : account.getXmppConnection().getFeatures();
@@ -44,6 +44,8 @@ public enum  Method {
 			return HTTP_UPLOAD_LEGACY;
 		} else if (features.httpUpload(0)) {
 			return HTTP_UPLOAD;
+		} else if (features.p1S3FileTransfer()) {
+			return P1_S3;
 		} else {
 			return HTTP_UPLOAD;
 		}

src/main/java/eu/siacs/conversations/http/P1S3UrlStreamHandler.java

@@ -0,0 +1,62 @@
+/*
+ * Copyright (c) 2018, Daniel Gultsch All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without modification,
+ * are permitted provided that the following conditions are met:
+ *
+ * 1. Redistributions of source code must retain the above copyright notice, this
+ * list of conditions and the following disclaimer.
+ *
+ * 2. Redistributions in binary form must reproduce the above copyright notice,
+ * this list of conditions and the following disclaimer in the documentation and/or
+ * other materials provided with the distribution.
+ *
+ * 3. Neither the name of the copyright holder nor the names of its contributors
+ * may be used to endorse or promote products derived from this software without
+ * specific prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND
+ * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
+ * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+ * DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE FOR
+ * ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
+ * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
+ * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON
+ * ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
+ * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+package eu.siacs.conversations.http;
+
+import java.net.MalformedURLException;
+import java.net.URL;
+import java.net.URLConnection;
+import java.net.URLStreamHandler;
+
+import eu.siacs.conversations.xml.Element;
+
+public class P1S3UrlStreamHandler extends URLStreamHandler {
+
+	public static final String PROTOCOL_NAME = "p1s3";
+
+	@Override
+	protected URLConnection openConnection(URL url) {
+		throw new IllegalStateException("Unable to open connection with stub protocol");
+	}
+
+	public static URL of(String fileId, String filename) throws MalformedURLException {
+		if (fileId == null || filename == null) {
+			throw new MalformedURLException("Paramaters must not be null");
+		}
+		return new URL(PROTOCOL_NAME+"://" + fileId + "/" + filename);
+	}
+
+	public static URL of(Element x) {
+		try {
+			return of(x.getAttribute("fileid"),x.getAttribute("name"));
+		} catch (MalformedURLException e) {
+			return null;
+		}
+	}
+}

src/main/java/eu/siacs/conversations/http/SlotRequester.java

@@ -29,23 +29,21 @@
 
 package eu.siacs.conversations.http;
 
-import com.google.common.collect.ImmutableMap;
+import android.util.Log;
-import com.google.common.util.concurrent.ListenableFuture;
-import com.google.common.util.concurrent.SettableFuture;
 
-import java.util.Map;
+import java.net.MalformedURLException;
+import java.net.URL;
+import java.util.HashMap;
 
+import eu.siacs.conversations.Config;
 import eu.siacs.conversations.entities.Account;
 import eu.siacs.conversations.entities.DownloadableFile;
 import eu.siacs.conversations.parser.IqParser;
 import eu.siacs.conversations.services.XmppConnectionService;
 import eu.siacs.conversations.xml.Element;
 import eu.siacs.conversations.xml.Namespace;
-import eu.siacs.conversations.xmpp.IqResponseException;
 import eu.siacs.conversations.xmpp.Jid;
 import eu.siacs.conversations.xmpp.stanzas.IqPacket;
-import okhttp3.Headers;
-import okhttp3.HttpUrl;
 
 public class SlotRequester {
 
@@ -55,52 +53,51 @@ public class SlotRequester {
 		this.service = service;
 	}
 
-    public ListenableFuture<Slot> request(Method method, Account account, DownloadableFile file, String mime) {
+	public void request(Method method, Account account, DownloadableFile file, String mime, String md5, OnSlotRequested callback) {
-        if (method == Method.HTTP_UPLOAD_LEGACY) {
+		if (method == Method.HTTP_UPLOAD) {
-            final Jid host = account.getXmppConnection().findDiscoItemByFeature(Namespace.HTTP_UPLOAD_LEGACY);
+			Jid host = account.getXmppConnection().findDiscoItemByFeature(Namespace.HTTP_UPLOAD);
-            return requestHttpUploadLegacy(account, host, file, mime);
+			requestHttpUpload(account, host, file, mime, callback);
+		} else if (method == Method.HTTP_UPLOAD_LEGACY) {
+			Jid host = account.getXmppConnection().findDiscoItemByFeature(Namespace.HTTP_UPLOAD_LEGACY);
+			requestHttpUploadLegacy(account, host, file, mime, callback);
 		} else {
-            final Jid host = account.getXmppConnection().findDiscoItemByFeature(Namespace.HTTP_UPLOAD);
+			requestP1S3(account, account.getDomain(), file.getName(), md5, callback);
-            return requestHttpUpload(account, host, file, mime);
 		}
 	}
 
-    private ListenableFuture<Slot> requestHttpUploadLegacy(Account account, Jid host, DownloadableFile file, String mime) {
+	private void requestHttpUploadLegacy(Account account, Jid host, DownloadableFile file, String mime, OnSlotRequested callback) {
-        final SettableFuture<Slot> future = SettableFuture.create();
+		IqPacket request = service.getIqGenerator().requestHttpUploadLegacySlot(host, file, mime);
-        final IqPacket request = service.getIqGenerator().requestHttpUploadLegacySlot(host, file, mime);
 		service.sendIqPacket(account, request, (a, packet) -> {
 			if (packet.getType() == IqPacket.TYPE.RESULT) {
-                final Element slotElement = packet.findChild("slot", Namespace.HTTP_UPLOAD_LEGACY);
+				Element slotElement = packet.findChild("slot", Namespace.HTTP_UPLOAD_LEGACY);
 				if (slotElement != null) {
 					try {
 						final String putUrl = slotElement.findChildContent("put");
 						final String getUrl = slotElement.findChildContent("get");
 						if (getUrl != null && putUrl != null) {
-                            final Slot slot = new Slot(
+							Slot slot = new Slot(new URL(putUrl));
-                                    HttpUrl.get(putUrl),
+							slot.getUrl = new URL(getUrl);
-                                    HttpUrl.get(getUrl),
+							slot.headers = new HashMap<>();
-                                    Headers.of("Content-Type", mime == null ? "application/octet-stream" : mime)
+							slot.headers.put("Content-Type", mime == null ? "application/octet-stream" : mime);
-                            );
+							callback.success(slot);
-                            future.set(slot);
 							return;
 						}
-                    } catch (final IllegalArgumentException e) {
+					} catch (MalformedURLException e) {
-                        future.setException(e);
+						//fall through
-                        return;
 					}
 				}
 			}
-            future.setException(new IqResponseException(IqParser.extractErrorMessage(packet)));
+			Log.d(Config.LOGTAG, account.getJid().toString() + ": invalid response to slot request " + packet);
+			callback.failure(IqParser.extractErrorMessage(packet));
 		});
-        return future;
+
 	}
 
-    private ListenableFuture<Slot> requestHttpUpload(Account account, Jid host, DownloadableFile file, String mime) {
+	private void requestHttpUpload(Account account, Jid host, DownloadableFile file, String mime, OnSlotRequested callback) {
-        final SettableFuture<Slot> future = SettableFuture.create();
+		IqPacket request = service.getIqGenerator().requestHttpUploadSlot(host, file, mime);
-        final IqPacket request = service.getIqGenerator().requestHttpUploadSlot(host, file, mime);
 		service.sendIqPacket(account, request, (a, packet) -> {
 			if (packet.getType() == IqPacket.TYPE.RESULT) {
-                final Element slotElement = packet.findChild("slot", Namespace.HTTP_UPLOAD);
+				Element slotElement = packet.findChild("slot", Namespace.HTTP_UPLOAD);
 				if (slotElement != null) {
 					try {
 						final Element put = slotElement.findChild("put");
@@ -108,47 +105,86 @@ public class SlotRequester {
 						final String putUrl = put == null ? null : put.getAttribute("url");
 						final String getUrl = get == null ? null : get.getAttribute("url");
 						if (getUrl != null && putUrl != null) {
-                            final ImmutableMap.Builder<String, String> headers = new ImmutableMap.Builder<>();
+							Slot slot = new Slot(new URL(putUrl));
-                            for (final Element child : put.getChildren()) {
+							slot.getUrl = new URL(getUrl);
+							slot.headers = new HashMap<>();
+							for (Element child : put.getChildren()) {
 								if ("header".equals(child.getName())) {
 									final String name = child.getAttribute("name");
 									final String value = child.getContent();
 									if (HttpUploadConnection.WHITE_LISTED_HEADERS.contains(name) && value != null && !value.trim().contains("\n")) {
-                                        headers.put(name, value.trim());
+										slot.headers.put(name, value.trim());
 									}
 								}
 							}
-                            headers.put("Content-Type", mime == null ? "application/octet-stream" : mime);
+							slot.headers.put("Content-Type", mime == null ? "application/octet-stream" : mime);
-                            final Slot slot = new Slot(HttpUrl.get(putUrl), HttpUrl.get(getUrl), headers.build());
+							callback.success(slot);
-                            future.set(slot);
 							return;
 						}
-                    } catch (final IllegalArgumentException e) {
+					} catch (MalformedURLException e) {
-                        future.setException(e);
+						//fall through
-                        return;
 					}
 				}
 			}
-            future.setException(new IqResponseException(IqParser.extractErrorMessage(packet)));
+			Log.d(Config.LOGTAG, account.getJid().toString() + ": invalid response to slot request " + packet);
+			callback.failure(IqParser.extractErrorMessage(packet));
 		});
-        return future;
+
+	}
+
+	private void requestP1S3(final Account account, Jid host, String filename, String md5, OnSlotRequested callback) {
+		IqPacket request = service.getIqGenerator().requestP1S3Slot(host, md5);
+		service.sendIqPacket(account, request, (a, packet) -> {
+			if (packet.getType() == IqPacket.TYPE.RESULT) {
+				String putUrl = packet.query(Namespace.P1_S3_FILE_TRANSFER).getAttribute("upload");
+				String id = packet.query().getAttribute("fileid");
+				try {
+					if (putUrl != null && id != null) {
+						Slot slot = new Slot(new URL(putUrl));
+						slot.getUrl = P1S3UrlStreamHandler.of(id, filename);
+						slot.headers = new HashMap<>();
+						slot.headers.put("Content-MD5", md5);
+						slot.headers.put("Content-Type", " "); //required to force it to empty. otherwise library will set something
+						callback.success(slot);
+						return;
+					}
+				} catch (MalformedURLException e) {
+					//fall through;
+				}
+			}
+			callback.failure("unable to request slot");
+		});
+		Log.d(Config.LOGTAG, "requesting slot with p1. md5=" + md5);
+	}
+
+
+	public interface OnSlotRequested {
+
+		void success(Slot slot);
+
+		void failure(String message);
+
 	}
 
 	public static class Slot {
-        public final HttpUrl put;
+		private final URL putUrl;
-        public final HttpUrl get;
+		private URL getUrl;
-        public final Headers headers;
+		private HashMap<String, String> headers;
 
-        private Slot(HttpUrl put, HttpUrl get, Headers headers) {
+		private Slot(URL putUrl) {
-            this.put = put;
+			this.putUrl = putUrl;
-            this.get = get;
-            this.headers = headers;
 		}
 
-        private Slot(HttpUrl put, HttpUrl getUrl, Map<String, String> headers) {
+		public URL getPutUrl() {
-            this.put = put;
+			return putUrl;
-            this.get = getUrl;
+		}
-            this.headers = Headers.of(headers);
+
+		public URL getGetUrl() {
+			return getUrl;
+		}
+
+		public HashMap<String, String> getHeaders() {
+			return headers;
 		}
 	}
 }

src/main/java/eu/siacs/conversations/http/URL.java

@@ -1,32 +0,0 @@
-package eu.siacs.conversations.http;
-
-import java.net.URI;
-import java.net.URISyntaxException;
-import java.util.Arrays;
-import java.util.List;
-
-import okhttp3.HttpUrl;
-
-public class URL {
-
-    public static final List<String> WELL_KNOWN_SCHEMES = Arrays.asList("http", "https", AesGcmURL.PROTOCOL_NAME);
-
-    public static String tryParse(String url) {
-        final URI uri;
-        try {
-            uri = new URI(url);
-        } catch (URISyntaxException e) {
-            return null;
-        }
-        if (WELL_KNOWN_SCHEMES.contains(uri.getScheme())) {
-            return uri.toString();
-        } else {
-            return null;
-        }
-    }
-
-    public static HttpUrl stripFragment(final HttpUrl url) {
-        return url.newBuilder().fragment(null).build();
-    }
-
-}

src/main/java/eu/siacs/conversations/parser/MessageParser.java

@@ -3,6 +3,7 @@ package eu.siacs.conversations.parser;
 import android.util.Log;
 import android.util.Pair;
 
+import java.net.URL;
 import java.text.SimpleDateFormat;
 import java.util.ArrayList;
 import java.util.Arrays;
@@ -32,6 +33,7 @@ import eu.siacs.conversations.entities.ReadByMarker;
 import eu.siacs.conversations.entities.ReceiptRequest;
 import eu.siacs.conversations.entities.RtpSessionStatus;
 import eu.siacs.conversations.http.HttpConnectionManager;
+import eu.siacs.conversations.http.P1S3UrlStreamHandler;
 import eu.siacs.conversations.services.MessageArchiveService;
 import eu.siacs.conversations.services.QuickConversationsService;
 import eu.siacs.conversations.services.XmppConnectionService;
@@ -406,6 +408,8 @@ public class MessageParser extends AbstractParser implements OnMessagePacketRece
         final String pgpEncrypted = packet.findChildContent("x", "jabber:x:encrypted");
         final Element replaceElement = packet.findChild("replace", "urn:xmpp:message-correct:0");
         final Element oob = packet.findChild("x", Namespace.OOB);
+        final Element xP1S3 = packet.findChild("x", Namespace.P1_S3_FILE_TRANSFER);
+        final URL xP1S3url = xP1S3 == null ? null : P1S3UrlStreamHandler.of(xP1S3);
         final String oobUrl = oob != null ? oob.findChildContent("url") : null;
         final String replacementId = replaceElement == null ? null : replaceElement.getAttribute("id");
         final Element axolotlEncrypted = packet.findChildEnsureSingle(XmppAxolotlMessage.CONTAINERTAG, AxolotlService.PEP_PREFIX);
@@ -460,7 +464,7 @@ public class MessageParser extends AbstractParser implements OnMessagePacketRece
             }
         }
 
-        if ((body != null || pgpEncrypted != null || (axolotlEncrypted != null && axolotlEncrypted.hasChild("payload")) || oobUrl != null) && !isMucStatusMessage) {
+        if ((body != null || pgpEncrypted != null || (axolotlEncrypted != null && axolotlEncrypted.hasChild("payload")) || oobUrl != null || xP1S3 != null) && !isMucStatusMessage) {
             final boolean conversationIsProbablyMuc = isTypeGroupChat || mucUserElement != null || account.getXmppConnection().getMucServersWithholdAccount().contains(counterpart.getDomain().toEscapedString());
             final Conversation conversation = mXmppConnectionService.findOrCreateConversation(account, counterpart.asBareJid(), conversationIsProbablyMuc, false, query, false);
             final boolean conversationMultiMode = conversation.getMode() == Conversation.MODE_MULTI;
@@ -484,11 +488,13 @@ public class MessageParser extends AbstractParser implements OnMessagePacketRece
                 if (conversation.getMucOptions().isSelf(counterpart)) {
                     status = Message.STATUS_SEND_RECEIVED;
                     isCarbon = true; //not really carbon but received from another resource
-                    if (mXmppConnectionService.markMessage(conversation, remoteMsgId, status, serverMsgId, body)) {
+                    //TODO this would be the place to change the body after something like mod_pastebin
+                    if (mXmppConnectionService.markMessage(conversation, remoteMsgId, status, serverMsgId)) {
                         return;
                     } else if (remoteMsgId == null || Config.IGNORE_ID_REWRITE_IN_MUC) {
-                        if (body != null) {
+                        LocalizedContent localizedBody = packet.getBody();
-                            Message message = conversation.findSentMessageWithBody(body.content);
+                        if (localizedBody != null) {
+                            Message message = conversation.findSentMessageWithBody(localizedBody.content);
                             if (message != null) {
                                 mXmppConnectionService.markMessage(message, status);
                                 return;
@@ -500,7 +506,13 @@ public class MessageParser extends AbstractParser implements OnMessagePacketRece
                 }
             }
             final Message message;
-            if (pgpEncrypted != null && Config.supportOpenPgp()) {
+            if (xP1S3url != null) {
+                message = new Message(conversation, xP1S3url.toString(), Message.ENCRYPTION_NONE, status);
+                message.setOob(true);
+                if (CryptoHelper.isPgpEncryptedUrl(xP1S3url.toString())) {
+                    message.setEncryption(Message.ENCRYPTION_DECRYPTED);
+                }
+            } else if (pgpEncrypted != null && Config.supportOpenPgp()) {
                 message = new Message(conversation, pgpEncrypted, Message.ENCRYPTION_PGP, status);
             } else if (axolotlEncrypted != null && Config.supportOmemo()) {
                 Jid origin;

src/main/java/eu/siacs/conversations/parser/PresenceParser.java

@@ -2,8 +2,6 @@ package eu.siacs.conversations.parser;
 
 import android.util.Log;
 
-import org.openintents.openpgp.util.OpenPgpUtils;
-
 import java.util.ArrayList;
 import java.util.List;
 
@@ -315,10 +313,9 @@ public class PresenceParser extends AbstractParser implements
 			PgpEngine pgp = mXmppConnectionService.getPgpEngine();
 			Element x = packet.findChild("x", "jabber:x:signed");
 			if (pgp != null && x != null) {
-				final String status = packet.findChildContent("status");
+				Element status = packet.findChild("status");
-				final long keyId = pgp.fetchKeyId(account, status, x.getContent());
+				String msg = status != null ? status.getContent() : "";
-				if (keyId != 0 && contact.setPgpKeyId(keyId)) {
+				if (contact.setPgpKeyId(pgp.fetchKeyId(account, msg, x.getContent()))) {
-					Log.d(Config.LOGTAG,account.getJid().asBareJid()+": found OpenPGP key id for "+contact.getJid()+" "+OpenPgpUtils.convertKeyIdToHex(keyId));
 					mXmppConnectionService.syncRoster(account);
 				}
 			}

src/main/java/eu/siacs/conversations/persistance/DatabaseBackend.java

@@ -11,8 +11,6 @@ import android.os.SystemClock;
 import android.util.Base64;
 import android.util.Log;
 
-import com.google.common.base.Stopwatch;
-
 import org.json.JSONException;
 import org.json.JSONObject;
 import org.whispersystems.libsignal.IdentityKey;
@@ -64,9 +62,7 @@ import eu.siacs.conversations.xmpp.mam.MamReference;
 public class DatabaseBackend extends SQLiteOpenHelper {
 
     private static final String DATABASE_NAME = "history";
-    private static final int DATABASE_VERSION = 50;
+    private static final int DATABASE_VERSION = 49;
-
-    private static boolean requiresMessageIndexRebuild = false;
     private static DatabaseBackend instance = null;
     private static final String CREATE_CONTATCS_STATEMENT = "create table "
             + Contact.TABLENAME + "(" + Contact.ACCOUNT + " TEXT, "
@@ -169,17 +165,16 @@ public class DatabaseBackend extends SQLiteOpenHelper {
             + "UNIQUE(" + Resolver.Result.DOMAIN + ") ON CONFLICT REPLACE"
             + ");";
 
-    private static final String CREATE_MESSAGE_TIME_INDEX = "CREATE INDEX message_time_index ON " + Message.TABLENAME + "(" + Message.TIME_SENT + ")";
+    private static final String CREATE_MESSAGE_TIME_INDEX = "create INDEX message_time_index ON " + Message.TABLENAME + "(" + Message.TIME_SENT + ")";
-    private static final String CREATE_MESSAGE_CONVERSATION_INDEX = "CREATE INDEX message_conversation_index ON " + Message.TABLENAME + "(" + Message.CONVERSATION + ")";
+    private static final String CREATE_MESSAGE_CONVERSATION_INDEX = "create INDEX message_conversation_index ON " + Message.TABLENAME + "(" + Message.CONVERSATION + ")";
-    private static final String CREATE_MESSAGE_DELETED_INDEX = "CREATE INDEX message_deleted_index ON " + Message.TABLENAME + "(" + Message.DELETED + ")";
+    private static final String CREATE_MESSAGE_DELETED_INDEX = "create index message_deleted_index ON " + Message.TABLENAME + "(" + Message.DELETED + ")";
-    private static final String CREATE_MESSAGE_RELATIVE_FILE_PATH_INDEX = "CREATE INDEX message_file_path_index ON " + Message.TABLENAME + "(" + Message.RELATIVE_FILE_PATH + ")";
+    private static final String CREATE_MESSAGE_RELATIVE_FILE_PATH_INDEX = "create INDEX message_file_path_index ON " + Message.TABLENAME + "(" + Message.RELATIVE_FILE_PATH + ")";
-    private static final String CREATE_MESSAGE_TYPE_INDEX = "CREATE INDEX message_type_index ON " + Message.TABLENAME + "(" + Message.TYPE + ")";
+    private static final String CREATE_MESSAGE_TYPE_INDEX = "create INDEX message_type_index ON " + Message.TABLENAME + "(" + Message.TYPE + ")";
 
-    private static final String CREATE_MESSAGE_INDEX_TABLE = "CREATE VIRTUAL TABLE messages_index USING fts4 (uuid,body,notindexed=\"uuid\",content=\"" + Message.TABLENAME + "\",tokenize='unicode61')";
+    private static final String CREATE_MESSAGE_INDEX_TABLE = "CREATE VIRTUAL TABLE messages_index USING FTS4(uuid TEXT PRIMARY KEY, body TEXT)";
-    private static final String CREATE_MESSAGE_INSERT_TRIGGER = "CREATE TRIGGER after_message_insert AFTER INSERT ON " + Message.TABLENAME + " BEGIN INSERT INTO messages_index(rowid,uuid,body) VALUES(NEW.rowid,NEW.uuid,NEW.body); END;";
+    private static final String CREATE_MESSAGE_INSERT_TRIGGER = "CREATE TRIGGER after_message_insert AFTER INSERT ON " + Message.TABLENAME + " BEGIN INSERT INTO messages_index (uuid,body) VALUES (new.uuid,new.body); END;";
-    private static final String CREATE_MESSAGE_UPDATE_TRIGGER = "CREATE TRIGGER after_message_update UPDATE OF uuid,body ON " + Message.TABLENAME + " BEGIN UPDATE messages_index SET body=NEW.body,uuid=NEW.uuid WHERE rowid=OLD.rowid; END;";
+    private static final String CREATE_MESSAGE_UPDATE_TRIGGER = "CREATE TRIGGER after_message_update UPDATE of uuid,body ON " + Message.TABLENAME + " BEGIN update messages_index set body=new.body,uuid=new.uuid WHERE uuid=old.uuid; END;";
-    private static final String CREATE_MESSAGE_DELETE_TRIGGER = "CREATE TRIGGER after_message_delete AFTER DELETE ON " + Message.TABLENAME + " BEGIN DELETE FROM messages_index WHERE rowid=OLD.rowid; END;";
+    private static final String COPY_PREEXISTING_ENTRIES = "INSERT into messages_index(uuid,body) select uuid,body FROM " + Message.TABLENAME + ";";
-    private static final String COPY_PREEXISTING_ENTRIES = "INSERT INTO messages_index(messages_index) VALUES('rebuild');";
 
     private DatabaseBackend(Context context) {
         super(context, DATABASE_NAME, null, DATABASE_VERSION);
@@ -192,17 +187,6 @@ public class DatabaseBackend extends SQLiteOpenHelper {
         return values;
     }
 
-    public static boolean requiresMessageIndexRebuild() {
-        return requiresMessageIndexRebuild;
-    }
-
-    public void rebuildMessagesIndex() {
-        final SQLiteDatabase db = getWritableDatabase();
-        final Stopwatch stopwatch = Stopwatch.createStarted();
-        db.execSQL(COPY_PREEXISTING_ENTRIES);
-        Log.d(Config.LOGTAG,"rebuilt message index in "+ stopwatch.stop().toString());
-    }
-
     public static synchronized DatabaseBackend getInstance(Context context) {
         if (instance == null) {
             instance = new DatabaseBackend(context);
@@ -279,7 +263,6 @@ public class DatabaseBackend extends SQLiteOpenHelper {
         db.execSQL(CREATE_MESSAGE_INDEX_TABLE);
         db.execSQL(CREATE_MESSAGE_INSERT_TRIGGER);
         db.execSQL(CREATE_MESSAGE_UPDATE_TRIGGER);
-        db.execSQL(CREATE_MESSAGE_DELETE_TRIGGER);
     }
 
     @Override
@@ -532,10 +515,16 @@ public class DatabaseBackend extends SQLiteOpenHelper {
             db.execSQL("ALTER TABLE " + Message.TABLENAME + " ADD COLUMN " + Message.MARKABLE + " NUMBER DEFAULT 0");
         }
 
-        if (oldVersion < 39 && newVersion >= 39) {
+        if (oldVersion < 41 && newVersion >= 41) {
-            db.execSQL(CREATE_RESOLVER_RESULTS_TABLE);
+            db.execSQL(CREATE_MESSAGE_INDEX_TABLE);
+            db.execSQL(CREATE_MESSAGE_INSERT_TRIGGER);
+            db.execSQL(CREATE_MESSAGE_UPDATE_TRIGGER);
+            db.execSQL(COPY_PREEXISTING_ENTRIES);
         }
 
+        if (oldVersion < 42 && newVersion >= 42) {
+            db.execSQL("DROP TRIGGER IF EXISTS after_message_delete");
+        }
         if (QuickConversationsService.isQuicksy() && oldVersion < 43 && newVersion >= 43) {
             List<Account> accounts = getAccounts(db);
             for (Account account : accounts) {
@@ -575,29 +564,7 @@ public class DatabaseBackend extends SQLiteOpenHelper {
             db.execSQL("ALTER TABLE " + Contact.TABLENAME + " ADD COLUMN " + Contact.PRESENCE_NAME + " TEXT");
         }
         if (oldVersion < 49 && newVersion >= 49) {
-            // dirty workaround for failed migration
+            db.execSQL("ALTER TABLE " + Contact.TABLENAME + " ADD COLUMN " + Contact.RTP_CAPABILITY + " TEXT");
-            db.execSQL("IF NOT EXISTS (SELECT * FROM INFORMATION_SCHEMA.COLUMNS WHERE TABLE_NAME = '" + Contact.TABLENAME + "' AND COLUMN_NAME = '" + Contact.RTP_CAPABILITY + "') THEN"
-		+ "ALTER TABLE " + Contact.TABLENAME + " ADD COLUMN " + Contact.RTP_CAPABILITY + " TEXT");
-        }
-        if (oldVersion < 50 && newVersion >= 50) {
-            db.beginTransaction();
-            db.execSQL("DROP TRIGGER IF EXISTS after_message_insert;");
-            db.execSQL("DROP TRIGGER IF EXISTS after_message_update;");
-            db.execSQL("DROP TRIGGER IF EXISTS after_message_delete;");
-            db.execSQL("DROP TABLE IF EXISTS messages_index;");
-            // a hack that should not be necessary, but
-            // there was at least one occurence when SQLite failed at this
-            db.execSQL("DROP TABLE IF EXISTS messages_index_docsize;");
-            db.execSQL("DROP TABLE IF EXISTS messages_index_segdir;");
-            db.execSQL("DROP TABLE IF EXISTS messages_index_segments;");
-            db.execSQL("DROP TABLE IF EXISTS messages_index_stat;");
-            db.execSQL(CREATE_MESSAGE_INDEX_TABLE);
-            db.execSQL(CREATE_MESSAGE_INSERT_TRIGGER);
-            db.execSQL(CREATE_MESSAGE_UPDATE_TRIGGER);
-            db.execSQL(CREATE_MESSAGE_DELETE_TRIGGER);
-            db.setTransactionSuccessful();
-            db.endTransaction();
-            requiresMessageIndexRebuild = true;
         }
     }
 
@@ -824,7 +791,7 @@ public class DatabaseBackend extends SQLiteOpenHelper {
         final SQLiteDatabase db = this.getReadableDatabase();
         final StringBuilder SQL = new StringBuilder();
         final String[] selectionArgs;
-        SQL.append("SELECT " + Message.TABLENAME + ".*," + Conversation.TABLENAME + "." + Conversation.CONTACTJID + "," + Conversation.TABLENAME + "." + Conversation.ACCOUNT + "," + Conversation.TABLENAME + "." + Conversation.MODE + " FROM " + Message.TABLENAME + " JOIN " + Conversation.TABLENAME + " ON " + Message.TABLENAME + "." + Message.CONVERSATION + "=" + Conversation.TABLENAME + "." + Conversation.UUID + " JOIN messages_index ON messages_index.rowid=messages.rowid WHERE " + Message.ENCRYPTION + " NOT IN(" + Message.ENCRYPTION_AXOLOTL_NOT_FOR_THIS_DEVICE + "," + Message.ENCRYPTION_PGP + "," + Message.ENCRYPTION_DECRYPTION_FAILED + "," + Message.ENCRYPTION_AXOLOTL_FAILED + ") AND " + Message.TYPE + " IN(" + Message.TYPE_TEXT + "," + Message.TYPE_PRIVATE + ") AND messages_index.body MATCH ?");
+        SQL.append("SELECT " + Message.TABLENAME + ".*," + Conversation.TABLENAME + '.' + Conversation.CONTACTJID + ',' + Conversation.TABLENAME + '.' + Conversation.ACCOUNT + ',' + Conversation.TABLENAME + '.' + Conversation.MODE + " FROM " + Message.TABLENAME + " join " + Conversation.TABLENAME + " on " + Message.TABLENAME + '.' + Message.CONVERSATION + '=' + Conversation.TABLENAME + '.' + Conversation.UUID + " join messages_index ON messages_index.uuid=messages.uuid where " + Message.ENCRYPTION + " NOT IN(" + Message.ENCRYPTION_AXOLOTL_NOT_FOR_THIS_DEVICE + ',' + Message.ENCRYPTION_PGP + ',' + Message.ENCRYPTION_DECRYPTION_FAILED + ',' + Message.ENCRYPTION_AXOLOTL_FAILED + ") AND " + Message.TYPE + " IN(" + Message.TYPE_TEXT + ',' + Message.TYPE_PRIVATE + ") AND messages_index.body MATCH ?");
         if (uuid == null) {
             selectionArgs = new String[]{FtsUtils.toMatchString(term)};
         } else {
@@ -1075,7 +1042,8 @@ public class DatabaseBackend extends SQLiteOpenHelper {
         long start = SystemClock.elapsedRealtime();
         final SQLiteDatabase db = this.getWritableDatabase();
         db.beginTransaction();
-        final String[] args = {conversation.getUuid()};
+        String[] args = {conversation.getUuid()};
+        db.delete("messages_index", "uuid in (select uuid from messages where conversationUuid=?)", args);
         int num = db.delete(Message.TABLENAME, Message.CONVERSATION + "=?", args);
         db.setTransactionSuccessful();
         db.endTransaction();
@@ -1086,6 +1054,7 @@ public class DatabaseBackend extends SQLiteOpenHelper {
         final String[] args = {String.valueOf(timestamp)};
         SQLiteDatabase db = this.getReadableDatabase();
         db.beginTransaction();
+        db.delete("messages_index", "uuid in (select uuid from messages where timeSent<?)", args);
         db.delete(Message.TABLENAME, "timeSent<?", args);
         db.setTransactionSuccessful();
         db.endTransaction();

src/main/java/eu/siacs/conversations/persistance/FileBackend.java

@@ -29,11 +29,7 @@ import android.util.Log;
 import android.util.LruCache;
 
 import androidx.annotation.RequiresApi;
-import androidx.annotation.StringRes;
 import androidx.core.content.FileProvider;
-import androidx.exifinterface.media.ExifInterface;
-
-import com.google.common.io.ByteStreams;
 
 import java.io.ByteArrayOutputStream;
 import java.io.Closeable;
@@ -47,6 +43,7 @@ import java.io.InputStream;
 import java.io.OutputStream;
 import java.net.ServerSocket;
 import java.net.Socket;
+import java.net.URL;
 import java.security.DigestOutputStream;
 import java.security.MessageDigest;
 import java.security.NoSuchAlgorithmException;
@@ -67,6 +64,7 @@ import eu.siacs.conversations.ui.RecordingActivity;
 import eu.siacs.conversations.ui.util.Attachment;
 import eu.siacs.conversations.utils.Compatibility;
 import eu.siacs.conversations.utils.CryptoHelper;
+import eu.siacs.conversations.utils.ExifHelper;
 import eu.siacs.conversations.utils.FileUtils;
 import eu.siacs.conversations.utils.FileWriterException;
 import eu.siacs.conversations.utils.MimeUtils;
@@ -225,12 +223,8 @@ public class FileBackend {
     }
 
     private static boolean hasAlpha(final Bitmap bitmap) {
-        final int w = bitmap.getWidth();
+        for (int x = 0; x < bitmap.getWidth(); ++x) {
-        final int h = bitmap.getHeight();
+            for (int y = 0; y < bitmap.getWidth(); ++y) {
-        final int yStep = Math.max(1, w / 100);
-        final int xStep = Math.max(1, h / 100);
-        for (int x = 0; x < w; x += xStep) {
-            for (int y = 0; y < h; y += yStep) {
                 if (Color.alpha(bitmap.getPixel(x, y)) < 255) {
                     return true;
                 }
@@ -297,7 +291,12 @@ public class FileBackend {
         if (dimensions != null) {
             return dimensions;
         }
-        final int rotation = extractRotationFromMediaRetriever(metadataRetriever);
+        final int rotation;
+        if (android.os.Build.VERSION.SDK_INT >= android.os.Build.VERSION_CODES.JELLY_BEAN_MR1) {
+            rotation = extractRotationFromMediaRetriever(metadataRetriever);
+        } else {
+            rotation = 0;
+        }
         boolean rotated = rotation == 90 || rotation == 270;
         int height;
         try {
@@ -318,6 +317,7 @@ public class FileBackend {
         return rotated ? new Dimensions(width, height) : new Dimensions(height, width);
     }
 
+    @RequiresApi(api = Build.VERSION_CODES.JELLY_BEAN_MR1)
     private static int extractRotationFromMediaRetriever(MediaMetadataRetriever metadataRetriever) {
         String r = metadataRetriever.extractMetadata(MediaMetadataRetriever.METADATA_KEY_VIDEO_ROTATION);
         try {
@@ -417,9 +417,9 @@ public class FileBackend {
         }
     }
 
-    public static void updateFileParams(Message message, String url, long size) {
+    public static void updateFileParams(Message message, URL url, long size) {
         final StringBuilder body = new StringBuilder();
-        body.append(url).append('|').append(size);
+        body.append(url.toString()).append('|').append(size);
         message.setBody(body.toString());
     }
 
@@ -596,12 +596,12 @@ public class FileBackend {
         }
     }
 
-    public boolean useImageAsIs(final Uri uri) {
+    public boolean useImageAsIs(Uri uri) {
-        final String path = getOriginalPath(uri);
+        String path = getOriginalPath(uri);
         if (path == null || isPathBlacklisted(path)) {
             return false;
         }
-        final File file = new File(path);
+        File file = new File(path);
         long size = file.length();
         if (size == 0 || size >= mXmppConnectionService.getResources().getInteger(R.integer.auto_accept_filesize)) {
             return false;
@@ -609,15 +609,12 @@ public class FileBackend {
         BitmapFactory.Options options = new BitmapFactory.Options();
         options.inJustDecodeBounds = true;
         try {
-            final InputStream inputStream = mXmppConnectionService.getContentResolver().openInputStream(uri);
+            BitmapFactory.decodeStream(mXmppConnectionService.getContentResolver().openInputStream(uri), null, options);
-            BitmapFactory.decodeStream(inputStream, null, options);
-            close(inputStream);
             if (options.outMimeType == null || options.outHeight <= 0 || options.outWidth <= 0) {
                 return false;
             }
             return (options.outWidth <= Config.IMAGE_SIZE && options.outHeight <= Config.IMAGE_SIZE && options.outMimeType.contains(Config.IMAGE_FORMAT.name().toLowerCase()));
         } catch (FileNotFoundException e) {
-            Log.d(Config.LOGTAG, "unable to get image dimensions", e);
             return false;
         }
     }
@@ -629,38 +626,36 @@ public class FileBackend {
     private void copyFileToPrivateStorage(File file, Uri uri) throws FileCopyException {
         Log.d(Config.LOGTAG, "copy file (" + uri.toString() + ") to private storage " + file.getAbsolutePath());
         file.getParentFile().mkdirs();
+        OutputStream os = null;
+        InputStream is = null;
         try {
             file.createNewFile();
-        } catch (IOException e) {
+            os = new FileOutputStream(file);
-            throw new FileCopyException(R.string.error_unable_to_create_temporary_file);
+            is = mXmppConnectionService.getContentResolver().openInputStream(uri);
-        }
+            byte[] buffer = new byte[1024];
-        try (final OutputStream os = new FileOutputStream(file);
+            int length;
-             final InputStream is = mXmppConnectionService.getContentResolver().openInputStream(uri)) {
+            while ((length = is.read(buffer)) > 0) {
-            if (is == null) {
-                throw new FileCopyException(R.string.error_file_not_found);
-            }
                 try {
-                ByteStreams.copy(is, os);
+                    os.write(buffer, 0, length);
                 } catch (IOException e) {
                     throw new FileWriterException();
                 }
+            }
             try {
                 os.flush();
             } catch (IOException e) {
                 throw new FileWriterException();
             }
-        } catch (final FileNotFoundException e) {
+        } catch (FileNotFoundException e) {
-            cleanup(file);
             throw new FileCopyException(R.string.error_file_not_found);
-        } catch (final FileWriterException e) {
+        } catch (FileWriterException e) {
-            cleanup(file);
             throw new FileCopyException(R.string.error_unable_to_create_temporary_file);
-        } catch (final SecurityException e) {
+        } catch (IOException e) {
-            cleanup(file);
+            e.printStackTrace();
-            throw new FileCopyException(R.string.error_security_exception);
-        } catch (final IOException e) {
-            cleanup(file);
             throw new FileCopyException(R.string.error_io_exception);
+        } finally {
+            close(os);
+            close(is);
         }
     }
 
@@ -709,11 +704,8 @@ public class FileBackend {
         return pos > 0 ? filename.substring(pos + 1) : null;
     }
 
-    private void copyImageToPrivateStorage(File file, Uri image, int sampleSize) throws FileCopyException, ImageCompressionException {
+    private void copyImageToPrivateStorage(File file, Uri image, int sampleSize) throws FileCopyException, NotAnImageFileException {
-        final File parent = file.getParentFile();
+        file.getParentFile().mkdirs();
-        if (parent != null && parent.mkdirs()) {
-            Log.d(Config.LOGTAG, "created parent directory");
-        }
         InputStream is = null;
         OutputStream os = null;
         try {
@@ -724,22 +716,18 @@ public class FileBackend {
             if (is == null) {
                 throw new FileCopyException(R.string.error_not_an_image_file);
             }
-            final Bitmap originalBitmap;
+            Bitmap originalBitmap;
-            final BitmapFactory.Options options = new BitmapFactory.Options();
+            BitmapFactory.Options options = new BitmapFactory.Options();
-            final int inSampleSize = (int) Math.pow(2, sampleSize);
+            int inSampleSize = (int) Math.pow(2, sampleSize);
             Log.d(Config.LOGTAG, "reading bitmap with sample size " + inSampleSize);
             options.inSampleSize = inSampleSize;
             originalBitmap = BitmapFactory.decodeStream(is, null, options);
             is.close();
             if (originalBitmap == null) {
-                throw new ImageCompressionException("Source file was not an image");
+                throw new NotAnImageFileException();
-            }
-            if (!"image/jpeg".equals(options.outMimeType) && hasAlpha(originalBitmap)) {
-                originalBitmap.recycle();
-                throw new ImageCompressionException("Source file had alpha channel");
             }
             Bitmap scaledBitmap = resize(originalBitmap, Config.IMAGE_SIZE);
-            final int rotation = getRotation(image);
+            int rotation = getRotation(image);
             scaledBitmap = rotate(scaledBitmap, rotation);
             boolean targetSizeReached = false;
             int quality = Config.IMAGE_QUALITY;
@@ -755,16 +743,14 @@ public class FileBackend {
                 quality -= 5;
             }
             scaledBitmap.recycle();
-        } catch (final FileNotFoundException e) {
+        } catch (FileNotFoundException e) {
-            cleanup(file);
             throw new FileCopyException(R.string.error_file_not_found);
-        } catch (final IOException e) {
+        } catch (IOException e) {
-            cleanup(file);
+            e.printStackTrace();
             throw new FileCopyException(R.string.error_io_exception);
         } catch (SecurityException e) {
-            cleanup(file);
             throw new FileCopyException(R.string.error_security_exception_during_image_copy);
-        } catch (final OutOfMemoryError e) {
+        } catch (OutOfMemoryError e) {
             ++sampleSize;
             if (sampleSize <= 3) {
                 copyImageToPrivateStorage(file, image, sampleSize);
@@ -777,20 +763,12 @@ public class FileBackend {
         }
     }
 
-    private static void cleanup(final File file) {
+    public void copyImageToPrivateStorage(File file, Uri image) throws FileCopyException, NotAnImageFileException {
-        try {
-            file.delete();
-        } catch (Exception e) {
-
-        }
-    }
-
-    public void copyImageToPrivateStorage(File file, Uri image) throws FileCopyException, ImageCompressionException {
         Log.d(Config.LOGTAG, "copy image (" + image.toString() + ") to private storage " + file.getAbsolutePath());
         copyImageToPrivateStorage(file, image, 0);
     }
 
-    public void copyImageToPrivateStorage(Message message, Uri image) throws FileCopyException, ImageCompressionException {
+    public void copyImageToPrivateStorage(Message message, Uri image) throws FileCopyException, NotAnImageFileException {
         switch (Config.IMAGE_FORMAT) {
             case JPEG:
                 message.setRelativeFilePath(message.getUuid() + ".jpg");
@@ -806,49 +784,31 @@ public class FileBackend {
         updateFileParams(message);
     }
 
-    public boolean unusualBounds(final Uri image) {
+    public boolean unusualBounds(Uri image) {
         try {
-            final BitmapFactory.Options options = new BitmapFactory.Options();
+            BitmapFactory.Options options = new BitmapFactory.Options();
             options.inJustDecodeBounds = true;
-            final InputStream inputStream = mXmppConnectionService.getContentResolver().openInputStream(image);
+            BitmapFactory.decodeStream(mXmppConnectionService.getContentResolver().openInputStream(image), null, options);
-            BitmapFactory.decodeStream(inputStream, null, options);
-            close(inputStream);
             float ratio = (float) options.outHeight / options.outWidth;
             return ratio > (21.0f / 9.0f) || ratio < (9.0f / 21.0f);
-        } catch (final Exception e) {
+        } catch (Exception e) {
-            Log.w(Config.LOGTAG, "unable to detect image bounds", e);
             return false;
         }
     }
 
-    private int getRotation(final File file) {
+    private int getRotation(File file) {
-        try (final InputStream inputStream = new FileInputStream(file)) {
+        return getRotation(Uri.parse("file://" + file.getAbsolutePath()));
-            return getRotation(inputStream);
-        } catch (Exception e) {
-            return 0;
-        }
     }
 
-    private int getRotation(final Uri image) {
+    private int getRotation(Uri image) {
-        try (final InputStream is = mXmppConnectionService.getContentResolver().openInputStream(image)) {
+        InputStream is = null;
-            return is == null ? 0 : getRotation(is);
+        try {
-        } catch (final Exception e) {
+            is = mXmppConnectionService.getContentResolver().openInputStream(image);
-            return 0;
+            return ExifHelper.getOrientation(is);
-        }
+        } catch (FileNotFoundException e) {
-    }
-
-    private static int getRotation(final InputStream inputStream) throws IOException {
-        final ExifInterface exif = new ExifInterface(inputStream);
-        final int orientation = exif.getAttributeInt(ExifInterface.TAG_ORIENTATION, ExifInterface.ORIENTATION_UNDEFINED);
-        switch (orientation) {
-            case ExifInterface.ORIENTATION_ROTATE_180:
-                return 180;
-            case ExifInterface.ORIENTATION_ROTATE_90:
-                return 90;
-            case ExifInterface.ORIENTATION_ROTATE_270:
-                return 270;
-            default:
             return 0;
+        } finally {
+            close(is);
         }
     }
 
@@ -869,11 +829,11 @@ public class FileBackend {
                 } else if (mime.startsWith("video/")) {
                     thumbnail = getVideoPreview(file, size);
                 } else {
-                    final Bitmap fullSize = getFullSizeImagePreview(file, size);
+                    Bitmap fullsize = getFullSizeImagePreview(file, size);
-                    if (fullSize == null) {
+                    if (fullsize == null) {
                         throw new FileNotFoundException();
                     }
-                    thumbnail = resize(fullSize, size);
+                    thumbnail = resize(fullsize, size);
                     thumbnail = rotate(thumbnail, getRotation(file));
                     if (mime.equals("image/gif")) {
                         Bitmap withGifOverlay = thumbnail.copy(Bitmap.Config.ARGB_8888, true);
@@ -1321,11 +1281,9 @@ public class FileBackend {
     }
 
     private int calcSampleSize(Uri image, int size) throws FileNotFoundException, SecurityException {
-        final BitmapFactory.Options options = new BitmapFactory.Options();
+        BitmapFactory.Options options = new BitmapFactory.Options();
         options.inJustDecodeBounds = true;
-        final InputStream inputStream = mXmppConnectionService.getContentResolver().openInputStream(image);
+        BitmapFactory.decodeStream(mXmppConnectionService.getContentResolver().openInputStream(image), null, options);
-        BitmapFactory.decodeStream(inputStream, null, options);
-        close(inputStream);
         return calcSampleSize(options, size);
     }
 
@@ -1333,7 +1291,7 @@ public class FileBackend {
         updateFileParams(message, null);
     }
 
-    public void updateFileParams(Message message, String url) {
+    public void updateFileParams(Message message, URL url) {
         DownloadableFile file = getFile(message);
         final String mime = file.getMimeType();
         final boolean privateMessage = message.isPrivateMessage();
@@ -1343,7 +1301,7 @@ public class FileBackend {
         final boolean pdf = "application/pdf".equals(mime);
         final StringBuilder body = new StringBuilder();
         if (url != null) {
-            body.append(url);
+            body.append(url.toString());
         }
         body.append('|').append(file.getSize());
         if (image || video || (pdf && Compatibility.runsTwentyOne())) {
@@ -1481,23 +1439,18 @@ public class FileBackend {
         }
     }
 
-    public static class ImageCompressionException extends Exception {
+    public static class NotAnImageFileException extends Exception {
 
-        ImageCompressionException(String message) {
-            super(message);
     }
-    }
-
 
     public static class FileCopyException extends Exception {
         private final int resId;
 
-        private FileCopyException(@StringRes int resId) {
+        private FileCopyException(int resId) {
             this.resId = resId;
         }
 
-        public @StringRes
+        public int getResId() {
-        int getResId() {
             return resId;
         }
     }

src/main/java/eu/siacs/conversations/services/AbstractConnectionManager.java

@@ -5,8 +5,6 @@ import android.os.PowerManager;
 import android.os.SystemClock;
 import android.util.Log;
 
-import androidx.core.content.ContextCompat;
-
 import org.bouncycastle.crypto.engines.AESEngine;
 import org.bouncycastle.crypto.io.CipherInputStream;
 import org.bouncycastle.crypto.io.CipherOutputStream;
@@ -15,25 +13,22 @@ import org.bouncycastle.crypto.modes.GCMBlockCipher;
 import org.bouncycastle.crypto.params.AEADParameters;
 import org.bouncycastle.crypto.params.KeyParameter;
 
-import java.io.FileInputStream;
 import java.io.FileNotFoundException;
 import java.io.FileOutputStream;
-import java.io.IOException;
 import java.io.InputStream;
 import java.io.OutputStream;
+import java.security.InvalidAlgorithmParameterException;
+import java.security.InvalidKeyException;
+import java.security.NoSuchAlgorithmException;
+import java.security.NoSuchProviderException;
 import java.util.concurrent.atomic.AtomicLong;
 
-import javax.annotation.Nullable;
+import javax.crypto.NoSuchPaddingException;
 
 import eu.siacs.conversations.Config;
 import eu.siacs.conversations.R;
 import eu.siacs.conversations.entities.DownloadableFile;
 import eu.siacs.conversations.utils.Compatibility;
-import okhttp3.MediaType;
-import okhttp3.RequestBody;
-import okio.BufferedSink;
-import okio.Okio;
-import okio.Source;
 
 import static eu.siacs.conversations.entities.Transferable.VALID_CRYPTO_EXTENSIONS;
 
@@ -47,7 +42,7 @@ public class AbstractConnectionManager {
         this.mXmppConnectionService = service;
     }
 
-    public static InputStream upgrade(DownloadableFile file, InputStream is) {
+    public static InputStream upgrade(DownloadableFile file, InputStream is) throws InvalidAlgorithmParameterException, NoSuchAlgorithmException, InvalidKeyException, NoSuchPaddingException, NoSuchProviderException {
         if (file.getKey() != null && file.getIv() != null) {
             AEADBlockCipher cipher = new GCMBlockCipher(new AESEngine());
             cipher.init(true, new AEADParameters(new KeyParameter(file.getKey()), 128, file.getIv()));
@@ -57,43 +52,6 @@ public class AbstractConnectionManager {
         }
     }
 
-
-    //For progress tracking see:
-    //https://github.com/square/okhttp/blob/master/samples/guide/src/main/java/okhttp3/recipes/Progress.java
-
-    public static RequestBody requestBody(final DownloadableFile file, final ProgressListener progressListener) {
-        return new RequestBody() {
-
-            @Override
-            public long contentLength() {
-                return file.getSize() + (file.getKey() != null ? 16 : 0);
-            }
-
-            @Nullable
-            @Override
-            public MediaType contentType() {
-                return MediaType.parse(file.getMimeType());
-            }
-
-            @Override
-            public void writeTo(final BufferedSink sink) throws IOException {
-                long transmitted = 0;
-                try (final Source source = Okio.source(upgrade(file, new FileInputStream(file)))) {
-                    long read;
-                    while ((read = source.read(sink.buffer(), 8196)) != -1) {
-                        transmitted += read;
-                        sink.flush();
-                        progressListener.onProgress(transmitted);
-                    }
-                }
-            }
-        };
-    }
-
-    public interface ProgressListener {
-        void onProgress(long progress);
-    }
-
     public static OutputStream createOutputStream(DownloadableFile file, boolean append, boolean decrypt) {
         FileOutputStream os;
         try {
@@ -120,8 +78,7 @@ public class AbstractConnectionManager {
     }
 
     public long getAutoAcceptFileSize() {
-        final long autoAcceptFileSize = this.mXmppConnectionService.getLongPreference("auto_accept_file_size", R.integer.auto_accept_filesize);
+        return this.mXmppConnectionService.getLongPreference("auto_accept_file_size", R.integer.auto_accept_filesize);
-        return autoAcceptFileSize <= 0 ? -1 : autoAcceptFileSize;
     }
 
     public boolean hasStoragePermission() {
@@ -137,8 +94,8 @@ public class AbstractConnectionManager {
         }
     }
 
-    public PowerManager.WakeLock createWakeLock(final String name) {
+    public PowerManager.WakeLock createWakeLock(String name) {
-        final PowerManager powerManager = ContextCompat.getSystemService(mXmppConnectionService, PowerManager.class);
+        PowerManager powerManager = (PowerManager) mXmppConnectionService.getSystemService(Context.POWER_SERVICE);
         return powerManager.newWakeLock(PowerManager.PARTIAL_WAKE_LOCK, name);
     }
 
@@ -160,7 +117,6 @@ public class AbstractConnectionManager {
         }
 
         public static Extension of(String path) {
-            //TODO accept List<String> pathSegments
             final int pos = path.lastIndexOf('/');
             final String filename = path.substring(pos + 1).toLowerCase();
             final String[] parts = filename.split("\\.");

src/main/java/eu/siacs/conversations/services/AttachFileToConversationRunnable.java

@@ -3,19 +3,19 @@ package eu.siacs.conversations.services;
 import android.content.Context;
 import android.content.SharedPreferences;
 import android.net.Uri;
+import android.os.Build;
+import android.os.ParcelFileDescriptor;
 import android.preference.PreferenceManager;
 import android.util.Log;
 
-import androidx.annotation.NonNull;
+import androidx.annotation.RequiresApi;
 
-import com.otaliastudios.transcoder.Transcoder;
+import net.ypresto.androidtranscoder.MediaTranscoder;
-import com.otaliastudios.transcoder.TranscoderListener;
+import net.ypresto.androidtranscoder.format.MediaFormatStrategy;
-
-import org.jetbrains.annotations.NotNull;
 
 import java.io.File;
+import java.io.FileDescriptor;
 import java.io.FileNotFoundException;
-import java.util.Objects;
 import java.util.concurrent.ExecutionException;
 import java.util.concurrent.Future;
 
@@ -26,10 +26,11 @@ import eu.siacs.conversations.entities.DownloadableFile;
 import eu.siacs.conversations.entities.Message;
 import eu.siacs.conversations.persistance.FileBackend;
 import eu.siacs.conversations.ui.UiCallback;
+import eu.siacs.conversations.utils.Android360pFormatStrategy;
+import eu.siacs.conversations.utils.Android720pFormatStrategy;
 import eu.siacs.conversations.utils.MimeUtils;
-import eu.siacs.conversations.utils.TranscoderStrategies;
 
-public class AttachFileToConversationRunnable implements Runnable, TranscoderListener {
+public class AttachFileToConversationRunnable implements Runnable, MediaTranscoder.Listener {
 
 	private final XmppConnectionService mXmppConnectionService;
 	private final Message message;
@@ -53,7 +54,7 @@ public class AttachFileToConversationRunnable implements Runnable, TranscoderLis
 	}
 
 	boolean isVideoMessage() {
-        return this.isVideoMessage;
+		return this.isVideoMessage && Build.VERSION.SDK_INT >= Build.VERSION_CODES.JELLY_BEAN_MR2;
 	}
 
 	private void processAsFile() {
@@ -88,23 +89,20 @@ public class AttachFileToConversationRunnable implements Runnable, TranscoderLis
 		}
 	}
 
+	@RequiresApi(api = Build.VERSION_CODES.JELLY_BEAN_MR2)
 	private void processAsVideo() throws FileNotFoundException {
 		Log.d(Config.LOGTAG,"processing file as video");
 		mXmppConnectionService.startForcingForegroundNotification();
 		message.setRelativeFilePath(message.getUuid() + ".mp4");
 		final DownloadableFile file = mXmppConnectionService.getFileBackend().getFile(message);
-        if (Objects.requireNonNull(file.getParentFile()).mkdirs()) {
+		final MediaFormatStrategy formatStrategy = "720".equals(getVideoCompression()) ? new Android720pFormatStrategy() : new Android360pFormatStrategy();
-            Log.d(Config.LOGTAG, "created parent directory for video file");
+		file.getParentFile().mkdirs();
+		final ParcelFileDescriptor parcelFileDescriptor = mXmppConnectionService.getContentResolver().openFileDescriptor(uri, "r");
+		if (parcelFileDescriptor == null) {
+			throw new FileNotFoundException("Parcel File Descriptor was null");
 		}
-
+		FileDescriptor fileDescriptor = parcelFileDescriptor.getFileDescriptor();
-        final boolean highQuality = "720".equals(getVideoCompression());
+		Future<Void> future = MediaTranscoder.getInstance().transcodeVideo(fileDescriptor, file.getAbsolutePath(), formatStrategy, this);
-
-        final Future<Void> future = Transcoder.into(file.getAbsolutePath()).
-                addDataSource(mXmppConnectionService, uri)
-                .setVideoTrackStrategy(highQuality ? TranscoderStrategies.VIDEO_720P : TranscoderStrategies.VIDEO_360P)
-                .setAudioTrackStrategy(highQuality ? TranscoderStrategies.AUDIO_HQ : TranscoderStrategies.AUDIO_MQ)
-                .setListener(this)
-                .transcode();
 		try {
 			future.get();
 		} catch (InterruptedException e) {
@@ -129,7 +127,7 @@ public class AttachFileToConversationRunnable implements Runnable, TranscoderLis
 	}
 
 	@Override
-    public void onTranscodeCompleted(int successCode) {
+	public void onTranscodeCompleted() {
 		mXmppConnectionService.stopForcingForegroundNotification();
 		final File file = mXmppConnectionService.getFileBackend().getFile(message);
 		long convertedFileSize = mXmppConnectionService.getFileBackend().getFile(message).getSize();
@@ -159,9 +157,9 @@ public class AttachFileToConversationRunnable implements Runnable, TranscoderLis
 	}
 
 	@Override
-    public void onTranscodeFailed(@NonNull @NotNull Throwable exception) {
+	public void onTranscodeFailed(Exception e) {
 		mXmppConnectionService.stopForcingForegroundNotification();
-        Log.d(Config.LOGTAG, "video transcoding failed", exception);
+		Log.d(Config.LOGTAG,"video transcoding failed",e);
 		processAsFile();
 	}
 

src/main/java/eu/siacs/conversations/services/ChannelDiscoveryService.java

@@ -50,9 +50,14 @@ public class ChannelDiscoveryService {
     }
 
     void initializeMuclumbusService() {
-        final OkHttpClient.Builder builder = HttpConnectionManager.OK_HTTP_CLIENT.newBuilder();
+        final OkHttpClient.Builder builder = new OkHttpClient.Builder();
+
         if (service.useTorToConnect()) {
+            try {
                 builder.proxy(HttpConnectionManager.getProxy());
+            } catch (IOException e) {
+                throw new RuntimeException("Unable to use Tor proxy", e);
+            }
         }
         Retrofit retrofit = new Retrofit.Builder()
                 .client(builder.build())
@@ -68,7 +73,7 @@ public class ChannelDiscoveryService {
     }
 
     void discover(@NonNull final String query, Method method, OnChannelSearchResultsFound onChannelSearchResultsFound) {
-        final List<Room> result = cache.getIfPresent(key(method, query));
+        List<Room> result = cache.getIfPresent(key(method, query));
         if (result != null) {
             onChannelSearchResultsFound.onChannelSearchResultsFound(result);
             return;

src/main/java/eu/siacs/conversations/services/MemorizingTrustManager.java

@@ -31,7 +31,6 @@ import android.app.NotificationManager;
 import android.app.Service;
 import android.content.Context;
 import android.content.Intent;
-import android.content.SharedPreferences;
 import android.net.Uri;
 import android.os.Handler;
 import android.preference.PreferenceManager;
@@ -41,20 +40,19 @@ import android.util.SparseArray;
 
 import androidx.appcompat.app.AppCompatActivity;
 
-import com.google.common.base.Charsets;
-import com.google.common.base.Joiner;
-import com.google.common.io.CharStreams;
-
 import org.json.JSONArray;
 import org.json.JSONException;
 import org.json.JSONObject;
 
+import java.io.BufferedReader;
 import java.io.File;
 import java.io.FileInputStream;
+import java.io.FileNotFoundException;
 import java.io.FileOutputStream;
 import java.io.IOException;
 import java.io.InputStream;
 import java.io.InputStreamReader;
+import java.net.URL;
 import java.security.KeyStore;
 import java.security.KeyStoreException;
 import java.security.MessageDigest;
@@ -62,10 +60,12 @@ import java.security.NoSuchAlgorithmException;
 import java.security.cert.Certificate;
 import java.security.cert.CertificateEncodingException;
 import java.security.cert.CertificateException;
+import java.security.cert.CertificateExpiredException;
 import java.security.cert.CertificateParsingException;
 import java.security.cert.X509Certificate;
 import java.text.SimpleDateFormat;
 import java.util.ArrayList;
+import java.util.Collection;
 import java.util.Enumeration;
 import java.util.List;
 import java.util.Locale;
@@ -73,14 +73,16 @@ import java.util.logging.Level;
 import java.util.logging.Logger;
 import java.util.regex.Pattern;
 
+import javax.net.ssl.HostnameVerifier;
+import javax.net.ssl.HttpsURLConnection;
+import javax.net.ssl.SSLSession;
 import javax.net.ssl.TrustManager;
 import javax.net.ssl.TrustManagerFactory;
 import javax.net.ssl.X509TrustManager;
 
 import eu.siacs.conversations.R;
-import eu.siacs.conversations.crypto.XmppDomainVerifier;
+import eu.siacs.conversations.crypto.DomainHostnameVerifier;
 import eu.siacs.conversations.entities.MTMDecision;
-import eu.siacs.conversations.http.HttpConnectionManager;
 import eu.siacs.conversations.persistance.FileBackend;
 import eu.siacs.conversations.ui.MemorizingActivity;
 
@@ -96,12 +98,12 @@ import eu.siacs.conversations.ui.MemorizingActivity;
  */
 public class MemorizingTrustManager {
 
-    private static final SimpleDateFormat DATE_FORMAT = new SimpleDateFormat("yyyy-MM-dd", Locale.US);
 
     final static String DECISION_INTENT = "de.duenndns.ssl.DECISION";
     public final static String DECISION_INTENT_ID = DECISION_INTENT + ".decisionId";
     public final static String DECISION_INTENT_CERT = DECISION_INTENT + ".cert";
     public final static String DECISION_TITLE_ID = DECISION_INTENT + ".titleId";
+    final static String DECISION_INTENT_CHOICE = DECISION_INTENT + ".decisionChoice";
     final static String NO_TRUST_ANCHOR = "Trust anchor for certification path not found.";
     private static final Pattern PATTERN_IPV4 = Pattern.compile("\\A(25[0-5]|2[0-4]\\d|[0-1]?\\d?\\d)(\\.(25[0-5]|2[0-4]\\d|[0-1]?\\d?\\d)){3}\\z");
     private static final Pattern PATTERN_IPV6_HEX4DECCOMPRESSED = Pattern.compile("\\A((?:[0-9A-Fa-f]{1,4}(?::[0-9A-Fa-f]{1,4})*)?) ::((?:[0-9A-Fa-f]{1,4}:)*)(25[0-5]|2[0-4]\\d|[0-1]?\\d?\\d)(\\.(25[0-5]|2[0-4]\\d|[0-1]?\\d?\\d)){3}\\z");
@@ -109,6 +111,7 @@ public class MemorizingTrustManager {
     private static final Pattern PATTERN_IPV6_HEXCOMPRESSED = Pattern.compile("\\A((?:[0-9A-Fa-f]{1,4}(?::[0-9A-Fa-f]{1,4})*)?)::((?:[0-9A-Fa-f]{1,4}(?::[0-9A-Fa-f]{1,4})*)?)\\z");
     private static final Pattern PATTERN_IPV6 = Pattern.compile("\\A(?:[0-9a-fA-F]{1,4}:){7}[0-9a-fA-F]{1,4}\\z");
     private final static Logger LOGGER = Logger.getLogger(MemorizingTrustManager.class.getName());
+    private final static int NOTIFICATION_ID = 100509;
     static String KEYSTORE_DIR = "KeyStore";
     static String KEYSTORE_FILE = "KeyStore.bks";
     private static int decisionId = 0;
@@ -162,6 +165,20 @@ public class MemorizingTrustManager {
         this.defaultTrustManager = getTrustManager(null);
     }
 
+    /**
+     * Changes the path for the KeyStore file.
+     * <p>
+     * The actual filename relative to the app's directory will be
+     * <code>app_<i>dirname</i>/<i>filename</i></code>.
+     *
+     * @param dirname  directory to store the KeyStore.
+     * @param filename file name for the KeyStore.
+     */
+    public static void setKeyStoreFile(String dirname, String filename) {
+        KEYSTORE_DIR = dirname;
+        KEYSTORE_FILE = filename;
+    }
+
     private static boolean isIp(final String server) {
         return server != null && (
                 PATTERN_IPV4.matcher(server).matches()
@@ -197,7 +214,9 @@ public class MemorizingTrustManager {
             MessageDigest md = MessageDigest.getInstance(digest);
             md.update(cert.getEncoded());
             return hexString(md.digest());
-        } catch (CertificateEncodingException | NoSuchAlgorithmException e) {
+        } catch (java.security.cert.CertificateEncodingException e) {
+            return e.getMessage();
+        } catch (java.security.NoSuchAlgorithmException e) {
             return e.getMessage();
         }
     }
@@ -218,7 +237,7 @@ public class MemorizingTrustManager {
         }
     }
 
-    void init(final Context m) {
+    void init(Context m) {
         master = m;
         masterHandler = new Handler(m.getMainLooper());
         notificationManager = (NotificationManager) master.getSystemService(Context.NOTIFICATION_SERVICE);
@@ -241,6 +260,36 @@ public class MemorizingTrustManager {
         appKeyStore = loadAppKeyStore();
     }
 
+    /**
+     * Binds an Activity to the MTM for displaying the query dialog.
+     * <p>
+     * This is useful if your connection is run from a service that is
+     * triggered by user interaction -- in such cases the activity is
+     * visible and the user tends to ignore the service notification.
+     * <p>
+     * You should never have a hidden activity bound to MTM! Use this
+     * function in onResume() and @see unbindDisplayActivity in onPause().
+     *
+     * @param act Activity to be bound
+     */
+    public void bindDisplayActivity(AppCompatActivity act) {
+        foregroundAct = act;
+    }
+
+    /**
+     * Removes an Activity from the MTM display stack.
+     * <p>
+     * Always call this function when the Activity added with
+     * {@link #bindDisplayActivity(AppCompatActivity)} is hidden.
+     *
+     * @param act Activity to be unbound
+     */
+    public void unbindDisplayActivity(AppCompatActivity act) {
+        // do not remove if it was overridden by a different activity
+        if (foregroundAct == act)
+            foregroundAct = null;
+    }
+
     /**
      * Get a list of all certificate aliases stored in MTM.
      *
@@ -255,6 +304,21 @@ public class MemorizingTrustManager {
         }
     }
 
+    /**
+     * Get a certificate for a given alias.
+     *
+     * @param alias the certificate's alias as returned by {@link #getCertificates()}.
+     * @return the certificate associated with the alias or <tt>null</tt> if none found.
+     */
+    public Certificate getCertificate(String alias) {
+        try {
+            return appKeyStore.getCertificate(alias);
+        } catch (KeyStoreException e) {
+            // this should never happen, however...
+            throw new RuntimeException(e);
+        }
+    }
+
     /**
      * Removes the given certificate from MTMs key store.
      *
@@ -273,6 +337,32 @@ public class MemorizingTrustManager {
         keyStoreUpdated();
     }
 
+    /**
+     * Creates a new hostname verifier supporting user interaction.
+     *
+     * <p>This method creates a new {@link HostnameVerifier} that is bound to
+     * the given instance of {@link MemorizingTrustManager}, and leverages an
+     * existing {@link HostnameVerifier}. The returned verifier performs the
+     * following steps, returning as soon as one of them succeeds:
+     * /p>
+     * <ol>
+     * <li>Success, if the wrapped defaultVerifier accepts the certificate.</li>
+     * <li>Success, if the server certificate is stored in the keystore under the given hostname.</li>
+     * <li>Ask the user and return accordingly.</li>
+     * <li>Failure on exception.</li>
+     * </ol>
+     *
+     * @param defaultVerifier the {@link HostnameVerifier} that should perform the actual check
+     * @return a new hostname verifier using the MTM's key store
+     * @throws IllegalArgumentException if the defaultVerifier parameter is null
+     */
+    public DomainHostnameVerifier wrapHostnameVerifier(final HostnameVerifier defaultVerifier, final boolean interactive) {
+        if (defaultVerifier == null)
+            throw new IllegalArgumentException("The default verifier may not be null");
+
+        return new MemorizingHostnameVerifier(defaultVerifier, interactive);
+    }
+
     X509TrustManager getTrustManager(KeyStore ks) {
         try {
             TrustManagerFactory tmf = TrustManagerFactory.getInstance("X509");
@@ -359,8 +449,16 @@ public class MemorizingTrustManager {
         }
     }
 
+    private boolean isExpiredException(Throwable e) {
+        do {
+            if (e instanceof CertificateExpiredException)
+                return true;
+            e = e.getCause();
+        } while (e != null);
+        return false;
+    }
 
-    private void checkCertTrusted(X509Certificate[] chain, String authType, String domain, boolean isServer, boolean interactive)
+    public void checkCertTrusted(X509Certificate[] chain, String authType, String domain, boolean isServer, boolean interactive)
             throws CertificateException {
         LOGGER.log(Level.FINE, "checkCertTrusted(" + chain + ", " + authType + ", " + isServer + ")");
         try {
@@ -369,8 +467,13 @@ public class MemorizingTrustManager {
                 appTrustManager.checkServerTrusted(chain, authType);
             else
                 appTrustManager.checkClientTrusted(chain, authType);
-        } catch (final CertificateException ae) {
+        } catch (CertificateException ae) {
             LOGGER.log(Level.FINER, "checkCertTrusted: appTrustManager failed", ae);
+            // if the cert is stored in our appTrustManager, we ignore expiredness
+            if (isExpiredException(ae)) {
+                LOGGER.log(Level.INFO, "checkCertTrusted: accepting expired certificate from keystore");
+                return;
+            }
             if (isCertKnown(chain[0])) {
                 LOGGER.log(Level.INFO, "checkCertTrusted: accepting cert already stored in keystore");
                 return;
@@ -383,18 +486,15 @@ public class MemorizingTrustManager {
                     defaultTrustManager.checkServerTrusted(chain, authType);
                 else
                     defaultTrustManager.checkClientTrusted(chain, authType);
-            } catch (final CertificateException e) {
+            } catch (CertificateException e) {
-                final SharedPreferences preferences = PreferenceManager.getDefaultSharedPreferences(master);
+                boolean trustSystemCAs = !PreferenceManager.getDefaultSharedPreferences(master).getBoolean("dont_trust_system_cas", false);
-                final boolean trustSystemCAs = !preferences.getBoolean("dont_trust_system_cas", false);
+                if (domain != null && isServer && trustSystemCAs && !isIp(domain)) {
-                if (domain != null && isServer && trustSystemCAs && !isIp(domain) && !domain.endsWith(".onion")) {
                     final String hash = getBase64Hash(chain[0], "SHA-256");
                     final List<String> fingerprints = getPoshFingerprints(domain);
                     if (hash != null && fingerprints.size() > 0) {
                         if (fingerprints.contains(hash)) {
                             Log.d("mtm", "trusted cert fingerprint of " + domain + " via posh");
                             return;
-                        } else {
-                            Log.d("mtm", "fingerprint " + hash + " not found in " + fingerprints);
                         }
                         if (getPoshCacheFile(domain).delete()) {
                             Log.d("mtm", "deleted posh file for " + domain + " after not being able to verify");
@@ -411,7 +511,7 @@ public class MemorizingTrustManager {
     }
 
     private List<String> getPoshFingerprints(String domain) {
-        final List<String> cached = getPoshFingerprintsFromCache(domain);
+        List<String> cached = getPoshFingerprintsFromCache(domain);
         if (cached == null) {
             return getPoshFingerprintsFromServer(domain);
         } else {
@@ -425,13 +525,19 @@ public class MemorizingTrustManager {
 
     private List<String> getPoshFingerprintsFromServer(String domain, String url, int maxTtl, boolean followUrl) {
         Log.d("mtm", "downloading json for " + domain + " from " + url);
-        final SharedPreferences preferences = PreferenceManager.getDefaultSharedPreferences(master);
-        final boolean useTor = QuickConversationsService.isConversations() && preferences.getBoolean("use_tor", master.getResources().getBoolean(R.bool.use_tor));
         try {
-            final List<String> results = new ArrayList<>();
+            List<String> results = new ArrayList<>();
-            final InputStream inputStream = HttpConnectionManager.open(url, useTor);
+            HttpsURLConnection connection = (HttpsURLConnection) new URL(url).openConnection();
-            final String body = CharStreams.toString(new InputStreamReader(inputStream, Charsets.UTF_8));
+            connection.setConnectTimeout(5000);
-            final JSONObject jsonObject = new JSONObject(body);
+            connection.setReadTimeout(5000);
+            BufferedReader in = new BufferedReader(new InputStreamReader(connection.getInputStream()));
+            String inputLine;
+            StringBuilder builder = new StringBuilder();
+            while ((inputLine = in.readLine()) != null) {
+                builder.append(inputLine);
+            }
+            JSONObject jsonObject = new JSONObject(builder.toString());
+            in.close();
             int expires = jsonObject.getInt("expires");
             if (expires <= 0) {
                 return new ArrayList<>();
@@ -448,15 +554,17 @@ public class MemorizingTrustManager {
             if (followUrl && redirect != null && redirect.toLowerCase().startsWith("https")) {
                 return getPoshFingerprintsFromServer(domain, redirect, expires, false);
             }
-            final JSONArray fingerprints = jsonObject.getJSONArray("fingerprints");
+            JSONArray fingerprints = jsonObject.getJSONArray("fingerprints");
             for (int i = 0; i < fingerprints.length(); i++) {
-                final JSONObject fingerprint = fingerprints.getJSONObject(i);
+                JSONObject fingerprint = fingerprints.getJSONObject(i);
-                final String sha256 = fingerprint.getString("sha-256");
+                String sha256 = fingerprint.getString("sha-256");
+                if (sha256 != null) {
                     results.add(sha256);
                 }
+            }
             writeFingerprintsToCache(domain, results, 1000L * expires + System.currentTimeMillis());
             return results;
-        } catch (final Exception e) {
+        } catch (Exception e) {
             Log.d("mtm", "error fetching posh " + e.getMessage());
             return new ArrayList<>();
         }
@@ -467,7 +575,7 @@ public class MemorizingTrustManager {
     }
 
     private void writeFingerprintsToCache(String domain, List<String> results, long expires) {
-        final File file = getPoshCacheFile(domain);
+        File file = getPoshCacheFile(domain);
         file.getParentFile().mkdirs();
         try {
             file.createNewFile();
@@ -484,11 +592,20 @@ public class MemorizingTrustManager {
     }
 
     private List<String> getPoshFingerprintsFromCache(String domain) {
-        final File file = getPoshCacheFile(domain);
+        File file = getPoshCacheFile(domain);
         try {
-            final InputStream inputStream = new FileInputStream(file);
+            InputStream is = new FileInputStream(file);
-            final String json = CharStreams.toString(new InputStreamReader(inputStream, Charsets.UTF_8));
+            BufferedReader buf = new BufferedReader(new InputStreamReader(is));
-            final JSONObject jsonObject = new JSONObject(json);
+
+            String line = buf.readLine();
+            StringBuilder sb = new StringBuilder();
+
+            while (line != null) {
+                sb.append(line).append("\n");
+                line = buf.readLine();
+            }
+            JSONObject jsonObject = new JSONObject(sb.toString());
+            is.close();
             long expires = jsonObject.getLong("expires");
             long expiresIn = expires - System.currentTimeMillis();
             if (expiresIn < 0) {
@@ -497,13 +614,15 @@ public class MemorizingTrustManager {
             } else {
                 Log.d("mtm", "posh fingerprints expire in " + (expiresIn / 1000) + "s");
             }
-            final List<String> result = new ArrayList<>();
+            List<String> result = new ArrayList<>();
-            final JSONArray jsonArray = jsonObject.getJSONArray("fingerprints");
+            JSONArray jsonArray = jsonObject.getJSONArray("fingerprints");
             for (int i = 0; i < jsonArray.length(); ++i) {
                 result.add(jsonArray.getString(i));
             }
             return result;
-        } catch (final IOException e) {
+        } catch (FileNotFoundException e) {
+            return null;
+        } catch (IOException e) {
             return null;
         } catch (JSONException e) {
             file.delete();
@@ -513,7 +632,7 @@ public class MemorizingTrustManager {
 
     private X509Certificate[] getAcceptedIssuers() {
         LOGGER.log(Level.FINE, "getAcceptedIssuers()");
-        return defaultTrustManager == null ? new X509Certificate[0] : defaultTrustManager.getAcceptedIssuers();
+        return defaultTrustManager.getAcceptedIssuers();
     }
 
     private int createDecisionId(MTMDecision d) {
@@ -526,24 +645,14 @@ public class MemorizingTrustManager {
         return myId;
     }
 
-    private void certDetails(final StringBuffer si, final X509Certificate c, final boolean showValidFor) {
+    private void certDetails(StringBuffer si, X509Certificate c) {
-
+        SimpleDateFormat validityDateFormater = new SimpleDateFormat("yyyy-MM-dd");
         si.append("\n");
-        if (showValidFor) {
+        si.append(c.getSubjectDN().toString());
-            try {
-                si.append("Valid for: ");
-                si.append(Joiner.on(", ").join(XmppDomainVerifier.parseValidDomains(c).all()));
-            } catch (final CertificateParsingException e) {
-                si.append("Unable to parse Certificate");
-            }
         si.append("\n");
-        } else {
+        si.append(validityDateFormater.format(c.getNotBefore()));
-            si.append(c.getSubjectDN());
-        }
-        si.append("\n");
-        si.append(DATE_FORMAT.format(c.getNotBefore()));
         si.append(" - ");
-        si.append(DATE_FORMAT.format(c.getNotAfter()));
+        si.append(validityDateFormater.format(c.getNotAfter()));
         si.append("\nSHA-256: ");
         si.append(certHash(c, "SHA-256"));
         si.append("\nSHA-1: ");
@@ -556,7 +665,7 @@ public class MemorizingTrustManager {
     private String certChainMessage(final X509Certificate[] chain, CertificateException cause) {
         Throwable e = cause;
         LOGGER.log(Level.FINE, "certChainMessage for " + e);
-        final StringBuffer si = new StringBuffer();
+        StringBuffer si = new StringBuffer();
         if (e.getCause() != null) {
             e = e.getCause();
             // HACK: there is no sane way to check if the error is a "trust anchor
@@ -571,13 +680,46 @@ public class MemorizingTrustManager {
         si.append(master.getString(R.string.mtm_connect_anyway));
         si.append("\n\n");
         si.append(master.getString(R.string.mtm_cert_details));
-        si.append('\n');
+        for (X509Certificate c : chain) {
-        for(int i = 0; i < chain.length; ++i) {
+            certDetails(si, c);
-            certDetails(si, chain[i], i == 0);
         }
         return si.toString();
     }
 
+    private String hostNameMessage(X509Certificate cert, String hostname) {
+        StringBuffer si = new StringBuffer();
+
+        si.append(master.getString(R.string.mtm_hostname_mismatch, hostname));
+        si.append("\n\n");
+        try {
+            Collection<List<?>> sans = cert.getSubjectAlternativeNames();
+            if (sans == null) {
+                si.append(cert.getSubjectDN());
+                si.append("\n");
+            } else for (List<?> altName : sans) {
+                Object name = altName.get(1);
+                if (name instanceof String) {
+                    si.append("[");
+                    si.append(altName.get(0));
+                    si.append("] ");
+                    si.append(name);
+                    si.append("\n");
+                }
+            }
+        } catch (CertificateParsingException e) {
+            e.printStackTrace();
+            si.append("<Parsing error: ");
+            si.append(e.getLocalizedMessage());
+            si.append(">\n");
+        }
+        si.append("\n");
+        si.append(master.getString(R.string.mtm_connect_anyway));
+        si.append("\n\n");
+        si.append(master.getString(R.string.mtm_cert_details));
+        certDetails(si, cert);
+        return si.toString();
+    }
+
     /**
      * Returns the top-most entry of the activity stack.
      *
@@ -635,6 +777,17 @@ public class MemorizingTrustManager {
         }
     }
 
+    boolean interactHostname(X509Certificate cert, String hostname) {
+        switch (interact(hostNameMessage(cert, hostname), R.string.mtm_accept_servername)) {
+            case MTMDecision.DECISION_ALWAYS:
+                storeCert(hostname, cert);
+            case MTMDecision.DECISION_ONCE:
+                return true;
+            default:
+                return false;
+        }
+    }
+
     public X509TrustManager getNonInteractive(String domain) {
         return new NonInteractiveMemorizingTrustManager(domain);
     }
@@ -651,6 +804,57 @@ public class MemorizingTrustManager {
         return new InteractiveMemorizingTrustManager(null);
     }
 
+    class MemorizingHostnameVerifier implements DomainHostnameVerifier {
+        private final HostnameVerifier defaultVerifier;
+        private final boolean interactive;
+
+        public MemorizingHostnameVerifier(HostnameVerifier wrapped, boolean interactive) {
+            this.defaultVerifier = wrapped;
+            this.interactive = interactive;
+        }
+
+        @Override
+        public boolean verify(String domain, String hostname, SSLSession session) {
+            LOGGER.log(Level.FINE, "hostname verifier for " + domain + ", trying default verifier first");
+            // if the default verifier accepts the hostname, we are done
+            if (defaultVerifier instanceof DomainHostnameVerifier) {
+                if (((DomainHostnameVerifier) defaultVerifier).verify(domain, hostname, session)) {
+                    return true;
+                }
+            } else {
+                if (defaultVerifier.verify(domain, session)) {
+                    return true;
+                }
+            }
+
+
+            // otherwise, we check if the hostname is an alias for this cert in our keystore
+            try {
+                X509Certificate cert = (X509Certificate) session.getPeerCertificates()[0];
+                //Log.d(TAG, "cert: " + cert);
+                if (cert.equals(appKeyStore.getCertificate(domain.toLowerCase(Locale.US)))) {
+                    LOGGER.log(Level.FINE, "certificate for " + domain + " is in our keystore. accepting.");
+                    return true;
+                } else {
+                    LOGGER.log(Level.FINE, "server " + domain + " provided wrong certificate, asking user.");
+                    if (interactive) {
+                        return interactHostname(cert, domain);
+                    } else {
+                        return false;
+                    }
+                }
+            } catch (Exception e) {
+                e.printStackTrace();
+                return false;
+            }
+        }
+
+        @Override
+        public boolean verify(String domain, SSLSession sslSession) {
+            return verify(domain, null, sslSession);
+        }
+    }
+
     private class NonInteractiveMemorizingTrustManager implements X509TrustManager {
 
         private final String domain;

src/main/java/eu/siacs/conversations/services/MessageArchiveService.java

@@ -209,7 +209,7 @@ public class MessageArchiveService implements OnAdvancedStreamFeaturesLoaded {
 	}
 
 	void executePendingQueries(final Account account) {
-        final List<Query> pending = new ArrayList<>();
+		List<Query> pending = new ArrayList<>();
 		synchronized (this.pendingQueries) {
 			for (Iterator<Query> iterator = this.pendingQueries.iterator(); iterator.hasNext(); ) {
 				Query query = iterator.next();
@@ -390,17 +390,8 @@ public class MessageArchiveService implements OnAdvancedStreamFeaturesLoaded {
 		}
 	}
 
-    void kill(final Conversation conversation) {
+	void kill(Conversation conversation) {
 		final ArrayList<Query> toBeKilled = new ArrayList<>();
-        synchronized (this.pendingQueries) {
-            for (final Iterator<Query> iterator = this.pendingQueries.iterator(); iterator.hasNext(); ) {
-                final Query query = iterator.next();
-                if (query.getConversation() == conversation) {
-                    iterator.remove();
-                    Log.d(Config.LOGTAG, conversation.getAccount().getJid().asBareJid() + ": killed pending MAM query for archived conversation");
-                }
-            }
-        }
 		synchronized (this.queries) {
 			for (final Query q : queries) {
 				if (q.conversation == conversation) {
@@ -408,7 +399,7 @@ public class MessageArchiveService implements OnAdvancedStreamFeaturesLoaded {
 				}
 			}
 		}
-        for (final Query q : toBeKilled) {
+		for (Query q : toBeKilled) {
 			kill(q);
 		}
 	}

src/main/java/eu/siacs/conversations/services/NotificationService.java

@@ -12,12 +12,10 @@ import android.content.res.Resources;
 import android.graphics.Bitmap;
 import android.graphics.Typeface;
 import android.media.AudioAttributes;
-import android.media.Ringtone;
 import android.media.RingtoneManager;
 import android.net.Uri;
 import android.os.Build;
 import android.os.SystemClock;
-import android.os.Vibrator;
 import android.preference.PreferenceManager;
 import android.text.SpannableString;
 import android.text.style.StyleSpan;
@@ -34,9 +32,6 @@ import androidx.core.app.RemoteInput;
 import androidx.core.content.ContextCompat;
 import androidx.core.graphics.drawable.IconCompat;
 
-import com.google.common.base.Strings;
-import com.google.common.collect.Iterables;
-
 import java.io.File;
 import java.io.IOException;
 import java.util.ArrayList;
@@ -48,10 +43,6 @@ import java.util.LinkedHashMap;
 import java.util.List;
 import java.util.Map;
 import java.util.Set;
-import java.util.concurrent.Executors;
-import java.util.concurrent.ScheduledExecutorService;
-import java.util.concurrent.ScheduledFuture;
-import java.util.concurrent.TimeUnit;
 import java.util.concurrent.atomic.AtomicInteger;
 import java.util.regex.Matcher;
 import java.util.regex.Pattern;
@@ -79,13 +70,12 @@ import eu.siacs.conversations.xmpp.jingle.Media;
 
 public class NotificationService {
 
-    private static final ScheduledExecutorService SCHEDULED_EXECUTOR_SERVICE = Executors.newSingleThreadScheduledExecutor();
-
     public static final Object CATCHUP_LOCK = new Object();
 
     private static final int LED_COLOR = 0xff00ff00;
 
-    private static final long[] CALL_PATTERN = {0, 500, 300, 600};
+    private static final int CALL_DAT = 120;
+    private static final long[] CALL_PATTERN = {0, 3 * CALL_DAT, CALL_DAT, CALL_DAT, 3 * CALL_DAT, CALL_DAT, CALL_DAT};
 
     private static final String CONVERSATIONS_GROUP = "eu.siacs.conversations";
     private static final int NOTIFICATION_ID_MULTIPLIER = 1024 * 1024;
@@ -102,10 +92,6 @@ public class NotificationService {
     private boolean mIsInForeground;
     private long mLastNotification;
 
-    private static final String INCOMING_CALLS_NOTIFICATION_CHANNEL = "incoming_calls_channel";
-    private Ringtone currentlyPlayingRingtone = null;
-    private ScheduledFuture<?> vibrationFuture;
-
     NotificationService(final XmppConnectionService service) {
         this.mXmppConnectionService = service;
     }
@@ -143,7 +129,6 @@ public class NotificationService {
         }
 
         notificationManager.deleteNotificationChannel("export");
-        notificationManager.deleteNotificationChannel("incoming_calls");
 
         notificationManager.createNotificationChannelGroup(new NotificationChannelGroup("status", c.getString(R.string.notification_group_status_information)));
         notificationManager.createNotificationChannelGroup(new NotificationChannelGroup("chats", c.getString(R.string.notification_group_messages)));
@@ -151,7 +136,7 @@ public class NotificationService {
         final NotificationChannel foregroundServiceChannel = new NotificationChannel("foreground",
                 c.getString(R.string.foreground_service_channel_name),
                 NotificationManager.IMPORTANCE_MIN);
-        foregroundServiceChannel.setDescription(c.getString(R.string.foreground_service_channel_description, c.getString(R.string.app_name)));
+        foregroundServiceChannel.setDescription(c.getString(R.string.foreground_service_channel_description));
         foregroundServiceChannel.setShowBadge(false);
         foregroundServiceChannel.setGroup("status");
         notificationManager.createNotificationChannel(foregroundServiceChannel);
@@ -177,16 +162,20 @@ public class NotificationService {
         exportChannel.setGroup("status");
         notificationManager.createNotificationChannel(exportChannel);
 
-        final NotificationChannel incomingCallsChannel = new NotificationChannel(INCOMING_CALLS_NOTIFICATION_CHANNEL,
+        final NotificationChannel incomingCallsChannel = new NotificationChannel("incoming_calls",
                 c.getString(R.string.incoming_calls_channel_name),
                 NotificationManager.IMPORTANCE_HIGH);
-        incomingCallsChannel.setSound(null, null);
+        incomingCallsChannel.setSound(RingtoneManager.getDefaultUri(RingtoneManager.TYPE_RINGTONE), new AudioAttributes.Builder()
+                .setContentType(AudioAttributes.CONTENT_TYPE_SONIFICATION)
+                .setUsage(AudioAttributes.USAGE_NOTIFICATION_RINGTONE)
+                .build());
         incomingCallsChannel.setShowBadge(false);
         incomingCallsChannel.setLightColor(LED_COLOR);
         incomingCallsChannel.enableLights(true);
         incomingCallsChannel.setGroup("calls");
         incomingCallsChannel.setBypassDnd(true);
-        incomingCallsChannel.enableVibration(false);
+        incomingCallsChannel.enableVibration(true);
+        incomingCallsChannel.setVibrationPattern(CALL_PATTERN);
         notificationManager.createNotificationChannel(incomingCallsChannel);
 
         final NotificationChannel ongoingCallsChannel = new NotificationChannel("ongoing_calls",
@@ -369,8 +358,8 @@ public class NotificationService {
 
     public void pushFailedDelivery(final Message message) {
         final Conversation conversation = (Conversation) message.getConversation();
-        final boolean isScreenLocked = !mXmppConnectionService.isScreenLocked();
+        final boolean isScreenOn = mXmppConnectionService.isInteractive();
-        if (this.mIsInForeground && isScreenLocked && this.mOpenConversation == message.getConversation()) {
+        if (this.mIsInForeground && isScreenOn && this.mOpenConversation == message.getConversation()) {
             Log.d(Config.LOGTAG, message.getConversation().getAccount().getJid().asBareJid() + ": suppressing failed delivery notification because conversation is open");
             return;
         }
@@ -398,56 +387,14 @@ public class NotificationService {
         notify(DELIVERY_FAILED_NOTIFICATION_ID, summaryNotification);
     }
 
-    public synchronized void startRinging(final AbstractJingleConnection.Id id, final Set<Media> media) {
+    public void showIncomingCallNotification(final AbstractJingleConnection.Id id, final Set<Media> media) {
-        showIncomingCallNotification(id, media);
-        final NotificationManager notificationManager = (NotificationManager) mXmppConnectionService.getSystemService(Context.NOTIFICATION_SERVICE);
-        final int currentInterruptionFilter;
-        if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.M && notificationManager != null) {
-            currentInterruptionFilter = notificationManager.getCurrentInterruptionFilter();
-        } else {
-            currentInterruptionFilter = 1; //INTERRUPTION_FILTER_ALL
-        }
-        if (currentInterruptionFilter != 1) {
-            Log.d(Config.LOGTAG, "do not ring or vibrate because interruption filter has been set to " + currentInterruptionFilter);
-            return;
-        }
-        final ScheduledFuture<?> currentVibrationFuture = this.vibrationFuture;
-        this.vibrationFuture = SCHEDULED_EXECUTOR_SERVICE.scheduleAtFixedRate(
-                new VibrationRunnable(),
-                0,
-                3,
-                TimeUnit.SECONDS
-        );
-        if (currentVibrationFuture != null) {
-            currentVibrationFuture.cancel(true);
-        }
-        final SharedPreferences preferences = PreferenceManager.getDefaultSharedPreferences(mXmppConnectionService);
-        final Resources resources = mXmppConnectionService.getResources();
-        final String ringtonePreference = preferences.getString("call_ringtone", resources.getString(R.string.incoming_call_ringtone));
-        if (Strings.isNullOrEmpty(ringtonePreference)) {
-            Log.d(Config.LOGTAG, "ringtone has been set to none");
-            return;
-        }
-        final Uri uri = Uri.parse(ringtonePreference);
-        this.currentlyPlayingRingtone = RingtoneManager.getRingtone(mXmppConnectionService, uri);
-        if (this.currentlyPlayingRingtone == null) {
-            Log.d(Config.LOGTAG, "unable to find ringtone for uri " + uri);
-            return;
-        }
-        if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.P) {
-            this.currentlyPlayingRingtone.setLooping(true);
-        }
-        this.currentlyPlayingRingtone.play();
-    }
-
-    private void showIncomingCallNotification(final AbstractJingleConnection.Id id, final Set<Media> media) {
         final Intent fullScreenIntent = new Intent(mXmppConnectionService, RtpSessionActivity.class);
         fullScreenIntent.putExtra(RtpSessionActivity.EXTRA_ACCOUNT, id.account.getJid().asBareJid().toEscapedString());
         fullScreenIntent.putExtra(RtpSessionActivity.EXTRA_WITH, id.with.toEscapedString());
         fullScreenIntent.putExtra(RtpSessionActivity.EXTRA_SESSION_ID, id.sessionId);
         fullScreenIntent.addFlags(Intent.FLAG_ACTIVITY_NEW_TASK);
         fullScreenIntent.addFlags(Intent.FLAG_ACTIVITY_CLEAR_TOP);
-        final NotificationCompat.Builder builder = new NotificationCompat.Builder(mXmppConnectionService, INCOMING_CALLS_NOTIFICATION_CHANNEL);
+        final NotificationCompat.Builder builder = new NotificationCompat.Builder(mXmppConnectionService, "incoming_calls");
         if (media.contains(Media.VIDEO)) {
             builder.setSmallIcon(R.drawable.ic_videocam_white_24dp);
             builder.setContentTitle(mXmppConnectionService.getString(R.string.rtp_state_incoming_video_call));
@@ -488,24 +435,15 @@ public class NotificationService {
         notify(INCOMING_CALL_NOTIFICATION_ID, notification);
     }
 
-    public Notification getOngoingCallNotification(final XmppConnectionService.OngoingCall ongoingCall) {
+    public Notification getOngoingCallNotification(final AbstractJingleConnection.Id id, final Set<Media> media) {
-        final AbstractJingleConnection.Id id = ongoingCall.id;
         final NotificationCompat.Builder builder = new NotificationCompat.Builder(mXmppConnectionService, "ongoing_calls");
-        if (ongoingCall.media.contains(Media.VIDEO)) {
+        if (media.contains(Media.VIDEO)) {
             builder.setSmallIcon(R.drawable.ic_videocam_white_24dp);
-            if (ongoingCall.reconnecting) {
-                builder.setContentTitle(mXmppConnectionService.getString(R.string.reconnecting_video_call));
-            } else {
             builder.setContentTitle(mXmppConnectionService.getString(R.string.ongoing_video_call));
-            }
         } else {
             builder.setSmallIcon(R.drawable.ic_call_white_24dp);
-            if (ongoingCall.reconnecting) {
-                builder.setContentTitle(mXmppConnectionService.getString(R.string.reconnecting_call));
-            } else {
             builder.setContentTitle(mXmppConnectionService.getString(R.string.ongoing_call));
         }
-        }
         builder.setContentText(id.account.getRoster().getContact(id.with).getDisplayName());
         builder.setVisibility(NotificationCompat.VISIBILITY_PUBLIC);
         builder.setPriority(NotificationCompat.PRIORITY_HIGH);
@@ -530,27 +468,9 @@ public class NotificationService {
     }
 
     public void cancelIncomingCallNotification() {
-        stopSoundAndVibration();
         cancel(INCOMING_CALL_NOTIFICATION_ID);
     }
 
-    public boolean stopSoundAndVibration() {
-        int stopped = 0;
-        if (this.currentlyPlayingRingtone != null) {
-            if (this.currentlyPlayingRingtone.isPlaying()) {
-                Log.d(Config.LOGTAG, "stop playing ring tone");
-                ++stopped;
-            }
-            this.currentlyPlayingRingtone.stop();
-        }
-        if (this.vibrationFuture != null && !this.vibrationFuture.isCancelled()) {
-            Log.d(Config.LOGTAG, "stop vibration");
-            this.vibrationFuture.cancel(true);
-            ++stopped;
-        }
-        return stopped > 0;
-    }
-
     public static void cancelIncomingCallNotification(final Context context) {
         final NotificationManagerCompat notificationManager = NotificationManagerCompat.from(context);
         try {
@@ -566,8 +486,8 @@ public class NotificationService {
             Log.d(Config.LOGTAG, message.getConversation().getAccount().getJid().asBareJid() + ": suppressing notification because turned off");
             return;
         }
-        final boolean isScreenLocked = mXmppConnectionService.isScreenLocked();
+        final boolean isScreenOn = mXmppConnectionService.isInteractive();
-        if (this.mIsInForeground && !isScreenLocked && this.mOpenConversation == message.getConversation()) {
+        if (this.mIsInForeground && isScreenOn && this.mOpenConversation == message.getConversation()) {
             Log.d(Config.LOGTAG, message.getConversation().getAccount().getJid().asBareJid() + ": suppressing notification because conversation is open");
             return;
         }
@@ -575,7 +495,7 @@ public class NotificationService {
             pushToStack(message);
             final Conversational conversation = message.getConversation();
             final Account account = conversation.getAccount();
-            final boolean doNotify = (!(this.mIsInForeground && this.mOpenConversation == null) || isScreenLocked)
+            final boolean doNotify = (!(this.mIsInForeground && this.mOpenConversation == null) || !isScreenOn)
                     && !account.inGracePeriod()
                     && !this.inMiniGracePeriod(account);
             updateNotification(doNotify, Collections.singletonList(conversation.getUuid()));
@@ -716,7 +636,17 @@ public class NotificationService {
         }
     }
 
-    private void modifyIncomingCall(final Builder mBuilder) {
+    private void modifyIncomingCall(Builder mBuilder) {
+        final SharedPreferences preferences = PreferenceManager.getDefaultSharedPreferences(mXmppConnectionService);
+        final Resources resources = mXmppConnectionService.getResources();
+        final String ringtone = preferences.getString("call_ringtone", resources.getString(R.string.incoming_call_ringtone));
+        mBuilder.setVibrate(CALL_PATTERN);
+        final Uri uri = Uri.parse(ringtone);
+        try {
+            mBuilder.setSound(fixRingtoneUri(uri));
+        } catch (SecurityException e) {
+            Log.d(Config.LOGTAG, "unable to use custom notification sound " + uri.toString());
+        }
         mBuilder.setPriority(NotificationCompat.PRIORITY_HIGH);
         setNotificationColor(mBuilder);
         mBuilder.setLights(LED_COLOR, 2000, 3000);
@@ -800,18 +730,17 @@ public class NotificationService {
                         .setSemanticAction(NotificationCompat.Action.SEMANTIC_ACTION_MARK_AS_READ)
                         .setShowsUserInterface(false)
                         .build();
-                final String replyLabel = mXmppConnectionService.getString(R.string.reply);
+                String replyLabel = mXmppConnectionService.getString(R.string.reply);
-                final String lastMessageUuid = Iterables.getLast(messages).getUuid();
+                NotificationCompat.Action replyAction = new NotificationCompat.Action.Builder(
-                final NotificationCompat.Action replyAction = new NotificationCompat.Action.Builder(
                         R.drawable.ic_send_text_offline,
                         replyLabel,
-                        createReplyIntent(conversation, lastMessageUuid, false))
+                        createReplyIntent(conversation, false))
                         .setSemanticAction(NotificationCompat.Action.SEMANTIC_ACTION_REPLY)
                         .setShowsUserInterface(false)
                         .addRemoteInput(remoteInput).build();
-                final NotificationCompat.Action wearReplyAction = new NotificationCompat.Action.Builder(R.drawable.ic_wear_reply,
+                NotificationCompat.Action wearReplyAction = new NotificationCompat.Action.Builder(R.drawable.ic_wear_reply,
                         replyLabel,
-                        createReplyIntent(conversation, lastMessageUuid, true)).addRemoteInput(remoteInput).build();
+                        createReplyIntent(conversation, true)).addRemoteInput(remoteInput).build();
                 mBuilder.extend(new NotificationCompat.WearableExtender().addAction(wearReplyAction));
                 int addedActionsCount = 1;
                 mBuilder.addAction(markReadAction);
@@ -1077,14 +1006,13 @@ public class NotificationService {
         return PendingIntent.getService(mXmppConnectionService, 0, intent, 0);
     }
 
-    private PendingIntent createReplyIntent(final Conversation conversation, final String lastMessageUuid, final boolean dismissAfterReply) {
+    private PendingIntent createReplyIntent(Conversation conversation, boolean dismissAfterReply) {
         final Intent intent = new Intent(mXmppConnectionService, XmppConnectionService.class);
         intent.setAction(XmppConnectionService.ACTION_REPLY_TO_CONVERSATION);
         intent.putExtra("uuid", conversation.getUuid());
         intent.putExtra("dismiss_notification", dismissAfterReply);
-        intent.putExtra("last_message_uuid", lastMessageUuid);
         final int id = generateRequestCode(conversation, dismissAfterReply ? 12 : 14);
-        return PendingIntent.getService(mXmppConnectionService, id, intent, PendingIntent.FLAG_UPDATE_CURRENT);
+        return PendingIntent.getService(mXmppConnectionService, id, intent, 0);
     }
 
     private PendingIntent createReadPendingIntent(Conversation conversation) {
@@ -1325,13 +1253,4 @@ public class NotificationService {
             Log.d(Config.LOGTAG, "unable to cancel notification", e);
         }
     }
-
-    private class VibrationRunnable implements Runnable {
-
-        @Override
-        public void run() {
-            final Vibrator vibrator = (Vibrator) mXmppConnectionService.getSystemService(Context.VIBRATOR_SERVICE);
-            vibrator.vibrate(CALL_PATTERN, -1);
-        }
-    }
 }

src/main/java/eu/siacs/conversations/services/XmppConnectionService.java

@@ -4,7 +4,6 @@ import android.Manifest;
 import android.annotation.SuppressLint;
 import android.annotation.TargetApi;
 import android.app.AlarmManager;
-import android.app.KeyguardManager;
 import android.app.Notification;
 import android.app.NotificationManager;
 import android.app.PendingIntent;
@@ -20,8 +19,6 @@ import android.database.ContentObserver;
 import android.graphics.Bitmap;
 import android.media.AudioManager;
 import android.net.ConnectivityManager;
-import android.net.Network;
-import android.net.NetworkCapabilities;
 import android.net.NetworkInfo;
 import android.net.Uri;
 import android.os.Binder;
@@ -57,6 +54,7 @@ import org.openintents.openpgp.util.OpenPgpApi;
 import org.openintents.openpgp.util.OpenPgpServiceConnection;
 
 import java.io.File;
+import java.net.URL;
 import java.security.SecureRandom;
 import java.security.Security;
 import java.security.cert.CertificateException;
@@ -75,8 +73,6 @@ import java.util.Set;
 import java.util.WeakHashMap;
 import java.util.concurrent.CopyOnWriteArrayList;
 import java.util.concurrent.CountDownLatch;
-import java.util.concurrent.Executor;
-import java.util.concurrent.Executors;
 import java.util.concurrent.atomic.AtomicBoolean;
 import java.util.concurrent.atomic.AtomicLong;
 import java.util.concurrent.atomic.AtomicReference;
@@ -107,6 +103,7 @@ import eu.siacs.conversations.generator.AbstractGenerator;
 import eu.siacs.conversations.generator.IqGenerator;
 import eu.siacs.conversations.generator.MessageGenerator;
 import eu.siacs.conversations.generator.PresenceGenerator;
+import eu.siacs.conversations.http.CustomURLStreamHandlerFactory;
 import eu.siacs.conversations.http.HttpConnectionManager;
 import eu.siacs.conversations.parser.AbstractParser;
 import eu.siacs.conversations.parser.IqParser;
@@ -138,7 +135,6 @@ import eu.siacs.conversations.utils.TorServiceUtils;
 import eu.siacs.conversations.utils.WakeLockHelper;
 import eu.siacs.conversations.utils.XmppUri;
 import eu.siacs.conversations.xml.Element;
-import eu.siacs.conversations.xml.LocalizedContent;
 import eu.siacs.conversations.xml.Namespace;
 import eu.siacs.conversations.xmpp.Jid;
 import eu.siacs.conversations.xmpp.OnBindListener;
@@ -156,7 +152,6 @@ import eu.siacs.conversations.xmpp.chatstate.ChatState;
 import eu.siacs.conversations.xmpp.forms.Data;
 import eu.siacs.conversations.xmpp.jingle.AbstractJingleConnection;
 import eu.siacs.conversations.xmpp.jingle.JingleConnectionManager;
-import eu.siacs.conversations.xmpp.jingle.JingleRtpConnection;
 import eu.siacs.conversations.xmpp.jingle.Media;
 import eu.siacs.conversations.xmpp.jingle.RtpEndUserState;
 import eu.siacs.conversations.xmpp.mam.MamReference;
@@ -185,10 +180,13 @@ public class XmppConnectionService extends Service {
 
     private static final String SETTING_LAST_ACTIVITY_TS = "last_activity_timestamp";
 
+    static {
+        URL.setURLStreamHandlerFactory(new CustomURLStreamHandlerFactory());
+    }
+
     public final CountDownLatch restoredFromDatabaseLatch = new CountDownLatch(1);
-    private final static Executor FILE_OBSERVER_EXECUTOR = Executors.newSingleThreadExecutor();
+    private final SerialSingleThreadExecutor mFileAddingExecutor = new SerialSingleThreadExecutor("FileAdding");
-    private final static Executor FILE_ATTACHMENT_EXECUTOR = Executors.newSingleThreadExecutor();
+    private final SerialSingleThreadExecutor mVideoCompressionExecutor = new SerialSingleThreadExecutor("VideoCompression");
-    private final static SerialSingleThreadExecutor VIDEO_COMPRESSION_EXECUTOR = new SerialSingleThreadExecutor("VideoCompression");
     private final SerialSingleThreadExecutor mDatabaseWriterExecutor = new SerialSingleThreadExecutor("DatabaseWriter");
     private final SerialSingleThreadExecutor mDatabaseReaderExecutor = new SerialSingleThreadExecutor("DatabaseReader");
     private final SerialSingleThreadExecutor mNotificationExecutor = new SerialSingleThreadExecutor("NotificationExecutor");
@@ -253,23 +251,10 @@ public class XmppConnectionService extends Service {
     private final OnMessageAcknowledged mOnMessageAcknowledgedListener = new OnMessageAcknowledged() {
 
         @Override
-        public boolean onMessageAcknowledged(final Account account, final Jid to, final String id) {
+        public boolean onMessageAcknowledged(Account account, String uuid) {
-            if (id.startsWith(JingleRtpConnection.JINGLE_MESSAGE_PROPOSE_ID_PREFIX)) {
-                final String sessionId = id.substring(JingleRtpConnection.JINGLE_MESSAGE_PROPOSE_ID_PREFIX.length());
-                mJingleConnectionManager.updateProposedSessionDiscovered(
-                        account,
-                        to,
-                        sessionId,
-                        JingleConnectionManager.DeviceDiscoveryState.SEARCHING_ACKNOWLEDGED
-                );
-            }
-
-
-            final Jid bare = to.asBareJid();
-
             for (final Conversation conversation : getConversations()) {
-                if (conversation.getAccount() == account && conversation.getJid().asBareJid().equals(bare)) {
+                if (conversation.getAccount() == account) {
-                    final Message message = conversation.findUnsentMessageWithUuid(id);
+                    Message message = conversation.findUnsentMessageWithUuid(uuid);
                     if (message != null) {
                         message.setStatus(Message.STATUS_SEND);
                         message.setErrorMessage(null);
@@ -345,7 +330,7 @@ public class XmppConnectionService extends Service {
             synchronized (account.inProgressConferencePings) {
                 account.inProgressConferencePings.clear();
             }
-            mJingleConnectionManager.notifyRebound(account);
+            mJingleConnectionManager.notifyRebound();
             mQuickConversationsService.considerSyncBackground(false);
             fetchRosterFromServer(account);
 
@@ -371,7 +356,6 @@ public class XmppConnectionService extends Service {
             }
             connectMultiModeConversations(account);
             syncDirtyContacts(account);
-
         }
     };
     private final AtomicLong mLastExpiryRun = new AtomicLong(0);
@@ -474,6 +458,7 @@ public class XmppConnectionService extends Service {
     private OpenPgpServiceConnection pgpServiceConnection;
     private PgpEngine mPgpEngine = null;
     private WakeLock wakeLock;
+    private PowerManager pm;
     private LruCache<String, Bitmap> mBitmapCache;
     private final BroadcastReceiver mInternalEventReceiver = new InternalEventReceiver();
     private final BroadcastReceiver mInternalScreenEventReceiver = new InternalEventReceiver();
@@ -566,14 +551,14 @@ public class XmppConnectionService extends Service {
         Log.d(Config.LOGTAG, "counterpart=" + message.getCounterpart());
         final AttachFileToConversationRunnable runnable = new AttachFileToConversationRunnable(this, uri, type, message, callback);
         if (runnable.isVideoMessage()) {
-            VIDEO_COMPRESSION_EXECUTOR.execute(runnable);
+            mVideoCompressionExecutor.execute(runnable);
         } else {
-            FILE_ATTACHMENT_EXECUTOR.execute(runnable);
+            mFileAddingExecutor.execute(runnable);
         }
     }
 
-    public void attachImageToConversation(final Conversation conversation, final Uri uri,  final String type, final UiCallback<Message> callback) {
+    public void attachImageToConversation(final Conversation conversation, final Uri uri, final UiCallback<Message> callback) {
-        final String mimeType = MimeUtils.guessMimeTypeFromUriAndMime(this, uri, type);
+        final String mimeType = MimeUtils.guessMimeTypeFromUri(this, uri);
         final String compressPictures = getCompressPicturesPreference();
 
         if ("never".equals(compressPictures)
@@ -595,11 +580,10 @@ public class XmppConnectionService extends Service {
             message.setType(Message.TYPE_IMAGE);
         }
         Log.d(Config.LOGTAG, "attachImage: type=" + message.getType());
-        FILE_ATTACHMENT_EXECUTOR.execute(() -> {
+        mFileAddingExecutor.execute(() -> {
             try {
                 getFileBackend().copyImageToPrivateStorage(message, uri);
-            } catch (FileBackend.ImageCompressionException e) {
+            } catch (FileBackend.NotAnImageFileException e) {
-                Log.d(Config.LOGTAG, "unable to compress image. fall back to file transfer", e);
                 attachFileToConversation(conversation, uri, mimeType, callback);
                 return;
             } catch (final FileBackend.FileCopyException e) {
@@ -661,7 +645,6 @@ public class XmppConnectionService extends Service {
                         if (Config.RESET_ATTEMPT_COUNT_ON_NETWORK_CHANGE) {
                             resetAllAttemptCounts(true, false);
                         }
-                        Resolver.clearCache();
                     }
                     break;
                 case Intent.ACTION_SHUTDOWN:
@@ -691,7 +674,6 @@ public class XmppConnectionService extends Service {
                 }
                 case TorServiceUtils.ACTION_STATUS:
                     final String status = intent.getStringExtra(TorServiceUtils.EXTRA_STATUS);
-                    //TODO port and host are in 'extras' - but this may not be a reliable source?
                     if ("ON".equals(status)) {
                         handleOrbotStartedEvent();
                         return START_STICKY;
@@ -726,7 +708,6 @@ public class XmppConnectionService extends Service {
                     }
                     final CharSequence body = remoteInput.getCharSequence("text_reply");
                     final boolean dismissNotification = intent.getBooleanExtra("dismiss_notification", false);
-                    final String lastMessageUuid = intent.getStringExtra("last_message_uuid");
                     if (body == null || body.length() <= 0) {
                         break;
                     }
@@ -735,7 +716,7 @@ public class XmppConnectionService extends Service {
                             restoredFromDatabaseLatch.await();
                             final Conversation c = findConversationByUuid(uuid);
                             if (c != null) {
-                                directReply(c, body.toString(), lastMessageUuid, dismissNotification);
+                                directReply(c, body.toString(), dismissNotification);
                             }
                         } catch (InterruptedException e) {
                             Log.d(Config.LOGTAG, "unable to process direct reply");
@@ -777,9 +758,8 @@ public class XmppConnectionService extends Service {
                     break;
                 case Intent.ACTION_SCREEN_ON:
                     deactivateGracePeriod();
-                case Intent.ACTION_USER_PRESENT:
                 case Intent.ACTION_SCREEN_OFF:
-                    if (awayWhenScreenLocked()) {
+                    if (awayWhenScreenOff()) {
                         refreshAllPresences();
                     }
                     break;
@@ -933,12 +913,8 @@ public class XmppConnectionService extends Service {
         }
     }
 
-    private void directReply(final Conversation conversation, final String body, final String lastMessageUuid, final boolean dismissAfterReply) {
+    private void directReply(Conversation conversation, String body, final boolean dismissAfterReply) {
-        final Message inReplyTo = lastMessageUuid == null ? null : conversation.findMessageWithUuid(lastMessageUuid);
+        Message message = new Message(conversation, body, conversation.getNextEncryption());
-        final Message message = new Message(conversation, body, conversation.getNextEncryption());
-        if (inReplyTo != null && inReplyTo.isPrivateMessage()) {
-            Message.configurePrivateMessage(message, inReplyTo.getCounterpart());
-        }
         message.markUnread();
         if (message.getEncryption() == Message.ENCRYPTION_PGP) {
             getPgpEngine().encrypt(message, new UiCallback<Message>() {
@@ -983,7 +959,7 @@ public class XmppConnectionService extends Service {
         return getBooleanPreference(SettingsActivity.TREAT_VIBRATE_AS_SILENT, R.bool.treat_vibrate_as_silent);
     }
 
-    private boolean awayWhenScreenLocked() {
+    private boolean awayWhenScreenOff() {
         return getBooleanPreference(SettingsActivity.AWAY_WHEN_SCREEN_IS_OFF, R.bool.away_when_screen_off);
     }
 
@@ -994,19 +970,29 @@ public class XmppConnectionService extends Service {
     private Presence.Status getTargetPresence() {
         if (dndOnSilentMode() && isPhoneSilenced()) {
             return Presence.Status.DND;
-        } else if (awayWhenScreenLocked() && isScreenLocked()) {
+        } else if (awayWhenScreenOff() && !isInteractive()) {
             return Presence.Status.AWAY;
         } else {
             return Presence.Status.ONLINE;
         }
     }
 
-    public boolean isScreenLocked() {
+    @SuppressLint("NewApi")
-        final KeyguardManager keyguardManager = (KeyguardManager) getSystemService(Context.KEYGUARD_SERVICE);
+    @SuppressWarnings("deprecation")
-        final PowerManager powerManager = (PowerManager) getSystemService(Context.POWER_SERVICE);
+    public boolean isInteractive() {
-        final boolean locked = keyguardManager != null && keyguardManager.isKeyguardLocked();
+        try {
-        final boolean interactive = powerManager != null && powerManager.isInteractive();
+            final PowerManager pm = (PowerManager) getSystemService(Context.POWER_SERVICE);
-        return locked || !interactive;
+
+            final boolean isScreenOn;
+            if (Build.VERSION.SDK_INT < Build.VERSION_CODES.LOLLIPOP) {
+                isScreenOn = pm.isScreenOn();
+            } else {
+                isScreenOn = pm.isInteractive();
+            }
+            return isScreenOn;
+        } catch (RuntimeException e) {
+            return false;
+        }
     }
 
     private boolean isPhoneSilenced() {
@@ -1084,20 +1070,11 @@ public class XmppConnectionService extends Service {
     }
 
     public boolean hasInternetConnection() {
-        final ConnectivityManager cm = ContextCompat.getSystemService(this, ConnectivityManager.class);
+        final ConnectivityManager cm = (ConnectivityManager) getSystemService(Context.CONNECTIVITY_SERVICE);
-        if (cm == null) {
-            return true; //if internet connection can not be checked it is probably best to just try
-        }
         try {
-            if (android.os.Build.VERSION.SDK_INT >= android.os.Build.VERSION_CODES.Q) {
+            final NetworkInfo activeNetwork = cm == null ? null : cm.getActiveNetworkInfo();
-                final Network activeNetwork = cm.getActiveNetwork();
+            return activeNetwork != null && (activeNetwork.isConnected() || activeNetwork.getType() == ConnectivityManager.TYPE_ETHERNET);
-                final NetworkCapabilities capabilities = activeNetwork == null ? null : cm.getNetworkCapabilities(activeNetwork);
+        } catch (RuntimeException e) {
-                return capabilities != null && capabilities.hasCapability(NetworkCapabilities.NET_CAPABILITY_INTERNET);
-            } else {
-                final NetworkInfo networkInfo = cm.getActiveNetworkInfo();
-                return networkInfo != null && (networkInfo.isConnected() || networkInfo.getType() == ConnectivityManager.TYPE_ETHERNET);
-            }
-        } catch (final RuntimeException e) {
             Log.d(Config.LOGTAG, "unable to check for internet connection", e);
             return true; //if internet connection can not be checked it is probably best to just try
         }
@@ -1154,11 +1131,11 @@ public class XmppConnectionService extends Service {
         if (Build.VERSION.SDK_INT < Build.VERSION_CODES.M || ContextCompat.checkSelfPermission(this, Manifest.permission.READ_CONTACTS) == PackageManager.PERMISSION_GRANTED) {
             startContactObserver();
         }
-        FILE_OBSERVER_EXECUTOR.execute(fileBackend::deleteHistoricAvatarPath);
+        mFileAddingExecutor.execute(fileBackend::deleteHistoricAvatarPath);
         if (Compatibility.hasStoragePermission(this)) {
             Log.d(Config.LOGTAG, "starting file observer");
-            FILE_OBSERVER_EXECUTOR.execute(this.fileObserver::startWatching);
+            mFileAddingExecutor.execute(this.fileObserver::startWatching);
-            FILE_OBSERVER_EXECUTOR.execute(this::checkForDeletedFiles);
+            mFileAddingExecutor.execute(this::checkForDeletedFiles);
         }
         if (Config.supportOpenPgp()) {
             this.pgpServiceConnection = new OpenPgpServiceConnection(this, "org.sufficientlysecure.keychain", new OpenPgpServiceConnection.OnBound() {
@@ -1179,7 +1156,7 @@ public class XmppConnectionService extends Service {
             this.pgpServiceConnection.bindToService();
         }
 
-        final PowerManager pm = ContextCompat.getSystemService(this, PowerManager.class);
+        this.pm = (PowerManager) getSystemService(Context.POWER_SERVICE);
         this.wakeLock = pm.newWakeLock(PowerManager.PARTIAL_WAKE_LOCK, "Conversations:Service");
 
         toggleForegroundService();
@@ -1263,7 +1240,6 @@ public class XmppConnectionService extends Service {
     public void onDestroy() {
         try {
             unregisterReceiver(this.mInternalEventReceiver);
-            unregisterReceiver(this.mInternalScreenEventReceiver);
         } catch (final IllegalArgumentException e) {
             //ignored
         }
@@ -1274,16 +1250,15 @@ public class XmppConnectionService extends Service {
 
     public void restartFileObserver() {
         Log.d(Config.LOGTAG, "restarting file observer");
-        FILE_OBSERVER_EXECUTOR.execute(this.fileObserver::restartWatching);
+        mFileAddingExecutor.execute(this.fileObserver::restartWatching);
-        FILE_OBSERVER_EXECUTOR.execute(this::checkForDeletedFiles);
+        mFileAddingExecutor.execute(this::checkForDeletedFiles);
     }
 
     public void toggleScreenEventReceiver() {
-        if (awayWhenScreenLocked() && !manuallyChangePresence()) {
+        if (awayWhenScreenOff() && !manuallyChangePresence()) {
             final IntentFilter filter = new IntentFilter();
             filter.addAction(Intent.ACTION_SCREEN_ON);
             filter.addAction(Intent.ACTION_SCREEN_OFF);
-            filter.addAction(Intent.ACTION_USER_PRESENT);
             registerReceiver(this.mInternalScreenEventReceiver, filter);
         } else {
             try {
@@ -1298,8 +1273,8 @@ public class XmppConnectionService extends Service {
         toggleForegroundService(false);
     }
 
-    public void setOngoingCall(AbstractJingleConnection.Id id, Set<Media> media, final boolean reconnecting) {
+    public void setOngoingCall(AbstractJingleConnection.Id id, Set<Media> media) {
-        ongoingCall.set(new OngoingCall(id, media, reconnecting));
+        ongoingCall.set(new OngoingCall(id, media));
         toggleForegroundService(false);
     }
 
@@ -1315,7 +1290,7 @@ public class XmppConnectionService extends Service {
             final Notification notification;
             final int id;
             if (ongoing != null) {
-                notification = this.mNotificationService.getOngoingCallNotification(ongoing);
+                notification = this.mNotificationService.getOngoingCallNotification(ongoing.id, ongoing.media);
                 id = NotificationService.ONGOING_CALL_NOTIFICATION_ID;
                 startForeground(id, notification);
                 mNotificationService.cancel(NotificationService.FOREGROUND_NOTIFICATION_ID);
@@ -1810,7 +1785,7 @@ public class XmppConnectionService extends Service {
             IqPacket request = mIqGenerator.deleteItem(Namespace.BOOKMARKS2, bookmark.getJid().asBareJid().toEscapedString());
             sendIqPacket(account, request, (a, response) -> {
                 if (response.getType() == IqPacket.TYPE.ERROR) {
-                    Log.d(Config.LOGTAG, a.getJid().asBareJid() + ": unable to delete bookmark " + response.getErrorCondition());
+                    Log.d(Config.LOGTAG, a.getJid().asBareJid() + ": unable to delete bookmark " + response.getError());
                 }
             });
         } else if (connection.getFeatures().bookmarksConversion()) {
@@ -1892,10 +1867,7 @@ public class XmppConnectionService extends Service {
             long diffConversationsRestore = SystemClock.elapsedRealtime() - startTimeConversationsRestore;
             Log.d(Config.LOGTAG, "finished restoring conversations in " + diffConversationsRestore + "ms");
             Runnable runnable = () -> {
-                if (DatabaseBackend.requiresMessageIndexRebuild()) {
+                long deletionDate = getAutomaticMessageDeletionDate();
-                    DatabaseBackend.getInstance(this).rebuildMessagesIndex();
-                }
-                final long deletionDate = getAutomaticMessageDeletionDate();
                 mLastExpiryRun.set(SystemClock.elapsedRealtime());
                 if (deletionDate > 0) {
                     Log.d(Config.LOGTAG, "deleting messages that are older than " + AbstractGenerator.getTimestamp(deletionDate));
@@ -1935,7 +1907,7 @@ public class XmppConnectionService extends Service {
     private void restoreMessages(Conversation conversation) {
         conversation.addAll(0, databaseBackend.getMessages(conversation, Config.PAGE_SIZE));
         conversation.findUnsentTextMessages(message -> markMessage(message, Message.STATUS_WAITING));
-        conversation.findUnreadMessages(mNotificationService::pushFromBacklog);
+        conversation.findUnreadMessages(message -> mNotificationService.pushFromBacklog(message));
     }
 
     public void loadPhoneContacts() {
@@ -2883,12 +2855,13 @@ public class XmppConnectionService extends Service {
                 }
 
                 @Override
-                public void onFetchFailed(final Conversation conversation, final String errorCondition) {
+                public void onFetchFailed(final Conversation conversation, Element error) {
                     if (conversation.getStatus() == Conversation.STATUS_ARCHIVED) {
                         Log.d(Config.LOGTAG, account.getJid().asBareJid() + ": conversation (" + conversation.getJid() + ") got archived before IQ result");
+
                         return;
                     }
-                    if ("remote-server-not-found".equals(errorCondition)) {
+                    if (error != null && "remote-server-not-found".equals(error.getName())) {
                         synchronized (account.inProgressConferenceJoins) {
                             account.inProgressConferenceJoins.remove(conversation);
                         }
@@ -3254,7 +3227,7 @@ public class XmppConnectionService extends Service {
                     Log.d(Config.LOGTAG, account.getJid().asBareJid() + ": received timeout waiting for conference configuration fetch");
                 } else {
                     if (callback != null) {
-                        callback.onFetchFailed(conversation, packet.getErrorCondition());
+                        callback.onFetchFailed(conversation, packet.getError());
                     }
                 }
             }
@@ -3347,26 +3320,35 @@ public class XmppConnectionService extends Service {
 
     public void changeAffiliationInConference(final Conversation conference, Jid user, final MucOptions.Affiliation affiliation, final OnAffiliationChanged callback) {
         final Jid jid = user.asBareJid();
-        final IqPacket request = this.mIqGenerator.changeAffiliation(conference, jid, affiliation.toString());
+        IqPacket request = this.mIqGenerator.changeAffiliation(conference, jid, affiliation.toString());
-        sendIqPacket(conference.getAccount(), request, (account, response) -> {
+        sendIqPacket(conference.getAccount(), request, new OnIqPacketReceived() {
-            if (response.getType() == IqPacket.TYPE.RESULT) {
+            @Override
+            public void onIqPacketReceived(Account account, IqPacket packet) {
+                if (packet.getType() == IqPacket.TYPE.RESULT) {
                     conference.getMucOptions().changeAffiliation(jid, affiliation);
                     getAvatarService().clear(conference);
-                if (callback != null) {
                     callback.onAffiliationChangedSuccessful(jid);
                 } else {
-                    Log.d(Config.LOGTAG, "changed affiliation of " + user + " to " + affiliation);
-                }
-            } else if (callback != null) {
                     callback.onAffiliationChangeFailed(jid, R.string.could_not_change_affiliation);
-            } else {
+                }
-                Log.d(Config.LOGTAG, "unable to change affiliation");
             }
         });
     }
 
+    public void changeAffiliationsInConference(final Conversation conference, MucOptions.Affiliation before, MucOptions.Affiliation after) {
+        List<Jid> jids = new ArrayList<>();
+        for (MucOptions.User user : conference.getMucOptions().getUsers()) {
+            if (user.getAffiliation() == before && user.getRealJid() != null) {
+                jids.add(user.getRealJid());
+            }
+        }
+        IqPacket request = this.mIqGenerator.changeAffiliation(conference, jids, after.toString());
+        sendIqPacket(conference.getAccount(), request, mDefaultIqHandler);
+    }
+
     public void changeRoleInConference(final Conversation conference, final String nick, MucOptions.Role role) {
         IqPacket request = this.mIqGenerator.changeRole(conference, nick, role.toString());
+        Log.d(Config.LOGTAG, request.toString());
         sendIqPacket(conference.getAccount(), request, (account, packet) -> {
             if (packet.getType() != IqPacket.TYPE.RESULT) {
                 Log.d(Config.LOGTAG, account.getJid().asBareJid() + " unable to change role of " + nick);
@@ -3449,23 +3431,15 @@ public class XmppConnectionService extends Service {
         }
     }
 
-    public void createContact(final Contact contact, final boolean autoGrant) {
+    public void createContact(Contact contact, boolean autoGrant) {
-        createContact(contact, autoGrant, null);
-    }
-
-    public void createContact(final Contact contact, final boolean autoGrant, final String preAuth) {
         if (autoGrant) {
             contact.setOption(Contact.Options.PREEMPTIVE_GRANT);
             contact.setOption(Contact.Options.ASKING);
         }
-        pushContactToServer(contact, preAuth);
+        pushContactToServer(contact);
     }
 
     public void pushContactToServer(final Contact contact) {
-        pushContactToServer(contact, null);
-    }
-
-    private void pushContactToServer(final Contact contact, final String preAuth) {
         contact.resetOption(Contact.Options.DIRTY_DELETE);
         contact.setOption(Contact.Options.DIRTY_PUSH);
         final Account account = contact.getAccount();
@@ -3481,7 +3455,7 @@ public class XmppConnectionService extends Service {
                 sendPresencePacket(account, mPresenceGenerator.sendPresenceUpdatesTo(contact));
             }
             if (ask) {
-                sendPresencePacket(account, mPresenceGenerator.requestPresenceUpdatesFrom(contact, preAuth));
+                sendPresencePacket(account, mPresenceGenerator.requestPresenceUpdatesFrom(contact));
             }
         } else {
             syncRoster(contact.getAccount());
@@ -3548,7 +3522,7 @@ public class XmppConnectionService extends Service {
                     if (publicationResponse.getType() == IqPacket.TYPE.RESULT) {
                         callback.onAvatarPublicationSucceeded();
                     } else {
-                        Log.d(Config.LOGTAG, "failed to publish vcard " + publicationResponse.getErrorCondition());
+                        Log.d(Config.LOGTAG, "failed to publish vcard " + publicationResponse.getError());
                         callback.onAvatarPublicationFailed(R.string.error_publish_avatar_server_reject);
                     }
                 });
@@ -3929,13 +3903,9 @@ public class XmppConnectionService extends Service {
         new Thread(() -> reconnectAccount(account, false, true)).start();
     }
 
-    public void invite(final Conversation conversation, final Jid contact) {
+    public void invite(Conversation conversation, Jid contact) {
         Log.d(Config.LOGTAG, conversation.getAccount().getJid().asBareJid() + ": inviting " + contact + " to " + conversation.getJid().asBareJid());
-        final MucOptions.User user = conversation.getMucOptions().findUserByRealJid(contact.asBareJid());
+        MessagePacket packet = mMessageGenerator.invite(conversation, contact);
-        if (user == null || user.getAffiliation() == MucOptions.Affiliation.OUTCAST) {
-            changeAffiliationInConference(conversation, contact, MucOptions.Affiliation.NONE, null);
-        }
-        final MessagePacket packet = mMessageGenerator.invite(conversation, contact);
         sendMessagePacket(conversation.getAccount(), packet);
     }
 
@@ -3972,30 +3942,16 @@ public class XmppConnectionService extends Service {
         return null;
     }
 
-    public boolean markMessage(final Conversation conversation, final String uuid, final int status, final String serverMessageId) {
+    public boolean markMessage(Conversation conversation, String uuid, int status, String serverMessageId) {
-        return markMessage(conversation, uuid, status, serverMessageId, null);
-    }
-
-    public boolean markMessage(final Conversation conversation, final String uuid, final int status, final String serverMessageId, final LocalizedContent body) {
         if (uuid == null) {
             return false;
         } else {
-            final Message message = conversation.findSentMessageWithUuid(uuid);
+            Message message = conversation.findSentMessageWithUuid(uuid);
             if (message != null) {
                 if (message.getServerMsgId() == null) {
                     message.setServerMsgId(serverMessageId);
                 }
-                if (message.getEncryption() == Message.ENCRYPTION_NONE
-                        && message.isTypeText()
-                        && isBodyModified(message, body)) {
-                    message.setBody(body.content);
-                    if (body.count > 1) {
-                        message.setBodyLanguage(body.language);
-                    }
-                    markMessage(message, status, null, true);
-                } else {
                 markMessage(message, status);
-                }
                 return true;
             } else {
                 return false;
@@ -4003,23 +3959,12 @@ public class XmppConnectionService extends Service {
         }
     }
 
-    private static boolean isBodyModified(final Message message, final LocalizedContent body) {
-        if (body == null || body.content == null) {
-            return false;
-        }
-        return !body.content.equals(message.getBody());
-    }
-
     public void markMessage(Message message, int status) {
         markMessage(message, status, null);
     }
 
 
     public void markMessage(final Message message, final int status, final String errorMessage) {
-        markMessage(message, status, errorMessage, false);
-    }
-
-    public void markMessage(final Message message, final int status, final String errorMessage, final boolean includeBody) {
         final int oldStatus = message.getStatus();
         if (status == Message.STATUS_SEND_FAILED && (oldStatus == Message.STATUS_SEND_RECEIVED || oldStatus == Message.STATUS_SEND_DISPLAYED)) {
             return;
@@ -4029,7 +3974,7 @@ public class XmppConnectionService extends Service {
         }
         message.setErrorMessage(errorMessage);
         message.setStatus(status);
-        databaseBackend.updateMessage(message, includeBody);
+        databaseBackend.updateMessage(message, false);
         updateConversationUi();
         if (oldStatus != status && status == Message.STATUS_SEND_FAILED) {
             mNotificationService.pushFailedDelivery(message);
@@ -4334,7 +4279,7 @@ public class XmppConnectionService extends Service {
     }
 
     public void sendMessagePacket(Account account, MessagePacket packet) {
-        final XmppConnection connection = account.getXmppConnection();
+        XmppConnection connection = account.getXmppConnection();
         if (connection != null) {
             connection.sendMessagePacket(packet);
         }
@@ -4369,7 +4314,7 @@ public class XmppConnectionService extends Service {
     }
 
     private void sendPresence(final Account account, final boolean includeIdleTimestamp) {
-        final Presence.Status status;
+        Presence.Status status;
         if (manuallyChangePresence()) {
             status = account.getPresenceStatus();
         } else {
@@ -4612,6 +4557,11 @@ public class XmppConnectionService extends Service {
                 syncRoster(account);
             }
         } else {
+            if (account.inProgressDiscoFetches.contains(key)) {
+                Log.d(Config.LOGTAG, account.getJid().asBareJid() + ": skipping duplicate disco request for " + key.second + " to " + jid);
+                return;
+            }
+            account.inProgressDiscoFetches.add(key);
             final IqPacket request = new IqPacket(IqPacket.TYPE.GET);
             request.setTo(jid);
             final String node = presence.getNode();
@@ -4623,7 +4573,7 @@ public class XmppConnectionService extends Service {
             Log.d(Config.LOGTAG, account.getJid().asBareJid() + ": making disco request for " + key.second + " to " + jid);
             sendIqPacket(account, request, (a, response) -> {
                 if (response.getType() == IqPacket.TYPE.RESULT) {
-                    final ServiceDiscoveryResult discoveryResult = new ServiceDiscoveryResult(response);
+                    ServiceDiscoveryResult discoveryResult = new ServiceDiscoveryResult(response);
                     if (presence.getVer().equals(discoveryResult.getVer())) {
                         databaseBackend.insertDiscoveryResult(discoveryResult);
                         injectServiceDiscoveryResult(a.getRoster(), presence.getHash(), presence.getVer(), discoveryResult);
@@ -4633,6 +4583,7 @@ public class XmppConnectionService extends Service {
                 } else {
                     Log.d(Config.LOGTAG, account.getJid().asBareJid() + ": unable to fetch caps from " + jid);
                 }
+                a.inProgressDiscoFetches.remove(key);
             });
         }
     }
@@ -4837,7 +4788,7 @@ public class XmppConnectionService extends Service {
     public interface OnConferenceConfigurationFetched {
         void onConferenceConfigurationFetched(Conversation conversation);
 
-        void onFetchFailed(Conversation conversation, String errorCondition);
+        void onFetchFailed(Conversation conversation, Element error);
     }
 
     public interface OnConferenceJoined {
@@ -4869,14 +4820,12 @@ public class XmppConnectionService extends Service {
     }
 
     public static class OngoingCall {
-        public final AbstractJingleConnection.Id id;
+        private final AbstractJingleConnection.Id id;
-        public final Set<Media> media;
+        private final Set<Media> media;
-        public final boolean reconnecting;
 
-        public OngoingCall(AbstractJingleConnection.Id id, Set<Media> media, final boolean reconnecting) {
+        public OngoingCall(AbstractJingleConnection.Id id, Set<Media> media) {
             this.id = id;
             this.media = media;
-            this.reconnecting = reconnecting;
         }
 
         @Override
@@ -4884,12 +4833,12 @@ public class XmppConnectionService extends Service {
             if (this == o) return true;
             if (o == null || getClass() != o.getClass()) return false;
             OngoingCall that = (OngoingCall) o;
-            return reconnecting == that.reconnecting && Objects.equal(id, that.id) && Objects.equal(media, that.media);
+            return Objects.equal(id, that.id);
         }
 
         @Override
         public int hashCode() {
-            return Objects.hashCode(id, media, reconnecting);
+            return Objects.hashCode(id);
         }
     }
 }

src/main/java/eu/siacs/conversations/ui/AboutActivity.java

@@ -5,19 +5,12 @@ import android.os.Bundle;
 import androidx.appcompat.app.AppCompatActivity;
 
 import eu.siacs.conversations.R;
-import eu.siacs.conversations.ui.util.SettingsUtils;
 import eu.siacs.conversations.utils.ThemeHelper;
 
 import static eu.siacs.conversations.ui.XmppActivity.configureActionBar;
 
 public class AboutActivity extends AppCompatActivity {
 
-    @Override
-    protected void onResume(){
-        super.onResume();
-        SettingsUtils.applyScreenshotPreventionSetting(this);
-    }
-
     @Override
     protected void onCreate(Bundle savedInstanceState) {
         super.onCreate(savedInstanceState);

src/main/java/eu/siacs/conversations/ui/AboutPreference.java

@@ -5,24 +5,22 @@ import android.content.Intent;
 import android.preference.Preference;
 import android.util.AttributeSet;
 
-import eu.siacs.conversations.BuildConfig;
 import eu.siacs.conversations.R;
 import eu.siacs.conversations.utils.PhoneHelper;
 
 public class AboutPreference extends Preference {
 	public AboutPreference(final Context context, final AttributeSet attrs, final int defStyle) {
 		super(context, attrs, defStyle);
-        setSummaryAndTitle(context);
+        final String appName = context.getString(R.string.app_name);
+        setSummary(appName +' '+ PhoneHelper.getVersionName(context));
+        setTitle(context.getString(R.string.title_activity_about_x, appName));
 	}
 
 	public AboutPreference(final Context context, final AttributeSet attrs) {
 		super(context, attrs);
-		setSummaryAndTitle(context);
+		final String appName = context.getString(R.string.app_name);
-	}
+		setSummary(appName +' '+ PhoneHelper.getVersionName(context));
-
+		setTitle(context.getString(R.string.title_activity_about_x, appName));
-	private void setSummaryAndTitle(final Context context) {
-	    setSummary(String.format("%s %s", BuildConfig.APP_NAME, BuildConfig.VERSION_NAME));
-        setTitle(context.getString(R.string.title_activity_about_x, BuildConfig.APP_NAME));
 	}
 
     @Override

src/main/java/eu/siacs/conversations/ui/ConferenceDetailsActivity.java

@@ -1,6 +1,5 @@
 package eu.siacs.conversations.ui;
 
-import android.app.Activity;
 import android.app.PendingIntent;
 import android.content.Context;
 import android.content.Intent;
@@ -8,7 +7,6 @@ import android.os.Bundle;
 import android.text.Editable;
 import android.text.SpannableStringBuilder;
 import android.text.TextWatcher;
-import android.text.method.LinkMovementMethod;
 import android.view.Menu;
 import android.view.MenuItem;
 import android.view.View;
@@ -88,13 +86,6 @@ public class ConferenceDetailsActivity extends XmppActivity implements OnConvers
         }
     };
 
-    public static void open(final Activity activity, final Conversation conversation) {
-        Intent intent = new Intent(activity, ConferenceDetailsActivity.class);
-        intent.setAction(ConferenceDetailsActivity.ACTION_VIEW_MUC);
-        intent.putExtra("uuid", conversation.getUuid());
-        activity.startActivity(intent);
-    }
-
     private final OnClickListener mNotifyStatusClickListener = new OnClickListener() {
         @Override
         public void onClick(View v) {
@@ -490,7 +481,6 @@ public class ConferenceDetailsActivity extends XmppActivity implements OnConvers
             this.binding.mucSubject.setTextAppearance(this, subject.length() > (hasTitle ? 128 : 196) ? R.style.TextAppearance_Conversations_Body1_Linkified : R.style.TextAppearance_Conversations_Subhead);
             this.binding.mucSubject.setAutoLinkMask(0);
             this.binding.mucSubject.setVisibility(View.VISIBLE);
-            this.binding.mucSubject.setMovementMethod(LinkMovementMethod.getInstance());
         } else {
             this.binding.mucSubject.setVisibility(View.GONE);
         }

src/main/java/eu/siacs/conversations/ui/ContactDetailsActivity.java

@@ -45,7 +45,6 @@ import eu.siacs.conversations.databinding.ActivityContactDetailsBinding;
 import eu.siacs.conversations.entities.Account;
 import eu.siacs.conversations.entities.Contact;
 import eu.siacs.conversations.entities.ListItem;
-import eu.siacs.conversations.services.AbstractQuickConversationsService;
 import eu.siacs.conversations.services.XmppConnectionService.OnAccountUpdate;
 import eu.siacs.conversations.services.XmppConnectionService.OnRosterUpdate;
 import eu.siacs.conversations.ui.adapter.MediaAdapter;
@@ -59,7 +58,6 @@ import eu.siacs.conversations.utils.AccountUtils;
 import eu.siacs.conversations.utils.Compatibility;
 import eu.siacs.conversations.utils.Emoticons;
 import eu.siacs.conversations.utils.IrregularUnicodeDetector;
-import eu.siacs.conversations.utils.PhoneNumberUtilWrapper;
 import eu.siacs.conversations.utils.UIHelper;
 import eu.siacs.conversations.utils.XmppUri;
 import eu.siacs.conversations.xml.Namespace;
@@ -133,31 +131,15 @@ public class ContactDetailsActivity extends OmemoActivity implements OnAccountUp
     }
 
     private void showAddToPhoneBookDialog() {
-        final Jid jid = contact.getJid();
-        final boolean quicksyContact = AbstractQuickConversationsService.isQuicksy()
-                && Config.QUICKSY_DOMAIN.equals(jid.getDomain())
-                && jid.getLocal() != null;
-        final String value;
-        if (quicksyContact) {
-            value = PhoneNumberUtilWrapper.toFormattedPhoneNumber(this, jid);
-        } else {
-            value = jid.toEscapedString();
-        }
         final AlertDialog.Builder builder = new AlertDialog.Builder(this);
         builder.setTitle(getString(R.string.action_add_phone_book));
-        builder.setMessage(getString(R.string.add_phone_book_text, value));
+        builder.setMessage(getString(R.string.add_phone_book_text, contact.getJid().toEscapedString()));
         builder.setNegativeButton(getString(R.string.cancel), null);
         builder.setPositiveButton(getString(R.string.add), (dialog, which) -> {
             final Intent intent = new Intent(Intent.ACTION_INSERT_OR_EDIT);
             intent.setType(Contacts.CONTENT_ITEM_TYPE);
-            if (quicksyContact) {
+            intent.putExtra(Intents.Insert.IM_HANDLE, contact.getJid().toEscapedString());
-                intent.putExtra(Intents.Insert.PHONE, value);
-            } else {
-                intent.putExtra(Intents.Insert.IM_HANDLE, value);
             intent.putExtra(Intents.Insert.IM_PROTOCOL, CommonDataKinds.Im.PROTOCOL_JABBER);
-                //TODO for modern use we want PROTOCOL_CUSTOM and an extra field with a value of 'XMPP'
-                // however we don’t have such a field and thus have to use the legacy PROTOCOL_JABBER
-            }
             intent.putExtra("finishActivityOnSaveCompleted", true);
             try {
                 startActivityForResult(intent, 0);
@@ -251,7 +233,6 @@ public class ContactDetailsActivity extends OmemoActivity implements OnAccountUp
 
     @Override
     public void onRequestPermissionsResult(int requestCode, @NonNull String[] permissions, @NonNull int[] grantResults) {
-        super.onRequestPermissionsResult(requestCode, permissions, grantResults);
         if (grantResults.length > 0)
             if (grantResults[0] == PackageManager.PERMISSION_GRANTED) {
                 if (requestCode == REQUEST_SYNC_CONTACTS && xmppConnectionServiceBound) {

src/main/java/eu/siacs/conversations/ui/ConversationActivity.java

@@ -6,8 +6,6 @@ import android.os.Bundle;
 import androidx.annotation.Nullable;
 import androidx.appcompat.app.AppCompatActivity;
 
-import eu.siacs.conversations.ui.util.SettingsUtils;
-
 public class ConversationActivity extends AppCompatActivity {
 
 	@Override
@@ -16,10 +14,4 @@ public class ConversationActivity extends AppCompatActivity {
 		startActivity(new Intent(this, ConversationsActivity.class));
 		finish();
 	}
-
-	@Override
-	protected void onResume(){
-		super.onResume();
-		SettingsUtils.applyScreenshotPreventionSetting(this);
-	}
 }

src/main/java/eu/siacs/conversations/ui/ConversationFragment.java

@@ -135,8 +135,6 @@ import static eu.siacs.conversations.utils.PermissionUtils.allGranted;
 import static eu.siacs.conversations.utils.PermissionUtils.getFirstDenied;
 import static eu.siacs.conversations.utils.PermissionUtils.writeGranted;
 
-import org.jetbrains.annotations.NotNull;
-
 
 public class ConversationFragment extends XmppFragment implements EditMessage.KeyboardListener, MessageAdapter.OnContactPictureLongClicked, MessageAdapter.OnContactPictureClicked {
 
@@ -188,7 +186,10 @@ public class ConversationFragment extends XmppFragment implements EditMessage.Ke
 
         @Override
         public void onClick(View v) {
-            ConferenceDetailsActivity.open(getActivity(), conversation);
+            Intent intent = new Intent(getActivity(), ConferenceDetailsActivity.class);
+            intent.setAction(ConferenceDetailsActivity.ACTION_VIEW_MUC);
+            intent.putExtra("uuid", conversation.getUuid());
+            startActivity(intent);
         }
     };
     private final OnClickListener leaveMuc = new OnClickListener() {
@@ -688,14 +689,14 @@ public class ConversationFragment extends XmppFragment implements EditMessage.Ke
         toggleInputMethod();
     }
 
-    private void attachImageToConversation(Conversation conversation, Uri uri, String type) {
+    private void attachImageToConversation(Conversation conversation, Uri uri) {
         if (conversation == null) {
             return;
         }
         final Toast prepareFileToast = Toast.makeText(getActivity(), getText(R.string.preparing_image), Toast.LENGTH_LONG);
         prepareFileToast.show();
         activity.delegateUriPermissionsToService(uri);
-        activity.xmppConnectionService.attachImageToConversation(conversation, uri, type,
+        activity.xmppConnectionService.attachImageToConversation(conversation, uri,
                 new UiCallback<Message>() {
 
                     @Override
@@ -733,7 +734,7 @@ public class ConversationFragment extends XmppFragment implements EditMessage.Ke
         if (body.length() == 0 || conversation == null) {
             return;
         }
-        if (trustKeysIfNeeded(conversation, REQUEST_TRUST_KEYS_TEXT)) {
+        if (conversation.getNextEncryption() == Message.ENCRYPTION_AXOLOTL && trustKeysIfNeeded(REQUEST_TRUST_KEYS_TEXT)) {
             return;
         }
         final Message message;
@@ -756,10 +757,6 @@ public class ConversationFragment extends XmppFragment implements EditMessage.Ke
         }
     }
 
-    private boolean trustKeysIfNeeded(final Conversation conversation, final int requestCode) {
-        return conversation.getNextEncryption() == Message.ENCRYPTION_AXOLOTL && trustKeysIfNeeded(requestCode);
-    }
-
     protected boolean trustKeysIfNeeded(int requestCode) {
         AxolotlService axolotlService = conversation.getAccount().getAxolotlService();
         final List<Jid> targets = axolotlService.getCryptoTargets(conversation);
@@ -827,12 +824,6 @@ public class ConversationFragment extends XmppFragment implements EditMessage.Ke
             case REQUEST_TRUST_KEYS_ATTACHMENTS:
                 commitAttachments();
                 break;
-            case REQUEST_START_AUDIO_CALL:
-                triggerRtpSession(RtpSessionActivity.ACTION_MAKE_VOICE_CALL);
-                break;
-            case REQUEST_START_VIDEO_CALL:
-                triggerRtpSession(RtpSessionActivity.ACTION_MAKE_VIDEO_CALL);
-                break;
             case ATTACHMENT_CHOICE_CHOOSE_IMAGE:
                 final List<Attachment> imageUris = Attachment.extractAttachments(getActivity(), data, Attachment.Type.IMAGE);
                 mediaPreviewAdapter.addMediaPreviews(imageUris);
@@ -856,15 +847,9 @@ public class ConversationFragment extends XmppFragment implements EditMessage.Ke
                 toggleInputMethod();
                 break;
             case ATTACHMENT_CHOICE_LOCATION:
-                final double latitude = data.getDoubleExtra("latitude", 0);
+                double latitude = data.getDoubleExtra("latitude", 0);
-                final double longitude = data.getDoubleExtra("longitude", 0);
+                double longitude = data.getDoubleExtra("longitude", 0);
-                final int accuracy = data.getIntExtra("accuracy", 0);
+                Uri geo = Uri.parse("geo:" + latitude + "," + longitude);
-                final Uri geo;
-                if (accuracy > 0) {
-                    geo = Uri.parse(String.format("geo:%s,%s;u=%s", latitude, longitude, accuracy));
-                } else {
-                    geo = Uri.parse(String.format("geo:%s,%s", latitude, longitude));
-                }
                 mediaPreviewAdapter.addMediaPreviews(Attachment.of(getActivity(), geo, Attachment.Type.LOCATION));
                 toggleInputMethod();
                 break;
@@ -885,7 +870,7 @@ public class ConversationFragment extends XmppFragment implements EditMessage.Ke
         if (anyNeedsExternalStoragePermission(attachments) && !hasPermissions(REQUEST_COMMIT_ATTACHMENTS, Manifest.permission.WRITE_EXTERNAL_STORAGE)) {
             return;
         }
-        if (trustKeysIfNeeded(conversation, REQUEST_TRUST_KEYS_ATTACHMENTS)) {
+        if (conversation.getNextEncryption() == Message.ENCRYPTION_AXOLOTL && trustKeysIfNeeded(REQUEST_TRUST_KEYS_ATTACHMENTS)) {
             return;
         }
         final PresenceSelector.OnPresenceSelected callback = () -> {
@@ -895,7 +880,7 @@ public class ConversationFragment extends XmppFragment implements EditMessage.Ke
                     attachLocationToConversation(conversation, attachment.getUri());
                 } else if (attachment.getType() == Attachment.Type.IMAGE) {
                     Log.d(Config.LOGTAG, "ConversationsActivity.commitAttachments() - attaching image to conversations. CHOOSE_IMAGE");
-                    attachImageToConversation(conversation, attachment.getUri(), attachment.getMime());
+                    attachImageToConversation(conversation, attachment.getUri());
                 } else {
                     Log.d(Config.LOGTAG, "ConversationsActivity.commitAttachments() - attaching file to conversations. CHOOSE_FILE/RECORD_VOICE/RECORD_VIDEO");
                     attachFileToConversation(conversation, attachment.getUri(), attachment.getMime());
@@ -1001,7 +986,7 @@ public class ConversationFragment extends XmppFragment implements EditMessage.Ke
                 menuCall.setVisible(false);
                 menuOngoingCall.setVisible(false);
             } else {
-                final XmppConnectionService service = activity == null ? null : activity.xmppConnectionService;
+                final XmppConnectionService service = activity.xmppConnectionService;
                 final Optional<OngoingRtpSession> ongoingRtpSession = service == null ? Optional.absent() : service.getJingleConnectionManager().getOngoingRtpConnection(conversation.getContact());
                 if (ongoingRtpSession.isPresent()) {
                     menuOngoingCall.setVisible(true);
@@ -1009,9 +994,8 @@ public class ConversationFragment extends XmppFragment implements EditMessage.Ke
                 } else {
                     menuOngoingCall.setVisible(false);
                     final RtpCapability.Capability rtpCapability = RtpCapability.check(conversation.getContact());
-                    final boolean cameraAvailable = activity != null && activity.isCameraFeatureAvailable();
                     menuCall.setVisible(rtpCapability != RtpCapability.Capability.NONE);
-                    menuVideoCall.setVisible(rtpCapability == RtpCapability.Capability.VIDEO && cameraAvailable);
+                    menuVideoCall.setVisible(rtpCapability == RtpCapability.Capability.VIDEO);
                 }
                 menuContactDetails.setVisible(!this.conversation.withSelf());
                 menuMucDetails.setVisible(false);
@@ -1053,6 +1037,7 @@ public class ConversationFragment extends XmppFragment implements EditMessage.Ke
         messageListAdapter = new MessageAdapter((XmppActivity) getActivity(), this.messageList);
         messageListAdapter.setOnContactPictureClicked(this);
         messageListAdapter.setOnContactPictureLongClicked(this);
+        messageListAdapter.setOnQuoteListener(this::quoteText);
         binding.messagesView.setAdapter(messageListAdapter);
 
         registerForContextMenu(binding.messagesView);
@@ -1070,6 +1055,7 @@ public class ConversationFragment extends XmppFragment implements EditMessage.Ke
         Log.d(Config.LOGTAG, "ConversationFragment.onDestroyView()");
         messageListAdapter.setOnContactPictureClicked(null);
         messageListAdapter.setOnContactPictureLongClicked(null);
+        messageListAdapter.setOnQuoteListener(null);
     }
 
     private void quoteText(String text) {
@@ -1277,7 +1263,10 @@ public class ConversationFragment extends XmppFragment implements EditMessage.Ke
                 activity.switchToContactDetails(conversation.getContact());
                 break;
             case R.id.action_muc_details:
-                ConferenceDetailsActivity.open(getActivity(), conversation);
+                Intent intent = new Intent(getActivity(), ConferenceDetailsActivity.class);
+                intent.setAction(ConferenceDetailsActivity.ACTION_VIEW_MUC);
+                intent.putExtra("uuid", conversation.getUuid());
+                startActivity(intent);
                 break;
             case R.id.action_invite:
                 startActivityForResult(ChooseContactActivity.create(activity, conversation), REQUEST_INVITE_TO_CONVERSATION);
@@ -1377,6 +1366,7 @@ public class ConversationFragment extends XmppFragment implements EditMessage.Ke
             Toast.makeText(getActivity(), R.string.only_one_call_at_a_time, Toast.LENGTH_LONG).show();
             return;
         }
+
         final Contact contact = conversation.getContact();
         if (contact.getPresences().anySupport(Namespace.JINGLE_MESSAGE)) {
             triggerRtpSession(contact.getAccount(), contact.getJid().asBareJid(), action);
@@ -1583,12 +1573,11 @@ public class ConversationFragment extends XmppFragment implements EditMessage.Ke
                 } else {
                     res = R.string.no_storage_permission;
                 }
-                Toast.makeText(getActivity(), getString(res, getString(R.string.app_name)), Toast.LENGTH_SHORT).show();
+                Toast.makeText(getActivity(), res, Toast.LENGTH_SHORT).show();
             }
         }
         if (writeGranted(grantResults, permissions)) {
             if (activity != null && activity.xmppConnectionService != null) {
-                activity.xmppConnectionService.getBitmapCache().evictAll();
                 activity.xmppConnectionService.restartFileObserver();
             }
             refresh();
@@ -1618,7 +1607,7 @@ public class ConversationFragment extends XmppFragment implements EditMessage.Ke
     }
 
     private void createNewConnection(final Message message) {
-        if (!activity.xmppConnectionService.hasInternetConnection()) {
+        if (!activity.xmppConnectionService.getHttpConnectionManager().checkConnection(message)) {
             Toast.makeText(getActivity(), R.string.not_connected_try_again, Toast.LENGTH_SHORT).show();
             return;
         }
@@ -1627,9 +1616,9 @@ public class ConversationFragment extends XmppFragment implements EditMessage.Ke
 
     @SuppressLint("InflateParams")
     protected void clearHistoryDialog(final Conversation conversation) {
-        final AlertDialog.Builder builder = new AlertDialog.Builder(requireActivity());
+        AlertDialog.Builder builder = new AlertDialog.Builder(getActivity());
         builder.setTitle(getString(R.string.clear_conversation_history));
-        final View dialogView = requireActivity().getLayoutInflater().inflate(R.layout.dialog_clear_history, null);
+        final View dialogView = getActivity().getLayoutInflater().inflate(R.layout.dialog_clear_history, null);
         final CheckBox endConversationCheckBox = dialogView.findViewById(R.id.end_conversation_checkbox);
         builder.setView(dialogView);
         builder.setNegativeButton(getString(R.string.cancel), null);
@@ -1647,7 +1636,7 @@ public class ConversationFragment extends XmppFragment implements EditMessage.Ke
     }
 
     protected void muteConversationDialog(final Conversation conversation) {
-        final AlertDialog.Builder builder = new AlertDialog.Builder(requireActivity());
+        AlertDialog.Builder builder = new AlertDialog.Builder(getActivity());
         builder.setTitle(R.string.disable_notifications);
         final int[] durations = getResources().getIntArray(R.array.mute_options_durations);
         final CharSequence[] labels = new CharSequence[durations.length];
@@ -1663,13 +1652,13 @@ public class ConversationFragment extends XmppFragment implements EditMessage.Ke
             if (durations[which] == -1) {
                 till = Long.MAX_VALUE;
             } else {
-                till = System.currentTimeMillis() + (durations[which] * 1000L);
+                till = System.currentTimeMillis() + (durations[which] * 1000);
             }
             conversation.setMutedTill(till);
             activity.xmppConnectionService.updateConversation(conversation);
             activity.onConversationsListItemUpdated();
             refresh();
-            requireActivity().invalidateOptionsMenu();
+            getActivity().invalidateOptionsMenu();
         });
         builder.create().show();
     }
@@ -1701,7 +1690,7 @@ public class ConversationFragment extends XmppFragment implements EditMessage.Ke
         this.activity.xmppConnectionService.updateConversation(conversation);
         this.activity.onConversationsListItemUpdated();
         refresh();
-        requireActivity().invalidateOptionsMenu();
+        getActivity().invalidateOptionsMenu();
     }
 
 
@@ -1711,7 +1700,9 @@ public class ConversationFragment extends XmppFragment implements EditMessage.Ke
         switch (attachmentChoice) {
             case ATTACHMENT_CHOICE_CHOOSE_IMAGE:
                 intent.setAction(Intent.ACTION_GET_CONTENT);
+                if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.JELLY_BEAN_MR2) {
                     intent.putExtra(Intent.EXTRA_ALLOW_MULTIPLE, true);
+                }
                 intent.setType("image/*");
                 chooser = true;
                 break;
@@ -1729,7 +1720,9 @@ public class ConversationFragment extends XmppFragment implements EditMessage.Ke
             case ATTACHMENT_CHOICE_CHOOSE_FILE:
                 chooser = true;
                 intent.setType("*/*");
+                if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.JELLY_BEAN_MR2) {
                     intent.putExtra(Intent.EXTRA_ALLOW_MULTIPLE, true);
+                }
                 intent.addCategory(Intent.CATEGORY_OPENABLE);
                 intent.setAction(Intent.ACTION_GET_CONTENT);
                 break;
@@ -1812,7 +1805,7 @@ public class ConversationFragment extends XmppFragment implements EditMessage.Ke
     }
 
     private void showErrorMessage(final Message message) {
-        AlertDialog.Builder builder = new AlertDialog.Builder(requireActivity());
+        AlertDialog.Builder builder = new AlertDialog.Builder(getActivity());
         builder.setTitle(R.string.error_message);
         final String errorMessage = message.getErrorMessage();
         final String[] errorMessageParts = errorMessage == null ? new String[0] : errorMessage.split("\\u001f");
@@ -1833,7 +1826,7 @@ public class ConversationFragment extends XmppFragment implements EditMessage.Ke
 
 
     private void deleteFile(final Message message) {
-        AlertDialog.Builder builder = new AlertDialog.Builder(requireActivity());
+        AlertDialog.Builder builder = new AlertDialog.Builder(getActivity());
         builder.setNegativeButton(R.string.cancel, null);
         builder.setTitle(R.string.delete_file_dialog);
         builder.setMessage(R.string.delete_file_dialog_msg);
@@ -1862,7 +1855,7 @@ public class ConversationFragment extends XmppFragment implements EditMessage.Ke
                 if (!message.hasFileOnRemoteHost()
                         && xmppConnection != null
                         && conversation.getMode() == Conversational.MODE_SINGLE
-                        && !xmppConnection.getFeatures().httpUpload(message.getFileParams().getSize())) {
+                        && !xmppConnection.getFeatures().httpUpload(message.getFileParams().size)) {
                     activity.selectPresence(conversation, () -> {
                         message.setCounterpart(conversation.getNextCounterpart());
                         activity.xmppConnectionService.resendFailedMessages(message);
@@ -1967,7 +1960,7 @@ public class ConversationFragment extends XmppFragment implements EditMessage.Ke
     }
 
     @Override
-    public void onSaveInstanceState(@NotNull Bundle outState) {
+    public void onSaveInstanceState(Bundle outState) {
         super.onSaveInstanceState(outState);
         if (conversation != null) {
             outState.putString(STATE_CONVERSATION_UUID, conversation.getUuid());
@@ -2191,14 +2184,13 @@ public class ConversationFragment extends XmppFragment implements EditMessage.Ke
         final boolean asQuote = extras.getBoolean(ConversationsActivity.EXTRA_AS_QUOTE);
         final boolean pm = extras.getBoolean(ConversationsActivity.EXTRA_IS_PRIVATE_MESSAGE, false);
         final boolean doNotAppend = extras.getBoolean(ConversationsActivity.EXTRA_DO_NOT_APPEND, false);
-        final String type = extras.getString(ConversationsActivity.EXTRA_TYPE);
         final List<Uri> uris = extractUris(extras);
         if (uris != null && uris.size() > 0) {
             if (uris.size() == 1 && "geo".equals(uris.get(0).getScheme())) {
                 mediaPreviewAdapter.addMediaPreviews(Attachment.of(getActivity(), uris.get(0), Attachment.Type.LOCATION));
             } else {
                 final List<Uri> cleanedUris = cleanUris(new ArrayList<>(uris));
-                mediaPreviewAdapter.addMediaPreviews(Attachment.of(getActivity(), cleanedUris, type));
+                mediaPreviewAdapter.addMediaPreviews(Attachment.of(getActivity(), cleanedUris));
             }
             toggleInputMethod();
             return;
@@ -3001,11 +2993,6 @@ public class ConversationFragment extends XmppFragment implements EditMessage.Ke
             final Menu menu = popupMenu.getMenu();
             menu.findItem(R.id.action_manage_accounts).setVisible(QuickConversationsService.isConversations());
             popupMenu.setOnMenuItemClickListener(item -> {
-                final XmppActivity activity = this.activity;
-                if (activity == null) {
-                    Log.e(Config.LOGTAG,"Unable to perform action. no context provided");
-                    return true;
-                }
                 switch (item.getItemId()) {
                     case R.id.action_show_qr_code:
                         activity.showQrCode(conversation.getAccount().getShareableUri());
@@ -3057,12 +3044,4 @@ public class ConversationFragment extends XmppFragment implements EditMessage.Ke
         }
         activity.switchToAccount(message.getConversation().getAccount(), fingerprint);
     }
-
-    private Activity requireActivity() {
-        final Activity activity = getActivity();
-        if (activity == null) {
-            throw new IllegalStateException("Activity not attached");
-        }
-        return activity;
-    }
 }

src/main/java/eu/siacs/conversations/ui/ConversationsActivity.java

@@ -30,8 +30,6 @@
 package eu.siacs.conversations.ui;
 
 
-import static eu.siacs.conversations.ui.ConversationFragment.REQUEST_DECRYPT_PGP;
-
 import android.annotation.SuppressLint;
 import android.app.Activity;
 import android.app.Fragment;
@@ -67,16 +65,13 @@ import eu.siacs.conversations.R;
 import eu.siacs.conversations.crypto.OmemoSetting;
 import eu.siacs.conversations.databinding.ActivityConversationsBinding;
 import eu.siacs.conversations.entities.Account;
-import eu.siacs.conversations.entities.Contact;
 import eu.siacs.conversations.entities.Conversation;
-import eu.siacs.conversations.entities.Conversational;
 import eu.siacs.conversations.services.XmppConnectionService;
 import eu.siacs.conversations.ui.interfaces.OnBackendConnected;
 import eu.siacs.conversations.ui.interfaces.OnConversationArchived;
 import eu.siacs.conversations.ui.interfaces.OnConversationRead;
 import eu.siacs.conversations.ui.interfaces.OnConversationSelected;
 import eu.siacs.conversations.ui.interfaces.OnConversationsListItemUpdated;
-import eu.siacs.conversations.ui.util.ActionBarUtil;
 import eu.siacs.conversations.ui.util.ActivityResult;
 import eu.siacs.conversations.ui.util.ConversationMenuConfigurator;
 import eu.siacs.conversations.ui.util.MenuDoubleTabUtil;
@@ -88,6 +83,8 @@ import eu.siacs.conversations.utils.XmppUri;
 import eu.siacs.conversations.xmpp.Jid;
 import eu.siacs.conversations.xmpp.OnUpdateBlocklist;
 
+import static eu.siacs.conversations.ui.ConversationFragment.REQUEST_DECRYPT_PGP;
+
 public class ConversationsActivity extends XmppActivity implements OnConversationSelected, OnConversationArchived, OnConversationsListItemUpdated, OnConversationRead, XmppConnectionService.OnAccountUpdate, XmppConnectionService.OnConversationUpdate, XmppConnectionService.OnRosterUpdate, OnUpdateBlocklist, XmppConnectionService.OnShowErrorToast, XmppConnectionService.OnAffiliationChanged {
 
     public static final String ACTION_VIEW_CONVERSATION = "eu.siacs.conversations.action.VIEW";
@@ -99,7 +96,6 @@ public class ConversationsActivity extends XmppActivity implements OnConversatio
     public static final String EXTRA_DO_NOT_APPEND = "do_not_append";
     public static final String EXTRA_POST_INIT_ACTION = "post_init_action";
     public static final String POST_ACTION_RECORD_VOICE = "record_voice";
-    public static final String EXTRA_TYPE = "type";
 
     private static final List<String> VIEW_AND_SHARE_ACTIONS = Arrays.asList(
             ACTION_VIEW_CONVERSATION,
@@ -228,7 +224,7 @@ public class ConversationsActivity extends XmppActivity implements OnConversatio
                 && getPreferences().getBoolean(getBatteryOptimizationPreferenceKey(), true)) {
             AlertDialog.Builder builder = new AlertDialog.Builder(this);
             builder.setTitle(R.string.battery_optimizations_enabled);
-            builder.setMessage(getString(R.string.battery_optimizations_enabled_dialog, getString(R.string.app_name)));
+            builder.setMessage(R.string.battery_optimizations_enabled_dialog);
             builder.setPositiveButton(R.string.next, (dialog, which) -> {
                 Intent intent = new Intent(Settings.ACTION_REQUEST_IGNORE_BATTERY_OPTIMIZATIONS);
                 Uri uri = Uri.parse("package:" + getPackageName());
@@ -282,7 +278,6 @@ public class ConversationsActivity extends XmppActivity implements OnConversatio
 
     @Override
     public void onRequestPermissionsResult(int requestCode, @NonNull String[] permissions, @NonNull int[] grantResults) {
-        super.onRequestPermissionsResult(requestCode, permissions, grantResults);
         UriHandlerActivity.onRequestPermissionResult(this, requestCode, grantResults);
         if (grantResults.length > 0) {
             if (grantResults[0] == PackageManager.PERMISSION_GRANTED) {
@@ -430,18 +425,16 @@ public class ConversationsActivity extends XmppActivity implements OnConversatio
     }
 
     private void openConversation(Conversation conversation, Bundle extras) {
-        final FragmentManager fragmentManager = getFragmentManager();
+        ConversationFragment conversationFragment = (ConversationFragment) getFragmentManager().findFragmentById(R.id.secondary_fragment);
-        executePendingTransactions(fragmentManager);
-        ConversationFragment conversationFragment = (ConversationFragment) fragmentManager.findFragmentById(R.id.secondary_fragment);
         final boolean mainNeedsRefresh;
         if (conversationFragment == null) {
             mainNeedsRefresh = false;
-            final Fragment mainFragment = fragmentManager.findFragmentById(R.id.main_fragment);
+            Fragment mainFragment = getFragmentManager().findFragmentById(R.id.main_fragment);
             if (mainFragment instanceof ConversationFragment) {
                 conversationFragment = (ConversationFragment) mainFragment;
             } else {
                 conversationFragment = new ConversationFragment();
-                FragmentTransaction fragmentTransaction = fragmentManager.beginTransaction();
+                FragmentTransaction fragmentTransaction = getFragmentManager().beginTransaction();
                 fragmentTransaction.replace(R.id.main_fragment, conversationFragment);
                 fragmentTransaction.addToBackStack(null);
                 try {
@@ -463,14 +456,6 @@ public class ConversationsActivity extends XmppActivity implements OnConversatio
         }
     }
 
-    private static void executePendingTransactions(final FragmentManager fragmentManager) {
-        try {
-            fragmentManager.executePendingTransactions();
-        } catch (final Exception e) {
-            Log.e(Config.LOGTAG,"unable to execute pending fragment transactions");
-        }
-    }
-
     public boolean onXmppUriClicked(Uri uri) {
         XmppUri xmppUri = new XmppUri(uri);
         if (xmppUri.isValidJid() && !xmppUri.hasFingerprints()) {
@@ -539,7 +524,6 @@ public class ConversationsActivity extends XmppActivity implements OnConversatio
 
     @Override
     protected void onStart() {
-        super.onStart();
         final int theme = findTheme();
         if (this.mTheme != theme) {
             this.mSkipBackgroundBinding = true;
@@ -548,6 +532,7 @@ public class ConversationsActivity extends XmppActivity implements OnConversatio
             this.mSkipBackgroundBinding = false;
         }
         mRedirectInProcess.set(false);
+        super.onStart();
     }
 
     @Override
@@ -577,18 +562,17 @@ public class ConversationsActivity extends XmppActivity implements OnConversatio
     }
 
     private void initializeFragments() {
-        final FragmentManager fragmentManager = getFragmentManager();
+        FragmentTransaction transaction = getFragmentManager().beginTransaction();
-        FragmentTransaction transaction = fragmentManager.beginTransaction();
+        Fragment mainFragment = getFragmentManager().findFragmentById(R.id.main_fragment);
-        final Fragment mainFragment = fragmentManager.findFragmentById(R.id.main_fragment);
+        Fragment secondaryFragment = getFragmentManager().findFragmentById(R.id.secondary_fragment);
-        final Fragment secondaryFragment = fragmentManager.findFragmentById(R.id.secondary_fragment);
         if (mainFragment != null) {
             if (binding.secondaryFragment != null) {
                 if (mainFragment instanceof ConversationFragment) {
                     getFragmentManager().popBackStack();
                     transaction.remove(mainFragment);
                     transaction.commit();
-                    fragmentManager.executePendingTransactions();
+                    getFragmentManager().executePendingTransactions();
-                    transaction = fragmentManager.beginTransaction();
+                    transaction = getFragmentManager().beginTransaction();
                     transaction.replace(R.id.secondary_fragment, mainFragment);
                     transaction.replace(R.id.main_fragment, new ConversationsOverviewFragment());
                     transaction.commit();
@@ -599,7 +583,7 @@ public class ConversationsActivity extends XmppActivity implements OnConversatio
                     transaction.remove(secondaryFragment);
                     transaction.commit();
                     getFragmentManager().executePendingTransactions();
-                    transaction = fragmentManager.beginTransaction();
+                    transaction = getFragmentManager().beginTransaction();
                     transaction.replace(R.id.main_fragment, secondaryFragment);
                     transaction.addToBackStack(null);
                     transaction.commit();
@@ -617,38 +601,18 @@ public class ConversationsActivity extends XmppActivity implements OnConversatio
 
     private void invalidateActionBarTitle() {
         final ActionBar actionBar = getSupportActionBar();
-        if (actionBar == null) {
+        if (actionBar != null) {
-            return;
+            Fragment mainFragment = getFragmentManager().findFragmentById(R.id.main_fragment);
-        }
-        final FragmentManager fragmentManager = getFragmentManager();
-        final Fragment mainFragment = fragmentManager.findFragmentById(R.id.main_fragment);
             if (mainFragment instanceof ConversationFragment) {
                 final Conversation conversation = ((ConversationFragment) mainFragment).getConversation();
                 if (conversation != null) {
                     actionBar.setTitle(EmojiWrapper.transform(conversation.getName()));
                     actionBar.setDisplayHomeAsUpEnabled(true);
-                ActionBarUtil.setActionBarOnClickListener(
-                        binding.toolbar,
-                        (v) -> openConversationDetails(conversation)
-                );
                     return;
                 }
             }
             actionBar.setTitle(R.string.app_name);
             actionBar.setDisplayHomeAsUpEnabled(false);
-        ActionBarUtil.resetActionBarOnClickListeners(binding.toolbar);
-    }
-
-    private void openConversationDetails(final Conversation conversation) {
-        if (conversation.getMode() == Conversational.MODE_MULTI) {
-            ConferenceDetailsActivity.open(this, conversation);
-        } else {
-            final Contact contact = conversation.getContact();
-            if (contact.isSelf()) {
-                switchToAccount(conversation.getAccount());
-            } else {
-                switchToContactDetails(contact);
-            }
         }
     }
 
@@ -657,18 +621,17 @@ public class ConversationsActivity extends XmppActivity implements OnConversatio
         if (performRedirectIfNecessary(conversation, false)) {
             return;
         }
-        final FragmentManager fragmentManager = getFragmentManager();
+        Fragment mainFragment = getFragmentManager().findFragmentById(R.id.main_fragment);
-        final Fragment mainFragment = fragmentManager.findFragmentById(R.id.main_fragment);
         if (mainFragment instanceof ConversationFragment) {
             try {
-                fragmentManager.popBackStack();
+                getFragmentManager().popBackStack();
-            } catch (final IllegalStateException e) {
+            } catch (IllegalStateException e) {
                 Log.w(Config.LOGTAG, "state loss while popping back state after archiving conversation", e);
                 //this usually means activity is no longer active; meaning on the next open we will run through this again
             }
             return;
         }
-        final Fragment secondaryFragment = fragmentManager.findFragmentById(R.id.secondary_fragment);
+        Fragment secondaryFragment = getFragmentManager().findFragmentById(R.id.secondary_fragment);
         if (secondaryFragment instanceof ConversationFragment) {
             if (((ConversationFragment) secondaryFragment).getConversation() == conversation) {
                 Conversation suggestion = ConversationsOverviewFragment.getSuggestion(this, conversation);

src/main/java/eu/siacs/conversations/ui/EditAccountActivity.java

@@ -38,6 +38,7 @@ import com.google.common.base.CharMatcher;
 
 import org.openintents.openpgp.util.OpenPgpUtils;
 
+import java.net.URL;
 import java.util.Arrays;
 import java.util.List;
 import java.util.Set;
@@ -77,7 +78,6 @@ import eu.siacs.conversations.xmpp.XmppConnection;
 import eu.siacs.conversations.xmpp.XmppConnection.Features;
 import eu.siacs.conversations.xmpp.forms.Data;
 import eu.siacs.conversations.xmpp.pep.Avatar;
-import okhttp3.HttpUrl;
 
 public class EditAccountActivity extends OmemoActivity implements OnAccountUpdate, OnUpdateBlocklist,
         OnKeyStatusUpdated, OnCaptchaRequested, KeyChainAliasCallback, XmppConnectionService.OnShowErrorToast, XmppConnectionService.OnMamPreferencesFetched {
@@ -188,7 +188,7 @@ public class EditAccountActivity extends OmemoActivity implements OnAccountUpdat
             final boolean openRegistrationUrl = registerNewAccount && !accountInfoEdited && mAccount != null && mAccount.getStatus() == Account.State.REGISTRATION_WEB;
             final boolean openPaymentUrl = mAccount != null && mAccount.getStatus() == Account.State.PAYMENT_REQUIRED;
             final boolean redirectionWorthyStatus = openPaymentUrl || openRegistrationUrl;
-            final HttpUrl url = connection != null && redirectionWorthyStatus ? connection.getRedirectionUrl() : null;
+            URL url = connection != null && redirectionWorthyStatus ? connection.getRedirectionUrl() : null;
             if (url != null && !wasDisabled) {
                 try {
                     startActivity(new Intent(Intent.ACTION_VIEW, Uri.parse(url.toString())));
@@ -531,7 +531,7 @@ public class EditAccountActivity extends OmemoActivity implements OnAccountUpdat
                     }
                 } else {
                     XmppConnection connection = mAccount == null ? null : mAccount.getXmppConnection();
-                    HttpUrl url = connection != null && mAccount.getStatus() == Account.State.PAYMENT_REQUIRED ? connection.getRedirectionUrl() : null;
+                    URL url = connection != null && mAccount.getStatus() == Account.State.PAYMENT_REQUIRED ? connection.getRedirectionUrl() : null;
                     if (url != null) {
                         this.binding.saveButton.setText(R.string.open_website);
                     } else if (inNeedOfSaslAccept()) {
@@ -542,7 +542,7 @@ public class EditAccountActivity extends OmemoActivity implements OnAccountUpdat
                 }
             } else {
                 XmppConnection connection = mAccount == null ? null : mAccount.getXmppConnection();
-                HttpUrl url = connection != null && mAccount.getStatus() == Account.State.REGISTRATION_WEB ? connection.getRedirectionUrl() : null;
+                URL url = connection != null && mAccount.getStatus() == Account.State.REGISTRATION_WEB ? connection.getRedirectionUrl() : null;
                 if (url != null && this.binding.accountRegisterNew.isChecked() && !accountInfoEdited) {
                     this.binding.saveButton.setText(R.string.open_website);
                 } else {
@@ -736,8 +736,7 @@ public class EditAccountActivity extends OmemoActivity implements OnAccountUpdat
     }
 
     @Override
-    public void onNewIntent(final Intent intent) {
+    public void onNewIntent(Intent intent) {
-        super.onNewIntent(intent);
         if (intent != null && intent.getData() != null) {
             final XmppUri uri = new XmppUri(intent.getData());
             if (xmppConnectionServiceBound) {
@@ -1072,6 +1071,9 @@ public class EditAccountActivity extends OmemoActivity implements OnAccountUpdat
                 } else {
                     this.binding.serverInfoHttpUpload.setText(R.string.server_info_available);
                 }
+            } else if (features.p1S3FileTransfer()) {
+                this.binding.serverInfoHttpUploadDescription.setText(R.string.p1_s3_filetransfer);
+                this.binding.serverInfoHttpUpload.setText(R.string.server_info_available);
             } else {
                 this.binding.serverInfoHttpUpload.setText(R.string.server_info_unavailable);
             }
@@ -1207,7 +1209,7 @@ public class EditAccountActivity extends OmemoActivity implements OnAccountUpdat
         this.binding.osOptimization.setVisibility(showBatteryWarning || showDataSaverWarning ? View.VISIBLE : View.GONE);
         if (showDataSaverWarning && android.os.Build.VERSION.SDK_INT >= android.os.Build.VERSION_CODES.N) {
             this.binding.osOptimizationHeadline.setText(R.string.data_saver_enabled);
-            this.binding.osOptimizationBody.setText(getString(R.string.data_saver_enabled_explained, getString(R.string.app_name)));
+            this.binding.osOptimizationBody.setText(R.string.data_saver_enabled_explained);
             this.binding.osOptimizationDisable.setText(R.string.allow);
             this.binding.osOptimizationDisable.setOnClickListener(v -> {
                 Intent intent = new Intent(Settings.ACTION_IGNORE_BACKGROUND_DATA_RESTRICTIONS_SETTINGS);
@@ -1216,13 +1218,13 @@ public class EditAccountActivity extends OmemoActivity implements OnAccountUpdat
                 try {
                     startActivityForResult(intent, REQUEST_DATA_SAVER);
                 } catch (ActivityNotFoundException e) {
-                    Toast.makeText(EditAccountActivity.this, getString(R.string.device_does_not_support_data_saver, getString(R.string.app_name)), Toast.LENGTH_SHORT).show();
+                    Toast.makeText(EditAccountActivity.this, R.string.device_does_not_support_data_saver, Toast.LENGTH_SHORT).show();
                 }
             });
         } else if (showBatteryWarning && android.os.Build.VERSION.SDK_INT >= android.os.Build.VERSION_CODES.M) {
             this.binding.osOptimizationDisable.setText(R.string.disable);
             this.binding.osOptimizationHeadline.setText(R.string.battery_optimizations_enabled);
-            this.binding.osOptimizationBody.setText(getString(R.string.battery_optimizations_enabled_explained, getString(R.string.app_name)));
+            this.binding.osOptimizationBody.setText(R.string.battery_optimizations_enabled_explained);
             this.binding.osOptimizationDisable.setOnClickListener(v -> {
                 Intent intent = new Intent(Settings.ACTION_REQUEST_IGNORE_BATTERY_OPTIMIZATIONS);
                 Uri uri = Uri.parse("package:" + getPackageName());

src/main/java/eu/siacs/conversations/ui/LocationActivity.java

@@ -31,6 +31,8 @@ import org.osmdroid.views.MapView;
 import org.osmdroid.views.overlay.CopyrightOverlay;
 import org.osmdroid.views.overlay.Overlay;
 
+import java.io.IOException;
+
 import eu.siacs.conversations.BuildConfig;
 import eu.siacs.conversations.Config;
 import eu.siacs.conversations.R;
@@ -39,7 +41,6 @@ import eu.siacs.conversations.services.QuickConversationsService;
 import eu.siacs.conversations.ui.util.LocationHelper;
 import eu.siacs.conversations.ui.widget.Marker;
 import eu.siacs.conversations.ui.widget.MyLocation;
-import eu.siacs.conversations.ui.util.SettingsUtils;
 import eu.siacs.conversations.utils.ThemeHelper;
 
 public abstract class LocationActivity extends ActionBarActivity implements LocationListener {
@@ -69,7 +70,6 @@ public abstract class LocationActivity extends ActionBarActivity implements Loca
 		}
 	}
 
-
 	protected void updateLocationMarkers() {
 		clearMarkers();
 	}
@@ -98,7 +98,11 @@ public abstract class LocationActivity extends ActionBarActivity implements Loca
 		config.load(ctx, getPreferences());
 		config.setUserAgentValue(BuildConfig.APPLICATION_ID + "/" + BuildConfig.VERSION_CODE);
 		if (QuickConversationsService.isConversations() && getBooleanPreference("use_tor", R.bool.use_tor)) {
+			try {
 				config.setHttpProxy(HttpConnectionManager.getProxy());
+			} catch (IOException e) {
+				throw new RuntimeException("Unable to configure proxy");
+			}
 		}
 	}
 
@@ -224,7 +228,6 @@ public abstract class LocationActivity extends ActionBarActivity implements Loca
 	@Override
 	protected void onResume() {
 		super.onResume();
-		SettingsUtils.applyScreenshotPreventionSetting(this);
 		Configuration.getInstance().load(this, getPreferences());
 		map.onResume();
 		this.setMyLoc(null);

src/main/java/eu/siacs/conversations/ui/MemorizingActivity.java

@@ -39,7 +39,6 @@ import java.util.logging.Logger;
 import eu.siacs.conversations.R;
 import eu.siacs.conversations.entities.MTMDecision;
 import eu.siacs.conversations.services.MemorizingTrustManager;
-import eu.siacs.conversations.ui.util.SettingsUtils;
 import eu.siacs.conversations.utils.ThemeHelper;
 
 public class MemorizingActivity extends AppCompatActivity implements OnClickListener, OnCancelListener {
@@ -62,8 +61,6 @@ public class MemorizingActivity extends AppCompatActivity implements OnClickList
 	@Override
 	public void onResume() {
 		super.onResume();
-		SettingsUtils.applyScreenshotPreventionSetting(this);
-
 		Intent i = getIntent();
 		decisionId = i.getIntExtra(MemorizingTrustManager.DECISION_INTENT_ID, MTMDecision.DECISION_INVALID);
 		int titleId = i.getIntExtra(MemorizingTrustManager.DECISION_TITLE_ID, R.string.mtm_accept_cert);

src/main/java/eu/siacs/conversations/ui/PublishProfilePictureActivity.java

@@ -131,7 +131,6 @@ public class PublishProfilePictureActivity extends XmppActivity implements XmppC
 
     @Override
     public void onActivityResult(int requestCode, int resultCode, Intent data) {
-        super.onActivityResult(requestCode, resultCode, data);
         if (requestCode == CropImage.CROP_IMAGE_ACTIVITY_REQUEST_CODE) {
             CropImage.ActivityResult result = CropImage.getActivityResult(data);
             if (resultCode == RESULT_OK) {

src/main/java/eu/siacs/conversations/ui/RecordingActivity.java

@@ -28,7 +28,6 @@ import eu.siacs.conversations.Config;
 import eu.siacs.conversations.R;
 import eu.siacs.conversations.databinding.ActivityRecordingBinding;
 import eu.siacs.conversations.persistance.FileBackend;
-import eu.siacs.conversations.ui.util.SettingsUtils;
 import eu.siacs.conversations.utils.ThemeHelper;
 import eu.siacs.conversations.utils.TimeFrameUtils;
 
@@ -67,12 +66,6 @@ public class RecordingActivity extends Activity implements View.OnClickListener
         getWindow().addFlags(WindowManager.LayoutParams.FLAG_KEEP_SCREEN_ON);
     }
 
-    @Override
-    protected void onResume(){
-        super.onResume();
-        SettingsUtils.applyScreenshotPreventionSetting(this);
-    }
-
     @Override
     protected void onStart() {
         super.onStart();

src/main/java/eu/siacs/conversations/ui/RtpSessionActivity.java

@@ -1,8 +1,5 @@
 package eu.siacs.conversations.ui;
 
-import static java.util.Arrays.asList;
-import static eu.siacs.conversations.utils.PermissionUtils.getFirstDenied;
-
 import android.Manifest;
 import android.annotation.SuppressLint;
 import android.app.PictureInPictureParams;
@@ -17,7 +14,6 @@ import android.os.PowerManager;
 import android.os.SystemClock;
 import android.util.Log;
 import android.util.Rational;
-import android.view.KeyEvent;
 import android.view.Menu;
 import android.view.MenuItem;
 import android.view.View;
@@ -38,7 +34,6 @@ import com.google.common.util.concurrent.FutureCallback;
 import com.google.common.util.concurrent.Futures;
 
 import org.checkerframework.checker.nullness.compatqual.NullableDecl;
-import org.webrtc.RendererCommon;
 import org.webrtc.SurfaceViewRenderer;
 import org.webrtc.VideoTrack;
 
@@ -58,7 +53,6 @@ import eu.siacs.conversations.services.AppRTCAudioManager;
 import eu.siacs.conversations.services.XmppConnectionService;
 import eu.siacs.conversations.ui.util.AvatarWorkerTask;
 import eu.siacs.conversations.ui.util.MainThreadExecutor;
-import eu.siacs.conversations.ui.util.Rationals;
 import eu.siacs.conversations.utils.PermissionUtils;
 import eu.siacs.conversations.utils.TimeFrameUtils;
 import eu.siacs.conversations.xml.Namespace;
@@ -69,7 +63,10 @@ import eu.siacs.conversations.xmpp.jingle.JingleRtpConnection;
 import eu.siacs.conversations.xmpp.jingle.Media;
 import eu.siacs.conversations.xmpp.jingle.RtpEndUserState;
 
-public class RtpSessionActivity extends XmppActivity implements XmppConnectionService.OnJingleRtpConnectionUpdate, eu.siacs.conversations.ui.widget.SurfaceViewRenderer.OnAspectRatioChanged {
+import static eu.siacs.conversations.utils.PermissionUtils.getFirstDenied;
+import static java.util.Arrays.asList;
+
+public class RtpSessionActivity extends XmppActivity implements XmppConnectionService.OnJingleRtpConnectionUpdate {
 
     public static final String EXTRA_WITH = "with";
     public static final String EXTRA_SESSION_ID = "session_id";
@@ -83,7 +80,6 @@ public class RtpSessionActivity extends XmppActivity implements XmppConnectionSe
 
     private static final List<RtpEndUserState> END_CARD = Arrays.asList(
             RtpEndUserState.APPLICATION_ERROR,
-            RtpEndUserState.SECURITY_ERROR,
             RtpEndUserState.DECLINED_OR_BUSY,
             RtpEndUserState.CONNECTIVITY_ERROR,
             RtpEndUserState.CONNECTIVITY_LOST_ERROR,
@@ -91,22 +87,11 @@ public class RtpSessionActivity extends XmppActivity implements XmppConnectionSe
     );
     private static final List<RtpEndUserState> STATES_SHOWING_HELP_BUTTON = Arrays.asList(
             RtpEndUserState.APPLICATION_ERROR,
-            RtpEndUserState.CONNECTIVITY_ERROR,
+            RtpEndUserState.CONNECTIVITY_ERROR
-            RtpEndUserState.SECURITY_ERROR
     );
     private static final List<RtpEndUserState> STATES_SHOWING_SWITCH_TO_CHAT = Arrays.asList(
             RtpEndUserState.CONNECTING,
-            RtpEndUserState.CONNECTED,
+            RtpEndUserState.CONNECTED
-            RtpEndUserState.RECONNECTING
-    );
-    private static final List<RtpEndUserState> STATES_CONSIDERED_CONNECTED = Arrays.asList(
-            RtpEndUserState.CONNECTED,
-            RtpEndUserState.RECONNECTING
-    );
-    private static final List<RtpEndUserState> STATES_SHOWING_PIP_PLACEHOLDER = Arrays.asList(
-            RtpEndUserState.ACCEPTING_CALL,
-            RtpEndUserState.CONNECTING,
-            RtpEndUserState.RECONNECTING
     );
     private static final String PROXIMITY_WAKE_LOCK_TAG = "conversations:in-rtp-session";
     private static final int REQUEST_ACCEPT_CALL = 0x1111;
@@ -161,18 +146,6 @@ public class RtpSessionActivity extends XmppActivity implements XmppConnectionSe
         return super.onCreateOptionsMenu(menu);
     }
 
-    @Override
-    public boolean onKeyDown(final int keyCode, final KeyEvent event) {
-        if (keyCode == KeyEvent.KEYCODE_VOLUME_DOWN) {
-            if (xmppConnectionService != null) {
-                if (xmppConnectionService.getNotificationService().stopSoundAndVibration()) {
-                    return true;
-                }
-            }
-        }
-        return super.onKeyDown(keyCode, event);
-    }
-
     private boolean isHelpButtonVisible() {
         try {
             return STATES_SHOWING_HELP_BUTTON.contains(requireRtpConnection().getEndUserState());
@@ -403,7 +376,6 @@ public class RtpSessionActivity extends XmppActivity implements XmppConnectionSe
             if (state != null) {
                 Log.d(Config.LOGTAG, "restored last state from intent extra");
                 updateButtonConfiguration(state);
-                updateVerifiedShield(false);
                 updateStateDisplay(state);
                 updateProfilePicture(state);
                 invalidateOptionsMenu();
@@ -449,7 +421,7 @@ public class RtpSessionActivity extends XmppActivity implements XmppConnectionSe
             } else {
                 throw new IllegalStateException("Invalid permission result request");
             }
-            Toast.makeText(this, getString(res, getString(R.string.app_name)), Toast.LENGTH_SHORT).show();
+            Toast.makeText(this, res, Toast.LENGTH_SHORT).show();
         }
     }
 
@@ -457,14 +429,12 @@ public class RtpSessionActivity extends XmppActivity implements XmppConnectionSe
     public void onStart() {
         super.onStart();
         mHandler.postDelayed(mTickExecutor, CALL_DURATION_UPDATE_INTERVAL);
-        this.binding.remoteVideo.setOnAspectRatioChanged(this);
     }
 
     @Override
     public void onStop() {
         mHandler.removeCallbacks(mTickExecutor);
         binding.remoteVideo.release();
-        binding.remoteVideo.setOnAspectRatioChanged(null);
         binding.localVideo.release();
         final WeakReference<JingleRtpConnection> weakReference = this.rtpConnectionReference;
         final JingleRtpConnection jingleRtpConnection = weakReference == null ? null : weakReference.get();
@@ -505,14 +475,15 @@ public class RtpSessionActivity extends XmppActivity implements XmppConnectionSe
             return;
         }
         //TODO apparently this method is not getting called on Android 10 when using the task switcher
-        if (emptyReference(rtpConnectionReference) && xmppConnectionService != null) {
+        final boolean emptyReference = rtpConnectionReference == null || rtpConnectionReference.get() == null;
+        if (emptyReference && xmppConnectionService != null) {
             retractSessionProposal();
         }
     }
 
     private boolean isConnected() {
         final JingleRtpConnection connection = this.rtpConnectionReference != null ? this.rtpConnectionReference.get() : null;
-        return connection != null && STATES_CONSIDERED_CONNECTED.contains(connection.getEndUserState());
+        return connection != null && connection.getEndUserState() == RtpEndUserState.CONNECTED;
     }
 
     private boolean switchToPictureInPicture() {
@@ -528,12 +499,9 @@ public class RtpSessionActivity extends XmppActivity implements XmppConnectionSe
     @RequiresApi(api = Build.VERSION_CODES.O)
     private void startPictureInPicture() {
         try {
-            final Rational rational = this.binding.remoteVideo.getAspectRatio();
-            final Rational clippedRational = Rationals.clip(rational);
-            Log.d(Config.LOGTAG, "suggested rational " + rational + ". clipped to " + clippedRational);
             enterPictureInPictureMode(
                     new PictureInPictureParams.Builder()
-                            .setAspectRatio(clippedRational)
+                            .setAspectRatio(new Rational(10, 16))
                             .build()
             );
         } catch (final IllegalStateException e) {
@@ -542,17 +510,6 @@ public class RtpSessionActivity extends XmppActivity implements XmppConnectionSe
         }
     }
 
-    @Override
-    public void onAspectRatioChanged(final Rational rational) {
-        if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.O && isPictureInPicture()) {
-            final Rational clippedRational = Rationals.clip(rational);
-            Log.d(Config.LOGTAG, "suggested rational after aspect ratio change " + rational + ". clipped to " + clippedRational);
-            setPictureInPictureParams(new PictureInPictureParams.Builder()
-                    .setAspectRatio(clippedRational)
-                    .build());
-        }
-    }
-
     private boolean deviceSupportsPictureInPicture() {
         if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.N) {
             return getPackageManager().hasSystemFeature(PackageManager.FEATURE_PICTURE_IN_PICTURE);
@@ -588,7 +545,6 @@ public class RtpSessionActivity extends XmppActivity implements XmppConnectionSe
         }
         this.rtpConnectionReference = reference;
         final RtpEndUserState currentState = requireRtpConnection().getEndUserState();
-        final boolean verified = requireRtpConnection().isVerified();
         if (currentState == RtpEndUserState.ENDED) {
             reference.get().throwStateTransitionException();
             finish();
@@ -604,7 +560,6 @@ public class RtpSessionActivity extends XmppActivity implements XmppConnectionSe
         binding.with.setText(getWith().getDisplayName());
         updateVideoViews(currentState);
         updateStateDisplay(currentState, media);
-        updateVerifiedShield(verified && STATES_SHOWING_SWITCH_TO_CHAT.contains(currentState));
         updateButtonConfiguration(currentState, media);
         updateProfilePicture(currentState);
         invalidateOptionsMenu();
@@ -623,7 +578,6 @@ public class RtpSessionActivity extends XmppActivity implements XmppConnectionSe
         updateStateDisplay(state);
         updateProfilePicture(state);
         updateCallDuration();
-        updateVerifiedShield(false);
         invalidateOptionsMenu();
         binding.with.setText(account.getRoster().getContact(with).getDisplayName());
     }
@@ -645,8 +599,8 @@ public class RtpSessionActivity extends XmppActivity implements XmppConnectionSe
         surfaceViewRenderer.setVisibility(View.VISIBLE);
         try {
             surfaceViewRenderer.init(requireRtpConnection().getEglBaseContext(), null);
-        } catch (final IllegalStateException e) {
+        } catch (IllegalStateException e) {
-            //Log.d(Config.LOGTAG, "SurfaceViewRenderer was already initialized");
+            Log.d(Config.LOGTAG, "SurfaceViewRenderer was already initialized");
         }
         surfaceViewRenderer.setEnableHardwareScaler(true);
     }
@@ -671,9 +625,6 @@ public class RtpSessionActivity extends XmppActivity implements XmppConnectionSe
             case CONNECTED:
                 setTitle(R.string.rtp_state_connected);
                 break;
-            case RECONNECTING:
-                setTitle(R.string.rtp_state_reconnecting);
-                break;
             case ACCEPTING_CALL:
                 setTitle(R.string.rtp_state_accepting_call);
                 break;
@@ -701,9 +652,6 @@ public class RtpSessionActivity extends XmppActivity implements XmppConnectionSe
             case APPLICATION_ERROR:
                 setTitle(R.string.rtp_state_application_failure);
                 break;
-            case SECURITY_ERROR:
-                setTitle(R.string.rtp_state_security_error);
-                break;
             case ENDED:
                 throw new IllegalStateException("Activity should have called finishAndReleaseWakeLock();");
             default:
@@ -711,14 +659,6 @@ public class RtpSessionActivity extends XmppActivity implements XmppConnectionSe
         }
     }
 
-    private void updateVerifiedShield(final boolean verified) {
-        if (isPictureInPicture()) {
-            this.binding.verified.setVisibility(View.GONE);
-            return;
-        }
-        this.binding.verified.setVisibility(verified ? View.VISIBLE : View.GONE);
-    }
-
     private void updateProfilePicture(final RtpEndUserState state) {
         updateProfilePicture(state, null);
     }
@@ -779,8 +719,7 @@ public class RtpSessionActivity extends XmppActivity implements XmppConnectionSe
                 RtpEndUserState.CONNECTIVITY_ERROR,
                 RtpEndUserState.CONNECTIVITY_LOST_ERROR,
                 RtpEndUserState.APPLICATION_ERROR,
-                RtpEndUserState.RETRACTED,
+                RtpEndUserState.RETRACTED
-                RtpEndUserState.SECURITY_ERROR
         ).contains(state)) {
             this.binding.rejectCall.setContentDescription(getString(R.string.exit));
             this.binding.rejectCall.setOnClickListener(this::exit);
@@ -816,7 +755,7 @@ public class RtpSessionActivity extends XmppActivity implements XmppConnectionSe
 
     @SuppressLint("RestrictedApi")
     private void updateInCallButtonConfiguration(final RtpEndUserState state, final Set<Media> media) {
-        if (STATES_CONSIDERED_CONNECTED.contains(state) && !isPictureInPicture()) {
+        if (state == RtpEndUserState.CONNECTED && !isPictureInPicture()) {
             Preconditions.checkArgument(media.size() > 0, "Media must not be empty");
             if (media.contains(Media.VIDEO)) {
                 final JingleRtpConnection rtpConnection = requireRtpConnection();
@@ -911,12 +850,7 @@ public class RtpSessionActivity extends XmppActivity implements XmppConnectionSe
     }
 
     private void enableVideo(View view) {
-        try {
         requireRtpConnection().setVideoEnabled(true);
-        } catch (final IllegalStateException e) {
-            Toast.makeText(this, R.string.unable_to_enable_video, Toast.LENGTH_SHORT).show();
-            return;
-        }
         updateInCallButtonConfigurationVideo(true, requireRtpConnection().isCameraSwitchable());
     }
 
@@ -944,11 +878,14 @@ public class RtpSessionActivity extends XmppActivity implements XmppConnectionSe
             this.binding.duration.setVisibility(View.GONE);
             return;
         }
-        if (connection.zeroDuration()) {
+        final long rtpConnectionStarted = connection.getRtpConnectionStarted();
-            this.binding.duration.setVisibility(View.GONE);
+        final long rtpConnectionEnded = connection.getRtpConnectionEnded();
-        } else {
+        if (rtpConnectionStarted != 0) {
-            this.binding.duration.setText(TimeFrameUtils.formatElapsedTime(connection.getCallDuration(), false));
+            final long ended = rtpConnectionEnded == 0 ? SystemClock.elapsedRealtime() : rtpConnectionEnded;
+            this.binding.duration.setText(TimeFrameUtils.formatTimePassed(rtpConnectionStarted, ended, false));
             this.binding.duration.setVisibility(View.VISIBLE);
+        } else {
+            this.binding.duration.setVisibility(View.GONE);
         }
     }
 
@@ -956,17 +893,13 @@ public class RtpSessionActivity extends XmppActivity implements XmppConnectionSe
         if (END_CARD.contains(state) || state == RtpEndUserState.ENDING_CALL) {
             binding.localVideo.setVisibility(View.GONE);
             binding.localVideo.release();
-            binding.remoteVideoWrapper.setVisibility(View.GONE);
+            binding.remoteVideo.setVisibility(View.GONE);
             binding.remoteVideo.release();
             binding.pipLocalMicOffIndicator.setVisibility(View.GONE);
             if (isPictureInPicture()) {
                 binding.appBarLayout.setVisibility(View.GONE);
                 binding.pipPlaceholder.setVisibility(View.VISIBLE);
-                if (Arrays.asList(
+                if (state == RtpEndUserState.APPLICATION_ERROR || state == RtpEndUserState.CONNECTIVITY_ERROR) {
-                        RtpEndUserState.APPLICATION_ERROR,
-                        RtpEndUserState.CONNECTIVITY_ERROR,
-                        RtpEndUserState.SECURITY_ERROR)
-                        .contains(state)) {
                     binding.pipWarning.setVisibility(View.VISIBLE);
                     binding.pipWaiting.setVisibility(View.GONE);
                 } else {
@@ -980,9 +913,9 @@ public class RtpSessionActivity extends XmppActivity implements XmppConnectionSe
             getWindow().clearFlags(WindowManager.LayoutParams.FLAG_FULLSCREEN);
             return;
         }
-        if (isPictureInPicture() && STATES_SHOWING_PIP_PLACEHOLDER.contains(state)) {
+        if (isPictureInPicture() && (state == RtpEndUserState.CONNECTING || state == RtpEndUserState.ACCEPTING_CALL)) {
             binding.localVideo.setVisibility(View.GONE);
-            binding.remoteVideoWrapper.setVisibility(View.GONE);
+            binding.remoteVideo.setVisibility(View.GONE);
             binding.appBarLayout.setVisibility(View.GONE);
             binding.pipPlaceholder.setVisibility(View.VISIBLE);
             binding.pipWarning.setVisibility(View.GONE);
@@ -1004,18 +937,12 @@ public class RtpSessionActivity extends XmppActivity implements XmppConnectionSe
         if (remoteVideoTrack.isPresent()) {
             ensureSurfaceViewRendererIsSetup(binding.remoteVideo);
             addSink(remoteVideoTrack.get(), binding.remoteVideo);
-            binding.remoteVideo.setScalingType(
-                    RendererCommon.ScalingType.SCALE_ASPECT_FILL,
-                    RendererCommon.ScalingType.SCALE_ASPECT_FIT
-            );
             if (state == RtpEndUserState.CONNECTED) {
                 binding.appBarLayout.setVisibility(View.GONE);
                 getWindow().addFlags(WindowManager.LayoutParams.FLAG_FULLSCREEN);
-                binding.remoteVideoWrapper.setVisibility(View.VISIBLE);
             } else {
-                binding.appBarLayout.setVisibility(View.VISIBLE);
                 getWindow().clearFlags(WindowManager.LayoutParams.FLAG_FULLSCREEN);
-                binding.remoteVideoWrapper.setVisibility(View.GONE);
+                binding.remoteVideo.setVisibility(View.GONE);
             }
             if (isPictureInPicture() && !requireRtpConnection().isMicrophoneEnabled()) {
                 binding.pipLocalMicOffIndicator.setVisibility(View.VISIBLE);
@@ -1024,7 +951,7 @@ public class RtpSessionActivity extends XmppActivity implements XmppConnectionSe
             }
         } else {
             getWindow().clearFlags(WindowManager.LayoutParams.FLAG_FULLSCREEN);
-            binding.remoteVideoWrapper.setVisibility(View.GONE);
+            binding.remoteVideo.setVisibility(View.GONE);
             binding.pipLocalMicOffIndicator.setVisibility(View.GONE);
         }
     }
@@ -1125,7 +1052,7 @@ public class RtpSessionActivity extends XmppActivity implements XmppConnectionSe
             updateRtpSessionProposalState(account, with, state);
             return;
         }
-        if (emptyReference(this.rtpConnectionReference)) {
+        if (this.rtpConnectionReference == null) {
             if (END_CARD.contains(state)) {
                 Log.d(Config.LOGTAG, "not reinitializing session");
                 return;
@@ -1135,7 +1062,6 @@ public class RtpSessionActivity extends XmppActivity implements XmppConnectionSe
             return;
         }
         final AbstractJingleConnection.Id id = requireRtpConnection().getId();
-        final boolean verified = requireRtpConnection().isVerified();
         final Set<Media> media = getMedia();
         final Contact contact = getWith();
         if (account == id.account && id.with.equals(with) && id.sessionId.equals(sessionId)) {
@@ -1145,7 +1071,6 @@ public class RtpSessionActivity extends XmppActivity implements XmppConnectionSe
             }
             runOnUiThread(() -> {
                 updateStateDisplay(state, media);
-                updateVerifiedShield(verified && STATES_SHOWING_SWITCH_TO_CHAT.contains(state));
                 updateButtonConfiguration(state, media);
                 updateVideoViews(state);
                 updateProfilePicture(state, contact);
@@ -1195,7 +1120,6 @@ public class RtpSessionActivity extends XmppActivity implements XmppConnectionSe
         }
         if (Jid.ofEscaped(withExtra).asBareJid().equals(with)) {
             runOnUiThread(() -> {
-                updateVerifiedShield(false);
                 updateStateDisplay(state);
                 updateButtonConfiguration(state);
                 updateProfilePicture(state);
@@ -1223,8 +1147,4 @@ public class RtpSessionActivity extends XmppActivity implements XmppConnectionSe
         intent.putExtra(EXTRA_LAST_ACTION, media.contains(Media.VIDEO) ? ACTION_MAKE_VIDEO_CALL : ACTION_MAKE_VOICE_CALL);
         setIntent(intent);
     }
-
-    private static boolean emptyReference(final WeakReference<?> weakReference) {
-        return weakReference == null || weakReference.get() == null;
-    }
 }

src/main/java/eu/siacs/conversations/ui/ScanActivity.java

@@ -60,7 +60,6 @@ import java.util.Map;
 import eu.siacs.conversations.Config;
 import eu.siacs.conversations.R;
 import eu.siacs.conversations.ui.service.CameraManager;
-import eu.siacs.conversations.ui.util.SettingsUtils;
 import eu.siacs.conversations.ui.widget.ScannerView;
 
 /**
@@ -182,7 +181,6 @@ public final class ScanActivity extends Activity implements SurfaceTextureListen
 	@Override
 	protected void onResume() {
 		super.onResume();
-		SettingsUtils.applyScreenshotPreventionSetting(this);
 		maybeOpenCamera();
 	}
 

src/main/java/eu/siacs/conversations/ui/SettingsActivity.java

@@ -40,7 +40,6 @@ import eu.siacs.conversations.services.MemorizingTrustManager;
 import eu.siacs.conversations.services.QuickConversationsService;
 import eu.siacs.conversations.ui.util.StyledAttributes;
 import eu.siacs.conversations.utils.GeoHelper;
-import eu.siacs.conversations.ui.util.SettingsUtils;
 import eu.siacs.conversations.utils.TimeFrameUtils;
 import eu.siacs.conversations.xmpp.Jid;
 
@@ -58,10 +57,8 @@ public class SettingsActivity extends XmppActivity implements
 	public static final String THEME = "theme";
 	public static final String SHOW_DYNAMIC_TAGS = "show_dynamic_tags";
 	public static final String OMEMO_SETTING = "omemo";
-	public static final String PREVENT_SCREENSHOTS = "prevent_screenshots";
 
 	public static final int REQUEST_CREATE_BACKUP = 0xbf8701;
-
 	private SettingsFragment mSettingsFragment;
 
 	@Override
@@ -396,15 +393,8 @@ public class SettingsActivity extends XmppActivity implements
 			if (this.mTheme != theme) {
 				recreate();
 			}
-		} else if(name.equals(PREVENT_SCREENSHOTS)){
-			SettingsUtils.applyScreenshotPreventionSetting(this);
-		}
 		}
 
-	@Override
-	public void onResume(){
-		super.onResume();
-		SettingsUtils.applyScreenshotPreventionSetting(this);
 	}
 
 	@Override
@@ -415,16 +405,12 @@ public class SettingsActivity extends XmppActivity implements
 					createBackup();
 				}
 			} else {
-				Toast.makeText(this, getString(R.string.no_storage_permission, getString(R.string.app_name)), Toast.LENGTH_SHORT).show();
+				Toast.makeText(this, R.string.no_storage_permission, Toast.LENGTH_SHORT).show();
 			}
 	}
 
 	private void createBackup() {
 		ContextCompat.startForegroundService(this, new Intent(this, ExportBackupService.class));
-		final AlertDialog.Builder builder = new AlertDialog.Builder(this);
-		builder.setMessage(R.string.backup_started_message);
-		builder.setPositiveButton(R.string.ok, null);
-		builder.create().show();
 	}
 
 	private void displayToast(final String msg) {

src/main/java/eu/siacs/conversations/ui/ShareLocationActivity.java

@@ -13,13 +13,10 @@ import androidx.annotation.NonNull;
 import androidx.databinding.DataBindingUtil;
 
 import com.google.android.material.snackbar.Snackbar;
-import com.google.common.math.DoubleMath;
 
 import org.osmdroid.api.IGeoPoint;
 import org.osmdroid.util.GeoPoint;
 
-import java.math.RoundingMode;
-
 import eu.siacs.conversations.Config;
 import eu.siacs.conversations.R;
 import eu.siacs.conversations.databinding.ActivityShareLocationBinding;
@@ -79,7 +76,23 @@ public class ShareLocationActivity extends LocationActivity implements LocationL
 		});
 		ThemeHelper.fix(this.snackBar);
 
-        this.binding.shareButton.setOnClickListener(this::shareLocation);
+		this.binding.shareButton.setOnClickListener(view -> {
+			final Intent result = new Intent();
+
+			if (marker_fixed_to_loc && myLoc != null) {
+				result.putExtra("latitude", myLoc.getLatitude());
+				result.putExtra("longitude", myLoc.getLongitude());
+				result.putExtra("altitude", myLoc.getAltitude());
+				result.putExtra("accuracy", (int) myLoc.getAccuracy());
+			} else {
+				final IGeoPoint markerPoint = this.binding.map.getMapCenter();
+				result.putExtra("latitude", markerPoint.getLatitude());
+				result.putExtra("longitude", markerPoint.getLongitude());
+			}
+
+			setResult(RESULT_OK, result);
+			finish();
+		});
 
 		this.marker_fixed_to_loc = isLocationEnabledAndAllowed();
 
@@ -95,22 +108,6 @@ public class ShareLocationActivity extends LocationActivity implements LocationL
 		});
 	}
 
-    private void shareLocation(final View view) {
-        final Intent result = new Intent();
-        if (marker_fixed_to_loc && myLoc != null) {
-            result.putExtra("latitude", myLoc.getLatitude());
-            result.putExtra("longitude", myLoc.getLongitude());
-            result.putExtra("altitude", myLoc.getAltitude());
-            result.putExtra("accuracy", DoubleMath.roundToInt(myLoc.getAccuracy(), RoundingMode.HALF_UP));
-        } else {
-            final IGeoPoint markerPoint = this.binding.map.getMapCenter();
-            result.putExtra("latitude", markerPoint.getLatitude());
-            result.putExtra("longitude", markerPoint.getLongitude());
-        }
-        setResult(RESULT_OK, result);
-        finish();
-    }
-
 	@Override
 	public void onRequestPermissionsResult(final int requestCode,
 										   @NonNull final String[] permissions,

src/main/java/eu/siacs/conversations/ui/ShareWithActivity.java

@@ -33,8 +33,7 @@ public class ShareWithActivity extends XmppActivity implements XmppConnectionSer
         refreshUi();
     }
 
-    private static class Share {
+    private class Share {
-        public String type;
         ArrayList<Uri> uris = new ArrayList<>();
         public String account;
         public String contact;
@@ -66,7 +65,6 @@ public class ShareWithActivity extends XmppActivity implements XmppConnectionSer
 
     @Override
     public void onRequestPermissionsResult(int requestCode, String[] permissions, int[] grantResults) {
-        super.onRequestPermissionsResult(requestCode, permissions, grantResults);
         if (grantResults.length > 0)
             if (grantResults[0] == PackageManager.PERMISSION_GRANTED) {
                 if (requestCode == REQUEST_STORAGE_PERMISSION) {
@@ -77,7 +75,7 @@ public class ShareWithActivity extends XmppActivity implements XmppConnectionSer
                     }
                 }
             } else {
-                Toast.makeText(this, getString(R.string.no_storage_permission, getString(R.string.app_name)), Toast.LENGTH_SHORT).show();
+                Toast.makeText(this, R.string.no_storage_permission, Toast.LENGTH_SHORT).show();
             }
     }
 
@@ -141,7 +139,6 @@ public class ShareWithActivity extends XmppActivity implements XmppConnectionSer
             } else if (type != null && uri != null) {
                 this.share.uris.clear();
                 this.share.uris.add(uri);
-                this.share.type = type;
             } else {
                 this.share.text = text;
                 this.share.asQuote = asQuote;
@@ -196,9 +193,6 @@ public class ShareWithActivity extends XmppActivity implements XmppConnectionSer
             intent.setAction(Intent.ACTION_SEND_MULTIPLE);
             intent.putParcelableArrayListExtra(Intent.EXTRA_STREAM, share.uris);
             intent.addFlags(Intent.FLAG_GRANT_READ_URI_PERMISSION);
-            if (share.type != null) {
-                intent.putExtra(ConversationsActivity.EXTRA_TYPE, share.type);
-            }
         } else if (share.text != null) {
             intent.setAction(ConversationsActivity.ACTION_VIEW_CONVERSATION);
             intent.putExtra(Intent.EXTRA_TEXT, share.text);

src/main/java/eu/siacs/conversations/ui/StartConversationActivity.java

@@ -37,14 +37,10 @@ import android.widget.Spinner;
 import android.widget.TextView;
 import android.widget.Toast;
 
-import androidx.annotation.MenuRes;
 import androidx.annotation.NonNull;
 import androidx.annotation.Nullable;
-import androidx.annotation.StringRes;
 import androidx.appcompat.app.ActionBar;
 import androidx.appcompat.app.AlertDialog;
-import androidx.appcompat.widget.PopupMenu;
-import androidx.core.content.ContextCompat;
 import androidx.databinding.DataBindingUtil;
 import androidx.fragment.app.Fragment;
 import androidx.fragment.app.FragmentManager;
@@ -54,8 +50,6 @@ import androidx.viewpager.widget.PagerAdapter;
 import androidx.viewpager.widget.ViewPager;
 
 import com.google.android.material.textfield.TextInputLayout;
-import com.leinardi.android.speeddial.SpeedDialActionItem;
-import com.leinardi.android.speeddial.SpeedDialView;
 
 import java.util.ArrayList;
 import java.util.Collections;
@@ -271,7 +265,8 @@ public class StartConversationActivity extends XmppActivity implements XmppConne
 		setSupportActionBar(binding.toolbar);
 		configureActionBar(getSupportActionBar());
 
-        inflateFab(binding.speedDial, R.menu.start_conversation_fab_submenu);
+		binding.speedDial.inflate(R.menu.start_conversation_fab_submenu);
+
 		binding.tabLayout.setupWithViewPager(binding.startConversationViewPager);
 		binding.startConversationViewPager.addOnPageChangeListener(new ViewPager.SimpleOnPageChangeListener() {
 			@Override
@@ -342,21 +337,6 @@ public class StartConversationActivity extends XmppActivity implements XmppConne
 		});
 	}
 
-    private void inflateFab(final SpeedDialView speedDialView, final @MenuRes int menuRes) {
-        speedDialView.clearActionItems();
-        final PopupMenu popupMenu = new PopupMenu(this, new View(this));
-        popupMenu.inflate(menuRes);
-        final Menu menu = popupMenu.getMenu();
-        for (int i = 0; i < menu.size(); i++) {
-            final MenuItem menuItem = menu.getItem(i);
-            final SpeedDialActionItem actionItem = new SpeedDialActionItem.Builder(menuItem.getItemId(), menuItem.getIcon())
-                    .setLabel(menuItem.getTitle() != null ? menuItem.getTitle().toString() : null)
-                    .setFabImageTintColor(ContextCompat.getColor(this, R.color.white))
-                    .create();
-            speedDialView.addActionItem(actionItem);
-        }
-    }
-
 	public static boolean isValidJid(String input) {
 		try {
 			Jid jid = Jid.ofEscaped(input);
@@ -545,8 +525,7 @@ public class StartConversationActivity extends XmppActivity implements XmppConne
 			} else if (contact.showInRoster()) {
 				throw new EnterJidDialog.JidError(getString(R.string.contact_already_exists));
 			} else {
-                final String preAuth = invite == null ? null : invite.getParameter(XmppUri.PARAMETER_PRE_AUTH);
+				xmppConnectionService.createContact(contact, true);
-                xmppConnectionService.createContact(contact, true, preAuth);
 				if (invite != null && invite.hasFingerprints()) {
 					xmppConnectionService.verifyFingerprints(contact, invite.getFingerprints());
 				}
@@ -752,35 +731,19 @@ public class StartConversationActivity extends XmppActivity implements XmppConne
 		if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.M) {
 			if (checkSelfPermission(Manifest.permission.READ_CONTACTS) != PackageManager.PERMISSION_GRANTED) {
 				if (mRequestedContactsPermission.compareAndSet(false, true)) {
-                    if (QuickConversationsService.isQuicksy() || shouldShowRequestPermissionRationale(Manifest.permission.READ_CONTACTS)) {
+					if (shouldShowRequestPermissionRationale(Manifest.permission.READ_CONTACTS)) {
-                        final AlertDialog.Builder builder = new AlertDialog.Builder(this);
+						AlertDialog.Builder builder = new AlertDialog.Builder(this);
-                        final AtomicBoolean requestPermission = new AtomicBoolean(false);
 						builder.setTitle(R.string.sync_with_contacts);
 						if (QuickConversationsService.isQuicksy()) {
 							builder.setMessage(Html.fromHtml(getString(R.string.sync_with_contacts_quicksy)));
                         } else {
-                            builder.setMessage(getString(R.string.sync_with_contacts_long, getString(R.string.app_name)));
+                            builder.setMessage(R.string.sync_with_contacts_long);
                         }
-                        @StringRes int confirmButtonText;
+						builder.setPositiveButton(R.string.next, (dialog, which) -> requestPermissions(new String[]{Manifest.permission.READ_CONTACTS}, REQUEST_SYNC_CONTACTS));
-                        if (QuickConversationsService.isConversations()) {
+						builder.setOnDismissListener(dialog -> requestPermissions(new String[]{Manifest.permission.READ_CONTACTS}, REQUEST_SYNC_CONTACTS));
-                            confirmButtonText = R.string.next;
+						builder.setCancelable(false);
-                        } else {
+						AlertDialog dialog = builder.create();
-                            confirmButtonText = R.string.confirm;
+						dialog.setCanceledOnTouchOutside(false);
-                        }
-                        builder.setPositiveButton(confirmButtonText, (dialog, which) -> {
-                            if (requestPermission.compareAndSet(false, true)) {
-                                requestPermissions(new String[]{Manifest.permission.READ_CONTACTS}, REQUEST_SYNC_CONTACTS);
-                            }
-                        });
-                        builder.setOnDismissListener(dialog -> {
-                            if (QuickConversationsService.isConversations() && requestPermission.compareAndSet(false, true)) {
-                                requestPermissions(new String[]{Manifest.permission.READ_CONTACTS}, REQUEST_SYNC_CONTACTS);
-
-                            }
-                        });
-                        builder.setCancelable(QuickConversationsService.isQuicksy());
-                        final AlertDialog dialog = builder.create();
-                        dialog.setCanceledOnTouchOutside(QuickConversationsService.isQuicksy());
 						dialog.setOnShowListener(dialogInterface -> {
 							final TextView tv =  dialog.findViewById(android.R.id.message);
 							if (tv != null) {

src/main/java/eu/siacs/conversations/ui/TrustKeysActivity.java

@@ -237,7 +237,7 @@ public class TrustKeysActivity extends OmemoActivity implements OnKeyStatusUpdat
 				}
 				this.binding.keyErrorHintMutual.setVisibility(anyWithoutMutualPresenceSubscription ? View.VISIBLE : View.GONE);
 				Contact contact = mAccount.getRoster().getContact(contactJids.get(0));
-				binding.keyErrorGeneral.setText(getString(R.string.error_trustkey_general, getString(R.string.app_name), contact.getDisplayName()));
+				binding.keyErrorGeneral.setText(getString(R.string.error_trustkey_general, contact.getDisplayName()));
 				binding.ownKeysDetails.removeAllViews();
 				if (OmemoSetting.isAlways()) {
 					binding.disableButton.setVisibility(View.GONE);

src/main/java/eu/siacs/conversations/ui/UriHandlerActivity.java

@@ -7,39 +7,24 @@ import android.content.pm.PackageManager;
 import android.net.Uri;
 import android.os.Build;
 import android.os.Bundle;
-import android.util.Log;
-import android.view.View;
 import android.widget.Toast;
 
-import androidx.annotation.StringRes;
 import androidx.appcompat.app.AppCompatActivity;
 import androidx.core.content.ContextCompat;
-import androidx.databinding.DataBindingUtil;
 
 import com.google.common.base.Strings;
 
-import org.jetbrains.annotations.NotNull;
-
-import java.io.IOException;
 import java.util.List;
 import java.util.regex.Matcher;
 import java.util.regex.Pattern;
 
-import eu.siacs.conversations.Config;
 import eu.siacs.conversations.R;
-import eu.siacs.conversations.databinding.ActivityUriHandlerBinding;
-import eu.siacs.conversations.http.HttpConnectionManager;
 import eu.siacs.conversations.persistance.DatabaseBackend;
 import eu.siacs.conversations.services.QuickConversationsService;
 import eu.siacs.conversations.utils.ProvisioningUtils;
 import eu.siacs.conversations.utils.SignupUtils;
 import eu.siacs.conversations.utils.XmppUri;
 import eu.siacs.conversations.xmpp.Jid;
-import okhttp3.Call;
-import okhttp3.Callback;
-import okhttp3.HttpUrl;
-import okhttp3.Request;
-import okhttp3.Response;
 
 public class UriHandlerActivity extends AppCompatActivity {
 
@@ -49,9 +34,7 @@ public class UriHandlerActivity extends AppCompatActivity {
     private static final int REQUEST_CAMERA_PERMISSIONS_TO_SCAN = 0x6789;
     private static final int REQUEST_CAMERA_PERMISSIONS_TO_SCAN_AND_PROVISION = 0x6790;
     private static final Pattern V_CARD_XMPP_PATTERN = Pattern.compile("\nIMPP([^:]*):(xmpp:.+)\n");
-    private static final Pattern LINK_HEADER_PATTERN = Pattern.compile("<(.*?)>");
+    private boolean handled = false;
-    private ActivityUriHandlerBinding binding;
-    private Call call;
 
     public static void scan(final Activity activity) {
         scan(activity, false);
@@ -94,7 +77,9 @@ public class UriHandlerActivity extends AppCompatActivity {
     @Override
     protected void onCreate(Bundle savedInstanceState) {
         super.onCreate(savedInstanceState);
-        this.binding = DataBindingUtil.setContentView(this, R.layout.activity_uri_handler);
+        this.handled = savedInstanceState != null && savedInstanceState.getBoolean("handled", false);
+        getLayoutInflater().inflate(R.layout.toolbar, findViewById(android.R.id.content));
+        setSupportActionBar(findViewById(R.id.toolbar));
     }
 
     @Override
@@ -104,16 +89,21 @@ public class UriHandlerActivity extends AppCompatActivity {
     }
 
     @Override
-    public void onNewIntent(final Intent intent) {
+    public void onSaveInstanceState(Bundle savedInstanceState) {
-        super.onNewIntent(intent);
+        savedInstanceState.putBoolean("handled", this.handled);
+        super.onSaveInstanceState(savedInstanceState);
+    }
+
+    @Override
+    public void onNewIntent(Intent intent) {
         handleIntent(intent);
     }
 
-    private boolean handleUri(final Uri uri) {
+    private void handleUri(Uri uri) {
-        return handleUri(uri, false);
+        handleUri(uri, false);
     }
 
-    private boolean handleUri(final Uri uri, final boolean scanned) {
+    private void handleUri(Uri uri, final boolean scanned) {
         final Intent intent;
         final XmppUri xmppUri = new XmppUri(uri);
         final List<Jid> accounts = DatabaseBackend.getInstance(this).getAccountJids(true);
@@ -123,22 +113,19 @@ public class UriHandlerActivity extends AppCompatActivity {
             final Jid jid = xmppUri.getJid();
             if (xmppUri.isAction(XmppUri.ACTION_REGISTER)) {
                 if (jid.getEscapedLocal() != null && accounts.contains(jid.asBareJid())) {
-                    showError(R.string.account_already_exists);
+                    Toast.makeText(this, R.string.account_already_exists, Toast.LENGTH_LONG).show();
-                    return false;
+                    return;
                 }
                 intent = SignupUtils.getTokenRegistrationIntent(this, jid, preAuth);
                 startActivity(intent);
-                return true;
+                return;
             }
-            if (accounts.size() == 0 && xmppUri.isAction(XmppUri.ACTION_ROSTER) && "y".equals(xmppUri.getParameter(XmppUri.PARAMETER_IBR))) {
+            if (xmppUri.isAction(XmppUri.ACTION_ROSTER) && "y".equals(xmppUri.getParameter(XmppUri.PARAMETER_IBR))) {
                 intent = SignupUtils.getTokenRegistrationIntent(this, jid.getDomain(), preAuth);
                 intent.putExtra(StartConversationActivity.EXTRA_INVITE_URI, xmppUri.toString());
                 startActivity(intent);
-                return true;
+                return;
             }
-        } else if (xmppUri.isAction(XmppUri.ACTION_REGISTER)) {
-            showError(R.string.account_registrations_are_not_supported);
-            return false;
         }
 
         if (accounts.size() == 0) {
@@ -146,19 +133,26 @@ public class UriHandlerActivity extends AppCompatActivity {
                 intent = SignupUtils.getSignUpIntent(this);
                 intent.putExtra(StartConversationActivity.EXTRA_INVITE_URI, xmppUri.toString());
                 startActivity(intent);
-                return true;
             } else {
-                showError(R.string.invalid_jid);
+                Toast.makeText(this, R.string.invalid_jid, Toast.LENGTH_SHORT).show();
-                return false;
             }
+
+            return;
         }
 
         if (xmppUri.isAction(XmppUri.ACTION_MESSAGE)) {
+
             final Jid jid = xmppUri.getJid();
             final String body = xmppUri.getBody();
 
             if (jid != null) {
-                final Class<?> clazz = findShareViaAccountClass();
+                Class clazz;
+                try {
+                    clazz = Class.forName("eu.siacs.conversations.ui.ShareViaAccountActivity");
+                } catch (ClassNotFoundException e) {
+                    clazz = null;
+
+                }
                 if (clazz != null) {
                     intent = new Intent(this, clazz);
                     intent.putExtra("contact", jid.toEscapedString());
@@ -169,6 +163,7 @@ public class UriHandlerActivity extends AppCompatActivity {
                     intent.setData(uri);
                     intent.putExtra("account", accounts.get(0).toEscapedString());
                 }
+
             } else {
                 intent = new Intent(this, ShareWithActivity.class);
                 intent.setAction(Intent.ACTION_SEND);
@@ -188,94 +183,36 @@ public class UriHandlerActivity extends AppCompatActivity {
             intent.putExtra("scanned", scanned);
             intent.setData(uri);
         } else {
-            showError(R.string.invalid_jid);
+            Toast.makeText(this, R.string.invalid_jid, Toast.LENGTH_SHORT).show();
-            return false;
+            return;
         }
+
         startActivity(intent);
-        return true;
     }
 
-    private void checkForLinkHeader(final HttpUrl url) {
+    private void handleIntent(Intent data) {
-        Log.d(Config.LOGTAG, "checking for link header on " + url);
+        if (handled) {
-        this.call = HttpConnectionManager.OK_HTTP_CLIENT.newCall(new Request.Builder()
-                .url(url)
-                .head()
-                .build());
-        this.call.enqueue(new Callback() {
-            @Override
-            public void onFailure(@NotNull Call call, @NotNull IOException e) {
-                Log.d(Config.LOGTAG, "unable to check HTTP url", e);
-                showError(R.string.no_xmpp_adddress_found);
-            }
-
-            @Override
-            public void onResponse(@NotNull Call call, @NotNull Response response) {
-                if (response.isSuccessful()) {
-                    final String linkHeader = response.header("Link");
-                    if (linkHeader != null && processLinkHeader(linkHeader)) {
             return;
         }
-                }
+        if (data == null || data.getAction() == null) {
-                showError(R.string.no_xmpp_adddress_found);
-            }
-        });
-
-    }
-
-    private boolean processLinkHeader(final String header) {
-        final Matcher matcher = LINK_HEADER_PATTERN.matcher(header);
-        if (matcher.find()) {
-            final String group = matcher.group();
-            final String link = group.substring(1, group.length() - 1);
-            if (handleUri(Uri.parse(link))) {
             finish();
-                return true;
-            }
-        }
-        return false;
-    }
-
-    private void showError(@StringRes int error) {
-        this.binding.progress.setVisibility(View.INVISIBLE);
-        this.binding.error.setText(error);
-        this.binding.error.setVisibility(View.VISIBLE);
-    }
-
-    private static Class<?> findShareViaAccountClass() {
-        try {
-            return Class.forName("eu.siacs.conversations.ui.ShareViaAccountActivity");
-        } catch (final ClassNotFoundException e) {
-            return null;
-        }
-    }
-
-    private void handleIntent(final Intent data) {
-        final String action = data == null ? null : data.getAction();
-        if (action == null) {
             return;
         }
-        switch (action) {
+
-            case Intent.ACTION_MAIN:
+        handled = true;
-                binding.progress.setVisibility(call != null && !call.isCanceled() ? View.VISIBLE : View.INVISIBLE);
+
-                break;
+        switch (data.getAction()) {
             case Intent.ACTION_VIEW:
             case Intent.ACTION_SENDTO:
-                if (handleUri(data.getData())) {
+                handleUri(data.getData());
-                    finish();
-                }
                 break;
             case ACTION_SCAN_QR_CODE:
-                Log.d(Config.LOGTAG, "scan. allow=" + allowProvisioning());
+                Intent intent = new Intent(this, ScanActivity.class);
-                setIntent(createMainIntent());
+                startActivityForResult(intent, REQUEST_SCAN_QR_CODE);
-                startActivityForResult(new Intent(this, ScanActivity.class), REQUEST_SCAN_QR_CODE);
+                return;
-                break;
-        }
         }
 
-    private Intent createMainIntent() {
+        finish();
-        final Intent intent = new Intent(Intent.ACTION_MAIN);
-        intent.putExtra(EXTRA_ALLOW_PROVISIONING, allowProvisioning());
-        return intent;
     }
 
     private boolean allowProvisioning() {
@@ -287,7 +224,6 @@ public class UriHandlerActivity extends AppCompatActivity {
     public void onActivityResult(final int requestCode, final int resultCode, final Intent intent) {
         super.onActivityResult(requestCode, requestCode, intent);
         if (requestCode == REQUEST_SCAN_QR_CODE && resultCode == RESULT_OK) {
-            final boolean allowProvisioning = allowProvisioning();
             final String result = intent.getStringExtra(ScanActivity.INTENT_EXTRA_RESULT);
             if (Strings.isNullOrEmpty(result)) {
                 finish();
@@ -296,38 +232,22 @@ public class UriHandlerActivity extends AppCompatActivity {
             if (result.startsWith("BEGIN:VCARD\n")) {
                 final Matcher matcher = V_CARD_XMPP_PATTERN.matcher(result);
                 if (matcher.find()) {
-                    if (handleUri(Uri.parse(matcher.group(2)), true)) {
+                    handleUri(Uri.parse(matcher.group(2)), true);
+                }
                 finish();
-                    }
-                } else {
-                    showError(R.string.no_xmpp_adddress_found);
-                }
                 return;
-            } else if (QuickConversationsService.isConversations() && looksLikeJsonObject(result) && allowProvisioning) {
+            } else if (QuickConversationsService.isConversations() && looksLikeJsonObject(result) && allowProvisioning()) {
                 ProvisioningUtils.provision(this, result);
                 finish();
                 return;
             }
-            final Uri uri = Uri.parse(result.trim());
+            handleUri(Uri.parse(result), true);
-            if (allowProvisioning && "https".equalsIgnoreCase(uri.getScheme()) && !XmppUri.INVITE_DOMAIN.equalsIgnoreCase(uri.getHost())) {
-                final HttpUrl httpUrl = HttpUrl.parse(uri.toString());
-                if (httpUrl != null) {
-                    checkForLinkHeader(httpUrl);
-                } else {
-                    finish();
         }
-            } else if (handleUri(uri, true)) {
         finish();
-            } else {
-                setIntent(new Intent(Intent.ACTION_VIEW, uri));
-            }
-        } else {
-            finish();
-        }
     }
 
     private static boolean looksLikeJsonObject(final String input) {
-        final String trimmed = Strings.nullToEmpty(input).trim();
+        final String trimmed = Strings.emptyToNull(input).trim();
         return trimmed.charAt(0) == '{' && trimmed.charAt(trimmed.length() - 1) == '}';
     }
 }

src/main/java/eu/siacs/conversations/ui/XmppActivity.java

@@ -34,7 +34,6 @@ import android.os.IBinder;
 import android.os.PowerManager;
 import android.os.SystemClock;
 import android.preference.PreferenceManager;
-import android.text.Html;
 import android.text.InputType;
 import android.util.DisplayMetrics;
 import android.util.Log;
@@ -52,8 +51,6 @@ import androidx.appcompat.app.AlertDialog.Builder;
 import androidx.appcompat.app.AppCompatDelegate;
 import androidx.databinding.DataBindingUtil;
 
-import com.google.common.base.Strings;
-
 import java.io.IOException;
 import java.lang.ref.WeakReference;
 import java.util.ArrayList;
@@ -80,7 +77,6 @@ import eu.siacs.conversations.ui.util.PresenceSelector;
 import eu.siacs.conversations.ui.util.SoftKeyboardUtils;
 import eu.siacs.conversations.utils.AccountUtils;
 import eu.siacs.conversations.utils.ExceptionHelper;
-import eu.siacs.conversations.ui.util.SettingsUtils;
 import eu.siacs.conversations.utils.ThemeHelper;
 import eu.siacs.conversations.xmpp.Jid;
 import eu.siacs.conversations.xmpp.OnKeyStatusUpdated;
@@ -252,7 +248,7 @@ public abstract class XmppActivity extends ActionBarActivity {
         Builder builder = new AlertDialog.Builder(this);
         builder.setTitle(getString(R.string.openkeychain_required));
         builder.setIconAttribute(android.R.attr.alertDialogIcon);
-        builder.setMessage(Html.fromHtml(getString(R.string.openkeychain_required_long, getString(R.string.app_name))));
+        builder.setMessage(getText(R.string.openkeychain_required_long));
         builder.setNegativeButton(getString(R.string.cancel), null);
         builder.setNeutralButton(getString(R.string.restart),
                 (dialog, which) -> {
@@ -409,7 +405,11 @@ public abstract class XmppActivity extends ActionBarActivity {
         metrics = getResources().getDisplayMetrics();
         ExceptionHelper.init(getApplicationContext());
         new EmojiService(this).init();
+        if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.JELLY_BEAN_MR1) {
             this.isCameraFeatureAvailable = getPackageManager().hasSystemFeature(PackageManager.FEATURE_CAMERA_ANY);
+        } else {
+            this.isCameraFeatureAvailable = getPackageManager().hasSystemFeature(PackageManager.FEATURE_CAMERA);
+        }
         this.mTheme = findTheme();
         setTheme(this.mTheme);
     }
@@ -572,7 +572,13 @@ public abstract class XmppActivity extends ActionBarActivity {
         if (account.getPgpId() == 0) {
             choosePgpSignId(account);
         } else {
-            final String status = Strings.nullToEmpty(account.getPresenceStatusMessage());
+            String status = null;
+            if (manuallyChangePresence()) {
+                status = account.getPresenceStatusMessage();
+            }
+            if (status == null) {
+                status = "";
+            }
             xmppConnectionService.getPgpEngine().generateSignature(intent, account, status, new UiCallback<String>() {
 
                 @Override
@@ -820,9 +826,8 @@ public abstract class XmppActivity extends ActionBarActivity {
     }
 
     @Override
-    protected void onResume(){
+    public void onResume() {
         super.onResume();
-        SettingsUtils.applyScreenshotPreventionSetting(this);
     }
 
     protected int findTheme() {