config value defaults

* config loads and reads the config file in the init method to reduce io operations
+ get method is now able to take 2 optional arguments, a request key and a definable default value

config.py

@@ -10,10 +10,16 @@ class Config:
         # global config path
         conf_path = '/etc/ejabberd-metrics.conf'
         self.file = Path(conf_path)
-
         self.content = None
 
+        # read config file
+        self._read()
+
     def _read(self):
+        """init the config object with this method"""
+        self._check()
+
+        # open and load json content from config
         with open(self.file, 'r', encoding='utf-8') as f:
             try:
                 self.content = json.load(f)
@@ -24,10 +30,11 @@ class Config:
                 exit(1)
 
     def _check(self):
+        """internal method to check if the config file exists"""
         try:
             # if file is present try to read it's contents
             if self.file.exists():
-                self._read()
+                return
 
             # if not create a blank file
             else:
@@ -38,16 +45,19 @@ class Config:
             print(err, file=sys.stderr)
             sys.exit(err.errno)
 
-    def get(self, key: str = None) -> (dict, None):
-        self._check()
-
-        # if a special key is request, return just that
+    def get(self, key: str = None, default: (str, int) = None) -> (dict, str, int, None):
+        """method to retrieve the whole config data, a single value or the optional default value"""
+        # if a special key is request, return only that value
         if key is not None:
 
             # safety measure
             if key in self.content:
                 return self.content[key]
 
+            # if a default value is given return that
+            if default is not None:
+                return default
+
             # if the key isn't part if self.content return None
             else:
                 return None

influx.py

@@ -77,17 +77,17 @@ class Influx:
 
 if __name__ == '__main__':
     # load config
-    config = Config().get()
+    config = Config()
 
-    # creds and params
-    url = config['url'] if 'url' in config else 'http://localhost:5280/api'
-    login = config['login'] if 'login' in config else None
-    api = config['api'] if 'api' in config else 'rest'
+    # credentials and parameter
+    url = config.get('url', default='http://localhost:5280/api')
+    login = config.get('login', default=None)
+    api = config.get('api', default='rest')
 
     # config influxdb
-    influx_host = config['influxdb_host'] if 'influxdb_host' in config else 'localhost'
-    influx_port = config['influxdb_port'] if 'influxdb_port' in config else 8086
-    influx_dbname = config['influxdb_db'] if 'influxdb_db' in config else 'ejabberd'
+    influx_host = config.get('influxdb_host', default='localhost')
+    influx_port = config.get('influxdb_port', default=8086)
+    influx_dbname = config.get('influxdb_db', default='ejabberd')
 
     # init handler
     metrics = EjabberdMetrics(url, login, api)