From 8ca34866fd60abcc5a168fa1f8b2b1d4c7e8e7e3 Mon Sep 17 00:00:00 2001
From: Martin Geno <geno+dev@fireorbit.de>
Date: Wed, 14 Jun 2017 23:52:38 +0200
Subject: [PATCH] [TASK] add test to log hook output

---
 log/hook/output/main.go      | 13 ++++---
 log/hook/output/main_test.go | 68 ++++++++++++++++++++++++++++++++++++
 log/logger.go                |  1 +
 3 files changed, 77 insertions(+), 5 deletions(-)

diff --git a/log/hook/output/main.go b/log/hook/output/main.go
index 80edf12..16b4ef8 100644
--- a/log/hook/output/main.go
+++ b/log/hook/output/main.go
@@ -4,6 +4,7 @@ package output
 
 import (
 	"fmt"
+	"io"
 	"os"
 	"time"
 
@@ -13,9 +14,11 @@ import (
 )
 
 var (
-	TimeFormat = "2006-01-02 15:04:05"
-	ShowTime   = true
-	AboveLevel = log.InfoLevel
+	TimeFormat           = "2006-01-02 15:04:05"
+	ShowTime             = true
+	AboveLevel           = log.InfoLevel
+	errOutput  io.Writer = os.Stderr
+	output     io.Writer = os.Stdout
 )
 
 // logger for output
@@ -76,9 +79,9 @@ func (l *Logger) Hook(e *log.Entry) {
 	text := fmt.Sprintf(format, v...)
 
 	if e.Level > log.WarnLevel {
-		os.Stderr.WriteString(text)
+		errOutput.Write([]byte(text))
 	} else {
-		os.Stdout.WriteString(text)
+		output.Write([]byte(text))
 	}
 }
 
diff --git a/log/hook/output/main_test.go b/log/hook/output/main_test.go
index ad89311..e6dbb26 100644
--- a/log/hook/output/main_test.go
+++ b/log/hook/output/main_test.go
@@ -1 +1,69 @@
 package output
+
+import (
+	"bytes"
+	"os"
+	"testing"
+
+	"github.com/genofire/logmania/log"
+	"github.com/stretchr/testify/assert"
+)
+
+func captureOutput(f func()) (string, string) {
+	var bufErrOutput bytes.Buffer
+	var bufOutput bytes.Buffer
+	errOutput = &bufErrOutput
+	output = &bufOutput
+	f()
+	errOutput = os.Stderr
+	output = os.Stdout
+	return bufOutput.String(), bufErrOutput.String()
+}
+
+// Warning: colors are not tested (it should be in the imported package)
+func TestOutput(t *testing.T) {
+	assert := assert.New(t)
+	assert.True(true)
+	out, err := captureOutput(func() {
+		log.Info("test")
+	})
+	assert.Regexp("-.*\\[.{5}Info.{4}\\] test", out)
+	assert.Equal("", err)
+
+	ShowTime = false
+	out, err = captureOutput(func() {
+		log.Warn("test")
+	})
+	assert.Regexp("\\[.{5}Warn.{4}\\] test", out)
+	assert.NotRegexp("-.*\\[.{5}Warn.{4}\\] test", out)
+	assert.Equal("", err)
+
+	out, err = captureOutput(func() {
+		log.Error("test")
+	})
+	assert.Equal("", out)
+	assert.Regexp("\\[.{5}ERROR.{4}\\] test", err)
+
+	out, err = captureOutput(func() {
+		log.Debug("test")
+	})
+	assert.Equal("", out)
+	assert.Equal("", err)
+
+	AboveLevel = log.DebugLevel
+
+	out, err = captureOutput(func() {
+		log.New().AddField("a", 3).Debug("test")
+	})
+	assert.Regexp("\\[.{5}Debug.{4}\\] test .{8}(a=3)", out)
+	assert.Equal("", err)
+
+	log.RemoveLogger("output")
+
+	out, err = captureOutput(func() {
+		log.Info("test")
+	})
+	assert.Equal("", out)
+	assert.Equal("", err)
+
+}
diff --git a/log/logger.go b/log/logger.go
index f02b103..7094676 100644
--- a/log/logger.go
+++ b/log/logger.go
@@ -13,6 +13,7 @@ func AddLogger(name string, logger Logger) {
 	loggers[name] = logger
 }
 func RemoveLogger(name string) {
+	loggers[name].Close()
 	delete(loggers, name)
 }