Commit Graph

4549 Commits

Author SHA1 Message Date
Daniel Gultsch ed46d12115 close correct socket after faulty jingle socks connection 2019-09-20 10:00:57 +02:00
Daniel Gultsch abe01f18f2 improved logging for messages waiting for join 2019-09-19 10:00:50 +02:00
Daniel Gultsch af74c3604c fixed R8 weirdness 2019-09-18 11:04:36 +02:00
Daniel Gultsch 02351dc0fb fixed direct invites after adhoc 2019-09-18 09:55:18 +02:00
Daniel Gultsch 4c92d1b755 cancel spinning wheel on muclumbus error 2019-09-18 09:17:47 +02:00
Daniel Gultsch 2ec1d0cc09 warn when using _only_ ambiguous cyrillic 2019-09-16 15:13:53 +02:00
Daniel Gultsch d963d95e30 fixed some minor NPE 2019-09-16 14:20:15 +02:00
Daniel Gultsch ab57c59838 clear notifications when deleting account 2019-09-15 12:23:56 +02:00
Daniel Gultsch 4cd652884c do not finish or repair sessions for untrusted senders
finishing (sending a key transport message in response to pre key message) as
well as reparing sessions will leak resource and availability and might in
certain situations in group chat leak the Jabber ID.

Therefor we disable that. Leaking resource might not be considered harmful by
a lot of people however we have always doing similar things with receipts.
2019-09-15 11:49:58 +02:00
Daniel Gultsch be4953b1e4 parse LMC 1.1 2019-09-13 16:38:15 +02:00
Daniel Gultsch e395da18bf when parsing omemo messages ensure we only find one element 2019-09-12 12:43:11 +02:00
Daniel Gultsch a7c47a33fa inherit language from parent message when finding localized body 2019-09-12 12:42:42 +02:00
Daniel Gultsch 9bf5fb98ac show language in message bubble if multiple language variants were received
XML and by inheritence XMPP has the feature of transmitting multiple language
variants for the same content. This can be really useful if, for example, you
are talking to an automated system. A chat bot could greet you in your own
language.

On the wire this will usually look like this:

```xml
<message to="you">
  <body>Good morning</body>
  <body xml:lang="de">Guten Morgen</body>
</message>
```

However receiving such a message in a group chat can be very confusing and
potentially dangerous if the sender puts conflicting information in there and
different people get shown different strings.

Disabeling support for localization entirely isn’t an ideal solution as on
principle it is still a good feature; and other clients might still show a
localization even if Conversations would always show the default language.

So instead Conversations now shows the displayed language in a corner of the
message bubble if more than one translation has been received.

If multiple languages are received Conversations will attempt to find one in
the language the operating system is set to. If no such translation can be
found it will attempt to display the English string.

If English can not be found either (for example a message that only has ru and
fr on a phone that is set to de) it will display what ever language came first.

Furthermore Conversations will discard (not show at all) messages with with
multiple bodies of the same language. (This is considered an invalid message)

The lanuage tag will not be shown if Conversations received a single body in
a language not understood by the user. (For example operating system set to
'de' and message received with one body in 'ru' will just display that body as
usual.)

As a guide line to the user: If you are reading a message where it is important
that this message is not interpreted differently by different people (like a
vote (+1 / -1) in a chat room) make sure it has *no* language tag.
2019-09-12 10:12:51 +02:00
Daniel Gultsch 9273ba5653 pulled translations from transifex 2019-09-12 10:09:28 +02:00
Daniel Gultsch a39fff5c8e fixed 2 issues reported by new linter 2019-09-11 15:42:43 +02:00
Daniel Gultsch 24d1fc2bb5 pulled translations from transifex 2019-09-09 09:43:10 +02:00
Daniel Gultsch 8b69f8ae50 include ticker information in notification. fixes #3532 2019-09-08 17:58:15 +02:00
Daniel Gultsch dd9777a6b7 do not include scope in ipv6 annoucment 2019-09-08 17:44:26 +02:00
Daniel Gultsch 9129c9acde JET uses plain text file size 2019-09-06 13:11:37 +02:00
Daniel Gultsch 0e1c26c569 do not include link local in direct candidates 2019-09-05 13:17:45 +02:00
Daniel Gultsch 571c29f92a make Tor connections work with direct TLS 2019-09-05 12:08:58 +02:00
Daniel Gultsch 7ec1b443ab implemented support for for jingle encrypted transports (XEP-0396) 2019-09-04 16:14:01 +02:00
Daniel Gultsch ff4d127b6f use higher priority for proxy on receiving end 2019-09-02 08:51:50 +02:00
Daniel Gultsch 90e669313e send fallback to ibb after proxy activation failed 2019-09-01 21:41:28 +02:00
Daniel Gultsch 10b1365264 also reply with direct connections on response 2019-09-01 20:42:07 +02:00
Daniel Gultsch 1c413edf06 bare minimum direct connections 2019-09-01 15:06:59 +02:00
Daniel Gultsch 783ed53d3a order canditates by priority before attempting to connect 2019-09-01 11:34:36 +02:00
Daniel Gultsch 7d6bd540d9 version bump to 2.5.7 + changelog 2019-08-29 12:14:01 +02:00
Daniel Gultsch e49473007e
fix russian localization (#3526) 2019-08-29 07:48:34 +00:00
Daniel Gultsch ab86cc4689 pulled translations from transifex 2019-08-29 09:48:13 +02:00
Daniel Gultsch 29d0bed38b when sharing text from Conversations to Conversations use quotes 2019-08-26 13:40:47 +02:00
Andrey Sokolov c16438c475 fix russian localization 2019-08-25 12:46:09 +03:00
Daniel Gultsch 219ae65ef7 more ibb fixes (include sid in transport-accept) 2019-08-22 14:47:30 +02:00
Daniel Gultsch 2706deedbd pulled translations from transifex 2019-08-22 10:01:02 +02:00
Daniel Gultsch 98eb49904c fixed unlikely race between enabling carbons and discovering last MAM id 2019-08-22 09:57:39 +02:00
Daniel Gultsch c84a89924e include pgp sig and status in presence to non anon muc 2019-08-19 14:27:11 +02:00
Daniel Gultsch f11adf4c02 do not put default nick into bookmark if none has been set before 2019-08-19 13:55:52 +02:00
Daniel Gultsch 8574bea280 pulled translations from transifex 2019-08-18 13:12:02 +02:00
Daniel Gultsch fddd974412 do not put version info into disco
This will reduce traffic by limiting the variety of different caps version hashes.
It might also improve privacy by not leaking fdroid vs playstore vs self build information
2019-08-18 13:03:58 +02:00
Daniel Gultsch daf7e6224f fixed pgp decryption of automatically accepted jingle ft 2019-08-16 15:29:58 +02:00
Daniel Gultsch d3ccba445a increased reconnection interval after policy violation 2019-08-16 15:00:26 +02:00
Daniel Gultsch 9ea4f1534b pulled translations from transifex 2019-08-16 14:12:13 +02:00
Daniel Gultsch 0770914edf refactored filename and extension parsing 2019-08-16 14:09:42 +02:00
Daniel Gultsch c039ffcf35 clean up logging 2019-08-14 18:44:57 +02:00
Daniel Gultsch 195988398e removed dead code in location activity 2019-08-14 17:04:45 +02:00
Daniel Gultsch e735be323e catch npe on participants context menu 2019-08-14 17:04:31 +02:00
Daniel Gultsch 6e1394ab40 make config flag for leave before join 2019-08-14 12:04:27 +02:00
Daniel Gultsch ed95dd64ad create empty disco result on error to fire advance stream features event 2019-08-13 21:18:32 +02:00
Daniel Gultsch ad15fb1721 pulled translations from transifex 2019-08-12 13:09:02 +02:00
Daniel Gultsch 0f18f16dc2 show scrollbars in muc user screen 2019-08-12 13:08:13 +02:00
Daniel Gultsch 8ac042418b fixes #3514 2019-08-11 16:54:00 +02:00
Daniel Gultsch 1ff17fc3f0 catch more firebase library bugs 2019-08-06 15:04:59 +02:00
Daniel Gultsch ffc16faf7b pulled translations from transifex 2019-08-06 15:04:05 +02:00
Daniel Gultsch 011bdd8ef6 fixed send_multiple share intent with empty extras. fixes #3512 2019-08-05 21:32:20 +02:00
Daniel Gultsch 238df77a1e catch IllegalArgumentException when reading backup file 2019-07-25 17:01:43 +02:00
Daniel Gultsch 4957e50ac4 disable spell checking on country drop down field in Quicksy 2019-07-23 17:49:33 +02:00
Daniel Gultsch f597fc46da implement time out for waiting on voice recording 2019-07-23 17:31:56 +02:00
Daniel Gultsch 1af52a7a30 made some quicksy registration errors more explicit 2019-07-23 15:25:50 +02:00
Daniel Gultsch 68a20ecf63 pulled translations from transifex 2019-07-23 08:37:39 +02:00
Daniel Gultsch a4665d4657 made domain verifier case insensitive. fixes #3495 2019-07-20 17:51:37 +02:00
Daniel Gultsch c87e43eb92 put initial xmpp uri into signup intent 2019-07-20 15:58:05 +02:00
Daniel Gultsch c1589d76b5 resetToWaiting should include http uploaded files 2019-07-20 12:15:06 +02:00
Daniel Gultsch f5be53d08a jump into last field after re-enable pin entry 2019-07-20 12:14:33 +02:00
Daniel Gultsch 3837ec8122 do not include DNS servers from networks know to be inactive
* we still include DNS servers from VPNs because of edge cases where the XMPP server is hosted in the VPN
* on older Android versions we don’t know if a network is active or not (activeNetwork == null)

fixes #3465
2019-07-18 11:24:33 +02:00
Daniel Gultsch 6de6d054ac catch fcm library bugs 2019-07-17 21:03:56 +02:00
Daniel Gultsch d9f39df9c8 do password empty check in dialog not in restore backup service 2019-07-17 17:21:18 +02:00
Daniel Gultsch cb1feab350 open backup files on view action 2019-07-17 11:32:56 +02:00
Daniel Gultsch 603e1b35a5 allow backup to be restored from selected file 2019-07-16 16:49:47 +02:00
Daniel Gultsch b68851b719 create share button in backup done notification 2019-07-15 19:11:00 +02:00
Daniel Gultsch 97598c63dc split on first dot when using domain instead of black listed local part 2019-07-15 19:09:53 +02:00
Daniel Gultsch bc3e5f1dd4 muc message corrections only compare bare jid true counterpart
during live messages we only store the bare real jid; on muc catch up we might get the full jid
for that reason we only compare bare jids
2019-07-14 17:58:31 +02:00
Daniel Gultsch 719b35e431 prefer attachment in share intent if there is one 2019-07-14 16:39:09 +02:00
Daniel Gultsch 803334e42b pulled translations from transifex 2019-07-14 16:38:56 +02:00
Daniel Gultsch 553b65ffcd pulled translations from transifex 2019-07-11 08:14:07 +02:00
Daniel Gultsch 7e93c1021b handle blocking and unblocking of full jids 2019-07-10 17:58:48 +02:00
Daniel Gultsch c9bf1474e3 support status code 451 in quicksy registration 2019-07-04 19:35:03 +02:00
Daniel Gultsch 8138eb0346 use more default values in LocationActivity
fixes #3475
2019-07-04 18:17:16 +02:00
Daniel Gultsch 98c4e9056f use helper method to close socket 2019-07-04 10:12:08 +02:00
Daniel Gultsch e9099acd97 accept status code 201 for Quicksy registration 2019-07-03 18:01:46 +02:00
Daniel Gultsch feba9a71ee code clean up 2019-07-02 11:10:21 +02:00
Daniel Gultsch 8c526de0af disable muc push on archive instead of leave
leave can be triggered on swipe and doesn’t mean we don’t want pushes
2019-07-01 14:35:00 +02:00
Daniel Gultsch 59a2f39b27 pulled translations from transifex 2019-07-01 11:17:27 +02:00
Daniel Gultsch 4f0214b477 check if activity is not null before using it to paint send button 2019-07-01 10:17:29 +02:00
Daniel Gultsch 7ec8f7952f migrate copy ond write list to synchronized hashset for pending mucs 2019-06-30 21:57:37 +02:00
Daniel Gultsch 9f08a32ffb include remote server errors in errors that should trigger a self ping 2019-06-30 20:08:28 +02:00
Daniel Gultsch 0ecdb43be6 rate limit muc pings / joins. never run two pings at same time 2019-06-30 19:54:07 +02:00
Daniel Gultsch 49224335fc attempt to unregister when receiving push for channel no longer joined
when receiving a FCM push message for a channel the user is no longer in (this can happen when the disable command failed) an attempt will be made to explicitly unregister from the app server (which in turn will then send item-not-found on next push)
2019-06-26 17:40:12 +02:00
Daniel Gultsch 7809af9b57 implement FCM push for group chats 2019-06-25 18:15:51 +02:00
Daniel Gultsch e467fe341e implement client support for muc push
Staying connected to a MUC room hosted on a remote server can be challenging.

If a server reboots it will usually send a shut down notification to all
participants. However even if a client knows that a server was shut down it
doesn’t know when it comes up again. In some corner cases that shut down
notification might not even be delivered successfully leaving the client in a
state where it thinks it is connected but it really isn’t.

The possible work around implemented in this commit is to register the clients
full JID (user@domain.tld/Conversations.r4nd) as an App Server according to
XEP-0357 with the room. (Conversations checks for the push:0 namespace on the
room.)

After cycling through a reboot the first message send to a room will trigger
pubsub notifications to each registered full JID. This event will be used to
trigger a XEP-0410 ping and if necessary a subsequent rejoin of the MUC.

If the resource has become unavailable during down time of the MUC server the
user’s server will respond with an IQ error which in turn leads to the MUC
server disabling that push target.

Leaving a MUC will send a `disable` command. If sending that disable command
failed for some reason (network outage) and the client receives a pubsub
notification for a room it is no longer joined in it will respond with an
item-not-found IQ error which also disables subsequent pushes from the server.

Note: We 0410-ping before a join to avoid unnecessary full joins which can be
quite costly. Further client side optimazations will also surpress pings when
a ping is already in flight to further save traffic.
2019-06-24 18:16:06 +02:00
Daniel Gultsch b6d059ed89 ping muc after receiving not-acceptable error 2019-06-18 18:40:16 +02:00
Daniel Gultsch 17c8bf3452 attempt to keep messages waiting until muc is connected 2019-06-18 18:09:44 +02:00
Daniel Gultsch 6862b60c3f self ping (xep-0410) after receiving invite to muc 2019-06-18 13:20:24 +02:00
Daniel Gultsch 4c3cd89fe7 syntax clean up 2019-06-17 17:37:02 +02:00
Daniel Gultsch 782d889cc5 disallow subsequent session-accept 2019-06-17 09:51:49 +02:00
Daniel Gultsch c1bdda0a9b reenable http upload that got disabled in last commit 2019-06-17 08:33:19 +02:00
Daniel Gultsch 9fc1ead74f use ibb if other party doesn’t annouce s5b feature 2019-06-16 22:57:10 +02:00
Daniel Gultsch fe6c981ae2 accept direct ibb jingle offers 2019-06-16 21:23:18 +02:00
Daniel Gultsch 1cfba86aff don’t crash when attempting to publish bookmarks while offline 2019-06-16 18:05:06 +02:00
Daniel Gultsch 52c0bf73a0 handle some rare npe 2019-06-16 18:04:43 +02:00
Daniel Gultsch 2fbd9e6744 MessageStyle notifications replace car extender 2019-06-16 16:02:22 +02:00