sum7
/
ejabberd-tools
2
1
Fork 0
Code Issues 1 Pull Requests 1 Projects 1 Releases Wiki Activity

refactor os.environ to pathlib #1

Merged
mightyBroccoli merged 2 commits from configpath into master 2020-11-06 12:07:39 +01:00
Conversation 4 Commits 2 Files Changed 1 +4 -5
genofire commented 2020-09-26 21:56:28 +02:00
Owner
Copy Link
  • config.py should use the smaller lib to determine which config to load
* config.py should use the smaller lib to determine which config to load
genofire commented 2020-09-26 21:56:34 +02:00
Author
Owner
Copy Link

I am fairly sure that this will improve the config classes overall quality if we start to use pathlib instead of this env variable junk.
@genofire The only reason why I chose to open a pull request is that I am not sure if you use the env flag in your dev environment.

I am fairly sure that this will improve the config classes overall quality if we start to use pathlib instead of this env variable junk. @genofire The only reason why I chose to open a pull request is that I am not sure if you use the env flag in your dev environment.
mightyBroccoli was assigned by genofire 2020-09-26 22:02:57 +02:00
genofire self-assigned this 2020-09-26 22:02:58 +02:00
genofire commented 2020-09-26 22:10:11 +02:00
Author
Owner
Copy Link

looks good to me - i just write a short version of your change.
If it is okay, do you like it to merge?

looks good to me - i just write a short version of your change. If it is okay, do you like it to merge?
genofire requested review from mightyBroccoli 2020-09-26 22:10:18 +02:00
genofire removed their assignment 2020-09-26 22:10:25 +02:00
genofire added this to the Daily project 2020-10-11 11:21:21 +02:00
mightyBroccoli commented 2020-11-06 12:07:31 +01:00
Collaborator
Copy Link

I am so sorry I had the old site bookmarked and was wondering why everything wasn't doing what it should. This should have be merged weeks ago 👼

I am so sorry I had the old site bookmarked and was wondering why everything wasn't doing what it should. This should have be merged weeks ago 👼
mightyBroccoli merged commit c2b190b18b into master 2020-11-06 12:07:39 +01:00
mightyBroccoli deleted branch configpath 2020-11-06 12:08:11 +01:00
genofire commented 2020-11-06 14:53:13 +01:00
Author
Owner
Copy Link

All right, i will also setup ci for this soon ...

All right, i will also setup ci for this soon ...
Sign in to join this conversation.
Reviewers
No reviewers
mightyBroccoli
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Daily
Assignees
Clear assignees
No Assignees
mightyBroccoli
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: sum7/ejabberd-tools#1
No description provided.
Delete Branch "configpath"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?