dc72bc5bc3
extend logging for not finding query
2020-10-08 20:21:53 +02:00
364502d1a3
Fix various memory leaks reported by LeakCanary
...
- In some places, we weren't nulling out references to destroyed objects. This
fixes that.
- (These were all discovered via LeakCanary instrumentation, and the fixes are
hopefully rather straightforward-looking.)
2020-10-05 11:33:29 +00:00
b4805ac2c5
Remove the ListSelectionManager / message body selection (fixes memory leak!)
...
- When the `viewHolder.messageBody` `TextView` created by a `MessageAdapter` is
set to selectable, it leaks an `android.widget.Editor` (because that editor
registers a view observer that never gets unregistered).
- This memory leak is really quite problematic, as the message adapter is used
a lot!
- Having the text be selectable is useless anyway, though; there isn't any way
to select it (because long pressing just opens the context menu anyway).
- It looks like the ListSelectionManager was meant to track selections across
multiple messages. However, I'm not sure this feature ever gets used.
- Accordingly, this commit removes the entire feature, thus fixing the memory
leak (since no `Editor` objects are ever created).
- It should also reduce memory usage in general, since we aren't attaching an
`Editor` to every single textview we create.
- A `TextView` only allocates an `Editor` if you ask it to do certain things,
like make the text selectable or register custom selection callbacks.
2020-10-05 11:33:12 +00:00
ce1b707837
pulled translations from transifex
2020-09-09 10:47:48 +02:00
7fb617e39a
disable 'leave before join'
...
leaving a MUC before joining it was a work around for servers that did not treat a
<x/> join as a full join and didn’t send the full user list if they thought the user was
still in the room.
this happens if Conversations restarts after an inproper disconnect. The MUC will think
the user is still in the room.
however nowadays most modern servers will treat <x/> joins as full joins. on the user hand
leave before join would trigger flood prevention on ejabberds and race the first message
with the actual join (making the message arrive before the user is considered in the room)
2020-09-02 10:14:02 +02:00
9db0c85cda
rename 'add to favorites' to 'pin to top'
2020-09-02 10:13:10 +02:00
27c89e487a
restructure conversation menu
...
we don’t want 'manage accounts' and 'settings' to show up when within a conversation.
we also move out disable notifications and add to favorites into an overflow overflow
to make the menu shorter (after adding 'Search messages' it became very crowded)
2020-09-01 16:50:28 +02:00
73dac680e5
show notification if message failed to deliver. closes #3540
2020-09-01 14:04:38 +02:00
aa792a3af6
pulled translations from transifex
2020-09-01 11:41:16 +02:00
8d64e101c9
provide content description for fab in start conversation
2020-08-31 18:06:24 +02:00
3281a93dc3
use content description for play/pause button in audio player
2020-08-31 17:42:03 +02:00
81985ca7d7
shorten 'close conversation' string
2020-08-31 17:33:37 +02:00
f76ef17494
provide content descriptions for call screen
2020-08-31 17:30:54 +02:00
4b12033bd3
pulled translations from transifex
2020-08-31 17:12:41 +02:00
ce81123112
use content description in search fields
2020-08-31 17:12:31 +02:00
2de8f3d35b
change title of lock icon when changing encryption
2020-08-31 16:56:23 +02:00
97fe9fa01f
parse error messages from MAM results
2020-08-31 14:38:48 +02:00
6590dc922f
homogenize accessibility traversal in sent and received messages
2020-08-31 13:20:17 +02:00
c48499253b
set content description for all avatars
2020-08-31 13:05:10 +02:00
3c0773c6e7
use darker accent color in light theme
2020-08-31 11:19:27 +02:00
064264c20b
parse 'received' carbon-copied error messages. fixes #3803
2020-08-31 11:06:26 +02:00
3dcb36a417
persist presence name (pep, nick in subscribe) to DB. fixes #3856
2020-08-31 09:03:54 +02:00
35af8894d2
search individual conversations. fixes #3243
2020-08-29 08:16:08 +02:00
d158eeaf72
terminate jingle call when regular call starts
2020-08-24 12:47:54 +02:00
91e94db747
extend isBusyState to check phone state as well
2020-08-24 09:51:26 +02:00
15b323ee69
fix crash after session-accept failed and session-accept contained candidates
...
Conversations would attempt to feed any candidates found in the session-accept into
WebRTC; even if the session wasn’t setup correctly.
this commit processes the candidates only if the session was setup correctly
fixes #3867
2020-08-22 08:12:28 +02:00
f3362ebde5
add start/install orbot to error notification if applicable. fixes #3846
2020-08-19 15:29:25 +02:00
70c10fd0de
listen to orbot events instead of using intent result to reconnect account
2020-08-19 13:57:33 +02:00
1958cded23
improve logging for app server failures. change wording to include 'push'
2020-08-19 13:18:27 +02:00
7d2a7d536d
fix attachments getting lost when switching to chat during call
...
fixes #3854
2020-08-05 21:31:56 +02:00
129f43a349
verify hostname is valid before letting user save it
2020-08-01 15:03:20 +02:00
637c0cb15a
fixed rare race condition when receiving transport info right after WebRTCWrapper closes
...
fixes #3849
2020-08-01 14:18:03 +02:00
1ae7d6be16
recover from pre-jingle connection states (discover etc) into full fledged jingle connection
...
fixes #3847
2020-08-01 09:50:54 +02:00
f22e33e3ea
fixed race condition of WebRTCWrapper being closed before transitioning into terminal state
...
JingleRTPConnection shuts down the WebRTCWrapper before transitioning into a terminal state.
(This allows us to make sure it is actually closed when reaching that state);
However that means that, when we get a UI redrawn inbetween closing and transitioning we might
still be in SESSION_ACCEPTED but with no PeerConnection. This traditionally has triggered
an IllegalStateException on getting the EndUserState.
This commit catches the ISE and returns 'ENDING' instead.
Chances are that this is only visibiliy for a very brief time in the UI before the transition
triggers the UI to redraw with the proper state.
fixes #3848
2020-08-01 08:20:10 +02:00
5ecd250565
pulled translations from transifex
2020-07-30 13:02:25 +02:00
f5f9075da2
FileObserver: start monitoring new directories when they are created
2020-07-30 12:55:19 +02:00
9cd4e1d581
show toast when correction fails
2020-07-26 17:03:51 +02:00
6941d5edd1
ignore IQ result when MAM query had been killed
2020-07-26 16:39:48 +02:00
1c66772202
rename DnD to Busy in settings. fixes #3839
2020-07-26 16:30:02 +02:00
9bec186292
ignore RTP session logs when looking for LMC. fixes #3843
2020-07-26 13:46:01 +02:00
16300727d1
try to guess mime type via extension in display name
2020-07-21 10:19:21 +02:00
28856aaf9f
add icons for gpx files
2020-07-19 21:27:43 +02:00
32d55346cc
ensure server triggered jingle iq-errors get routed properly
2020-07-18 16:14:39 +02:00
994fd9ecad
restore backup in one transaction
2020-07-16 11:25:25 +02:00
fd68bfb8ca
pulled translations from transifex
2020-07-13 17:34:49 +02:00
9e6f7237af
use smaller image previews on narrow screens
2020-07-12 12:31:13 +02:00
7aeb2b2740
pulled translations from transifex. re-enabled some linter warnings
2020-07-12 10:15:51 +02:00
590deef8e9
use ctrl+arrow up to correct last message. fixes #3806
2020-07-12 09:45:27 +02:00
c9e6653e33
fixups and code clean up for 'Ctrl+Enter'
2020-07-12 08:28:09 +02:00
e7e04837b6
Support sending messages with ctrl+enter
...
Currently Conversations lacks any keyboard shortcut to send a message if enter_is_send is disabled.
KeyboardListener has been extended to include the original KeyEvent as an argument.
fixes #3829
2020-07-12 05:18:40 +00:00
aa47e53584
pulled translations from transifex
2020-07-11 12:48:20 +02:00
c3fa1d5d30
show switch to chat button during audio call. fixes #3825
2020-07-10 19:30:16 +02:00
bab9dd4893
make sure intent is only set to retracted if something was retracted. fixes #3826
2020-07-10 16:10:40 +02:00
bf85a55930
catch NPE when detecting camera facing. fixes #3820
2020-07-09 20:11:09 +02:00
1107529f56
ask for contact permission before adding to contact to phone book. fixes #3808
2020-07-09 20:03:02 +02:00
6a6c9fb3bf
ignore race condition when toggling fixes #3822
2020-07-09 19:14:28 +02:00
9ab0fbe48c
provide progress bar for import backup. fixes #3809
2020-07-09 18:52:46 +02:00
71a56002fe
fix emojis not rendering correctly with trailing variant selector. fixes #3819
2020-07-09 17:43:30 +02:00
2881a1b946
pulled translations from transifex
2020-06-25 20:33:02 +02:00
13d8eb1c7e
dismiss notification only if displayed id matches last remote id
2020-06-24 12:12:35 +02:00
fada3a63c9
store entire transport info for after session was accepted. fixes #3790
2020-06-22 18:07:27 +02:00
a5430d5ce1
retract call when user presses home button or back; not on stop. fixes #3802
2020-06-22 15:37:22 +02:00
57135e1a59
do not update recent quick action when recording voice mail. fixes #3799
2020-06-21 16:28:57 +02:00
15489547b7
add account provisioning via QR code to welcome screen
2020-06-21 15:40:51 +02:00
68960398b2
pulled translations from transifex
2020-06-21 08:59:10 +02:00
203e248a14
Fix screen blinking during the call for some Samsung phones ( #3800 )
2020-06-21 06:56:51 +00:00
d88f79e436
register Conversations to open *.ceb files from content and file uris
2020-06-19 09:31:23 +02:00
dddb7ece25
show app failure instead of crashing when egl fails to init. fixes #3795
2020-06-18 20:37:56 +02:00
169ee99afa
do not attempt to reject call if session had already ended. fixes #3798
2020-06-18 20:32:58 +02:00
fe68aff23c
validate install referrer beforing accepting it as xmpp uri
2020-06-18 10:15:51 +02:00
7bcb29c482
be more liberal in 0167 payload-type parameter parsing
...
some implementations will transform the following SDP coming from Firefox
m=audio 12346 RTP/AVP 101
a=rtpmap:101 telephone-event/8000
a=fmtp:101 0-15
to
<payload-type channels="1" name="telephone-event" clockrate="8000" id="101">
<parameter value="0-15" xmlns="urn:xmpp:jingle:apps:rtp:1"/>
</payload-type>
While a missing name attribute is not legal according to the XEP; and 0-15 are
technically not just one value the following commit will accept it if there is
just one paramater.
2020-06-17 21:15:12 +02:00
47804205b6
clear pending photo uri only when also clearing activity result
...
on some phones the onBackendConnected finishes prior to the onActivityResult()
leading to the pending photo uri being cleared before processing the result.
this leads to 'Take photo' not working.
but we probably don’t need to clear the photo uri if there is to activiyResult
to clear as well
2020-06-17 17:58:25 +02:00
4493f6cc13
Leave the incoming call notification category as CATEGORY_CALL ( #3792 )
2020-06-16 19:07:01 +00:00
23c4a26404
pulled translations from transifex
2020-06-16 10:16:25 +02:00
c8f23aef4e
error response to sending the jingle ft hash should not file the transfer
2020-06-15 21:33:32 +02:00
98e1044bdd
use Jid.ofLocalAndDomainEscaped when transforming account with locked domain
2020-06-15 19:17:21 +02:00
d823cefe47
pulled translations from transifex
2020-06-15 12:40:43 +02:00
20286ea8d2
fixed concurrent modification when displaying read markers
2020-06-14 19:09:55 +02:00
1f77d5e115
pass selected audio device to proximity sensor toggle
2020-06-14 16:22:53 +02:00
61aac78af0
pulled translations from transifex
2020-06-14 14:29:40 +02:00
16bc210211
fix regression for fixed domain
2020-06-14 11:28:25 +02:00
c3b9a4dabc
parse jmi proposals from MAM reloads. fixes #3778
2020-06-14 10:34:40 +02:00
ccdc91a497
remove check that would ensure you use jingle only with full jids
2020-06-14 09:01:47 +02:00
400c8461fc
fix feature discovery in jingle file transfer for empty resources
2020-06-13 22:53:24 +02:00
fda9e7b51c
make presence selector work with empty resources (bare jid)
2020-06-13 09:59:39 +02:00
0dba9f560c
rework quicksy domain checks
2020-06-13 08:26:32 +02:00
56ea9647cd
null check quicksy domain
2020-06-13 08:10:04 +02:00
971bb60f42
add more logging to caps fetching
2020-06-12 20:06:49 +02:00
01bfb5fd56
pulled translations from transifex
2020-06-12 09:19:56 +02:00
0ba4892d3e
RTP: write log message on background thread
2020-06-12 09:08:09 +02:00
b7f3b4333e
show help button on certain error conditions in RTP session. fixes #3770
2020-06-12 08:26:33 +02:00
644ad99520
create rtp end user state for connection lost. fixes #3769
2020-06-12 07:57:11 +02:00
552e17e39a
remember terminal RTP session state
...
if the activity is not connected during finish it won’t receive the last end user state.
this code remembers it even if the actual session is already gone. so when activity reconnects and
we can’t find the real rtp session we can look up the last state instead.
2020-06-11 21:17:15 +02:00
7e2d87f39c
recover if attachImage can’t generate scalled down version of image. fixes #3773
2020-06-09 21:08:27 +02:00
1853242c66
do not throw when finishing jingle ft twice. fixes #3765
...
the state machine in jingle file transfer does not prevent that the connection
is being finished twice
2020-06-07 15:00:00 +02:00
b78d45c7cc
fix Jingle FT candidate selection for equal priority. fixes #3771
2020-06-07 12:47:03 +02:00
4bc43af690
improve logging in export backup service. closes #3672
2020-06-02 07:59:46 +02:00
0391e78832
pulled translations from transifex. fixes crash in UK translation
2020-06-02 07:59:46 +02:00
61f6ce317b
pulled translations from transifex
2020-05-30 15:22:45 +02:00
637c208f55
ask for resource and use jingle direct init when JMI is not available. fixes #3751
2020-05-30 14:56:12 +02:00
8edfc61346
fixed concurrent modification when iterating over presences
2020-05-30 10:57:22 +02:00
8603d24bcb
add record voice mail button to busy screen. fixes #3754
2020-05-30 10:30:57 +02:00
bc6446beb8
pulled translations from transifex. closes #3760
2020-05-29 18:18:54 +02:00
59d1a2982e
RtpSessionActivity: throw instead of finish when session wasn’t found
2020-05-28 09:22:58 +02:00
63ba21a512
catch ISE cause by race when displaying video track. fixes #3752
2020-05-27 15:53:05 +02:00
5e3aab3abe
ensure that finishConnection succeeds
2020-05-27 13:54:35 +02:00
575ada3b27
fix scram crash for broken metronome servers
2020-05-27 13:53:28 +02:00
cdcc34ff91
pulled translations from transifex
2020-05-25 11:21:19 +02:00
1c625e55a0
set candidate gathering to continually. fixes #3719
...
This should be good enough to survive some network switches where both networks are online at the same time to allow for some handover
(for example when enabling wifi the 3G connection will usually (probably depends on OS) live on for a moment
2020-05-25 11:11:29 +02:00
8475a28dc5
control voice call volume when playing audio through earpiece. fixes #3705
2020-05-25 10:43:56 +02:00
7ca543e42f
replace /me when quoting messages. fixes #3669
2020-05-24 10:52:34 +02:00
88cc097732
fail pending messages on policy violation. fixes #3735
2020-05-22 18:23:53 +02:00
ed4d7bff92
reset tone manager after reaching NULL status
2020-05-22 16:25:29 +02:00
550fbc6d2c
make sure automatic jmi responses are sent before ack
2020-05-22 13:22:22 +02:00
685e01e83f
give TonManager control over audio mode to play dial tones on earpiece. fixes #3738
2020-05-21 15:39:59 +02:00
a2a7256682
disable hardware AEC on some devices. fixes #3734
2020-05-21 11:13:46 +02:00
de941f6036
use escaped jid for invites
2020-05-21 08:41:04 +02:00
574bccfc59
avoid unnecessary call to Jid.ofDomain()
2020-05-21 07:57:57 +02:00
aa1e69d277
use escaped jid for EXTRA_ACCOUNT
2020-05-20 20:14:13 +02:00
304411fc09
return audio mode to normal (instead of previous mode) after call ended
2020-05-20 19:40:26 +02:00
bfeebc141f
invalide options menu after pinning/unpinning. fixes #3745
2020-05-19 19:39:05 +02:00
dd0f354b62
publish pep bookmarks 1.0 to an item called 'current'
2020-05-19 19:39:05 +02:00
f8fedf0059
sasl prep password before hashing. fixes #1893
2020-05-19 15:28:12 +02:00
89c022f0cb
pulled translations from transifex
2020-05-18 12:00:10 +02:00
22f3aac465
fix media browser for escapbed jids
2020-05-18 11:48:24 +02:00
3ca10b8fa9
show escaped jids when it comes to account selection
2020-05-18 09:35:35 +02:00
df3273a6fc
fix jid.withResource() for domain jids
2020-05-18 09:14:57 +02:00
a0920b83e2
use Account.getDomain() for direct access to domain jid
2020-05-17 10:24:46 +02:00
b347d57848
don’t escape jids when parsing from uri
2020-05-17 08:53:44 +02:00
7abd37498e
pulled translations from transifex
2020-05-17 08:33:25 +02:00
1da490f77a
do not request storage permission for attaching location
2020-05-16 17:51:14 +02:00
4dd3b0c2aa
allow to pin conversations on top. fixes #3480
2020-05-16 12:10:26 +02:00
7a21b2c5ed
fixed parsing of unescaped jids with @ in local part
2020-05-16 10:40:26 +02:00
2195bce303
don’t allow escaped usernames in magic create
2020-05-16 08:55:13 +02:00
78a82a74bc
use unescaped jid in ManageAccount
2020-05-15 20:20:22 +02:00
dc29cf27a3
validate conference jid on input
2020-05-15 19:22:15 +02:00
198a7db954
use escaped jid in more places
2020-05-15 18:44:55 +02:00
ef7d4fca86
show escaped jid in most of the UI
...
for historical reasons we store unescaped variants in DB and use them in intents.
2020-05-15 18:22:04 +02:00
b6703dbe38
switch xmpp-addr to jxmpp-jid
2020-05-15 17:06:16 +02:00
3510f10e25
pulled translations from transifex
2020-05-15 11:30:12 +02:00
1b4f9cc8ab
allow 'login with certificate' from welcome screen. fixes #3724
2020-05-13 13:52:05 +02:00
36d2ecfcfa
always use private key for TLS connection when one is configured
2020-05-13 09:38:30 +02:00
2c4788b7c7
send retract when unable to setup webrtc as initiator. fixes #3717
2020-05-11 12:20:32 +02:00
b845c601d0
include senders in jingle file offer
2020-05-11 11:09:18 +02:00
90526efbd4
fixed destination calculation for direct socks candidates. fixes #3715
2020-05-11 11:08:45 +02:00
907b4d2b8a
pulled translations from transifex
2020-05-10 18:42:24 +02:00
46579550e4
fixed weird ToneGenerator crash. fixes #3712
...
obviously tones won’t work then anymore
2020-05-10 17:54:16 +02:00
4d3d3a7038
tie breaking racing jingle message proposals. fixes #3698
2020-05-10 14:09:16 +02:00
2c5bed61a1
introduce extra RTP state to handle going from sending proceed to receiving retract
2020-05-09 21:35:21 +02:00
9b8b4f1791
move call icon to left. fixes #3709
2020-05-09 21:10:35 +02:00
Daniel Gultsch